Commit Graph

10334 Commits

Author SHA1 Message Date
Tracy Zhou 269f30fb9b Merge "Set default value of gridName to current grid name in GridOptionsProvider" into ub-launcher3-master 2020-03-19 02:17:19 +00:00
Tracy Zhou 42255d22a7 Set default value of gridName to current grid name in GridOptionsProvider
With grid preview, a grid name is passed in when requesting preview under different grid setting. With wallpaper preview, no such grid name will be passed in, and it should be set to the current.

Bug: 145242344
Test: N/A
Change-Id: I282cb5341b7f3756d41c4abd8d97f986abaa6d27
2020-03-18 16:52:28 -07:00
TreeHugger Robot 2b5837f28f Merge "Adding additional logs to debug synchronous modification of update listeners" into ub-launcher3-master 2020-03-18 23:01:31 +00:00
Hyunyoung Song 9720993e9d Revert "[DO NOT MERGE] Turn off FOLDER_NAME_SUGGEST feature flag"
This reverts commit a299714c7a.

Reason for revert: PM decided to keep it on until R release to not have press write about feature going away.

Change-Id: I83c21e3938c38632e267498ba326d0da075e5dc8
2020-03-18 22:23:49 +00:00
Alex Mang 1ff2be0dce [DO NOT MERGE] Initiailize APP_SEARCH_IMRPOVEMENT flag outside DEBUG builds.
This is addressing a bug where flags are only changed on debug build
devices or initially when changes. When nexuslauncher restarts the flag
is no longer retrieved.

Change-Id: Ieb6f460a271c918ee4e493b34692244f39cb3740
(cherry picked from commit e1664fcf14)
2020-03-18 22:01:28 +00:00
Lucas Dupin e73d415bcc Merge "Add wallpaper zoom to areas that have blur" into ub-launcher3-master 2020-03-18 21:59:33 +00:00
Sunny Goyal b6fe161f58 Adding additional logs to debug synchronous modification of update listeners
Bug: 151665474
Change-Id: I6f2d900852bd8dc76249781ab15cb6c269dd7a7a
2020-03-18 14:03:49 -07:00
TreeHugger Robot dfa091c0e9 Merge "Decoupling some drag and drop code handling" into ub-launcher3-master 2020-03-18 20:43:38 +00:00
Lucas Dupin 4918ed38d2 Add wallpaper zoom to areas that have blur
Whenever blurring, the wallpaper should also zoom out. This is the
mental model of our Depth System.

Test: manual
Bug: 149792636
Change-Id: I1783eb87fefeb6f917f0ba64f2c6ec8f1f2004fa
2020-03-18 13:29:58 -07:00
Sunny Goyal 9b18010990 Decoupling some drag and drop code handling
> Removing some special checks around accessibility drag
> Unifying folder alarm code path for accessible and normal DnD
> Maintaining mDragStartTime inside the dragDriver instead of the callers
> Simplifying some accessibility callbacks

Future cl will create a Accessibility DragDriver and unify it with
other DnD flow

Change-Id: I1919ef218de0174678110f271b450bcb9aaf4a5c
2020-03-18 12:41:42 -07:00
Jon Miranda 9794d4d52a Ensure current animation is cancelled before building new folder animation.
Fixes bug where folder clip padding gets stuck as false.

Bug: 146884730
Change-Id: I3a24e561d15fbc46837bb21cd8f97283e69f9ce1
2020-03-18 12:26:37 -07:00
Tracy Zhou 39467a9a27 Enable USE_SURFACE_VIEW_FOR_GRID_PREVIEW flag
This flag is behind grid_options flag, so it's safe

Fixes: 150224413
Test: N/A
Change-Id: Icebb4b8476d987a7f1697115183058a2345e6acc
2020-03-17 18:29:24 -07:00
TreeHugger Robot 0465b4d71e Merge "Show IME suggestions while tapping on Folder EditText" into ub-launcher3-master 2020-03-18 00:54:25 +00:00
TreeHugger Robot bc2424d726 Merge "Force finishing spring animation on second touch, if the animation is close to completion" into ub-launcher3-master 2020-03-17 23:28:25 +00:00
jayaprakashs 9c05d2db04 Show IME suggestions while tapping on Folder EditText
Current behaviour doesn't show the suggestions in IME if the folder
name is non-empty (Shown only if the folder name is empty).

This change shows the IME suggestions always, but primary suggestions
are shown only if the folder name is empty (not overwritting the
current folder name with suggestion).

Bug: 151762006

Tested: on phone. (created a folder name, assigned custom name, added
    the third app to Folder, tap on Folder EditText and it shows IME
    suggestions)
Change-Id: Ic4d43660a371b8dd7d18acb42fe3dee06a730347
2020-03-17 16:20:05 -07:00
Jonathan Miranda af106d3c0a Merge "Add staggered workspace animation to keyguard unlock animation." into ub-launcher3-master 2020-03-17 22:31:11 +00:00
Sunny Goyal 26729a129a Force finishing spring animation on second touch,
if the animation is close to completion

Bug: 151180649
Change-Id: I7085bb76d4937910d55cbaf1cb71a0e6c24922d5
2020-03-17 15:02:21 -07:00
Jon Miranda c298078241 Add staggered workspace animation to keyguard unlock animation.
Added behind FeatureFlag.KEYGUARD_ANIMATION due to dependency on
Ie94ab8ecd35e9dcc28d0b8f7aaeb058e15b0f80b.

Added dynamic resource unlock_staggered_velocity_dp_per_s so that the
animation can be tuned.

Bug: 151238866
Change-Id: I4d349d32cc7d86be3cdc582c2a7c565be2931444
2020-03-17 14:27:35 -07:00
Vinit Nayak 28cb71ba18 Default fixed_rotation to off
Change-Id: I83f9f58acb1718ee4fc19530a3e8b25badefda0e
2020-03-17 14:15:32 -07:00
Sunny Goyal 9ed7515314 Fixing NPE on app launch logging
Bug: 149969889
Change-Id: I2f3802df1dff76b91df330350783db2b7730f6d6
2020-03-17 12:06:24 -07:00
Tracy Zhou 24b449d557 Merge "The new grid migration algorithm" into ub-launcher3-master 2020-03-17 06:44:22 +00:00
TreeHugger Robot c73071281b Merge "Moving animation config so a separate class" into ub-launcher3-master 2020-03-17 03:39:41 +00:00
Sunny Goyal f3ac703256 Moving animation config so a separate class
Using PendingAnimation for animation builder.
This will allow us to easily add SpringAnimation to stateAnimation

Change-Id: I8d88489a5da6fc85747ef9be7c13858b441cd28a
2020-03-16 19:36:36 -07:00
TreeHugger Robot 29082d894b Merge "Overview actions-adds feature flag for select mode" into ub-launcher3-master 2020-03-17 00:44:37 +00:00
Zak Cohen 56280a314e Overview actions-adds feature flag for select mode
Adds a feature flag for whether select mode is available or not.

Test: local
Change-Id: Ia3bc920b47083b238dd7be3dae6c1f0216bc61e5
2020-03-16 16:38:22 -07:00
Samuel Fufa 42c5f9b833 Hide hybrid hotseat for dp3
Bug:142753423
Change-Id: I3b1c89ccf81b6d199f8911b64b329f50582a1225
2020-03-16 15:23:51 -07:00
TreeHugger Robot 795a7a6de5 Merge "Enable APP_SEARCH_IMPROVEMENTS flag." into ub-launcher3-master 2020-03-16 18:56:16 +00:00
Tracy Zhou cfe7efb7e2 Merge "Use SurfaceView to render grid preview" into ub-launcher3-master 2020-03-16 18:44:28 +00:00
jayaprakashs 3113fd8833 Enable APP_SEARCH_IMPROVEMENTS flag.
Bug: 151196870

Change-Id: I0665be5d585f64f3d43d42201a6529fd88247ca4
2020-03-16 11:06:15 -07:00
Tracy Zhou f601872a0a The new grid migration algorithm
go/grid-migration-v2

When changing grid from option 1 to option 2, we calculate the diff and add the icons that are in option 1 but not option 2, to option 2's workspace, according to the reading order.

Test: manual and unit tests
Fixes: 144052802

Change-Id: Id01f69e90ce656a9b7c9051fed499807ee9ac0f7
2020-03-13 14:56:38 -07:00
Hyunyoung Song 9caed38e34 Merge "Null check every ComponentName call inside FolderNameProvider" into ub-launcher3-master 2020-03-13 16:41:17 +00:00
Tracy Zhou 85f0c3b841 Use SurfaceView to render grid preview
Demo: https://drive.google.com/open?id=1wQ8dT5bfTxSh-NRQpNBwTCkKOtOOUMPj

Bug: 150224413
Test: Manual
Change-Id: I44e7baed1bcd15351e03dcbeb2b525bc1b325478
2020-03-12 23:06:36 -07:00
Hyunyoung Song f546e0599e Null check every ComponentName call inside FolderNameProvider
Bug: 150522230
Change-Id: I50007a3a781234797e16d830935a8b8585ac242b
2020-03-12 22:33:19 -07:00
thiruram 3af7178356 Fixes missing smart folder logging bug. Uses ProtoLite.toString method to log LauncherEvents.
Change-Id: I45dbf189e7bd47f8d4d7ba55180e59686bd6ecae
2020-03-12 16:26:02 -07:00
Tony Wickham b6bc08ad57 Merge "Invert playNonAtomicComponent() as onlyPlayAtomicComponent()" into ub-launcher3-master 2020-03-12 21:48:42 +00:00
Vadim Tryshev 6aa63d9f8e Merge "Fixing activity leak via accumulation of draw listeners" into ub-launcher3-master 2020-03-12 21:01:30 +00:00
vadimt f0d96f83f7 Fixing activity leak via accumulation of draw listeners
Bug: 139137636
Change-Id: I0a2f0849f886acaac31746ac7c9724c765692e88
2020-03-12 20:06:01 +00:00
Sunny Goyal 4e82f5bc36 Fixing crash when swiping up using 3P Launcher
Change-Id: Ia181edc1a00136374b3f0d848beccf0c9acd7b5c
2020-03-12 12:32:40 -07:00
TreeHugger Robot f85fcc792f Merge "Hide work apps when work profile is paused" into ub-launcher3-master 2020-03-12 18:12:59 +00:00
Samuel Fufa f5a4deb120 Hide work apps when work profile is paused
- hide overlay icon in landscape mode
- don't show edu if user has already seen legacy work profile edu
- make sure personal tab is highlighted when work profile is reinstalled
- always go home after a work profile is added or removed
- add tests for work edu flow

Bug: 150122946
Test: Manual
Change-Id: I8f80ac763acf03ca31a534464f4ddfd84528d329
2020-03-12 10:25:50 -07:00
Vinit Nayak b9ec9319c5 Add fixed_rotation_transform to home settings
This sets the feature flag on launcher side
and also updates the setting in Settings.Global
Launcher DOES NOT listen to the Settings.Global
change from adb anymore. This should take
preference over setting it from command line.

Also fix a related swipe to home animation bug
that happened w/ merge conflict.

Fixes: 150260456
Test: Set and unset, visually verified behavior.
Tested w/ autorotate on and off.
Checked Settings.Global value correctly updated
via "adb shell settings get global
fixed_rotation_transform"
TODO: Update tests to reflect this new
default-on fixed rotation behavior.

Change-Id: Id95f006eb1e92a59e24b05567298fd21b1409b13
2020-03-11 19:38:33 -07:00
Tony Wickham 984c01cbcd Invert playNonAtomicComponent() as onlyPlayAtomicComponent()
This avoids the double negative we use in a few places, so should be clearer.
Also added some comments to explain what the animComponents are used for.

Change-Id: Ibd25bd12efce6553b377bbd9c0651e4f4ac3e498
2020-03-11 18:21:53 -07:00
TreeHugger Robot 31ff98e144 Merge "Only allow horizontal spring if page will change." into ub-launcher3-master 2020-03-12 00:26:57 +00:00
Sunny Goyal 4acdb3bcd7 Merge "Removing some properties out of AnimationBuilder" into ub-launcher3-master 2020-03-12 00:20:15 +00:00
Sunny Goyal 003782f93c Removing some properties out of AnimationBuilder
AnimationBuilder and PendingAnimation have similar logic. This will
allow to unify the two classes

Change-Id: Id8c1d8a7020d132adbccdc6c80538ed6556cb75e
2020-03-11 16:35:36 -07:00
Jon Miranda 9e19866ed8 Only allow horizontal spring if page will change.
Bug: 150876921
Change-Id: I88db4c28ec3f8213c583e8a0dcd1cce2b1fee322
2020-03-11 14:53:42 -07:00
Tony Wickham ddb08885f9 Try orienting popup the other way if offset pushes it out of bounds
orientAboutObject() currently determines whether the popup should align
its left side with the icon or the right side. However, after
determining this, there is an offset to ensure the popup lines up with
the icon as expected, which might push it out of bounds. In that case,
we fallback to centering the popup. However, there might be plenty of
room on the other side, so we should just align the other direction
instead. Updated the logic to do that by first trying to align left
(in LTR) or right (in RTL), then trying again with the other alignment
if it doesn't fit after all x calculations are made.

Bug: 150644839
Change-Id: I219dae331bf790e461d91394ffe025d40ec54c9b
2020-03-11 12:27:44 -07:00
Hyunyoung Song d7c8441676 Merge "DeviceFlag change is not detected when phenotype updates." into ub-launcher3-master 2020-03-10 19:15:37 +00:00
Sunny Goyal dbcc63edeb Removing some autoboxing during property animation
Change-Id: Ibd6f20c565a4d66dc6d606b3f0bbc96fec66fe56
2020-03-10 08:43:55 +00:00
Sunny Goyal add170098c Merge "Converting some anonymous classes to lambda calls" into ub-launcher3-master 2020-03-10 08:43:41 +00:00