Commit Graph

22163 Commits

Author SHA1 Message Date
Treehugger Robot 982c2abef5 Merge "Also cancel TaskView collection Jobs when Overview is not on screen." into main 2025-03-25 10:37:01 -07:00
Daniel Andersson 1735205986 Merge "desktop-exploded-view: Avoid triggering layout when starting animation" into main 2025-03-25 09:21:05 -07:00
Treehugger Robot d4c2dedf81 Merge "Add null backup for title." into main 2025-03-25 08:36:53 -07:00
Uwais Ashraf deefa3db71 Also cancel TaskView collection Jobs when Overview is not on screen.
This prevents old scopes still being active when new TaskView state emissions are being sent to main. They were previously cancelled in time but still result in empty continuations occuring on main.

Bug: 395294954
Flag: com.android.launcher3.enable_refactor_task_thumbnail
Test: Manual - checking perfetto traces
Change-Id: I539a6fde8c9315ceeac74c9bf622d1e2dca1403a
2025-03-25 15:23:56 +00:00
Shamali Patwa 15fa804ddf Merge "Add ViewStubs for DWB layouts to avoid duplicate views in refactor" into main 2025-03-25 06:38:42 -07:00
Uwais Ashraf e54f38f7c7 Add null backup for title.
Fix: 403146003
Flag: EXEMPT - test bugfix
Test: Postsubmit runs
Change-Id: Icd94a207ba6e35b92c72e407db4ebc1ba0178723
2025-03-25 13:20:25 +00:00
Alex Chau f5956e01b2 Merge "Still play home task dismiss animation when aniamtorSet is null" into main 2025-03-25 05:03:06 -07:00
Treehugger Robot 5ff3717c6f Merge "Add debounce to TaskView emissions" into main 2025-03-25 03:58:44 -07:00
Treehugger Robot 0a3f31940d Merge "Notify StateManager of workspace reveal animations." into main 2025-03-24 23:34:33 -07:00
Treehugger Robot 373bb0d190 Merge "Fix broken quick switch from home gesture with recents-in-window enabled" into main 2025-03-24 21:41:08 -07:00
Daniel Andersson 07c09556f0 desktop-exploded-view: Avoid triggering layout when starting animation
This fixes an issue with the desktop task view unexpectedly jumping
first to the right, and then back to the left. See the bug for more
information.

Flag: com.android.launcher3.enable_desktop_exploded_view
Test: Manual
Bug=399822967

Change-Id: I3713b20effa2a7f25ca04ed83ed524772d23ca2f
2025-03-24 15:04:27 -07:00
Treehugger Robot 44552dc98f Merge "Stay in the current task when a new desk is created" into main 2025-03-24 13:23:22 -07:00
Uwais Ashraf 2f193110b7 Add debounce to TaskView emissions
The emissions of each TaskView on Overview open are usually:
1. task exists
2. icon loaded
3. then thumbnail loaded

If the 3 updates above come in quick succession, then ideally the first 2 will be debounced and the last one will be consumed immediately.

Debouncing only when thumbnails are not present gives the best results. This is because thumbnail loading is a decent predictor of there being no more emissions to come as they are typically the last emission for a TaskView.

Bug: 395294954
Flag: com.android.launcher3.enable_refactor_task_thumbnail
Test: ABTD run of failing metric
Change-Id: Ib57d6dc7d9f58b7bb37ec1177b23d89360c24c0e
2025-03-24 20:17:35 +00:00
Vinit Nayak 16210fa129 Merge changes I48079ecb,Ifda20367 into main
* changes:
  Revert "Re-use existing method to get split root"
  Revert "Reset leashes before starting taskbar app pair launch animation"
2025-03-24 13:14:22 -07:00
Min Chen d5aa8031b1 Merge "Pass displayId to CachedTaskInfo when needed" into main 2025-03-24 13:10:29 -07:00
Shamali Patwa bb04b1135f Merge "Revert "Improve reliability of cleanup done in onDestroy."" into main 2025-03-24 13:06:27 -07:00
Min Chen 0599eaa522 Merge "Make sure the correct input consumer is created" into main 2025-03-24 12:34:44 -07:00
Alex Chau 09a3453052 Still play home task dismiss animation when aniamtorSet is null
- If onPrepareGestureEndAnimation is called with null aniamtorSet, plays the dismiss animator directly with 0 duration

Fix: 405368787
Flag: EXEMPT bugfix
Test: manual, adb shell input keyevent KEYCODE_APP_SWITCH or Window + Tab with keybnoard from home
Change-Id: I16048f9454f79e2828c6a4a75b788b9838e886ab
2025-03-24 18:51:26 +00:00
Treehugger Robot 69998a8c77 Merge "Using Choreographer for getting refreshrate instead of display manager" into main 2025-03-24 11:10:42 -07:00
Bill Yi af19c1113e Merge "Import translations. DO NOT MERGE ANYWHERE" into main 2025-03-24 11:00:23 -07:00
Suhua Lei 77481d611b Stay in the current task when a new desk is created
Bug: 401002178
Flag: com.android.window.flags.enable_multiple_desktops_frontend
Flag: com.android.window.flags.enable_multiple_desktops_backend
Test: manual create new desks
Change-Id: Iaa29c557a421d5c51b90aa808188d3cabec89143
2025-03-24 17:19:17 +00:00
minch e7a054ae2b Make sure the correct input consumer is created
Let `isGestureBlockedTask` return false directly if
`mGestureBlockingTaskId` is not valid. This can avoid
the caller go to create incorrect InputConsumer when
the chekcing `taskId` is also invalid.

Bug: 402218420
Flag: EXEMPT bug fix
Test: m
Change-Id: Ia0cde8ee2b97fc92028458d01487d958f2e87a80
2025-03-24 17:00:28 +00:00
minch 956a9e0abb Pass displayId to CachedTaskInfo when needed
Bug: 401582344
Flag: EXEMPT refactor
Test: m
Change-Id: Id930db727dd0072ab5be04ae4272dc68c8b6dcb3
2025-03-24 16:18:09 +00:00
Sunny Goyal 836a832bfe Using Choreographer for getting refreshrate instead of display manager
Bug: 404582684
Flag: EXEMPT bugfix
Test: Manually verified that values are same as before even after changing refresh rate `adb shell settings put system peak_refresh_rate [30/60/90/120]`
Change-Id: I5d5468d8ab81a9a5e8d8cd67a9097423b750edb3
2025-03-24 08:51:53 -07:00
Shamali Patwa cfcb27aa9d Revert "Improve reliability of cleanup done in onDestroy."
This reverts commit 9cf28d1772.

Reason for revert: Fix in ag/32425180

Change-Id: I714665944384db6f68634de529272e618bccdad9
2025-03-24 08:46:36 -07:00
Schneider Victor-Tulias 6daf7fd963 Fix broken quick switch from home gesture with recents-in-window enabled
Flag: com.android.launcher3.enable_launcher_overview_in_window
Fixes: 405201109
Bug: 377678992
Test: used quick switch gesture from home with flag enabled. presubmit tests on temporary test cl
Change-Id: I8dbd3a41c350aba6c785aa0b2c8f20da7a468998
2025-03-24 11:17:50 -04:00
Treehugger Robot f67f97ade2 Merge "Fix action buttons visibility in handheld devices with blur enabled(1/n)" into main 2025-03-24 08:05:04 -07:00
Massimo Carli 2d70081aa5 Merge "Fix Test supporting HSUM" into main 2025-03-24 07:47:17 -07:00
Treehugger Robot 1d5064b8dc Merge "Add debug logging for task view touch controllers." into main 2025-03-24 06:17:26 -07:00
vinayjoglekar 7d27140a59 Fix action buttons visibility in handheld devices with blur enabled(1/n)
Added scrim in overview over blur.

Bug: 404479758
Test: Manual. Enter overview from home with and without tasks in handheld devices.
Flag: com.android.launcher3.enable_overview_background_wallpaper_blur
Change-Id: If8cb37099f2e2b1fa8bed1611ed359b49f255d64
2025-03-24 18:10:18 +05:30
Andy Wickham adb3bf5a8d Notify StateManager of workspace reveal animations.
This way any subsequent state changes during the animation will
cancel it. Previously swiping up to All Apps immediately after
going home would cause the 2 depth animations to interleave,
ending with a depth of 0, for example. Now the workspace depth is
cancelled and the All Apps depth is correctly applied.

Demo: https://drive.google.com/file/d/1R1BwYAsxj31FDgAeIZqZdJbuSz7s9PZy/view?usp=sharing&resourcekey=0-4UyZfAMxecSHWAyqyeNZmg

Fix: 405836159
Test: Manual (swipe home and immediately to all apps)
Flag: EXEMPT bugfix
Change-Id: Iac32f2a03a5cbbb297c71ebd9cfedc8ee6e8cae7
2025-03-24 11:07:28 +00:00
Treehugger Robot 69461b2d75 Merge "Add "change aspect ratio" to Recents/Overview" into main 2025-03-24 01:04:31 -07:00
Robin Lee 116eafb95c Add "change aspect ratio" to Recents/Overview
This shows up if the launcher is in a sw600dp-or-greater configuration.

Test: AspectRatioSystemShortcutTests
Test: OverviewMenuImageTest
Test: Manual check on phone, tablet, and inner/outer fold screens.
Flag: com.android.window.flags.universal_resizable_by_default
Bug: 357141415
Change-Id: I1bcbf9299d28ce68cccd636d92ed7195d64736eb
2025-03-24 06:56:05 +01:00
Wei Sheng Shih 7e4fa0f833 Merge "Revert^2 "Remove DepartingAnimationTarget from BackMotionEvent(2/2)"" into main 2025-03-23 21:51:51 -07:00
Treehugger Robot 88b2f23a83 Merge changes from topic "ttt-refactor" into main
* changes:
  Migrate to TopTaskTracker.getPlaceholderGroupedTaskInfo
  Introduce TopTaskTracker.getPlaceholderGroupedTaskInfo
2025-03-22 08:35:44 -07:00
Treehugger Robot 43b4273e91 Merge "[Memory Leak] Avoid spamming DragLayer's run queue" into main 2025-03-21 22:54:24 -07:00
minch 13e1445773 Migrate to TopTaskTracker.getPlaceholderGroupedTaskInfo
Migrate all the call sites of `TopTaskTracker.getPlaceholderTasks`
and `getSplitPlaceholderTask`s to the new API
`getPlaceholderGroupedTaskInfo`

Bug: 401582344
Flag: EXEMPT refactor
Test: m
Change-Id: I0d71508f4dd9633fea025ed842c4c048d0e70462
2025-03-22 05:23:06 +00:00
minch fba9726258 Introduce TopTaskTracker.getPlaceholderGroupedTaskInfo
This CL just introduces an API inside TopTaskTracker to return
a GroupedTaskInfo, no existing logic being migrated to it yet.

It will be used to replace `getPlaceholderTasks` and
`getSplitPlaceholderTasks` in the follow-up cls.

Bug: 401582344
Flag: EXEMPT, introduce a new API without usage
Test: m
Change-Id: Ic12003833605582d191c4abfd4a0878c266dd30f
2025-03-22 05:22:05 +00:00
Sukesh Ram 54f23ff654 Fix Pinning Animation
Fix Pinning Animation.

Flag: EXEMPT not adding new behavior
Bug: 405469510
Test: m
Change-Id: Iabc580031495f39902cb4d718ab12a7362c07d13
2025-03-21 17:18:45 -07:00
Shamali P 4ec89fbc63 Add ViewStubs for DWB layouts to avoid duplicate views in refactor
This CL just moves existing code to use view stubs. The refactor CLs
will use the flag to conditionally inflate these views.

Bug: 405359346
Fix: 405359346
Flag: EXEMPT refactor
Test: Existing screenshot tests and manual demo
Change-Id: Ib023d5f3538a0959a5965704a4ff18d769f8aa94
2025-03-21 16:26:07 -07:00
Fengjiang Li 8c7805b67a [Memory Leak] Avoid spamming DragLayer's run queue
Avoid adding duplicated ViewTreeObserver#addOnDrawListener from DepthController

Fix: 405158421
Flag: NONE - released code
Test: manual - presubmit
Change-Id: Ib59c130667c5c0a012de3205d11c8de1d6de3903
2025-03-21 13:40:17 -07:00
Treehugger Robot 500698152c Merge "Hide scroll arrows from Alt+Tab UI" into main 2025-03-21 11:41:55 -07:00
Saumya Prakash cfe62a68d2 Merge "Ensure back button shows up in Simple View for SUW" into main 2025-03-21 10:41:59 -07:00
Liran Binyamin 6fb96f4fac Merge "Remove flaky test from BubbleBarViewAnimatorTest" into main 2025-03-21 10:40:14 -07:00
Saumya Prakash 91a081f26c Merge "Shift to using SUW System property flag for expressive theme" into main 2025-03-21 09:10:33 -07:00
Liran Binyamin 386212e7aa Remove flaky test from BubbleBarViewAnimatorTest
This test is flaky in robolectric but does not repro locally.
Looking at the test it verifies that the animation doesn't get
canceled immediately after it starts. So the scenario here is an
edge case for something that shouldn't happen generally because
the animation is controlled in this class, although theoretically
other classes could obtain a reference to the physics animator and
cancel it directly. But since the test flakes badly, we're better
off without it until it can be fixed.

Bug: 404773413
Flag: EXEMPT test only
Test: atest BubbleBarViewAnimatorTest
Change-Id: I24493b71842a2fe859ffe40b6f375ade7ee8535d
2025-03-21 07:00:53 -07:00
Alex Chau df6dc455a7 Merge changes from topic "revert_task_content_view" into main
* changes:
  Revert "Add TaskContentView parent to TaskThumbnailViewHeader and TTV"
  Revert "Remove redundant FrameLayout from task_header_view.xml"
2025-03-21 04:14:36 -07:00
Wei Sheng Shih 1354a8e084 Revert^2 "Remove DepartingAnimationTarget from BackMotionEvent(2/2)"
This would create another SurfaceControl object through IPC, which is
unnecessary because the animation should run through
BackAnimationRunner.

Flag: com.android.window.flags.remove_depart_target_from_motion
Bug: 395035430
Test: execute back-to-home transition several times, verify no
predict_back animation leash left in offscreen layer.

Change-Id: Ib54380411438fc7169a37740bf09d7d83344f916
2025-03-21 07:43:20 +00:00
Bill Yi ce919b4cda Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I8f0b708b27ae14e4f8f7fd8e1b3be445d1409e61
2025-03-21 05:54:09 +00:00
Treehugger Robot a75e779ee8 Merge "[CD Taskbar] Bypass binder calls for TaskbarManager#getDefaultDisplayId()" into main 2025-03-20 16:25:34 -07:00