Commit Graph

76729 Commits

Author SHA1 Message Date
Anna Zhuravleva 94228b18db Merge "Add user_type field and log it in Launcher" into main 2023-11-30 10:28:45 +00:00
Johannes Gallmann 0c3b20b585 Merge "Use Decelerate Interpolator for predictive back to home window scaling" into main 2023-11-30 08:10:04 +00:00
Johannes Gallmann c07b1c92b0 Merge "Prevent scaled window from leaving screen bounds for back to home" into main 2023-11-30 08:09:39 +00:00
Tracy Zhou 6209f34b02 Use enableSplitContextually() to guard split keyboard shortcut feature
enableSplitFromFullscreenWithKeyboardShortcuts() depends on enableSplitContextually() from the product perspective, hence merging these two flags

Bug: 270394122
Test: N/A
Change-Id: Iecf46a62bfa21ed0c3bad9ca8c9e2646b3aebc78
2023-11-29 22:20:42 -08:00
Winson Chung abb4483f6f Merge "Add Launcher support for left-right splits on portrait foldables" into main 2023-11-30 05:52:57 +00:00
Jagrut Desai a5ad8bed64 Decreasing the intensity of haptic feedback for taskbar invocation
Test: Presubmit, Manual
Bug: 308496668
Flag: NONE
Change-Id: Ic8c28b8e84bf9f388a73c518c91840d958287546
2023-11-29 19:03:33 -08:00
Jon @ 95306b1502 Merge "Allow initial call to onLauncherVisibilityChanged when using home transition listener." into main 2023-11-30 01:15:26 +00:00
Andy Wickham c0c420a3c2 Adds ENABLE_SEARCH_HAPTIC_COMMIT feature flag.
This controls whether a haptic is played when search invocation
starts. The assumption is that the search app will play this
haptic if the flag is disabled (default).

Test: Manual
Bug: 310659178
Bug: 314005577
Flag: LEGACY ENABLE_SEARCH_HAPTIC_COMMIT DISABLED
Change-Id: I406c18cfaf27d004e19de26f00c997c0a03de996
2023-11-29 17:07:20 -08:00
Brandon Dayauon e9c7f41920 Null check activityContext because the activityContext can be null when called from SearchDelegateView.
Bug: 312585134
Test: presubmit
Flag: None
Change-Id: Id31f05f0bbaa07bc8b740f6f423a66896e9de5ba
2023-11-29 16:31:58 -08:00
Sebastián Franco 033a335801 Merge "Revert^2 "Moving rearrangementExists to ReorderLogic since it's only used there"" into main 2023-11-30 00:09:47 +00:00
Vadim Tryshev 54dbd42cae Merge "Waiting for Launcher activity to stop when starting a Launchable" into main 2023-11-29 21:57:45 +00:00
Vadim Tryshev 1b058fd467 Waiting for Launcher activity to stop when starting a Launchable
This will help to ensure that Launcher state has settled before continuing the test.

Bug: 313926097
Flag: N/A
Test: presubmit
Change-Id: I8bed0225617a225c2dc9587a75d004b98395fe1f
2023-11-29 13:55:46 -08:00
Sebastián Franco 61fbd18e5d Revert^2 "Moving rearrangementExists to ReorderLogic since it's only used there"
This reverts commit 484a7ea4f3.

Reason for revert: Fixing build error 

Change-Id: I00dcbb831dc40a90d43ada7315969251413bb88b
2023-11-29 21:54:51 +00:00
fbaron 77e0faa670 Update cell drop visualizer radius
Fix: 313665319
Test: NONE
Flag: NONE
Change-Id: I1a6ab76f2feb8175eca3af5fa62efa2cf8be01ba
2023-11-29 13:49:48 -08:00
Holly Jiuyu Sun 1facb1eb52 Merge "[tile] Repurpose PEOPLE_TILE result type to QS_TILE" into main 2023-11-29 21:47:59 +00:00
Federico Baron f638d01063 Merge "Revert^2 "Update status bar scrim"" into main 2023-11-29 21:36:04 +00:00
Jon Miranda bd53046738 Allow initial call to onLauncherVisibilityChanged when using home transition listener.
Fixes: 308632502
Flag: ACONFIG ENABLE_HOME_TRANSITION_LISTENER TEAMFOOD
Test: HomeTransitionObserverTest
Change-Id: I8992f8f74cbfa7e98a79a136265ee6c4ad784c2c
2023-11-29 13:35:03 -08:00
Andy Wickham 3523154b07 Use NavHandleLongPressInputConsumer regardless of flags.
This way we can still log long press attempts even when the
feature flags or settings are disabled.

We always log LAUNCHER_LONG_PRESS_NAVBAR when a long press is
detected, even if nothing else happens.

Additionally, we log LAUNCHER_DEEP_PRESS_NAVBAR if the long
press was short-circuited by a deep press. In this case both
logs will appear.

If ENABLE_LPNH_DEEP_PRESS is false, it's possible that
LAUNCHER_DEEP_PRESS_NAVBAR will be logged without
LAUNCHER_LONG_PRESS_NAVBAR. This is because we log deep press
even if the feature is disabled, but it won't cause long press to
trigger immediately, so the user may release their finger before
the normal long press triggers.

Note: getLongPressRunnable will still return null if the flags or
other checks fail, so nothing will happen beyond logging.

Fix: 313477667
Fix: 310955078
Test: Manual with wwlogcat with flags in various states
Flag: NA
Change-Id: I40ceb5a22b364c2d5d6e4fdabb546b81c84354eb
2023-11-29 13:02:27 -08:00
Schneider Victor-tulias f67c54b48f Fix Keyboard quick switch screenshots and spliscreen launch
Flag: LEGACY ENABLE_KEYBOARD_QUICK_SWITCH ENABLED
Fixes: 312449590
Fixes: 292182490
Test: TaplTestsKeyboardQuickSwitch, keyboard quick switched with split app pairs
Change-Id: I0faf2f7d58b39270ad6e5a065cf59f48e0dd23f0
2023-11-29 15:59:04 -05:00
fbaron 9efed13652 Add ACONFIG flag enable_unfolded_two_pane_picker
Bug: 301918659
Test: NONE
Flag: ACONFIG com.android.launcher3.enable_unfolded_two_pane_picker DEVELOPMENT
Change-Id: I16e4cafb676564faa9da2d7402357cb815fd178e
2023-11-29 20:56:09 +00:00
Bill Yi 319caa3642 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I4925744b7e1c3a48c6c6f94b0ab0bff0a5515572
2023-11-29 12:48:26 -08:00
Bill Yi b72796db31 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I8827e64a1ba84eb28febabd33f591faf7113f362
2023-11-29 12:47:12 -08:00
Greg Kaiser 4144564af6 Merge "Revert "Moving rearrangementExists to ReorderLogic since it's only used there"" into main 2023-11-29 20:36:54 +00:00
Greg Kaiser 484a7ea4f3 Revert "Moving rearrangementExists to ReorderLogic since it's only used there"
This reverts commit 6890893a24.

Reason for revert: Many build breaks, like https://android-build.corp.google.com/artifact/submitted/11157014/mokey_go32-trunk_staging-userdebug/latest/view/logs%2Fbuild_error.log , seem related to this.

Change-Id: I049c94fbd1e089c65fd4e0abb4ac2c165f228c92
2023-11-29 20:26:47 +00:00
Winson Chung 104a4c8b69 Add Launcher support for left-right splits on portrait foldables
Bug: 291018646
Test: Manual
Flag: enable_left_right_split_in_portrait

Change-Id: I92af7ffd83770f7e942c3892a12b1611ff5b50f4
Signed-off-by: Winson Chung <winsonc@google.com>
2023-11-29 20:20:14 +00:00
Sebastián Franco 1c1c18ca28 Merge "Moving rearrangementExists to ReorderLogic since it's only used there" into main 2023-11-29 19:18:18 +00:00
Sebastián Franco 1f04ea22b7 Merge "Enabling ENABLE_NO_LONG_PRESS_DRAG" into main 2023-11-29 19:17:14 +00:00
Sebastian Franco 7a08e54eed Enabling ENABLE_NO_LONG_PRESS_DRAG
This is a simple flag, I don't think it requires the new
flagging system, I mainly added the flag for ease of debugging
if it breaks test on postsubmit.

This flag was already tested using enabled but it was disabled
before trunk stable, I think we can set this to true without risk
and then remove the flag.

Flag: LEGACY ENABLE_NO_LONG_PRESS_DRAG ENABLED
Fix: 299748096
Test: atest TaplDragTest
Change-Id: If99027d8cec7d75eee11012615da0e0d76951755
2023-11-29 10:09:57 -06:00
Alex Chau 4745e95ea7 Merge "Adjust app chip menu top margin." into main 2023-11-29 14:40:12 +00:00
Anna Zhuravleva 9c20381231 Add user_type field and log it in Launcher
Add new field user_type to decouple
work_profile and private_space users.
Deprecate is_work boolean field.

Bug: 312200869
Test: statsd_testdrive 19, output: https://paste.googleplex.com/5912695996416000
Flag: NA
Change-Id: Idc25f341b4353a85b8a93eab97c88195895baedc
2023-11-29 10:26:53 +00:00
Vinit Nayak eabb37822f Merge "Change SplitInstructionsView cancel from X to "Cancel"" into main 2023-11-29 00:18:42 +00:00
Holly Sun e76f092fa9 [tile] Repurpose PEOPLE_TILE result type to QS_TILE
Bug: 313696037
Test: manual
Flag: NA
Change-Id: Ia04654678e6eb146b532c1b81f51ecfb1afea1c5
2023-11-28 16:03:24 -08:00
Vinit Nayak 33a432a3c4 Pass through both the widget's pendingIntent and remoteView intent
* Both may be necessary to correctly launch a widget
* We pass it through as the second app's Bundle instead
of adding a new parameter.

Bug: 311263727
Test: Tested w/ 2 fresh launches, app + widget.
Also with existing task + widget.
Was not able to accurately test multiple tasks launched by the
widget since there are some issues with the allowlist check.
And the working case for multiple instances of Chrome didn't
work because none of the chrome widgets rely on the secondary
intent to launch any of the app's activities.
Flag: None, technically this code isn't reachable since widgets
are unsupported, but didn't seem worthwhile to add a separate flag
in the short duration we will begin supporting them again.
To run replace the early return in QuickstepInteractionHandler with
the call:
mLauncher.getSplitToWorkspaceController()
	.handleSecondWidgetSelectionForSplit(view, pendingIntent, options.first)

Change-Id: I1ebcb385b140d42a6a84368f589aba06c4bed2bd
2023-11-28 14:58:44 -08:00
Vinit Nayak e5277ab8e7 Remove unused animation of splitInstructionsView text
* The animation of the overall view is
sufficient and we don't need this separate one

Flag: None
Bug: 295983387
Test: Visually appears the same
Change-Id: I6e3fe7191df8af869a50abab820d30e95e23696c
2023-11-28 14:39:18 -08:00
Pat Manning ad6b044412 Adjust app chip menu top margin.
Include adjusting gap of menu when expanding app chip.

Fix: 313648444
Test: OverviewImageTest
Flag: ACONFIG com.android.launcher3.enable_overview_icon_menu TEAMFOOD
Change-Id: Iea8ea76873ac008b90b6a8f183dc99cba9237041
2023-11-28 22:38:22 +00:00
Vinit Nayak d6efde5cbb Change SplitInstructionsView cancel from X to "Cancel"
* Styling (accent color) is still a TODO,
just made it bold for now.

Flag: ACONFIG com.android.wm.shell.enable_split_contextual DEVELOPMENT
Bug: 295983387
Test: Tested w/ flag on and off, cancel doesn't show
with flag off

Change-Id: Id5214a86abbe0cf095e32f6f75522ea51d6b1f3c
2023-11-28 14:34:12 -08:00
Charlie Anderson 89449a30b3 Merge "Add aconfig flag enable_launcher_br_metrics" into main 2023-11-28 21:54:39 +00:00
Sunny Goyal a481659e51 Merge "Merging widget item click listener to default click listener" into main 2023-11-28 21:36:15 +00:00
Sebastián Franco 27614fc8ce Merge "Making sure the Launcher is present when running the test" into main 2023-11-28 21:16:30 +00:00
Johannes Gallmann 8c197b9328 Merge "Fix task window losing scale when going back to home" into main 2023-11-28 20:35:13 +00:00
Johannes Gallmann b4f33ab7bb Merge "Fix crash in LauncherBackAnimationController" into main 2023-11-28 20:34:10 +00:00
Saumya Prakash 5feb491549 Add taskbar pinning education for new users and update other steps
This change updates the current transient taskbar education to include
the pinning feature and additional updates to Lottie animations. It also
removes the tutorial that teaches users to switch navigation modes. The
pinning education is gated behind an additional pinning education static flag.

Fixes: 302588455,300161174
Test: Went through taskbar education for persistent and transient
taskbar with the flag on and off.
Flag: ACONFIG com.android.launcher3.enable_taskbar_pinning DISABLED

Change-Id: I836467091bfe694eee89ac46c4be597c490e1b3f
2023-11-28 20:20:25 +00:00
Sunny Goyal 464509b375 Merging widget item click listener to default click listener
> Also removing check for dragHandle, since dragHandle is already removed

Bug: 307306823
Test: atest Launcher3Tests
Flag: N/A
Change-Id: I0b452dd1fbccf15ed686370471e8866b179fd77e
2023-11-28 12:07:16 -08:00
Schneider Victor-tulias 812bc2a9c5 Merge "Refactor LottieAnimationColorUtils to enforce proper usage" into main 2023-11-28 19:49:36 +00:00
Jordan Silva 837fb91423 Merge "Validate responsive specs using more than 100% of remainder space" into main 2023-11-28 19:49:30 +00:00
Schneider Victor-tulias 891865dd60 Merge "Fix NPE in TaskAnimationManager" into main 2023-11-28 19:49:22 +00:00
Jordan Silva 2b5bac90b8 Merge "Update where responsive grid cell icon size is defined" into main 2023-11-28 19:48:43 +00:00
Sunny Goyal eb67c99e5f Merge "Removing unnecessary iconFactory class when generating badged icon" into main 2023-11-28 19:02:02 +00:00
Vinit Nayak 2349efe50d Merge "Revert "Add logs for workspace long press"" into main 2023-11-28 18:51:23 +00:00
Holly Jiuyu Sun b265cf8fdd Merge "[PS] Add emphasized interpolators when clicking the PS tile to scroll to bottom." into main 2023-11-28 18:41:00 +00:00