Commit Graph

76729 Commits

Author SHA1 Message Date
Treehugger Robot 45af4de0a1 Merge "[ps] Add data source for launcher." into main 2023-12-06 01:05:27 +00:00
Jagrut Desai 66283595b9 Fixing/Adding Support for "Move to top/left" and "Move to bottom/right" Talkback Menu Item Action
Test: Manual
Bug: 307878012
Flag: NONE
Change-Id: I9d80c3c976193bfea911e1531ed180f4ee4aa8f5
2023-12-05 13:55:49 -08:00
Vadim Tryshev 878784aa2d Merge "Waiting for Launcher activity to stop in OverviewTaskMenu.tapAppInfoMenuItem" into main 2023-12-05 21:34:23 +00:00
Vadim Tryshev 61434924f0 Waiting for wallpaper animation completion when configuring new widget
This will help to ensure that Launcher state has settled before continuing the test.

Bug: 313926097
Flag: N/A
Test: presubmit
Change-Id: Ice7ae8a2517d68c53d135a34cc33e11f3203f788
2023-12-05 13:32:41 -08:00
Jordan Silva 85cea3e07b Merge "Update ReorderWidget tests to drag and drop widget inside the board" into main 2023-12-05 21:18:29 +00:00
Will Leshner 9dce65e05a Show Launcher's widget picker in an activity.
Bug: 307306823
Test: atest Launcher3Tests
Flag: NA

Change-Id: I28ef731abcdf1bd44c66366d42a135912dbcc5be
2023-12-05 13:12:05 -08:00
Tracy Zhou 7fae462565 Pass in navigation bar panel context created by task bar when taskbar navbar unification is on
When the flag is on, task bar is created with window context navigation bar. The floating rotation button window context should be in navigation bar panel.

Fixes: 309930089
Test: N/A
Change-Id: I730a4b898d9fb65cc5d7544dcb37dfe32d49a632
2023-12-05 12:53:51 -08:00
Tony Wickham d546564f3e Change TAPL to swipe to stash taskbar (instead of deprecated long press)
This also means Taskbar is transient by default in automated tests,
instead of persistent. Updated some checks accordingly.

Flag: LEGACY ENABLE_TRANSIENT_TASKBAR ENABLED
Test: TaskbarExpandCollapse#hideShowTaskbar; TaplTestsTaskbar;
TaplTestsTransientTaskbar; TaplTestsPersistentTaskbar
Bug: 270395798

Change-Id: Ie7b8fcedb94e33742b7bf18cb829dab55af74b7d
2023-12-05 20:38:41 +00:00
Priyanka Advani f796ae1c2a Merge "Revert "Update isLauncherInitialized check to wait until Launcher has stopped binding items"" into main 2023-12-05 19:08:41 +00:00
Sebastian Franco e4965124ad Moving startBinding and clearPendingBinds to ModelCallbacks
Changes are part of go/launcher_SoR .

Flag: NA
Bug: 301108526
Test: This is a no-op change, compiling should be the test
Change-Id: I49eb6f88bb680c289f4e73cc108671b37b18fae7
2023-12-05 13:04:42 -06:00
Sebastián Franco 8d07e2f80a Merge "Adding ReorderParameters to ReorderAlgorithm" into main 2023-12-05 19:03:05 +00:00
Jordan Silva 3e5688af97 Fix folder icon drawable padding for responsive grid
Bug: 314285621
Flag: ACONFIG com.android.launcher3.enable_responsive_workspace TEAMFOOD
Test: NexusLauncherImageTests
Test: DeviceProfileDumpTest
Test: DeviceProfileAlternativeDisplaysDumpTest
Change-Id: I502a112a0c7d1e6ec1de8501efb8d2893436e880
2023-12-05 15:12:29 -03:00
Sunny Goyal 1aaa3aa795 Merge "Revert^3 "Changing SystemUiProxy to kotlin"" into main 2023-12-05 17:23:24 +00:00
Priyanka Advani 99d2b4827d Revert "Update isLauncherInitialized check to wait until Launcher has stopped binding items"
This reverts commit 7ab2c874c9.

Reason for revert: Likely culprit for b/311366267

Change-Id: I52a2c7527a90698866aef44217230ef7ae5064ee
2023-12-05 17:07:38 +00:00
Tracy Zhou d4235f504b Merge "Do not apply rounded corner background to task bar when it's in phone mode" into main 2023-12-05 16:55:26 +00:00
Jordan Silva 21cdba04c3 Update ReorderWidget tests to drag and drop widget inside the board
Fix: 314946012
Flag: N/A
Test: ReorderWidgets
Change-Id: I9e160e76a1fff568af9b21bebc46ef11fb97b962
2023-12-05 10:55:31 -03:00
Anna Zhuravleva 2ef6704e61 Log taps on PS container buttons
Log taps on space locked/unlocked, settings
buttons

PDD: https://eldar.corp.google.com/assessments/873128385/revisions/1

Test: logcat StatsLog, output
https://paste.googleplex.com/6250774946906112
Bug: 314933661
Flag: ACONFIG com.android.launcher3.Flags.enable_private_space TEAMFOOD
Change-Id: I528443ba56a0db144ce613ea8d41426b6ede434d
2023-12-05 13:40:00 +00:00
Andreas Agvard 52b5113e8d Merge "Adds supportsCommitHaptic" into main 2023-12-05 12:48:15 +00:00
Johannes Gallmann e8575dfbe9 Merge "Fix delayed taskbar animation for predictive back" into main 2023-12-05 12:37:30 +00:00
Jeremy Sim 6b99fe1a00 Revert^2 "Refactor/clean up Overview Actions buttons"
Second attempt after ag/25292769 was reverted (fixed the screenshot test failure)

Bug: 274835596
Test: atest OverviewImageTest#testOverview
Flag: NA
Change-Id: I3e442264e946b3a0979ca3e401b9ffd30671a291
2023-12-05 11:36:01 +00:00
Satish Yalla b85266aef2 Merge "Revert "Change TAPL to swipe to stash taskbar (instead of deprec..."" into main 2023-12-05 10:21:18 +00:00
Sunny Goyal f002d014cd Revert^3 "Changing SystemUiProxy to kotlin"
b1e430bcb9

Change-Id: I67ed9f357da99119686f935252c8ab88416b56bd
2023-12-05 07:28:46 +00:00
Satish Yalla de82f8f44f Revert "Change TAPL to swipe to stash taskbar (instead of deprec..."
Revert submission 25532044-tapl-transient-taskbar-default

Reason for revert: <test revert (b/314873201)>

Reverted changes: /q/submissionid:25532044-tapl-transient-taskbar-default

Change-Id: I51e78699f588a8fe8506c96398de921448e0ab6a
2023-12-05 06:48:25 +00:00
Federico Baron c22bc0dbf8 Merge "Add ACONFIG flag enable_unfolded_two_pane_picker" into main 2023-12-05 06:25:58 +00:00
Tracy Zhou ec26a138d5 Do not apply rounded corner background to task bar when it's in phone mode
Fixes: 311428370
Test: Make sure nav bar in landscape phone mode doesn't have weird clips
Change-Id: I0c402dd10a3bd39afd5692d21ef8adaad04646db
2023-12-04 22:07:04 -08:00
Schneider Victor-tulias dc4b61be59 Merge "Fix Keyboard quick switch screenshots and spliscreen launch" into main 2023-12-05 04:10:13 +00:00
Tony Wickham 2f334e9ca7 Merge "Change TAPL to swipe to stash taskbar (instead of deprecated long press)" into main 2023-12-05 02:40:02 +00:00
Vadim Tryshev 01444246cd Waiting for Launcher activity to stop in OverviewTaskMenu.tapAppInfoMenuItem
This will help to ensure that Launcher state has settled before continuing the test.

Bug: 313926097
Flag: N/A
Test: presubmit
Change-Id: I1100ec8e015a67ebef8b7e834b55b1ed5fcabae8
2023-12-04 18:22:33 -08:00
Sukesh Ram ea6f544f7d Merge "Fix 3-Button Color w/ Widget Sheet post-Rotation" into main 2023-12-04 23:39:13 +00:00
Vadim Tryshev dc7de0d9fb Merge "Waiting for Launcher activity to stop when starting an overview task" into main 2023-12-04 21:47:09 +00:00
Schneider Victor-tulias a74612611d Merge "Update isLauncherInitialized check to wait until Launcher has stopped binding items" into main 2023-12-04 20:02:10 +00:00
Sunny Goyal 21eeda4cc3 Merge "Revert^2 "Changing SystemUiProxy to kotlin"" into main 2023-12-04 19:30:37 +00:00
Vadim Tryshev 7b78d4093b Merge "Not diagnosing taskbar as <Launcher in invalid state>" into main 2023-12-04 19:21:17 +00:00
Holly Sun b226257c17 [cleanup] Clean up LayoutType.PEOPLE_TILE.
Bug: 313696037
Test: manual
Flag: LEGACY ENABLE_PEOPLE_TILE_PREVIEW DISABLED
Change-Id: Iae66c86357ef50a97083c79d6a94d038ad83dcf1
2023-12-04 11:14:00 -08:00
Sunny Goyal 3de59f24a0 Revert "Revert "Removing unnecessary iconFactory class when gene..."
Revert submission 25518508-revert-25483550-themed-badge-GJNKEECDMN

Reason for revert: Fixed badging bug

Reverted changes: /q/submissionid:25518508-revert-25483550-themed-badge-GJNKEECDMN

Change-Id: I0f378eaabcb7bdea855b80a33bdec007c9b11436
2023-12-04 18:53:50 +00:00
Sunny Goyal b1e430bcb9 Revert^2 "Changing SystemUiProxy to kotlin"
49997a7cf9

Change-Id: Ieed3f7ad7c9d36ee1c2fc53e0c03df34698c256d
2023-12-04 17:21:22 +00:00
Pat Manning f9e64bc0ce Merge "Revert^2 "Update cell drop visualizer radius"" into main 2023-12-04 11:06:00 +00:00
Pat Manning 5004d4dd3b Merge "Update focus indicator radius to match workspace drag indicator radius." into main 2023-12-04 11:06:00 +00:00
Sebastian Franco 25f8e406a7 Adding ReorderParameters to ReorderAlgorithm
No logic change made.

Flag: NA
Bug: 229292911
Test: ReorderAlgorithmUnitTest
Change-Id: Iababd2fba688a482cffe6d2243c987b0c022c6a5
2023-12-03 22:39:50 -06:00
Himanshu Gupta b6ebbb019c Fixing dangling PS container on profile addition.
When Work profile state is changed, the all apps container is redrawn
Eventually `PrivateProfileManager.reset()` is also called but PS decorator
is not added as there is no change in PS state.
https://photos.app.goo.gl/V2bmZWfzBzcRP97C8
To fix this, we allow decorator addition on reset, but only
apply the same when its not already present in the recycler view.

Flag: ACONFIG com.android.launcher3.Flags.enable_private_space DEVELOPMENT
Bug: 313498792
Test: PrivateProfileManagerTest
Change-Id: I4c9a89d84e670ed45bf53a2d2e2c4922b165463e
2023-12-03 23:34:19 +00:00
Himanshu Gupta f63c645d8c Merge "Fixing work widgets tab in WidgetsFullSheet." into main 2023-12-03 23:33:42 +00:00
Himanshu Gupta c2a2b86e76 Fixing work widgets tab in WidgetsFullSheet.
Currently the work widget matcher matches against all
non-foreground user profiles, due to which the work
tab is incorrectly shown in widgets full screen, when
PS is present.
This was missed in ag/25129268 where a bunch of work
matcher fixes were done.

Flag: ACONFIG com.android.launcher3.Flags.enable_private_space DEVELOPMENT
Bug: 312900122
Test: Launcher3 tests
Change-Id: I80d33e851ea3366dc3897bb1f5cc17fcd6b34520
2023-12-03 21:23:44 +00:00
Andreas Agvard 973c049fe0 Adds supportsCommitHaptic
Test: Manual
Bug: 314408519
Flag: LEGACY ENABLE_SEARCH_HAPTIC_COMMIT ENABLED
Change-Id: Ia8f90489c2b8d82f6c63b4b363f9be5de6b2598b
2023-12-02 11:04:51 +01:00
Andreas Agvard 4b9a14cd8b Merge changes I9c92d3cb,I98e2dea9 into main
* changes:
  Increase slider for haptic hint iterations
  Enables ENABLE_SEARCH_HAPTIC_COMMIT
2023-12-02 08:55:57 +00:00
Vadim Tryshev caf5958e57 Waiting for Launcher activity to stop when starting an overview task
This will help to ensure that Launcher state has settled before continuing the test.

Bug: 313926097
Flag: N/A
Test: presubmit
Change-Id: Ie72853a9d289b2688fdfbdf5220ce86808ac2da1
2023-12-01 16:15:45 -08:00
Sukesh Ram b8ddc944ff Fix 3-Button Color w/ Widget Sheet post-Rotation
Fixed issue where upon opening the widgets menu in the home screen in landscape, then rotating screen to portrait, then back to landscape (whilst keeping widget sheet open), the buttons are dim colored rather than white.

Flag: NONE
Test: Manually tested in pixel 7 in light mode and dark mode (with home screen rotation enabled).
Bug: 284801356
Change-Id: I0ed59373eb3af5f1b5ab695b43b850777042d2eb
2023-12-01 22:53:09 +00:00
Sebastián Franco b70b7fde7a Merge "Moving the remainder of reorder logic to ReorderAlgorithm" into main 2023-12-01 21:32:50 +00:00
Federico Baron 5f46067417 Merge "Fix flicker for widget picker" into main 2023-12-01 21:01:38 +00:00
Andreas Agvard 23de925836 Increase slider for haptic hint iterations
The haptic hint can now be made up to 200 itertions long (2.4 seconds)

Test: Manual
Flag: LEGACY ENABLE_SEARCH_HAPTIC_HINT DISABLED
Change-Id: I9c92d3cb24fabfa3b0d318a77d312423501737a6
2023-12-01 21:16:14 +01:00
Andreas Agvard fd7f192a0a Enables ENABLE_SEARCH_HAPTIC_COMMIT
ENABLE_SEARCH_HAPTIC_COMMIT should be enabled for now to keep consistency in
behavior.

Test: Manual
Flag: LEGACY ENABLE_SEARCH_HAPTIC_COMMIT ENABLED
Bug: 314005577
Change-Id: I98e2dea91fe58b6abaeeb63f6c92a5ee130b5204
2023-12-01 21:16:14 +01:00