Commit Graph

76729 Commits

Author SHA1 Message Date
Sebastian Franco afd0e4ab11 Making sure the Launcher is present when running the test
It seems that when a previous test fails this test starts failing
so we are not making sure we are in a correct state.

Bug: 303263644
Flag: NA
Test: will see if the flake rate goes down
Change-Id: I7ecdc0ea82914331d68fe20bf2665d2812bca46f
2023-11-28 12:35:39 -06:00
Sebastián Franco 4a708997a1 Merge "Moving the static initialization method from TaplTestsLauncher3 to AbstractLauncherUiTest" into main 2023-11-28 18:32:58 +00:00
Sergey Pinkevich d3087e3c16 Merge "Fix blinking for the active tile" into main 2023-11-28 18:31:07 +00:00
Tracy Zhou 898aec864d Merge "[taskbar/navbar unification] Do not shift back button after unlocking in phone mode" into main 2023-11-28 18:20:58 +00:00
Andy Wickham 9e6f276d41 Merge "Adds withPackageName to StatsLogger creation" into main 2023-11-28 17:15:55 +00:00
Schneider Victor-tulias e861fa05bc Merge "Refactor ActiveGestureLog and CompoundString in preparation for ProtoLog 2.0" into main 2023-11-28 16:23:47 +00:00
Schneider Victor-tulias ed2eba9beb Refactor ActiveGestureLog and CompoundString in preparation for ProtoLog 2.0
We will need to send formatted strings to the ProtoLog api, so it is simpler to use CompoundString as the default string storage in ActiveGestureLog.

Refactored CompoundString to be able to be broken down into a formattable string.

Flag: N/A
Fixes: 313640579
Test: ran launcher, completed gestures, dumped gesture logs
Change-Id: I5f290d1860c6bac5047cbf361537829fbe986685
2023-11-28 16:23:38 +00:00
Jordan Silva 4c09958671 Validate responsive specs using more than 100% of remainder space
Fix: 313463517
Flag: ACONFIG com.android.launcher3.enable_responsive_workspace TEAMFOOD
Test: ResponsiveSpecsProviderTest
Change-Id: Ic80846d27dabd8d57f43b35581174bd2f2f3611b
2023-11-28 15:11:27 +00:00
Jordan Silva 15cacd54c6 Update where responsive grid cell icon size is defined
This CL changes where the cell icon size, text size and drawable padding is defined to prevent an issue with taskbar.
The transient taskbar updates the DeviceProfile icon size with a different value than used for responsive grids, and this update wasn't working anymore because responsive grid implementation wasn't reading the value from iconSize inside the updateIconSize function, but from the responsive grid spec.

Bug: 313463280
Flag: ACONFIG com.android.launcher3.enable_responsive_workspace TEAMFOOD
Test: manual
Test: NexusLauncherImageTests
Change-Id: I835a90d724c2d1b2d32f483b758b789be7cbdcfe
2023-11-28 14:42:06 +00:00
Helen Cheuk 4a6d4994c3 Merge "Remove excess entry before putting new item" into main 2023-11-28 13:03:53 +00:00
Sergey Pinkevich 6c7ddc9b90 Fix blinking for the active tile
Call of `buildAnimationController` within `View#onApplyWindowInsets` if endTarget is not null.

Bug: 312439564
Flag: ACONFIG com.android.launcher3.enable_grid_only_overview TEAMFOOD
Test: manual - took a screen recording:
Before - https://drive.google.com/file/d/1P2GsTi0xCZFjAsTQKonMMADHGkKuxMe0/view?usp=sharing
After - https://drive.google.com/file/d/1xkbFa-2Xp1OwmPrKLcqE2cYshVRXY2YV/view?usp=sharing

Change-Id: I6eb2a48bb548e20c1d36a058921ff8e1a0983cad
2023-11-28 12:24:40 +00:00
Thales Lima 5fc47806f8 Merge "Make numFolderRows/numFolderColumns accept more values" into main 2023-11-28 11:22:27 +00:00
Johannes Gallmann 1de8952a30 Fix task window losing scale when going back to home
Bug: 305934426
Flag: NONE
Test: Manual, i.e. testing back to home with different devices and device orientations
Change-Id: I3eddbc918de95be713aecb469501b01e6b7b3d3b
2023-11-28 11:33:29 +01:00
Vadim Tryshev 8f2dc92364 Merge "Permanently demoting stress tests from presubmit to speed up presubmits" into main 2023-11-28 02:38:25 +00:00
Holly Sun 454590d7ea [PS] Add emphasized interpolators when clicking the PS tile to scroll to bottom.
UX spec: https://carbon.googleplex.com/google-material-3/pages/easing-and-duration/tokens-specs/bd8df608-11ee-48f9-b93d-90d74e3d35c8#5fa37127-0934-4c47-804e-cb2fbf47f73d. Use the first column "Emphasized" one.
Duration: 500ms

video: https://drive.google.com/file/d/1EYlkWVgiYFy0IB5WnQRVoQ9b_sbEkLj7/view?usp=sharing

Bug: 309522136
Test: manual
Flag: ACONFIG com.google.android.apps.nexuslauncher.inject_private_space_tile DEVELOPMENT
Change-Id: I178c075ebf5db8338f476d0607caabec7b8c7fde
2023-11-27 16:42:33 -08:00
Sebastián Franco 463131427d Merge "Add unit test for CellLayout making sure the reorder are valid and fix Multipage CellLyout" into main 2023-11-28 00:27:21 +00:00
Vinit Nayak fd66d09e94 Revert "Add logs for workspace long press"
This reverts commit 74fb544c27.

Reason for revert: b/311099513 is now no longer flaky. I suspect these logs may have improved a possibly existing race condition. Let's see if the flake returns w/o these logs.

Change-Id: Ib3a06b7d86f4eb5c3c95db9a68bc6eb15aead193
2023-11-28 00:22:02 +00:00
Federico Baron f378be865d Merge "Fix activity leak in QuickstepLauncher" into main 2023-11-28 00:02:30 +00:00
Sunny Goyal 0069e54f1e Removing unnecessary iconFactory class when generating badged icon
Bug: 276957152
Test: Verified on device
Flag: None
Change-Id: I31ca3ef939684b16c0134d19f0add574b4b59706
2023-11-27 15:44:31 -08:00
Sebastian Franco 6c7d817bc7 Add unit test for CellLayout making sure the reorder are valid and fix Multipage CellLyout
The new test generate hundreds of new boards using a fixed seed so the
test cases can be recreated if there is an error.

Some of the new clases where inside of CellLayoutBoard and moved
outside.

Flag: LEGACY FOLDABLE_SINGLE_PAGE DISABLED
Bug: 270395274
Test: ReorderAlgorithmUnitTest
Change-Id: I083fb6701b02b7c0b2cf24634ca71acb0c75902e
2023-11-27 17:12:43 -06:00
Sebastian Franco 6890893a24 Moving rearrangementExists to ReorderLogic since it's only used there
Also, simplify copyCurrentStateToSolution since it always gets false
as the second parameter.

Flag: NA
Bug: 229292911
Test: ReorderAlgorithmUnitTest
Change-Id: I025566897246fa59ca513cb7de9a12465054498f
2023-11-27 16:36:44 -06:00
Vadim Tryshev 5feaf596e6 Permanently demoting stress tests from presubmit to speed up presubmits
Bug: 187761685
Test: presubmit
Flag: N/A
Change-Id: Ib2edf419ad556d2a4bf5c77b5c026829f9b413b9
2023-11-27 11:54:22 -08:00
Sunny Goyal eb29313595 Updating WidgetSheets so that it can be displayed in any
activity and not just Launcher

Bug: 307306823
Test: atest Launcher3Tests
Flag: NA
Change-Id: I0e33323805c6e895e3a1639ecf5933e698212c65
2023-11-27 11:17:04 -08:00
Pat Manning 37cf983825 Merge "Wait for IME to hide in test only if software keyboard." into main 2023-11-27 18:32:23 +00:00
fbaron c04ad685f5 Fix activity leak in QuickstepLauncher
Fix: 312397873
Test: TaplAppIconMenuTest#testLaunchMenuItem
Flag: NONE
Change-Id: I63fe5fa5b3f2d301017dc6fb375e7a56e3e5fb4d
2023-11-27 18:10:45 +00:00
Federico Baron e517f0de70 Revert^2 "Update status bar scrim"
e620fc80c9

Change-Id: Id129124b5cdaaebd33b6f9671f34390d398691b4
2023-11-27 16:59:53 +00:00
helencheuk f2fc14ec4c Remove excess entry before putting new item
It is to fix gpu memory usage increase. Remove excess entry first so its max memory usage should not increase

Fix: 309182285
Flag: ACONFIG com.android.launcher3.enable_grid_only_overview TEAMFOOD
Test: N/A
Change-Id: I40b4ec50c09001e6ee9d012bdcdd1444230daac3
2023-11-27 14:57:38 +00:00
Helen Cheuk 946a2493eb Merge "Not show hover border on select mode" into main 2023-11-27 14:21:29 +00:00
Pat Manning b8145edf05 Wait for IME to hide in test only if software keyboard.
Fix: 311410127
Test: TaplKeyboardFocusTest#testAllAppsExitSearchAndFocusSearchResults
Flag: NONE.
Change-Id: I74f1023bdf9118abaa9cda651b881ef60636da34
2023-11-27 13:53:03 +00:00
Pat Manning 0f395e8a11 Update text style for icon app chip menu.
Bug: 311657856
Test: OverviewImageTest
Flag: ACONFIG com.android.launcher3.enable_overview_icon_menu TEAMFOOD
Change-Id: Ied1c5fddb94e3093729846cacfef9b257aad8df7
2023-11-25 11:24:45 +00:00
Thales Lima 24051842c7 Make numFolderRows/numFolderColumns accept more values
Now they can hold values for different configurations, making it akin to iconSize.

Bug: 309800141
Test: DeviceProfileResponsiveDumpTest
Test: DeviceProfileResponsiveAlternativeDisplaysDumpTest
Test: DeviceProfileDumpTest
Test: DeviceProfileAlternativeDisplaysDumpTest
Flag: ACONFIG com.android.launcher3.enable_responsive_workspace TEAMFOOD
Change-Id: I9d5cccda88a0311dbe0beecef194cc8d60c5c280
2023-11-24 15:54:56 +00:00
Jordan Silva 0bb6034f74 Merge "Extract cell size information to responsive grid structure" into main 2023-11-24 14:36:39 +00:00
Alex Chau c95a4e6b1d Merge "Revert "Remove logs for bug investigation"" into main 2023-11-24 14:02:39 +00:00
Jordan Silva 999dd2a06f Extract cell size information to responsive grid structure
Bug: 287975993
Flag: ACONFIG com.android.launcher3.enable_responsive_workspace TEAMFOOD
Test: ResponsiveCellSpecsProviderTest
Test: DeviceProfileDumpTest
Test: DeviceProfileResponsiveDumpTest
Change-Id: I26a87d9b690fdfcff1599d862c09e97fe9f9f930
2023-11-24 12:39:36 +00:00
Pat Manning 78a2dd66b2 Merge "Close allapps on press of ESC key." into main 2023-11-24 12:30:04 +00:00
Jordan Silva 2e1b287038 Merge "Use DeviceProfile numFolderRows and numFolderColumns" into main 2023-11-24 12:29:19 +00:00
Pat Manning a7a04fe901 Close allapps on press of ESC key.
Fix: 310206847
Test: TaplOpenCloseAllApps
Flag: NONE
Change-Id: I9b9f958eb2889680b731dd7134fce2793e62eb74
2023-11-24 11:03:13 +00:00
Johannes Gallmann e36c615716 Fix crash in LauncherBackAnimationController
Bug: 312949302
Flag: NONE
Test: Manual, i.e. testing quick fling back to home gesture
Change-Id: I670b2f02cab097b1d7a202a5b07fbda33d372ac8
2023-11-24 10:11:46 +01:00
Avinash Vadlamudi d1047f5415 Merge "Add necessary metric collections for barcode detection in Overview." into main 2023-11-24 01:31:07 +00:00
Sebastián Franco 525b0343f8 Merge "Moving classes inside of CellLayout to their own file" into main 2023-11-24 01:27:13 +00:00
Sebastian Franco 5f0af4f633 Moving classes inside of CellLayout to their own file
This is a no-op change ensure this we have ReorderAlgorithmUnitTest.

Flag: NA
Bug: 229292911
Test: ReorderAlgorithmUnitTest
Change-Id: I6ffe2a1260f869a4686a9f1e652dd1ab6d406269
2023-11-23 23:13:56 +00:00
Schneider Victor-tulias 2b988e5fd2 Fix NPE in TaskAnimationManager
Flag: N/A
Fixes: 312949734
Test: ran launcher and launched overview from home and app
Change-Id: I7894749ac196dfd07b5e2bfa5d801040ef9b34c6
2023-11-23 14:16:17 -05:00
Alex Chau 58a8c12713 Revert "Remove logs for bug investigation"
This reverts commit dad61a0098.

Reason for revert: b/279059025

Change-Id: Id8fcd1ddf67d7df0a23c81e3ddf3849c26c529bd
2023-11-23 19:01:16 +00:00
Schneider Victor-tulias 71afdf2f19 Refactor LottieAnimationColorUtils to enforce proper usage
Flag: N/A
Fixes: 312941637
Test: launched all set page and gesture nav tutorial
Change-Id: Iaa320fea0e78a93c4e955f617cb821a47aac6f96
2023-11-23 18:28:10 +00:00
Pat Manning 3e43b8a996 Merge "Do not hide icon app chip menu when resetting color tint." into main 2023-11-23 14:23:24 +00:00
Avinash Vadlamudi cd02807544 Add necessary metric collections for barcode detection in Overview.
- Log required metric events for the barcode content interactions.

Flag: ACONFIG com.google.android.apps.miphone.aiai.matchmaker.overview.ui.enable_barcode_detection_in_overview DEVELOPMENT
Bug: 310757242
Test: Built and tested on Pixel device.
Change-Id: Iff4e4a3aec35d9d096f5b52eab0124f6e7f22e15
2023-11-23 12:26:41 +00:00
Pat Manning c078064450 Do not hide icon app chip menu when resetting color tint.
Fix: 312372713
Test: Manual.
Flag: ACONFIG com.android.launcher3.enable_overview_icon_menu TEAMFOOD
Change-Id: Iab860eb7e69ddb47913b01040ca706a8d829abe6
2023-11-23 12:25:02 +00:00
helencheuk b4cda2adbe Not show hover border on select mode
Fix: 295175854
Test: TaskViewTest
Flag: ACONFIG com.android.launcher3.enable_cursor_hover_states Nextfood
Change-Id: I81b1af27b590ea509e8ec84a9d3ff008f31da21f
2023-11-23 10:51:58 +00:00
Pechetty Sravani d6233c18a0 Merge "Revert "Update status bar scrim"" into main 2023-11-23 10:38:42 +00:00
Pechetty Sravani e620fc80c9 Revert "Update status bar scrim"
Revert submission 25440774-scrim_update

Reason for revert: <Test Revert (b/312861259)>

Reverted changes: /q/submissionid:25440774-scrim_update

Change-Id: Ifdae7cc1754994ef16585859a9b0f08b2d257715
2023-11-23 08:50:59 +00:00