Commit Graph

76729 Commits

Author SHA1 Message Date
Sunny Goyal 8e1f37181d Merge "Allowing base class for ResourceBasedOverride to have Context based constructors" into main 2024-04-05 23:20:38 +00:00
Winson Chung 731739470b [automerger skipped] Fix regression in checking disabled state am: 95179cffab -s ours
am skip reason: Merged-In I7242e0c525ef578a54a06fb9137fcfc42c6f0e86 with SHA-1 fcbef122e6 is already in history

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/26857590

Change-Id: I05f4123c8c5c271e114bdfe60af1c4a90b6b7480
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-04-05 22:13:54 +00:00
Willie Koomson 7d2d6ced25 Fix resize frame for widgets added with tap-to-add button
This change updates the tap-to-add code to wait for the animations
between each step (close widget sheet, snap to Workspace page)
to finish before continuing with the next step of the flow.

Bug: 331425905
Bug: 331699050
Test: manual
Flag: ACONFIG com.android.launcher3.enable_widget_tap_to_add TEAMFOOD
Change-Id: I774b86b429cd2e8a397e5605243056e6cea666b3
2024-04-05 22:03:37 +00:00
Tony Wickham a6dcb11094 Merge "Apply insets to top-level providers, not just paramsForRotation" into main 2024-04-05 22:01:29 +00:00
Winson Chung 95179cffab Fix regression in checking disabled state
- It should only check the disabled state after the icon graphic
  has been set

Fixes: 333017803
Test: Load with an app pair icon on the workspace
Change-Id: Ic313f98e1e31d673d774f050bb418d359b4bd653
Merged-In: I7242e0c525ef578a54a06fb9137fcfc42c6f0e86
2024-04-05 21:54:22 +00:00
Jeremy Sim 24284467b5 Fix bug where app pair title was not updating with language
This CL adds the ability for an app pair icon to update its title string when package changes are detected. It also reorganizes some code in the app pairs classes for readability.

Fixes: 316051810
Flag: ACONFIG com.android.wm.shell.enable_app_pairs TRUNKFOOD
Test: Manual
Change-Id: I833e4f9766b7da8c0a3a5fb4b9fc050d8897437e
2024-04-05 21:35:58 +00:00
Jeremy Sim a7ce667e3a Merge "Fix launch flow when one app in an app pair is paused" into main 2024-04-05 21:30:09 +00:00
Jeremy Sim 08fc2d434f Delete app pairs on model load if flag is turned off
This CL adds a case to processFolderOrAppPair() -- if the ENABLE_APP_PAIRS flag is turned off, we do not load app pairs into launcher.

This prevents a case where a user uses backup+restore to migrate an app pair onto an environment where app pairs is disabled.

Fixes: 330412376
Flag: ACONFIG com.android.wm.shell.enable_app_pairs TRUNKFOOD
Test: Manual
Change-Id: I4a97e4aadc620f8b727439fcdd70ab0e7a3005a8
2024-04-05 13:07:20 -07:00
Sunny Goyal 21f498c5f3 Merge "Moving all configs from overrides.xml to config.xml" into main 2024-04-05 20:04:15 +00:00
Sunny Goyal 9d28eee769 Allowing base class for ResourceBasedOverride to have Context based constructors
Bug: 330920490
Flag: None
Test: Presubmit
Change-Id: Ib4d1ef80133596a114a4fb32ea8ae918852a77f5
2024-04-05 12:56:36 -07:00
Tony Wickham 3205876bf5 Apply insets to top-level providers, not just paramsForRotation
Bug: 329012507
Flag: none
Test: trigger assistant, ensure bottom insets are removed in
gesture nav mode; also verify IME inset override correctly
applies in 3 button mode

Change-Id: I823d0d360a7e3b41cc291f6949d9371e0dc32efb
2024-04-05 19:46:11 +00:00
Anushree Ganjam 16a0f61078 Merge "Add dump for PredictionRowView." into main 2024-04-05 19:41:31 +00:00
Tony Wickham f95a6b73e5 Apply insets to top-level providers, not just paramsForRotation
Bug: 329012507
Flag: none
Test: trigger assistant, ensure bottom insets are removed in
gesture nav mode; also verify IME inset override correctly
applies in 3 button mode

Change-Id: I823d0d360a7e3b41cc291f6949d9371e0dc32efb
2024-04-05 19:40:06 +00:00
Treehugger Robot 09cee48a84 Merge "Fix homescreen rotation delay during fold" into main 2024-04-05 18:39:26 +00:00
Sebastián Franco 5ccac93d0a Merge "Adding even more tracing for the tests" into main 2024-04-05 18:26:54 +00:00
Jeremy Sim 17db14b107 Fix launch flow when one app in an app pair is paused
This CL changes the error handling logic in ItemClickHandler to continue with app pair launch when only one app in an app pair is paused. It also changes AppPairIconGraphic so that the disabled state of the app pair is drawn modularly (if only one app is paused, only one app will appear visually paused).

Bug: 330795643
Flag: ACONFIG com.android.wm.shell.enable_app_pairs TRUNKFOOD
Test: Manual
Change-Id: Ieaf0120cced07b6ac0f3eb07c75b66666a8dcc85
2024-04-05 11:24:33 -07:00
Sunny Goyal bd07c05446 Moving all configs from overrides.xml to config.xml
> Removing some used configs
> Moving ids to id.xml

Bug: 330920490
Flag: None
Test: Presubmit
Change-Id: I86bd22db49a3980c55f5d42350a7c6368fa86d21
2024-04-05 11:20:17 -07:00
Liran Binyamin c21852a186 Suppress animation for bubbles that auto expand
Check whether the state update indicates that the bubble bar is expanding, and pass that to the bubblebarviewcontroller so that we can suppress the new bubble animation if we're expanding from stashed.
Note that in some cases the notification service may not include the auto expand flag on the message it sends to sysui, so launcher will end up getting 2 separate messages. We may need to handle that separately.

Flag: ACONFIG com.android.wm.shell.enable_bubble_bar DEVELOPMENT
Bug: 280605846
Test: manual
       - create bubble that auto expands
       - observe that the bubble does not animate
       - note that in some cases the notification service may not include the auto expand flag, will look into that separately.
Change-Id: Id7e2db5fd32d391413c57d83effb4b23b1085125
2024-04-05 14:09:32 -04:00
Anushree Ganjam 1115b416bb Add dump for PredictionRowView.
adb shell dumpsys activity NexusLauncherActivity : https://paste.googleplex.com/4907497231482880

When AllApps prediction is off : https://paste.googleplex.com/5930628737925120

Bug: 332171918
Test: Manual
Flag: NA
Change-Id: I753ff876aab162026d99fd1b35f63edf2e712f70
2024-04-05 10:57:44 -07:00
Tony Wickham 7149e036f1 Unstash taskbar due to IME immediately when system gesture starts am: fa696568e5
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/26852022

Change-Id: I09b82105630add2755057d665619e32d6e3a8154
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-04-05 17:36:29 +00:00
Sebastián Franco 6739770ea0 Merge "Set default grid when doing a backup and restore" into main 2024-04-05 17:23:25 +00:00
Zak Cohen 60e0bca4c3 Merge "Update OWNERS for Widget Picker team." into main 2024-04-05 17:19:01 +00:00
yyalan 12bd37ddd8 Fix homescreen rotation delay during fold
The issue is caused by the delay that Launcher handles the rotation; onDisplayInfoChanged that RotationHelper listens to is triggered later than the screen turning on. onDeviceProfileChanged is triggered earlier, but it only receives callback when in foreground. Using both listeners means that if in the background, we can still rely on onDisplayInfoChanged to update, assuming by the delay is tolerable given it takes time to changes to foreground.

Bug: 300929233
Flag: NA
Test: Manual and Perfetto trace in the bug
Change-Id: I5c6983649a38c3e4fe2b8c4a950435ceb07afa5a
2024-04-05 18:15:20 +01:00
Himanshu Gupta b04262784d Fix failing LauncherIntentTest.
Bug: 332894108
Test: atest Launcher3Tests
Flag: NA
Change-Id: I654a45d5a9371aa9da74ae89a0513bf203e27981
2024-04-05 18:11:06 +01:00
Holly Jiuyu Sun a65c0b97c3 Merge "[PS] Disable long press for install app button." into main 2024-04-05 16:59:22 +00:00
Schneider Victor-tulias 09268637b4 Merge "Add debug logs to TaskView" into main 2024-04-05 16:46:55 +00:00
Zak Cohen 02f0c92ea8 Merge "Widget Picker - center text description vertically to align with add button" into main 2024-04-05 16:46:44 +00:00
Sebastian Franco df7d2b0861 Set default grid when doing a backup and restore
When restoring from a tablet because phones don't have
the same table some issues can ocure because we setup a
non valid grid, the correct thing is to setup a default.

Bug: 325285743
Fix: 332964986
Flag: ACONFIG narrow_grid_restore enabled
Test: BackupAndRestoreDBSelectionTest
Change-Id: I28bf02e83dddf5ae84818d879a5e21600eddf67e
2024-04-05 08:53:32 -07:00
Tony Wickham fa696568e5 Unstash taskbar due to IME immediately when system gesture starts
This is reversing a previous change from a few years ago
(ag/16325264) because we now clip the recent apps on the bottom
during gesture nav, whereas before we left them unclipped until
you swiped up.

Flag: none
Fixes: 305977350
Test: verified visuals manually in persistent, transient, and 3
button nav; also tested interactions with All Apps

Change-Id: Ib3823a9bd9aebf923ad481c010c7e8544bcb6a4d
(cherry picked from commit a6b29968a4)
2024-04-05 15:50:15 +00:00
Tony Wickham fefe8a441b Merge "Unstash taskbar due to IME immediately when system gesture starts" into main 2024-04-05 15:49:36 +00:00
Schneider Victor-tulias 148cbffdbf Add debug logs to TaskView
Investigating b/332386996

Flag: N/A
Bug: 332386996
Test: TaplTestsQuickstep#testQuickSwitchFromApp
Change-Id: I633a1a67cadc8f1f85fbdeb3a0913623ae817bf1
2024-04-05 10:31:21 -04:00
Jakob Schneider 221117bcfd Merge "Fix issue where progress around icons is not shown" into main 2024-04-05 09:39:04 +00:00
Andreas Agvard c43b7163a2 Removes recovery
Flag: NONE
Bug: 326143814
Test: Unit
Change-Id: Icbebeade552cb101eb4b8bae4965b4d6c972f22e
Merged-In: Icbebeade552cb101eb4b8bae4965b4d6c972f22e
2024-04-05 06:10:04 +00:00
Brandon Dayauon c752dd032c Merge "Ripple to header and button when click happens" into main 2024-04-05 04:20:49 +00:00
Brandon Dayauon bcb6a62297 Merge "Apply icon alpha animation to expand/collapse private space." into main 2024-04-05 04:18:48 +00:00
Treehugger Robot 6539e29882 Merge "Launch AppPair live tile when not visible" into main 2024-04-05 02:08:17 +00:00
Holly Sun b4954547ac [PS] Disable long press for install app button.
For Install button - Disable long press would also disable drag logic altogether.
For apps in PS - Long press is not disabled as it. Drag is disabled in ag/25898351.

Video: https://drive.google.com/file/d/1g5jJ2vebZdiKUwjDMfkUnLwQ1oK1fWXB/view?usp=sharing

Bug: 332572841
Test: manual
Flag: aconfig com.android.launcher3.private_space_app_installer_button trunkfood
Change-Id: I418a31785b25c4f19dde2136747a74811628e92f
2024-04-04 18:14:25 -07:00
Liran Binyamin 98bbc2b46d Merge "Animate the stash handle for new bubbles" into main 2024-04-05 00:49:39 +00:00
Vinit Nayak 74a3314172 Explicitly set animation and timings for split cancel button
* Mismatched animation durations were causing recents task
thumbnails to flash in at the end.
* Following a similar pattern started at ag/26378432, except
here we manually call all the steps to create launcherState
animation

Fixes: 321863575
Test: Repro steps from bug no longer occur.
Tested on phone and large screen, workspace, overview and all apps

Change-Id: I02696c0470bf4cfe6a278f0a2bc0786367a9fe37
(cherry picked from commit aeb9595b37)
2024-04-05 00:07:26 +00:00
Vinit Nayak 8c14bef1f2 Merge "Explicitly set animation and timings for split cancel button" into main 2024-04-05 00:07:13 +00:00
Jeremy Sim 324c2478d8 Merge "Update app pair icon colors when switching containers" into main 2024-04-05 00:00:56 +00:00
Jagrut Desai d2508e5178 Merge "Adjusting Taskbar Icons for larger display size" into main 2024-04-04 23:39:51 +00:00
Zak Cohen 106cd240de Widget Picker - center text description vertically to align with add button
Bug: 332287648
Test: Widget picker tests
Flag: NA bug fix
Change-Id: I4d600633c3cfdc40973134903f4ba7a04090ccfe
2024-04-04 15:59:00 -07:00
Vinit Nayak 637274ebc9 Launch AppPair live tile when not visible
* End the recents animation and then relaunch as if
from scratch
* We explicitly ignore the anim for end of recents animation
since that will cause the taskbar to quickly show and stash
again, and we know in this case that we'll quickly be launching
right back into an app

Test: Tested w/ live tile + non live,
fullscreen + app pairs
Bug: 316485863

Change-Id: I6ae8cccc01401935bf96fba8a154216e6b1ad701
2024-04-04 15:58:17 -07:00
Fengjiang Li a197a4f3ae Merge "[1/2] Fix resize frame showing at left top corner of workspace." into main 2024-04-04 22:45:39 +00:00
Zak Cohen 86397baf6d Update OWNERS for Widget Picker team.
Bug: NA
Test: NA
Flag: NA
Change-Id: Ie8c79da48ef150e1323b512ff198bb68303f06d7
2024-04-04 15:28:47 -07:00
Zak Cohen ea3fe15fa8 Merge "Widget Picker - Always center add widget button text vertically" into main 2024-04-04 22:19:21 +00:00
Tony Wickham a6b29968a4 Unstash taskbar due to IME immediately when system gesture starts
This is reversing a previous change from a few years ago
(ag/16325264) because we now clip the recent apps on the bottom
during gesture nav, whereas before we left them unclipped until
you swiped up.

Flag: none
Fixes: 305977350
Test: verified visuals manually in persistent, transient, and 3
button nav; also tested interactions with All Apps

Change-Id: Ib3823a9bd9aebf923ad481c010c7e8544bcb6a4d
2024-04-04 22:07:43 +00:00
Jeremy Sim 05617cb11f Update app pair icon colors when switching containers
This CL updates the color for the app pair background, and adds a way for an app pair icon to redraw as a different color when switching containers.

Bug: 315731527
Flag: ACONFIG com.android.wm.shell.enable_app_pairs TRUNKFOOD
Test: Manual
Change-Id: I615cb95d51f7c4c120ad306246d9491bf4452229
2024-04-04 15:07:30 -07:00
Jeremy Sim e261ecbbd1 Merge "Update to correct Material SurfaceContainer values" into main 2024-04-04 21:59:32 +00:00