Commit Graph

76729 Commits

Author SHA1 Message Date
Helen Cheuk a0dc66c206 Merge "Add focus outline to overview clear all button" into main 2024-04-09 16:27:27 +00:00
Vadim Tryshev 6ae89d13ff Merge "Re-enabling stress tests in presubmit" into main 2024-04-09 16:26:17 +00:00
Vadim Tryshev 5940c59a2c Merge "Honoring @PortraitLandscape annotation in presubmit" into main 2024-04-09 16:26:14 +00:00
Brian Isganitis 093b432985 Merge "Reset allAppsVisible if folding to phone upon recreateTaskbar." into main 2024-04-09 16:22:16 +00:00
Brian Isganitis 4ba8346a34 Merge "Use translation shift setter when showing AllApps without animation." into main 2024-04-09 16:21:54 +00:00
Alex Chau 3c0729c462 Add task menu item to move task to Desktop
- Call SystemUiProxy.moveToDesktop to move existing Overview tasks to desktop
- Animation polish will be handled separately
- Refactored AbstractFloatingView method into a helper to allow testing

Fix: 320310347
Test: DesktopSystemShortcutTest, AbstractFloatingViewHelperTest
Flag: ACONFIG com.android.window.flags.enable_desktop_windowing_mode DEVELOPMENT
Change-Id: I2e4e04182e46ba4750e0683ee1789ba8fada06ea
2024-04-09 16:35:55 +01:00
Johannes Gallmann 75dd62fd22 Update predictive back progress interpolator
Bug: 332512902
Flag: ACONFIG com.android.systemui.predictive_back_sysui TRUNKFOOD
Test: Manual, i.e. analysing screenrecordings and verify that there are no more animation jumps at the start/end of the back animations
Change-Id: I99b13199032f7098fedb1cbd02cfe478d6fbb1f7
2024-04-09 14:11:40 +00:00
Liran Binyamin 60d4e8d3b8 Merge "Fix NPE when setting bubble bar bounds" into main 2024-04-09 14:04:19 +00:00
Vinit Nayak 0e920d2ca2 [automerger skipped] Merge "On disabled app pairs, set color tint instead of changing alpha" into 24D1-dev am: fc7f52967d -s ours
am skip reason: Merged-In Ifc8ac694f321a6b28996ba9a42860dfc419d5901 with SHA-1 09fe96b95a is already in history

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/26860296

Change-Id: I5a38b585280b693fcf52d1f15c6dda4d9a6ee55d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-04-09 05:50:40 +00:00
Jeremy Sim 43a6065d80 [automerger skipped] On disabled app pairs, set color tint instead of changing alpha am: 00dc98c9e4 -s ours
am skip reason: Merged-In Ifc8ac694f321a6b28996ba9a42860dfc419d5901 with SHA-1 09fe96b95a is already in history

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/26860296

Change-Id: I74810685ff051698f2156b2c59fd374d1cc84f09
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-04-09 05:50:37 +00:00
Vinit Nayak 7eeaf283c1 [automerger skipped] Add CUJ Jank interactions for App Pair saving and launching am: 674aa03862 -s ours
am skip reason: Merged-In Ia4944f8d23634bb92296938ea2d07a6babf6f77c with SHA-1 422a634a24 is already in history

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/26879812

Change-Id: I935f2444b8f7b9571f073dad9a0ffaa386516165
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-04-09 05:49:19 +00:00
Sunny Goyal 8ecbaa422f Merge "Moving various nav-bar configs out of feature flags" into main 2024-04-09 05:45:21 +00:00
Vinit Nayak fc7f52967d Merge "On disabled app pairs, set color tint instead of changing alpha" into 24D1-dev 2024-04-09 05:40:02 +00:00
Vinit Nayak 26c11f2c49 Launch split tasks at beginning of animation instead of the end
* Ideally we animate the live leashes from the placeholder tasks,
that's a lot more changes at this moment so we don't do that
* Instead we just hold off fading in the leashes until the very
end of the animation
* This way taskbar can scale down correctly in both contextual and
app pair launch cases since now launcher visibility will be changed
at the same time

Bug: 308851855
Test: Launches are a bit snappier from workspace/all apps compared
to overview, but in a good way!(?)

Change-Id: I73a9284a2b1a993c5a020396e2aca8499fc5eb09
2024-04-08 22:28:01 -07:00
Jeremy Sim 6a60c3b113 Prevent menu items from showing on split tasks
This CL changes the TaskShortcutFactory for SCREENSHOT and MODAL so that the associated menu options ("Screenshot" and "Select") don't show up on split tasks. These actions are not fully supported on splitscreen tiles (they will only work on one of the two apps), so we disable them.

Bug: 327434215
Flag: N/A
Test: Manual
Change-Id: I121a9c28fa7570f10e13be2de6489182e3362cfc
2024-04-08 17:56:29 -07:00
Jeremy Sim be2a18d3fc Merge "Delete app pairs on model load if flag is turned off" into main 2024-04-09 00:38:42 +00:00
Jeremy Sim fa3eae99a5 Merge "Fix bug where app pair title was not updating with language" into main 2024-04-09 00:22:19 +00:00
Vinit Nayak 674aa03862 Add CUJ Jank interactions for App Pair saving and launching
* Added finishCallback consumer to LauncherAccessibilityDelegate
to inform when adding an item to workspace was completed.
* The logic seemed to be dependent on the parameter
"focusForAccessibility", but all callers of that are currently
passing in true

Bug: 328646540
Test: https://paste.googleplex.com/6232597136408576
Newly added CUJs showing up when playing w/ device

Change-Id: Ia4944f8d23634bb92296938ea2d07a6babf6f77c
Merged-In: Ia4944f8d23634bb92296938ea2d07a6babf6f77c
2024-04-09 00:17:21 +00:00
Uwais Ashraf fe1a9c36b7 Merge "Use script to auto-enable all tests that are currently working" into main 2024-04-09 00:01:05 +00:00
Sunny Goyal 89931316a2 Moving various nav-bar configs out of feature flags
Bug: 332588958
Test: Presubmit
Flag: None
Change-Id: Ia4dc5b69bcf4d461e3444b9e37bb7334bb74aae4
2024-04-08 16:54:04 -07:00
Jeremy Sim 00dc98c9e4 On disabled app pairs, set color tint instead of changing alpha
This CL changes the way disabled app pair icons are drawn: instead of setting alpha, it sets a color filter to indicate disabled status. This brings it in line with other apps icons and V's design specs.

Fixes: 326665140
Flag: ACONFIG com.android.wm.shell.enable_app_pairs TRUNKFOOD
Test: Manual
Change-Id: Ifc8ac694f321a6b28996ba9a42860dfc419d5901
Merged-In: Ifc8ac694f321a6b28996ba9a42860dfc419d5901
(cherry picked from commit 09fe96b95a)
2024-04-08 23:37:50 +00:00
Song Chun Fan e5ad96ce10 [Launcher/Archive] remove all checks for the archiving system property
No longer needed

Change-Id: I62c8843aa04a245d1dcc30f7787c71d17993f5d1
BUG: 331165939
Test: builds
2024-04-08 23:14:07 +00:00
Vadim Tryshev 47f192f3be Merge "Restoring the full set of combinations in testDragShortcutToMultipleWorkspaceCells in presubmit" into main 2024-04-08 23:02:42 +00:00
Shamali Patwa b8714e1f7f Merge "Maintain the recommendations that were initially displayed" into main 2024-04-08 22:52:12 +00:00
Shamali Patwa 4c5472e6a1 Merge "Add maxlines bounds to the category title." into main 2024-04-08 22:51:56 +00:00
Brian Isganitis 6d63e7796d Reset allAppsVisible if folding to phone upon recreateTaskbar.
For taskbar unification, we should reset this bit to false when folding
into phone orientation. Otherwise, we will reinit Taskbar AllApps over
the phone UI which is unexpected behavior.

Test: Manual
Flag: N/A
Fix: 293379641
Change-Id: I53c38c8b4df477191be3c21b7750c55a71c7336f
2024-04-08 15:36:31 -07:00
Brian Isganitis 514f866f5c Use translation shift setter when showing AllApps without animation.
The no-animation case used to be handled immediately upon inflating the
view, so we got away with reassigning the field to
TRANSLATION_SHIFT_OPENED directly. Since this happens in post of a
handler, we need to instead use the setter so that a relayout happens.

Test: Manual
Fix: 324268840
Flag: N/A
Change-Id: I089f15a8d64e0d22885ae387679214a540790ad0
2024-04-08 15:15:41 -07:00
Jordan Silva 65972d5ba4 Merge "Update save app pair test to validate when icon chip menu is disabled" into main 2024-04-08 22:08:49 +00:00
Liran Binyamin 4d257139ad Fix NPE when setting bubble bar bounds
The bubble bar bounds change listener is sometimes invoked before the IBubbles service has been initialized.
This change adds a null check before calling the service.

Flag: ACONFIG com.android.wm.shell.enable_bubble_bar DEVELOPMENT
Fixes: 332423960
Test: manual
Change-Id: Iaa048c62a60c90c5e416da05ba53467a5034d86c
2024-04-08 21:05:00 +00:00
Uwais Ashraf 7a0150d02e Use script to auto-enable all tests that are currently working
Fix: 325088906
Test: presubmits passing, gradle robo run passing locally
Flag: NA
Change-Id: I481bfe9caeb8cc18b3e01ec8b7a58fb0eb36fdaa
2024-04-08 20:59:23 +00:00
Jordan Silva a3eff1fe96 Update save app pair test to validate when icon chip menu is disabled
This CL adds a validation in the test to check if save app pair action is available in the overview actions. Kept the validation to check if save app pair is available in the menu only for overview icon menu flag enabled.

Bug: 330515672
Flag: N/A
Test: TaplTestsSplitscreen
Change-Id: I3097180a24b430f2310d11ddec36e6d6cf4982fb
2024-04-08 12:30:51 -07:00
Federico Baron 9462c3b604 Merge "Fix null pointer in FloatingWidgetView" into main 2024-04-08 18:52:43 +00:00
Shamali P 11aa56e48f Add maxlines bounds to the category title.
- So far, none of the translations exceeded 1-line, but setting maxlines
to avoid it to happen in future.

* http://screen/35PYFHV5SCeBhqC (at max font size)

Bug: N/A
Flag: ACONFIG com.android.launcher3.enable_categorized_widget_suggestions TEAMFOOD
Test: Manual - see videos.
Change-Id: I263706a5d85dd4a37a4150abd58222283d5e039a
2024-04-08 18:23:25 +00:00
Treehugger Robot 8687018b09 Merge "Disable app chip menu height limit for bottom row" into main 2024-04-08 18:22:08 +00:00
Treehugger Robot 18694cc977 Merge "Add max height logic and avoidance of taskbar into task menu" into main 2024-04-08 18:22:08 +00:00
Treehugger Robot adbdfe2ac7 Merge "Fix failing LauncherIntentTest." into main 2024-04-08 16:43:28 +00:00
Liran Binyamin 9a9ef494ae Merge changes I74b09220,Id7e2db5f into main
* changes:
  Don't animate bubbles in the initial state update
  Suppress animation for bubbles that auto expand
2024-04-08 16:30:30 +00:00
Uwais Ashraf d9de4b0558 Add max height logic and avoidance of taskbar into task menu
Fix: 329842207
Test: Manually tested, see video in bug
Flag: NA
Change-Id: I08079f14cee63fe7973ba751529109ca66423bb6
2024-04-08 16:23:59 +00:00
Shamali P 168d420440 Maintain the recommendations that were initially displayed
- The component names of the widgets shown on first opening the picker
are saved across orientation change - and only those shown initially are
displayed.

* http://screencast/cast/NDkyMDQ0OTg3OTI0NDgwMHw4ZGU1ZjRmNy0zNQ
* https://screencast/cast/NTc1NjQ1NDI5MTExMTkzNnxiZGJlMjQ2Yi01Ng

Bug: 331776686
Flag: ACONFIG com.android.launcher3.enable_categorized_widget_suggestions TEAMFOOD
Test: Manual - see videos.
Change-Id: I6af7421c2757fde321d06406514ab2576a48fb47
2024-04-08 16:02:05 +00:00
Alex Chau 293d2cb867 Disable app chip menu height limit for bottom row
Bug: 326952853
Flag: ACONFIG com.android.launcher3.enable_overview_icon_menu TEAMFOOD
Test: manual
Change-Id: I104296979803eb8967b07793f4f2590e592f9df7
2024-04-08 16:24:45 +01:00
Alex Chau 7714b2cd32 Add more logs tracking gesture and recents animation in RecentsView
Bug: 332635097
Test: manual
Flag: None
Change-Id: I6f83806f783344c07f7f59fe87c37b7cc377fff2
2024-04-08 13:12:06 +01:00
Treehugger Robot 962b3d43ea Merge "Explicitly set animation and timings for split cancel button" into 24D1-dev am: dcb860a22a
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/26842505

Change-Id: Ib72008aa452836829f865970e51986b52555210a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-04-06 07:59:40 +00:00
Treehugger Robot dcb860a22a Merge "Explicitly set animation and timings for split cancel button" into 24D1-dev 2024-04-06 07:30:28 +00:00
Saumya Prakash 83646f9b82 Merge "Add Taskbar education for Circle to Search for pinned taskbar" into main 2024-04-06 05:39:28 +00:00
Saumya Prakash 5453c053b9 Add Taskbar education for Circle to Search for pinned taskbar
This change adds a new education tooltip for pinned taskbar that teaches
users how to use Circle to Search invoked through the action key. It won't run on
transient taskbar or if the user is in 3 button mode. The disclosures at
the bottom of the tooltip link to localized legal agreements for the feature.

Fix: 330401405
Test: Pin the taskbar and observe that the next time an app is launched
the edu shows up. After dismissal it shouldn't show up again.
Additionally, click on the disclosures and ensure they launch.
Flag: ACONFIG com.android.launcher3.enable_taskbar_pinning NEXTFOOD

Change-Id: I64aea3004aca77c3ec81b81dea0cfab7a9c1e272
2024-04-06 01:52:49 +00:00
Andy Wickham 29671bdf1f Adds AssistStateManager#supportsShowWhenLocked.
This indicates whether search can show over the lock screen.

Bug: 320444706
Test: Manual with supported and unsupported AGA APKs
Flag: NA
Change-Id: I06612af6731b991b38614e47f207e190db109c24
2024-04-05 17:48:03 -07:00
Willie Koomson 2041fd04a4 Merge "Fix resize frame for widgets added with tap-to-add button" into main 2024-04-06 00:45:37 +00:00
Tony Wickham b3754c7cee Merge "Apply insets to top-level providers, not just paramsForRotation" into 24D1-dev am: c189a54ca3
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/26856995

Change-Id: Id766dd34cc7f8e1e882f7a3157d75ac373a0be04
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-04-06 00:19:42 +00:00
Liran Binyamin 0701ab166d Don't animate bubbles in the initial state update
When launcher receives the initial bubble state update from sysui, don't animate the bubbles. The initial update is sent when bubble bar is created and not when new bubbles are created.

Flag: ACONFIG com.android.wm.shell.enable_bubble_bar DEVELOPMENT
Bug: 280605846
Test: manual
Change-Id: I74b09220be22d7382fa6d7c1351d5e60a799a054
2024-04-05 20:15:52 -04:00
Tony Wickham c189a54ca3 Merge "Apply insets to top-level providers, not just paramsForRotation" into 24D1-dev 2024-04-06 00:01:19 +00:00