After exiting the search, we clear the search results and hide the
results lists (because that recycler view shouldn't be accessible after it). However, it often doesn't get chance to layout the empty data.
So, the next time we show the search results list again with new data,
it first animates to clear the old results and then animates in the new
ones. In this fix,
[demo](http://screencast/cast/NDg5OTg2NzIyMTU1NzI0OHxhMTk0NzEzZS1hYw), we swap the adapter to remove any old views, because old search results aren't valid anymore. Spoke with yigit who worked on RV in past and they suggested swapAdapter
was fine for this.
Other options explored:
1. set item animator = null; so, it doesn't animate flushing out old
results -> but we want animations
2. delay the visibility update to let layout happen -> but, if we are
hiding the section, why wait making the other UI updates until
layout?
Bug: 274051332
Flag: N/A
Test: Manual
Change-Id: I9f9c5a67b47b5415b2d9e4caa23fd4b6daf7cdea
(cherry picked from commit 809e1a8efb)
Revert submission 26414135-RecentsViewContainer
Reason for revert: Probable culprit for b/333767026. Will be verifying through ABTD for confirmation and before submitting the revert.
Reverted changes: /q/submissionid:26414135-RecentsViewContainer
Change-Id: I25775cd6531355f1dc042ddb7a8d442ee0b36e58
Revert submission 26414135-RecentsViewContainer
Reason for revert: Probable culprit for b/333767026. Will be verifying through ABTD for confirmation and before submitting the revert.
Reverted changes: /q/submissionid:26414135-RecentsViewContainer
Change-Id: Ibafc66cf3677d24e7912d55cb45c948cb6519df7
* changes:
fixing tests to match new abstraction
abtracting Activity from recentsView through recentsviewcontainer and basecontainerinterface interfaces
Previously, app pairs and folders shared a common data model, FolderInfo. Now we need to separate them, so a new type, CollectionInfo, will serve as the parent of both types.
Bug: 315731527
Fixes: 326664798
Flag: ACONFIG com.android.wm.shell.enable_app_pairs TRUNKFOOD
Test: Manual, unit tests to follow
Change-Id: Ia8c429cf6e6a376f2554ae1866549ef0bcab2a22
Merged-In: Ia8c429cf6e6a376f2554ae1866549ef0bcab2a22
We also check if the new default is bigger than or equal to the
previous one.
Flag: ACONFIG enable_grid_migration_fix enabled
Flag: ACONFIG enable_narrow_grid_restore enabled
Bug: 325286145
Bug: 325285743
Test: BackupAndRestoreDBSelectionTest.kt
Test: GridMigrationTest.kt
Change-Id: I98315a4e4c112ca96a74200dd76016803dfaf820
This change will let us move from activity to other parent views for recent views.
Summary: In prep for new recentsview containers outside of activity we needed to decouple recentsview from activity and state.
This change will let us move from activity to other parent views for recent views.
Test: Built and tested locally for 1p and 3p launchers on tablet, and portrait modes. Verified working functionality.
Bug: 292269949
Flag: NONE
Change-Id: I5c72745f438d466362ece988c35a97d829e9c1b4
This also linked to the overlap we were seeing in
bug 331816144 (as can be seen in before and after video)
Bug: N/A
Test: See videos
Flag: aconfig launcher.enable_add_app_widget_via_config_activity_v2 NEXTFOOD
Change-Id: I21717e0c4d4eab7efa1746e46d3218b8b3cee4ef
Use existing override duration and touch slop multiplier values for the 1st stage. Times `TWO_STAGE_MULTIPLIER` for the 2nd stage.
See http://shortn/_WqYj0buH7R
Bug: 330446193
Test: manual
Flag: legacy ENABLE_LPNH_TWO_STAGES disabled
Change-Id: Ic200f431524578d17fd98ebfbc65e44e0971e31c
There are two things that need to be changed for this to work:
1. Make the isInOverview condition check for any Overview UI (including
the split select state, modal, etc.)
2. Toggle Home All Apps directly, because firing the intent will cause
Launcher to pause and resume before the intent is handled. We
misinterpret the pause as a request to cancel split screen. Since
TaskbarManager has a reference to Launcher, we might as well call the
method directly.
Test: Manual
Fix: 319076403
Flag: N/A
Change-Id: Ib8899188f593a168a054a16717df4a95be098557
Legacy feature flags will be locked to their current values in code.
All new feature development should use aconfig flags
Bug: 332588958
Flag: None
Test: Presubmit
Change-Id: Ie72dd8276b7135620de279835d6721a34f82ede4
Wait until launcher is not animating to show resize frame
Fix: 331433240
Test: manual - took a photo
Flag: NONE
Change-Id: I3aec7f8bf2b6081134004b30de3d389e5b1ab253
For duration, the data source and value should be the same for LPNH and LPH. E.g., if AGSA overrides duration, it applies for both LPNH and LPH. When there is no AGSA override, there are cases that one of our feature flag is enabled and the other one is disabled. We just simply rely on LPNH's feature flag in this case. This should be fine because the purpose is to cross check the data source and its value.
Bug: 332722082
Test: manual
Flag: legacy CUSTOM_LPNH_THRESHOLDS enabled
Change-Id: I3f10b944257e7021ae7c930b782f1d963c0e505b
This CL adds an initial test, that creates
private profile and verifies the elements
present in unlocked state.
More tests will be followed in next CL.
Doc: go/private-space-tapl
Bug: 322882655
Test: TaplPrivateSpaceTest
Flag: NA
Change-Id: I6032f4531818031991a5d51e23cfad22518250e6
This test has been failing because the "unexpected" Binder call is actually expected. Updated the test to account for this.
Flag: N/A
Fixes: 315075477
Test: BinderTests#testSwitchToOverview
Change-Id: I2f5d3d07f6ec373f394e7a6f3887000af5f63c7e
1) This part is missing from the previous set of CLs. `getLPNHCustomSlopMultiplier` is defined but unused. Similar as reading LPNHDuration, we should also read the touch slot multiplier in Launcher for LPNH.
2) Also, change type to float, which is consistent with our existing implementation and the definition in OverviewProxyService.
3) Slop value is in percentage and Launcher divide it by 100. We haven't got AGSA implementation yet so we can predefine this part.
Bug: 330444720
Bug: 330446188
Test: manual
Flag: legacy CUSTOM_LPNH_THRESHOLDS disabled
Change-Id: Id606a4bc765fe01464ef36a2806c280ee42d30cd
Bill Yi
Priyanka Advani
Sunny Goyal
Shamali P
Vinit Nayak
Randy Pfohl
Jeremy Sim
Android Build Coastguard Worker
Sebastian Franco
Song Chun Fan
Holly Jiuyu Sun
Alina Zaidi
Brian Isganitis
Treehugger Robot
Anushree Ganjam
Himanshu Gupta
Fengjiang Li
Alex Chau
Schneider Victor-tulias