Commit Graph

71524 Commits

Author SHA1 Message Date
fbaron 7f4bbfa599 Fix indexoutofbounds folder preview
The indexoutofbounds issue came from the fact that folder was being animated open when there are no items in preview. It might be a race condition where we try to open the folder at a time where it's actually being emptied. This check should prevent folders from running animateOpen() if there's <= 1 items, avoiding the outofbounds error

Fix: 298740874
Flag: no flag
Test: no test
Change-Id: I31ed53fbdf22a7f19bc9ec414242312afe7c6cd2
2023-09-20 23:57:00 -07:00
Sebastián Franco c468af4139 Merge "Disable FOLDABLE_SINGLE_PAGE" into udc-qpr-dev am: 216a765894 am: 07ce8fa893
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24681787

Change-Id: I74496b2ce863dadce1fbe3889de242c133a75121
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-09-14 19:02:27 +00:00
Andy Wickham be81b736fa Merge "Don't animate layout changes for WorkModeSwitch." into udc-qpr-dev am: 3140efe569 am: ca71d4b857
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24751396

Change-Id: I58f3850bd6671e5bf54002276bab929ac3499ce4
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-09-14 18:59:15 +00:00
Sebastián Franco 07ce8fa893 Merge "Disable FOLDABLE_SINGLE_PAGE" into udc-qpr-dev am: 216a765894
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24681787

Change-Id: I91986355b221bbd623100dcf79d180ed9cc9a0c3
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-09-14 18:08:54 +00:00
Andy Wickham ca71d4b857 Merge "Don't animate layout changes for WorkModeSwitch." into udc-qpr-dev am: 3140efe569
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24751396

Change-Id: I98449ff59af5111dfc0f3a5586864de36a454bf4
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-09-14 18:05:49 +00:00
Sebastián Franco 216a765894 Merge "Disable FOLDABLE_SINGLE_PAGE" into udc-qpr-dev 2023-09-14 17:50:54 +00:00
Andy Wickham 3140efe569 Merge "Don't animate layout changes for WorkModeSwitch." into udc-qpr-dev 2023-09-14 17:31:17 +00:00
Federico Baron 099f7f936e Merge "Ensure PauseUIUpdate always ends up getting set to false" into udc-qpr-dev am: 15b81093d7 am: f3a2082285
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24749997

Change-Id: I8183be8017e43d588b5baed2b80bed70aca7a728
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-09-14 16:53:40 +00:00
Becky Qiu 543dbad157 Merge "Print out debug logging in bug report if not running test." into udc-qpr-dev am: d1d73e05ce am: 09b354b232
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24737823

Change-Id: Icd77d37a3e009bb54044fcd501bc7ea5fc659e0a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-09-14 16:52:54 +00:00
Tracy Zhou bcbb5745b8 Merge "Fix wrong insets in phone mode with FLAG_HIDE_NAVBAR_WINDOW on" into main 2023-09-14 16:51:26 +00:00
Federico Baron f3a2082285 Merge "Ensure PauseUIUpdate always ends up getting set to false" into udc-qpr-dev am: 15b81093d7
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24749997

Change-Id: I06df48dda4c77024b9b35127a8eeda9b42080607
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-09-14 16:51:15 +00:00
Federico Baron 15b81093d7 Merge "Ensure PauseUIUpdate always ends up getting set to false" into udc-qpr-dev 2023-09-14 16:26:34 +00:00
Jagrut Desai a144105c12 Merge "Fix TaplTestsNexus#testSearchForApp" into main 2023-09-14 16:08:35 +00:00
Becky Qiu 09b354b232 Merge "Print out debug logging in bug report if not running test." into udc-qpr-dev am: d1d73e05ce
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24737823

Change-Id: I628cb28daa134c58b10a8db6f84f4004ed1ddbf4
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-09-14 16:00:42 +00:00
Brian Isganitis 42d12badd8 Merge "Support tapping outside container from above IME if visible." into main 2023-09-14 15:25:05 +00:00
Becky Qiu d1d73e05ce Merge "Print out debug logging in bug report if not running test." into udc-qpr-dev 2023-09-14 15:07:43 +00:00
Alex Chau baf6e6ddbe Merge "Update enable_grid_only_overview to use correct release bug" into main 2023-09-14 12:57:57 +00:00
Alex Chau 0f7c0f4a53 Merge "Revert "Add debug log in InvariantDeviceProfile.minCellSize"" into main 2023-09-14 11:35:41 +00:00
Alex Chau c40e64e0cb Update enable_grid_only_overview to use correct release bug
Bug: 270397206
Test: presubmit
Change-Id: I513d77c61ee87485ecf0061d3b3a3c3a74c45982
2023-09-14 12:27:37 +01:00
Wei Sheng Shih 64116af237 Merge "Transfer the animation bounds to another coordinate if needed." into main 2023-09-14 10:02:28 +00:00
Alex Chau 7ecd70cb0d Revert "Add debug log in InvariantDeviceProfile.minCellSize"
Revert submission 24736047-b/298077774_logs

Reason for revert: b/298077774

Reverted changes: /q/submissionid:24736047-b/298077774_logs

Change-Id: I2771484f3537380644c1e8b2d18485b360df5715
2023-09-14 09:59:37 +00:00
Bill Yi 7ef2d061cd [automerger skipped] Import translations. DO NOT MERGE ANYWHERE am: 902c080b06 -s ours am: 4241ea0192 -s ours
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24744206

Change-Id: I39f6cf1bf24a0838a2983e54e3a988fd72b98576
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-09-14 03:19:19 +00:00
wilsonshih 3228322d49 Transfer the animation bounds to another coordinate if needed.
For a remote close animation target, because the orientation can be
different from launcher, so when launcher applying surface animation
to it, there should do another coordinate transfer based on it's
coordinate.
Also for closing animation, there shouldn't use #getWindowTargetBounds
because it only search for opening target.
There is no change when launcher's orientation matches animation target.

Bug: 254805643
Bug: 298318284
Test: close activity in each oritation, verify the position of remote
animaiton target is aligned with the floating view.

Change-Id: I7799357695a467f1bfc653e4f058a5e646ea2405
2023-09-14 02:41:21 +00:00
Bill Yi 4241ea0192 [automerger skipped] Import translations. DO NOT MERGE ANYWHERE am: 902c080b06 -s ours
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24744206

Change-Id: I85dc9af7fc9c7561bc00da5354f0a1a6f1fb089f
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-09-14 02:35:19 +00:00
Bill Yi 6a5638de90 Merge "Import translations. DO NOT MERGE ANYWHERE" into main 2023-09-14 02:08:56 +00:00
Bill Yi b87805f3c7 Merge "Import translations. DO NOT MERGE ANYWHERE" into main 2023-09-14 02:08:56 +00:00
Andy Wickham 1eb694a8cf Don't animate layout changes for WorkModeSwitch.
E.g. translation when rotating or unfolding the device.

The button is laid out as needed, so this was most visible when
entering all apps after folding/unfolding the device, but could
also be seen when rotating the device while in all apps.

Fix: 298073915
Test: Manual (folding/rotating device)
Flag: N/A
Change-Id: I573d7113a7870af0a251b3ca3916e3811f370ef9
2023-09-13 17:30:33 -07:00
Becky Qiu 28498d5f6f Print out debug logging in bug report if not running test.
Bug: 300101221
Test: local
Flag: not needed, logging only.
Change-Id: If016d6fe35a1c43e1a1f311d696b9f2ca0f36f6a
2023-09-13 17:24:51 -07:00
fbaron a101ac696f Ensure PauseUIUpdate always ends up getting set to false
when result was null but getTaskbarUIController() is not null, we don't setPauseUIUpdate to false. This CL ensure we always end up setting pauseUIUpdate to false so that the hotseat suggested apps show up.

Fix: 295892343
Flag: no flag
Test: verify hotseat icons don't disappear
Change-Id: Id872f3174df276cb7a4ed7f6672523d0851a11dd
2023-09-13 16:56:02 -07:00
Vadim Tryshev ba00ce8259 Merge "Copy testAddAndDeletePageAndFling to Launcher tests. The next steps will be changing config files to point at this test, and removing it in integration tests." into main 2023-09-13 23:25:11 +00:00
Brian Isganitis 4e5202867b Merge "Have backup TouchController of Taskbar All Apps AFV." into main 2023-09-13 22:29:54 +00:00
Vadim Tryshev e989ddd992 Copy testAddAndDeletePageAndFling to Launcher tests.
The next steps will be changing config files to point at this test, and removing it in integration tests.

Bug: 187761685
Test: presubmit
Flag: N/A
Change-Id: Ib2a590b7d6aa99a89973a77ca43b1ab762c79fdb
2023-09-13 21:17:17 +00:00
Brian Isganitis 6066c44ed8 Support tapping outside container from above IME if visible.
This is useful for tests where the keyboard is open, which can take up
about half the screen.

Test: Tapl
Fix: 299514609
Flag: No
Change-Id: I47e2fe7555140b4b54046d4d8ba6de1ebd38c6a4
2023-09-13 21:00:52 +00:00
Alex Chau 2ddd019a4c Merge "Migrate ENABLE_GRID_ONLY_OVERVIEW to aconfig" into main 2023-09-13 20:57:51 +00:00
Mady Mellor d56ec1ad5e Merge "Use the scrim value from bubble constants in launcher" into main 2023-09-13 20:28:27 +00:00
Alex Chau c2e3aa1a38 Merge "Revert "Move AppWidgetsRestoredReceiver methods to enable adding tests for restoring widget Ids"" into main 2023-09-13 20:11:21 +00:00
Pat Manning f5a29eaf82 Merge "Add widget resize CUJ test." into main 2023-09-13 19:18:10 +00:00
Brian Isganitis 91a4aca5a5 Have backup TouchController of Taskbar All Apps AFV.
BaseDragLayer only lets the top AFV intercpet touch events, otherwise it
moves onto its TouchController instances. Taskbar AllApps still needs to
intercept touch events sometimes when an AFV above it cannot (e.g. a
snackbar). This CL adds a TouchController to TaskbarOverlayDragLayer
that delegates to TaskbarAllAppsSlideInView if it is open.

Test: Manual
Fix: 299165179
Flag: No
Change-Id: I9b73c55f698de5b60b463f91140a6717a7053cd3
2023-09-13 18:47:43 +00:00
Brian Isganitis 793a9d9905 Merge "Focus Taskbar search EditText and show IME on meta key toggle." into main 2023-09-13 18:13:50 +00:00
Jagrut Desai 311d519292 Fix TaplTestsNexus#testSearchForApp
This cl is 1/2 part change

We are currently getting StaleObjectException when running this test.
We want to implment a synchoronized event beetween test and launcher,
so we know that search result adapter is done updating and page will
get no more updates of search results.

Test: Presubmit
Bug: 232008758
Flag: not needed
Change-Id: I40cf9b83d231a2487220aabc8f8e8c3ca71f255c
2023-09-13 11:09:05 -07:00
Alex Chau e1955fe4b9 Migrate ENABLE_GRID_ONLY_OVERVIEW to aconfig
- Keeping FeatureFlags.ENABLE_GRID_ONLY_OVERVIEW for local testing until aconfig is available in FlagFlipper
- Still reference ENABLE_GRID_ONLY_OVERVIEW in tests as aconfig still can't be mocked

Bug: 270397206
Test: manual
Change-Id: I799e05311adc21184a6ad7ce92a3abdab3f25c25
2023-09-13 15:59:01 +01:00
Alex Chau 2d86f3337a Revert "Move AppWidgetsRestoredReceiver methods to enable adding tests for restoring widget Ids"
This reverts commit 5f263a7ae1.

Bug: 294386159
Reason for revert: b/298077774

Change-Id: Idcfb721e980d4242330e4bd9a2f9ad0f1cc5a1b5
2023-09-13 12:36:48 +00:00
Bill Yi 902c080b06 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I1e5a9958e68122e5c138301126f915f27f1341b6
2023-09-13 04:51:49 -07:00
Alex Chau 3554656c13 Merge "Add debug log in InvariantDeviceProfile.minCellSize" into main 2023-09-13 10:00:24 +00:00
Bill Yi f0b7a4b87c Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I56f81a56e915bb784052101f7927dc80223887a9
2023-09-12 21:19:14 -07:00
Bill Yi 91869bb5fc Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: If357cbbd2d233f466c706a21e45e829bffe95633
2023-09-12 21:18:29 -07:00
Jagrut Desai ff077335d1 Merge "Revert "ENABLE_TASKBAR_PINNING for TEAMFOOD"" into main 2023-09-12 23:37:59 +00:00
Mady Mellor cf50be2c80 Use the scrim value from bubble constants in launcher
Test: manual - enable persistent taskbar (light theme shows it best)
             - expand bubbles
             => observe that the scrim on taskbar matches the rest of
                scrim
Bug: 294396107

Change-Id: I6fc516f3d57a3e8de4d80c079f3543874f289ad7
2023-09-12 16:17:39 -07:00
Colin Cross 3c7e501bb9 [automerger skipped] Fix kotlin nullable errors in Launcher3 am: 70ca32bca2 -s ours am: f65d8e122a -s ours am: 24803b44be -s ours am: d6f2c09616 -s ours
am skip reason: Merged-In I4525d0fa83a1db9cc5cff90f340fc3f863537c01 with SHA-1 4cc251e6c1 is already in history

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24721675

Change-Id: I2693da7b6993aa106403a5ab78d5c337b516c5ad
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-09-12 22:55:39 +00:00
Colin Cross d74064c1c7 [automerger skipped] Fix kotlin nullable errors in Launcher3 am: e892df24ca -s ours am: 79c7f28993 -s ours am: a42a24fb97 -s ours am: 81ebeb0a3b -s ours
am skip reason: Merged-In I26edfec35dca14abe90b08e3c74de0446eda95d2 with SHA-1 2608381792 is already in history

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24723831

Change-Id: Ib37a3a1a097314c8e9deb7b7215dbb67476070e4
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-09-12 22:55:28 +00:00