Commit Graph

60459 Commits

Author SHA1 Message Date
Luca Zuccarini 665ac9967b Merge "[Toast] Update A-Z <-> Toast transition for drawable backgrounds." into tm-qpr-dev am: 56ccb4eda5 am: b940d3e458
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20007687

Change-Id: Ida7f988f897da142021571830e1adbfd48c8c25a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-15 11:29:53 +00:00
Pat Manning 39a3ac6fe5 Update string for "swipe to go home" when in button nav.
Bug: 252938555
Test: manual
Change-Id: Id52867ec6a9b82a44ab0a803a9824258d9ad4044
2022-11-15 11:19:32 +00:00
Luca Zuccarini b940d3e458 Merge "[Toast] Update A-Z <-> Toast transition for drawable backgrounds." into tm-qpr-dev am: 56ccb4eda5
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20007687

Change-Id: I29a84d48d8f591bc911f8459b43079f6ddfba72e
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-15 11:07:23 +00:00
Luca Zuccarini 56ccb4eda5 Merge "[Toast] Update A-Z <-> Toast transition for drawable backgrounds." into tm-qpr-dev 2022-11-15 10:54:03 +00:00
TreeHugger Robot 7936906716 Merge "Reorder widgets no longer overlaps when no space is available" into tm-qpr-dev am: e2334d76fe am: 1660639dc0
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20413617

Change-Id: I14b439ed928a6418e29dd11299a16e91ebb822ae
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-15 10:37:14 +00:00
TreeHugger Robot 1660639dc0 Merge "Reorder widgets no longer overlaps when no space is available" into tm-qpr-dev am: e2334d76fe
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20413617

Change-Id: Ib60f471012fb310366f82e55653cdc65c2e7dd5a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-15 10:15:55 +00:00
TreeHugger Robot e2334d76fe Merge "Reorder widgets no longer overlaps when no space is available" into tm-qpr-dev 2022-11-15 09:53:02 +00:00
Saumya Prakash a836e9ba00 Merge "Add a flag for the redesigned Gesture Nav Tutorial" into tm-qpr-dev am: 59a3c51a43 am: b67ffcb04b
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20470536

Change-Id: Ic89466fcf8349427af5b618afacab5d490ab2dfc
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-15 03:10:37 +00:00
TreeHugger Robot 772c78c589 Merge "Make settings button touch target size larger" into tm-qpr-dev am: f7d000a6c7 am: c9452b5f70
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20468591

Change-Id: I72414fbe8bae33aaca402ff6f3993bcef2be7dcf
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-15 03:10:04 +00:00
Saumya Prakash b67ffcb04b Merge "Add a flag for the redesigned Gesture Nav Tutorial" into tm-qpr-dev am: 59a3c51a43
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20470536

Change-Id: Iaad0a7624aa157f982c8156c993d5b98faac8c4d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-15 03:06:02 +00:00
Saumya Prakash 59a3c51a43 Merge "Add a flag for the redesigned Gesture Nav Tutorial" into tm-qpr-dev 2022-11-15 02:45:29 +00:00
TreeHugger Robot c9452b5f70 Merge "Make settings button touch target size larger" into tm-qpr-dev am: f7d000a6c7
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20468591

Change-Id: Ia112118efc7f4925a92ffc28c9cf3d5da7d70cdc
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-15 02:35:41 +00:00
TreeHugger Robot f7d000a6c7 Merge "Make settings button touch target size larger" into tm-qpr-dev 2022-11-15 01:44:11 +00:00
Android Build Coastguard Worker ede4a716fb Snap for 9290907 from 62b9f80d1e to tm-qpr2-release
Change-Id: Ie36d3ef490be2d256e5b8fb9360d7bb901ff947b
2022-11-15 00:29:48 +00:00
Vinit Nayak b2711a81e6 Update unsupported split app error text
Bug: 258822425
Change-Id: I8ac24d094d14a5f65a1d83303a9fd087c76bf066
2022-11-14 15:20:25 -08:00
Saumya Prakash 7eac37254b Add a flag for the redesigned Gesture Nav Tutorial
We plan to improve the gesture navigation education tutorial as
discussed and shown in go/gesture-nav-education.

Test: N/A
Bug: 241813570
Change-Id: I2ad8d12cf14c1b3f0eec3208ad12a24ac54b9dbc
2022-11-14 22:38:21 +00:00
Schneider Victor-tulias 8320800bf2 Merge "Return to home when overview command fails." into tm-qpr-dev am: 62b9f80d1e am: 7d9e1d6fb9
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20442700

Change-Id: Iad101873486c0547b7be3ae5af5c9b8772c27324
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-14 21:40:22 +00:00
Alex Chau 2426514bf6 Put IDP.getDeviceProfile logging behind a feature flag
- To avoid memory regression in performance testse

Fix: 257359801
Test: manual
Change-Id: I5ed768d90dba149eeb8f7be7d1d229b0b599a485
2022-11-14 21:19:44 +00:00
Sihua Ma 7a382f139d Making talkback focus on the widget after the resize
Fix: 216386890
Test: Manual
Change-Id: I79b0280c0f24a81be44e1578755ed90cf3343f88
2022-11-14 13:12:44 -08:00
Schneider Victor-tulias 7d9e1d6fb9 Merge "Return to home when overview command fails." into tm-qpr-dev am: 62b9f80d1e
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20442700

Change-Id: I0a5517e8d26e276e021f49dd39deacffaec79b5d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-14 21:08:08 +00:00
Schneider Victor-tulias 62b9f80d1e Merge "Return to home when overview command fails." into tm-qpr-dev 2022-11-14 20:44:52 +00:00
Jon Miranda 5eba9000df Update transient taskbar transition duration to match spec (417ms).
Bug: 246632728
Bug: 246641848
Test: manual
Change-Id: If3f73774444c6074a81101d91d291ef33edcaf9c
2022-11-14 12:28:20 -08:00
Vinit Nayak 0abb205fef Merge "Prevent dropping a drag from TaskbarAllApps in Overview" into tm-qpr-dev am: 50306445a1 am: f47e27ee4f
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20324839

Change-Id: I6c456545cba82946f5a92d4e7a1bcaa8b14c4d0b
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-14 19:39:53 +00:00
Federico Baron 61dbfde9ed Merge "Add flag for 'Improve widget picker UX on large display form factor'" into tm-qpr-dev am: e779a8c783 am: 9b30b84879
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20341701

Change-Id: I7f4c1c4f43d2132714a98cd3429e7413dbd358b7
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-14 19:39:06 +00:00
Jon Miranda 9787ae6ad9 Allow transient taskbar to unstash over soft ime
Bug: 255818649
Test: pull up ime, swipe to reveal taskbar
Change-Id: Ibae77c8a29d06093823f2421fbf851979f9babed
2022-11-14 11:30:55 -08:00
Vinit Nayak f47e27ee4f Merge "Prevent dropping a drag from TaskbarAllApps in Overview" into tm-qpr-dev am: 50306445a1
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20324839

Change-Id: Ie80c46c5c86fde41f259ff2e07ca4213b45a673d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-14 19:21:19 +00:00
Vinit Nayak 50306445a1 Merge "Prevent dropping a drag from TaskbarAllApps in Overview" into tm-qpr-dev 2022-11-14 19:07:59 +00:00
Federico Baron 9b30b84879 Merge "Add flag for 'Improve widget picker UX on large display form factor'" into tm-qpr-dev am: e779a8c783
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20341701

Change-Id: I63d9f134fe7c428d1dfe1dc02dcd6e418f6b98f0
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-14 19:06:46 +00:00
Federico Baron e779a8c783 Merge "Add flag for 'Improve widget picker UX on large display form factor'" into tm-qpr-dev 2022-11-14 18:39:38 +00:00
Federico Baron 2a8ed8a3e8 Make settings button touch target size larger
The touch target of this item was 32dp, now we change it to 48dp to make it easier to interact with the button

Fix: 179116216
Test: enable talkback, then go to home settings -> suggestions -> suggestions on home screen. Turn on suggestions on home screen. Notice touch target size is small in settings button of toast.
Change-Id: I5b8b2ac99f3843cf6fe838cf572565a334e23b2a
2022-11-14 10:13:28 -08:00
Jerry Chang 309d627e7d Merge "Make multi-instances split opt-in based" into tm-qpr-dev am: 168c204f49 am: b4f100354e
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20306070

Change-Id: I404a73891dc8646b223b47e544ff0de69b5dac45
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-14 14:23:47 +00:00
Jerry Chang b4f100354e Merge "Make multi-instances split opt-in based" into tm-qpr-dev am: 168c204f49
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20306070

Change-Id: Icec4268adf433679226a7cb26dbdfd0327e899a2
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-14 13:51:16 +00:00
Jerry Chang 168c204f49 Merge "Make multi-instances split opt-in based" into tm-qpr-dev 2022-11-14 13:29:46 +00:00
Android Build Coastguard Worker 2a6fb3ce5f Snap for 9286161 from 584332202c to tm-qpr2-release
Change-Id: Iafd49cedd68e4d47a9e490d9059dddedcb6f24a8
2022-11-12 22:29:33 +00:00
Vinit Nayak f6abb5d4a1 Only show split button for single fullscreen task if taskbar is present in Overview am: 584332202c am: b8ef284a6c
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20442504

Change-Id: Iadefe00411ce025817f92d8e3a644412cb82a15d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-12 03:57:40 +00:00
Vinit Nayak b8ef284a6c Only show split button for single fullscreen task if taskbar is present in Overview am: 584332202c
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20442504

Change-Id: Ifde61fadc084a707e60a0d66db2f4fd06b7ef669
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-12 03:11:16 +00:00
Evan Rosky eb31fcc888 Merge "Revert^4 "Enable Shell Transitions"" 2022-11-11 23:31:25 +00:00
Colin Cross d930011746 Add a lint baseline for Launcher3
The lint version in tm-qpr-dev incorrectly flags BaseActivity.java.
Add an entry to lint-baseline.xml file to silence the incorrect
error.  The newer version of lint in master doesn't have the false
positive.

Bug: 258754271
Bug: 256019562
Test: m RUN_ERROR_PRONE=true javac-check lint-check
Change-Id: I2fd22e96c8e89b7dc25132089e36d599e012e747
Merged-In: If02f87ef74c73321afa3427d845ad80539292b30
2022-11-11 23:27:20 +00:00
Tracy Zhou 0b96f63514 Merge "Use movement on the trackpad instead of on screen for trackpad gestures used for gesture nav" 2022-11-11 22:31:35 +00:00
Federico Baron c0dc93d384 Add flag for 'Improve widget picker UX on large display form factor'
here's how we plan on improving widget picker under this flag: https://docs.google.com/presentation/d/1mcdjJWutr-ZGbPOndhe1D8YCdCh6EbO8eNyK3YMMVEY/edit#slide=id.g1571d496dda_0_145
Test: N/A
Bug: 256684299

Change-Id: I365516b43e70a37c7b93e089b6822c58a0f81540
2022-11-11 22:24:18 +00:00
Anushree Ganjam c36593139c Introduce imeHeight in KeyboardStateManager.
Bug: 204781396
Test: Manual
Change-Id: If9dc9427a73ab22d6418edb9c954e79fd0958395
2022-11-11 19:20:16 +00:00
Anushree Ganjam 6024013953 Add SearchResultCode to onSearchResult()
Bug: 204781396
Test: Manual
Change-Id: Ia776be0fdd42e1d5fa405911e28d9b0a12c1fdde
2022-11-11 18:26:58 +00:00
Anushree Ganjam 96c72745ae Add ImpressionLogger to StatsLogManager
go/toast-search-impression-logging

Bug: 204781396
Test: Manual
Change-Id: If00027581000d315590ce2fac46428cbf173da49
2022-11-11 18:23:25 +00:00
Tracy Zhou aef9d75f78 Use movement on the trackpad instead of on screen for trackpad gestures used for gesture nav
Bug: 254783214
Test: https://recall.googleplex.com/projects/3388b17c-d22f-46f8-b140-a102690377b4/sessions/f3311fbc-d8cf-4f19-b83c-8626aa285452
Change-Id: Iad2da5831af85dd3647e1e31b42fea0a6302b49c
2022-11-11 00:05:03 -08:00
Android Build Coastguard Worker 0e29e66066 Snap for 9279354 from b63cc3f113 to tm-qpr2-release
Change-Id: Id077e4133ebd549110adca0675bd28a413b8f098
2022-11-11 00:29:27 +00:00
Vinit Nayak eae4c99434 Prevent dropping a drag from TaskbarAllApps in Overview
* Don't close TaskbarAllApps once drag starts
(see comment in code regarding needing multiple shared drag
layers)
* Hide app menu split options for taskbar in overview
* One TODO is that the animation needs to be tweaked
because the scale of the icon when it's returned is too large.
* I think maybe we have to change the
TaskbarDragController#mDragIconSize since that gets directly
set from a resource. Unclear.

Test: Dragged in TaskbarAllApps in overivew and in split
select, app returned to original position and not taskbar
Bug: 251747761

Change-Id: I785f34b0bdb0b0abfc440450494074f8dfe7c31a
2022-11-10 16:17:26 -08:00
Vinit Nayak 584332202c Only show split button for single fullscreen task if taskbar is present in Overview
* Taskbar in overview allows second app to be
selected so user wouldn't be stuck in split
select state

Fixes: 258543259
Test: Tested w/ flag on and off
w/ one and multiple flags
w/ fullscreen and split single focused task

Change-Id: Ie588ad66fde4e012e08d8f5abbe1eef5a1a5db6b
2022-11-10 14:20:03 -08:00
Sebastian Franco 592e2691f6 Fix the wiggle reorder aniamtion stopping if dragging
We were using the minimum span to calculate the cell position
of the widget and if you move slightly because the minimum is usually smaller than the current size it would calculate wrong cell positions
that are change more frequently because it's smaller.

Also, I went back and moved
performReorder(... CellLayout.MODE_SHOW_REORDER_HINT) with the
alarm if block as it was before one of my refactors, it still works
if they are separate but is harder to think about the logic if they
are divided so it's better to all be in one block.

Fix: 255421416
Test: manual testing, reordering and making sure the animation is playing well.
Test: atest ReorderWidgets (to make sure the reorder is not broken)
Change-Id: I3eff5bc9f21fda8f2f8908380397d8639ac15ff9
2022-11-10 21:53:33 +00:00
Anushree Ganjam 9aa386cde2 Merge "Add ENABLE_TOAST_IMPRESSION_LOGGING to FeatureFlags." into tm-qpr-dev am: b63cc3f113 am: 9d77abc3f4
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20432435

Change-Id: Ifd258e36efa3b175292b7698a4233934abd7fad8
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-10 20:44:23 +00:00
Anushree Ganjam 5fc563b2b5 Merge "Add OnLayoutCompleted() Listener." into tm-qpr-dev am: fd7afb707a am: 04c268daef
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20432434

Change-Id: If48dabaf57308b293b7e9b211b04a50ce01420ad
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-10 20:44:15 +00:00