Commit Graph

60459 Commits

Author SHA1 Message Date
Pat Manning 0e77a9a840 Merge "Align system navigation setting link in AllSet page for tablets to top/start." into tm-qpr-dev am: 3c7a7a92b3 am: e6d4939db8
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20411892

Change-Id: Idb70a42e28a5b02a351f6ecddd123c3d390e416f
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-10 20:44:06 +00:00
Anushree Ganjam 9d77abc3f4 Merge "Add ENABLE_TOAST_IMPRESSION_LOGGING to FeatureFlags." into tm-qpr-dev am: b63cc3f113
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20432435

Change-Id: If02f87ef74c73321afa3427d845ad80539292b30
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-10 20:43:32 +00:00
Anushree Ganjam 04c268daef Merge "Add OnLayoutCompleted() Listener." into tm-qpr-dev am: fd7afb707a
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20432434

Change-Id: I21481a4769668479d161f5557caddaa8b7b85edf
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-10 20:43:22 +00:00
TreeHugger Robot 5a84fe1817 Merge "Create test for default grid" into tm-qpr-dev am: 267d7179cd am: ed50adb7b4
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20347132

Change-Id: I00abba38b3cd56d73bdef126493c1b7c601ad380
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-10 20:42:43 +00:00
Saumya Prakash a0df11e73c Merge "Add padding around clear all button in overview." into tm-qpr-dev am: 6db7d31ced am: 8d2f42ddd2
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20413157

Change-Id: I89495c90b7723b36f6828f56d34e557c7458adc9
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-10 20:42:32 +00:00
Anushree Ganjam b63cc3f113 Merge "Add ENABLE_TOAST_IMPRESSION_LOGGING to FeatureFlags." into tm-qpr-dev 2022-11-10 20:31:01 +00:00
Anushree Ganjam fd7afb707a Merge "Add OnLayoutCompleted() Listener." into tm-qpr-dev 2022-11-10 20:19:42 +00:00
Vinit Nayak 27d004d369 Merge "Improve Split portrait gesture animation" into tm-qpr-dev am: 2ca82f38e4 am: 4b6c05c2ef
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20330754

Change-Id: Ib1e9cf31c70edb187f6bc8467f7a2d5ddaa9bb1e
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-10 20:18:10 +00:00
Jeremy Sim cf8e94592e Merge "Allow user to select second split app from Taskbar" into tm-qpr-dev am: d5525c3bda am: 3d0b47a5ea
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20365694

Change-Id: I03cc7692d94a8d0aa99e2822442da6251639f190
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-10 20:17:47 +00:00
Pat Manning e6d4939db8 Merge "Align system navigation setting link in AllSet page for tablets to top/start." into tm-qpr-dev am: 3c7a7a92b3
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20411892

Change-Id: Ib44b14ba9fb1781efc443d6d10668aac4fdabeae
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-10 20:11:14 +00:00
TreeHugger Robot ed50adb7b4 Merge "Create test for default grid" into tm-qpr-dev am: 267d7179cd
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20347132

Change-Id: I6cb50a223aa63323812133b50499fb84b6c19698
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-10 20:09:29 +00:00
Pat Manning 3c7a7a92b3 Merge "Align system navigation setting link in AllSet page for tablets to top/start." into tm-qpr-dev 2022-11-10 19:58:48 +00:00
Schneider Victor-tulias 0844f2e8ef Return to home when overview command fails.
Returning a runnable list that doesn't get run later causes the overview command to be added to the pending command queue, but never gets removed. This causes following overview (and home on tablets) commands not to respond.

Test: forcefully caused the error condition programmatically; checked the queue is cleared and the user is sent home.
Fixes: 255851262
Change-Id: I9d2f54960c54963b1e7480a597d05911201c152b
2022-11-10 11:56:09 -08:00
TreeHugger Robot 267d7179cd Merge "Create test for default grid" into tm-qpr-dev 2022-11-10 19:37:11 +00:00
Saumya Prakash 8d2f42ddd2 Merge "Add padding around clear all button in overview." into tm-qpr-dev am: 6db7d31ced
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20413157

Change-Id: I0f9883e153ddb2ab09f17ac3ed453f73ad626496
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-10 19:29:43 +00:00
Vinit Nayak 4b6c05c2ef Merge "Improve Split portrait gesture animation" into tm-qpr-dev am: 2ca82f38e4
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20330754

Change-Id: I6cd4962097e2c72762cf28f8c4feb01efa66f22b
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-10 19:28:59 +00:00
Saumya Prakash 6db7d31ced Merge "Add padding around clear all button in overview." into tm-qpr-dev 2022-11-10 19:27:53 +00:00
Jeremy Sim 3d0b47a5ea Merge "Allow user to select second split app from Taskbar" into tm-qpr-dev am: d5525c3bda
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20365694

Change-Id: I8d1e153a3d9f2b04293a41a0e008cc348fe028d9
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-10 19:25:02 +00:00
Vinit Nayak 2ca82f38e4 Merge "Improve Split portrait gesture animation" into tm-qpr-dev 2022-11-10 19:19:39 +00:00
Jon Miranda f0349354ec Revert "Revert "Add TaskbarModeSwitchRule to test both transient/persistent taskbar.""
This reverts commit e7011d2b87.

Reason for revert: attempt to fix test issues

- Instead of using SharedPrefs which can be flaky anyways,
  we pass along a boolean to test transient taskbar when
  we are in the test harness

Bug: 257549303
Test: TaplTestsTaskbar
Change-Id: I7c15a97363adc377f29853c1fe60b1960c77bfc3
2022-11-10 11:11:14 -08:00
Jeremy Sim d5525c3bda Merge "Allow user to select second split app from Taskbar" into tm-qpr-dev 2022-11-10 18:56:22 +00:00
Anushree Ganjam 29eb74f9bd Add ENABLE_TOAST_IMPRESSION_LOGGING to FeatureFlags.
Bug: 204781396
Test: Manual
Change-Id: Icd1170d8fc349ca3a50836ef0d1d0c9a0c793002
2022-11-10 17:41:20 +00:00
Anushree Ganjam f213afc0a7 Add OnLayoutCompleted() Listener.
OnLayoutCompleted() Listener for RecyclerView.LayoutManager#onLayoutCompleted(RecyclerView.State) so we can do impression logging when RecyclerView has finished laying out the items.

Bug: 204781396
Test: Manual
Change-Id: I59b81e98415b2b0c6f3b26d2c41d348242342048
2022-11-10 17:38:59 +00:00
Luca Zuccarini 431f05b3a0 [Toast] Update A-Z <-> Toast transition for drawable backgrounds.
This and the other change in the topic are protected by a new feature
flag (included here).

Bug: 229297414
Bug: 248006105
Test: manual (see screenshots and recordings in the second bug)
Change-Id: I3478d7e194ee5d3bc4f8affdadbec969c033d084
2022-11-10 14:43:20 +00:00
Android Build Coastguard Worker 061645e13a Snap for 9274385 from 1d253ac8e0 to tm-qpr2-release
Change-Id: I7c95a6a25bad4cd97294630ec4a0c0bb7d851534
2022-11-10 00:25:56 +00:00
Saumya Prakash d82fc92b2d Add padding around clear all button in overview.
With different languages, the length of the string "clear all" varies,
leading to the clear all button in overview looking different. This
change adds padding to account for these different lengths to
ensure that users have a consistent experience.

Screenshot for English: https://screenshot.googleplex.com/4oijo96WSfGNwWp.png
Screenshot for Ukrainian: https://screenshot.googleplex.com/Bv2963Vn96BkMeT.png

Test: Manual
Fix: 225119413
Change-Id: I09fe7bc95ca0c2fd7fe620997d1298f2670b50a4
2022-11-09 23:02:12 +00:00
Jon Miranda cb580e64a3 Merge "Add dark theme bg for transient taskbar." into tm-qpr-dev am: 1d253ac8e0 am: 614a15c4b3
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20413620

Change-Id: I23d7678cdb1a77489f549107d8f47cab7667e630
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-09 18:53:12 +00:00
Jon Miranda 614a15c4b3 Merge "Add dark theme bg for transient taskbar." into tm-qpr-dev am: 1d253ac8e0
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20413620

Change-Id: I38ae0f159eab975c65a0044cb54c0aed419d72f9
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-09 18:19:11 +00:00
Jon Miranda 1d253ac8e0 Merge "Add dark theme bg for transient taskbar." into tm-qpr-dev 2022-11-09 17:56:34 +00:00
Thales Lima b67bfa7512 Create test for default grid
Fixes: 256044695
Test: DeviceDefaultGridTest
Change-Id: Ie0a4de12f777ad3d15020252b2f67b575cc0eca9
2022-11-09 14:00:44 +00:00
TreeHugger Robot bf6304508f Merge "Add CUJ_LAUNCHER_APP_SWIPE_TO_RECENTS" into tm-qpr-dev am: eaa5703f75 am: 10b0703a40
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20339809

Change-Id: I8686db03f5e6e10da7eab976d8624b29ff8bb1c3
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-09 13:40:17 +00:00
Pat Manning 2335490fe6 Align system navigation setting link in AllSet page for tablets to top/start.
Fix: 233610579
Test: manual
Change-Id: If6d462df02bf795e8a6e73fbb040a6a84ea99404
2022-11-09 13:19:33 +00:00
TreeHugger Robot 10b0703a40 Merge "Add CUJ_LAUNCHER_APP_SWIPE_TO_RECENTS" into tm-qpr-dev am: eaa5703f75
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20339809

Change-Id: Ib8d77e7a1ec40f44b8bccc1dd485c6e10411b616
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-09 13:08:47 +00:00
TreeHugger Robot eaa5703f75 Merge "Add CUJ_LAUNCHER_APP_SWIPE_TO_RECENTS" into tm-qpr-dev 2022-11-09 12:27:25 +00:00
Luca Zuccarini f58fac5d65 Merge "Fix IME sync flicker with 3-button navigation." into tm-qpr-dev am: 3d69d9bd98 am: de9d08fc64
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20175703

Change-Id: I036cb81d3fd679959128baa6e6abdad76ba4f584
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-09 11:40:41 +00:00
Luca Zuccarini de9d08fc64 Merge "Fix IME sync flicker with 3-button navigation." into tm-qpr-dev am: 3d69d9bd98
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20175703

Change-Id: I5679849bbf272da9fa66060ac09773cabd55d8d0
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-09 10:52:56 +00:00
Luca Zuccarini 3d69d9bd98 Merge "Fix IME sync flicker with 3-button navigation." into tm-qpr-dev 2022-11-09 10:19:30 +00:00
Bill Yi c0b515211c Merge "Import translations. DO NOT MERGE ANYWHERE" 2022-11-09 06:15:54 +00:00
TreeHugger Robot 195e9ef499 Merge "Revert "Add TaskbarModeSwitchRule to test both transient/persistent taskbar."" into tm-qpr-dev am: 8dd01f3ac2 am: b5c134d72c
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20416308

Change-Id: Ie5d094942e3e476a8be47de609a47cf52049e621
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-09 02:19:58 +00:00
TreeHugger Robot b5c134d72c Merge "Revert "Add TaskbarModeSwitchRule to test both transient/persistent taskbar."" into tm-qpr-dev am: 8dd01f3ac2
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20416308

Change-Id: I1c271f89300a0483af71aac53dafebfe7c45429e
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-09 01:32:38 +00:00
TreeHugger Robot 8dd01f3ac2 Merge "Revert "Add TaskbarModeSwitchRule to test both transient/persistent taskbar."" into tm-qpr-dev 2022-11-09 01:07:11 +00:00
Android Build Coastguard Worker 7498a24be8 Snap for 9268991 from 98f400397b to tm-qpr2-release
Change-Id: I2a40de173499e27fe0a637b3a15e6b7df7519bce
2022-11-09 00:25:43 +00:00
Jon Miranda 5cedbe2cab Merge "Proposal to move Developer Options to top of Home settings if studio build." into tm-qpr-dev am: e76c4b1a43 am: 344fb4d230
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20413621

Change-Id: Ia41c66c04bd79cc8249996e1958092c8a124a9cd
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-09 00:19:23 +00:00
TreeHugger Robot 75d4d63363 Merge "Prevent rotating TaskMenuViewWithArrow for large screen" into tm-qpr-dev am: 9297483eef am: 17fdc95996
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20250157

Change-Id: I1b3df76b948e935b138b6990ebf6f37f6c7e1c9a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-09 00:18:30 +00:00
Jon Miranda 344fb4d230 Merge "Proposal to move Developer Options to top of Home settings if studio build." into tm-qpr-dev am: e76c4b1a43
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20413621

Change-Id: I099457c70b97fdc39bd6e1ec7f3bcec76baa0fcc
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-09 00:16:11 +00:00
Jon Miranda e76c4b1a43 Merge "Proposal to move Developer Options to top of Home settings if studio build." into tm-qpr-dev 2022-11-08 23:54:11 +00:00
TreeHugger Robot 17fdc95996 Merge "Prevent rotating TaskMenuViewWithArrow for large screen" into tm-qpr-dev am: 9297483eef
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20250157

Change-Id: I289a222b4724adb5c98dd241122b9ae3d9e64815
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-08 23:43:53 +00:00
TreeHugger Robot 9297483eef Merge "Prevent rotating TaskMenuViewWithArrow for large screen" into tm-qpr-dev 2022-11-08 23:08:28 +00:00
Jeremy Sim 93fc0f3a7c Allow user to select second split app from Taskbar
This patch makes it so that (when we enable Taskbar in Overview) users will be able to select their second app for splitscreen by tapping the Taskbar icon, or the icon in AllApps.

This was done by performing a check to SplitSelectStateController when a taskbar icon is hit. If we are currently in split select mode, Taskbar/AllApps icons will no longer launch their respective fullscreen apps, but instead confirm the split attempt. The confirmed app will either be an already-running instance of the app, or a fresh instance of the app (if none is currently running). The split confirmation function is located in TaskbarUIController, where it is accessible to both LauncherTaskbarUIController (for 1P Launcher) and FallbackTaskbarUIController (for 3P launchers).

Also cleans up ~2 lines of unused code from the old splitscreen instructions toast.

Outstanding issues:
- When selecting a second app from within AllApps, the AllApps shade does not animate away in a satisfying way
- When selecting a second app and launching a fresh instance of that app, the animation appears to come from the wrong location
- Intent + Intent splitting does not currently work
- If the selected app is already running with multiple instances, it picks the oldest instance. Ideally, the newest instance is preferred.

Bug: 251747761
Test: Manual testing with Taskbar in Overview flag enabled
Change-Id: I302dc092740bb880f9134ba8e2e587c4f2c29d01
2022-11-08 14:38:05 -08:00
Jon Miranda e7011d2b87 Revert "Add TaskbarModeSwitchRule to test both transient/persistent taskbar."
This reverts commit d5a6b5f688.

Reason for revert: Breaks tests due to "SharedPreferences in credential encrypted storage are not available until after user is unlocked"

Bug: 258256906
Change-Id: I1de69249685f9d2e71183357cf3eda8d443c7d97
2022-11-08 21:56:52 +00:00