Commit Graph

16456 Commits

Author SHA1 Message Date
Brian Isganitis c79d577f18 Load widgets in wallpaper app launcher preview
Test: Widgets in wallpaper app launcher preview rendered
Bug: 185306338
Change-Id: I38569d2ff0b64ba55eb188afa42fba4100aae7ff
2021-06-18 15:47:56 -04:00
Stevie Kideckel a093523299 Load widget preview images before adding the rows to the adapter
This allows for smooth animations as the items will have their full
height resolved

Bug: 190892517
Test: verified locally
Test: CachingWidgetPreviewLoaderTest
Change-Id: I86afc6951a4cc82ae45e63795791d259a3bb3cda
2021-06-18 19:18:29 +00:00
Samuel Fufa 485796e814 Merge "Allow AllApps to restore current selected tab on activity recreate" into sc-dev am: f44a9ca6f0
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15014304

Change-Id: Ifbedb11e2c42d66e04093f0ddc7dd983ab27c1b7
2021-06-18 18:12:59 +00:00
Samuel Fufa f44a9ca6f0 Merge "Allow AllApps to restore current selected tab on activity recreate" into sc-dev 2021-06-18 17:57:08 +00:00
TreeHugger Robot d352253c2d Merge "Revert "Deduct padding from widget size only if padding has been inset"" into sc-dev am: 2af9d27116
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15026671

Change-Id: Ifd10e8688d2f5e3c67be615b03e8a403de26a02d
2021-06-18 11:21:07 +00:00
TreeHugger Robot 2af9d27116 Merge "Revert "Deduct padding from widget size only if padding has been inset"" into sc-dev 2021-06-18 11:11:20 +00:00
Steven Ng 2c1fb29d26 Merge "Log widget dimensions before deleting a widget violating min size" into sc-dev am: 21780405ac
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15015050

Change-Id: I8e2b4160bef59aa17f131a384642975eb0bfbd2c
2021-06-18 10:38:35 +00:00
Steven Ng 21780405ac Merge "Log widget dimensions before deleting a widget violating min size" into sc-dev 2021-06-18 10:21:32 +00:00
Steven Ng 54b5424548 Revert "Deduct padding from widget size only if padding has been inset"
This reverts commit 71cefb593f.

Reason for revert: The default padding is added by the framework not the launcher. We really need to subtract padding from the size.

Bug: 190498032
Change-Id: If7f164da34aec3d8e022ef2c752b72292cca0489
2021-06-18 09:37:44 +00:00
Steven Ng cbec62d33c Merge "Use relative bounds for app widget color extraction" into sc-dev am: be397e85e8
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15016211

Change-Id: I0aad84636553bd80252613c7df269448b094727e
2021-06-18 09:17:53 +00:00
Steven Ng be397e85e8 Merge "Use relative bounds for app widget color extraction" into sc-dev 2021-06-18 09:01:25 +00:00
Steven Ng 058308098b Use relative bounds for app widget color extraction
Fix 2 bugs in this CL
1. Before this CL, getBoundsForViewInDragLayer returns absolute bounds
   for widgets. What we want is the bounds of a widget when it is
   visible in the drag layer. ViewGroupFocusHelper#viewToRect has
   taken PagedView into account. This makes it a prefect candidate to
   calculate relative bounds of a widget.
2. requestLayout at the end of endDrag is problematic due to the drop
   animation. If the drop animation is still in progress when onLayout
   is called, the bounds of the widget isn't final. Since the color of
   app widget right before is already the final color. We don't really
   need to update the color extraction.

Test: Set the wallpaper and clock widget according to the bug. Then,
      reboot the device. The clock widget color shown right after
      reboot is the expected color. Long pressing the widget doesn't
      cause a color change.
Fix: 191114337
Change-Id: I466c8102dba0e5b207b3768e0935472cbd523235
2021-06-17 23:25:57 +01:00
Sunny Goyal 4a48a988c8 Simplifying Launcher binding callbacks
> Making all methods as default
> Removing obsolete logic around synchronous binding
> Removing some UI dependencies from bind callbacks

Bug: 187353581
Test: Manual
Change-Id: I0d2bbb060af2cab7c64541d7695055629dfaf0b8
2021-06-17 15:21:01 -07:00
Samuel Fufa e79b469986 Allow AllApps to restore current selected tab on activity recreate
This CL also fixes:

- Wrong tab selection on RTL
- Fixes header protection hydraulic scroll issue
- Work toggle button text background contrast

Bug: 186005219
Bug: 191250799
Bug: 191227662
Bug: 191349226
Test: Manual
Change-Id: I3777474c954ed0d542ac38ff552367904be147d3
2021-06-17 16:59:56 -05:00
Steven Ng b50d747d20 Log widget dimensions before deleting a widget violating min size
Test: N/A
Bug: 191223844
Change-Id: Id909ee19be1a1c7d70a09643422d9ed62a2d82a9
2021-06-17 21:13:17 +01:00
Samuel Fufa ab4fb243b7 Merge "Refactor FolderInsetAnimationCallback to be used with any view" into sc-dev am: efa5df380c
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15002979

Change-Id: I71867324537972713cb4660a70f20a4d06b5a012
2021-06-17 18:50:23 +00:00
Samuel Fufa efa5df380c Merge "Refactor FolderInsetAnimationCallback to be used with any view" into sc-dev 2021-06-17 18:48:49 +00:00
Stevie Kideckel f12eca67b2 Merge "Refresh widgets in the model when packages change" into sc-dev am: 10d4edade1
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15012535

Change-Id: I5167f8507164897fb4df07c98c8b49fdd5c41152
2021-06-17 15:19:11 +00:00
Stevie Kideckel 10d4edade1 Merge "Refresh widgets in the model when packages change" into sc-dev 2021-06-17 15:04:01 +00:00
Stevie Kideckel 69af278f8a Refresh widgets in the model when packages change
Fix: 191163748
Test: local sample app
Change-Id: Ic09ad11cabf6efa471fb6e685cb255c4a17493ee
2021-06-17 13:08:53 +00:00
Steven Ng 8b8de4ccab Merge "Deduct padding from widget size only if padding has been inset" into sc-dev am: 6ce6922c14
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15002454

Change-Id: Ia896edc6e95a0c61f228159e9e45d164cb3b97a5
2021-06-17 11:12:59 +00:00
Steven Ng 6ce6922c14 Merge "Deduct padding from widget size only if padding has been inset" into sc-dev 2021-06-17 11:00:33 +00:00
Yogisha Dixit d417d36615 Merge "Center drop target icons in landscape mode." into sc-dev am: 3287dd9fa7
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14980961

Change-Id: Id3f175c250acc0a40b9662c20c28c73c9fd35c13
2021-06-17 09:45:50 +00:00
Yogisha Dixit 3287dd9fa7 Merge "Center drop target icons in landscape mode." into sc-dev 2021-06-17 09:34:42 +00:00
Steven Ng b33e38242f Merge "Modify AT_LEAST_S check to include SDK int" into sc-dev am: 1184a03b08
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15002455

Change-Id: I9a2ed9eb320f6b8ce469d1c4fca96fb8218953fd
2021-06-17 09:19:45 +00:00
Steven Ng 595c7ced57 Merge "Fix PendingWidgetHostView overlapping UI" into sc-dev am: e8772c1659
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14980850

Change-Id: I462b605d109dcb9799bbf76f1c5adee0d283eccf
2021-06-17 09:19:40 +00:00
Steven Ng 1184a03b08 Merge "Modify AT_LEAST_S check to include SDK int" into sc-dev 2021-06-17 09:09:21 +00:00
Steven Ng e8772c1659 Merge "Fix PendingWidgetHostView overlapping UI" into sc-dev 2021-06-17 09:08:15 +00:00
TreeHugger Robot 1789b00e50 Merge "Fixes duplicate logging for LAUNCHER_ALLAPPS_KEYBOARD_CLOSED events." into sc-dev am: ea95f88361
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14986815

Change-Id: Ib480d52bb674ecf341aecd70ed3d13d52940d510
2021-06-17 06:19:36 +00:00
TreeHugger Robot ea95f88361 Merge "Fixes duplicate logging for LAUNCHER_ALLAPPS_KEYBOARD_CLOSED events." into sc-dev 2021-06-17 06:08:09 +00:00
TreeHugger Robot 6e89620c79 Merge "Add logging for tapped on 'Turn on/off work apps' button in all apps" into sc-dev am: 4f257655bd
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14989654

Change-Id: I5a2d2b0e81ffc7545640808aac19d468fd16a1db
2021-06-17 05:41:03 +00:00
TreeHugger Robot 4f257655bd Merge "Add logging for tapped on 'Turn on/off work apps' button in all apps" into sc-dev 2021-06-17 05:25:49 +00:00
Sunny Goyal f3fa2da436 Merge "Fixing widget not laid-out properly in preview" into sc-v2-dev 2021-06-17 01:20:46 +00:00
TreeHugger Robot ed7d1c052e Merge "Fix broken app icon on restart during install." into sc-dev am: 3115a4380b
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15003917

Change-Id: I46100f030897500f8eeac3fe2421fbb515ac06ae
2021-06-17 01:14:43 +00:00
TreeHugger Robot 3115a4380b Merge "Fix broken app icon on restart during install." into sc-dev 2021-06-17 01:11:53 +00:00
TreeHugger Robot 853186578d Merge "Prevents a ConcurrentModificationException in Widget" into sc-dev am: 3a37543fb9
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15001812

Change-Id: I6aa3f859df6a706716081d4258200eafeafcada3
2021-06-17 01:09:54 +00:00
Thiru Ramasamy 95b09f9067 Fixes duplicate logging for LAUNCHER_ALLAPPS_KEYBOARD_CLOSED events.
Bug: 178562918
Test: Manual
Change-Id: Id32b621c0f506bba4378f6f6b81d7cfece3cb373
2021-06-17 00:05:56 +00:00
Thiru Ramasamy 6f0e75740f Add logging for tapped on 'Turn on/off work apps' button in all apps
Bug: 190050582
Test: Manual
Change-Id: Ib83fba6dc9199ba40a500e0743c0e64cc4d4d0a0
2021-06-16 17:03:49 -07:00
Schneider Victor-tulias bcd72a7b32 Fix broken app icon on restart during install.
Fixes: 186610233
Test: manual with backup/restart and restart during install
Change-Id: Ic64bd98758bc2e1a2a1562579cb25de02faa624c
2021-06-16 16:47:45 -07:00
Jonathan Miranda b94b6e0d3c resolve merge conflicts of 0bf000104f to sc-v2-dev
Bug: 175329686
Change-Id: I48e3f6a20c27c8c7aeef5da7a464a6c4a5e4180c
Test: create folder / add items to folder
Merged-In: Iaab592410734b0b5239dbbddbb9b2ed5a9f5d8b0
2021-06-16 23:46:53 +00:00
TreeHugger Robot 3a37543fb9 Merge "Prevents a ConcurrentModificationException in Widget" into sc-dev 2021-06-16 23:43:29 +00:00
TreeHugger Robot 0bf000104f Merge "Fix bug where preview item icon fades/disappears for a frame during" into sc-dev 2021-06-16 23:24:58 +00:00
Sunny Goyal 0c299cb324 Merge "Simplifying the drop animation code" into sc-v2-dev 2021-06-16 23:18:16 +00:00
Steven Ng 71cefb593f Deduct padding from widget size only if padding has been inset
Test: Set the grid to 4x5 (without padding) and verify the min / max
      size sent to Conversation widget is expected.
Bug: 190498032
Change-Id: I8ef6e5d897ebd0e2ea9af4497b00059c8dfad70a
2021-06-17 00:15:52 +01:00
Steven Ng 7e31e9b267 Modify AT_LEAST_S check to include SDK int
BuildCompat.isAtLeastS() in Launcher dependency only checks if the
code name is "S". In the recent version of Android, the code name has
changed to "REL".

Test: Open Widgets picker, expand Conversations and observe a preview
      layout is shown.
Fix: 191239040, 191216821
Change-Id: I6a6e647d4cb327d251bde3484ea2d2e79c0f86f5
2021-06-16 23:56:38 +01:00
TreeHugger Robot c51564bb7a Merge "Reattach LauncherAppWidgetHostView to its parent after canceling drag" into sc-dev am: 4176cb33bb
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14970490

Change-Id: I5a92dc73ce2dcde24ea5fd7d826211e9d35a717e
2021-06-16 22:39:09 +00:00
Samuel Fufa d04a92d1ed Refactor FolderInsetAnimationCallback to be used with any view
- Update ic_corp_off icon to outline
- Remove shadow from work toggle
- Translate work fab when keyboard is shown

Screenshot: https://screenshot.googleplex.com/593tEg7bE4kSS4y

Bug: 191251404
Bug: 191250785
Test: local
Change-Id: Ie7dddfd17eb90575a1e1f67e281070dd8d268f8d
2021-06-16 17:25:53 -05:00
TreeHugger Robot 4176cb33bb Merge "Reattach LauncherAppWidgetHostView to its parent after canceling drag" into sc-dev 2021-06-16 22:25:41 +00:00
Sunny Goyal 5d5085c5c3 Fixing widget not laid-out properly in preview
Bug: 185306338
Test: Manual
Change-Id: Ib1ec8a53e4701f6813813b86bf481b837127a909
2021-06-16 15:24:16 -07:00
Pinyao Ting 9cd63c97ce Prevents a ConcurrentModificationException in Widget
InvariantDeviceProfile.supportedProfiles can be modified in respect to
configuration changes. This CL ensures the list was cloned before access
to prevent ConcurrentModificationException

Bug: 191231591
Test: manual
Change-Id: I123458dcfe99af4babca2cf73733e3d2af0fad3c
2021-06-16 21:02:48 +00:00