Commit Graph

16456 Commits

Author SHA1 Message Date
Jonathan Miranda c01e87daf0 Merge "Add ENABLE_SCRIM_FOR_APP_LAUNCH feature flag." into sc-dev am: 28e39335bc
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14987185

Change-Id: Iecfbdc781852e24aafb92744f9a3de4ff5cbbd00
2021-06-16 20:39:08 +00:00
Jonathan Miranda 28e39335bc Merge "Add ENABLE_SCRIM_FOR_APP_LAUNCH feature flag." into sc-dev 2021-06-16 20:34:48 +00:00
Hyunyoung Song cd4de5ed37 Merge "All apps motion" into sc-dev am: d2ad97989c
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14973766

Change-Id: I0defd93e9d2a6cb99e2695ff185e0ef552dee5f6
2021-06-16 20:34:36 +00:00
Hyunyoung Song d2ad97989c Merge "All apps motion" into sc-dev 2021-06-16 20:14:46 +00:00
Yogisha Dixit bd1581f030 Merge "Fix drop target icons being truncated." into sc-dev am: de268a51a1
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14899271

Change-Id: I027d4605768273e0c5115f02682d87fea206f204
2021-06-16 20:02:45 +00:00
Yogisha Dixit 58c5e65763 Center drop target icons in landscape mode.
Spec: https://docs.google.com/presentation/d/1UxdDh8EFhPbdRWRwzjbpgL-j02ew4Ew3eG3XBCeoYdo/edit#slide=id.vXfwHn8

Test: manual
Bug: 187376586
Change-Id: I2025ba75061a5ca3a004dfef2b33cdbcc17a1408
2021-06-16 20:55:56 +01:00
Yogisha Dixit de268a51a1 Merge "Fix drop target icons being truncated." into sc-dev 2021-06-16 19:48:08 +00:00
Jonathan Miranda 47f8a1c3ef Merge "App Shortcut menu bug fixes and polish." into sc-dev am: c846245f1b
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14985072

Change-Id: Icba377c0032eee2dacec8a3c4364fa5b958880b7
2021-06-16 18:19:16 +00:00
Hyunyoung Song 54a44d4c44 All apps motion
Bug: 189970327
Test: manual

TL;DR;;

equation: settleVelocity = releaseVelocity + interpolator 2nd deritive * t

Change-Id: I86fec339523fbc3bb347dec4affbd2d1c063d13d
2021-06-16 11:17:59 -07:00
Jon Miranda b73e591712 Add ENABLE_SCRIM_FOR_APP_LAUNCH feature flag.
Bug: 191088291
Test: manual
Change-Id: Ia144c72e0fe1292ed856a37ee714a1cda50083d5
2021-06-16 18:13:23 +00:00
Jonathan Miranda c846245f1b Merge "App Shortcut menu bug fixes and polish." into sc-dev 2021-06-16 18:06:13 +00:00
TreeHugger Robot e7cf240e0c Merge "Add work toggle to work apps paused message" into sc-dev am: 29dba38119
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14970540

Change-Id: I66f4c3273eb3fcf5e0f5d956d559915505dfaad3
2021-06-16 16:15:02 +00:00
TreeHugger Robot 29dba38119 Merge "Add work toggle to work apps paused message" into sc-dev 2021-06-16 15:57:49 +00:00
Yogisha Dixit ed052ab212 Fix drop target icons being truncated.
The icons were being truncated due to incorrect viewport width/height
values for the vector drawable.

Test: manual
Bug: 187036287
Change-Id: Ie2d0ffe815501d2e943146a79cb4ede379ce0ecf
2021-06-16 14:07:38 +01:00
Steven Ng 19bc880a5f Fix PendingWidgetHostView overlapping UI
* Only show launcher set up UI if a pending widget has not finished
set up.
* Update configuration string

Test: manual inspection
Bug: 190037003
Change-Id: I3b9fb39da21ea557f97e9ca7b05a3b52f3ec3452
2021-06-16 11:22:49 +01:00
Stevie Kideckel 857820793f Merge "Use drawable states for list positions instead of swapping drawables" into sc-dev am: 358411a96a
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14966492

Change-Id: Iab3dc8912f976159a2536a631594535b39ade45f
2021-06-16 09:50:25 +00:00
Stevie Kideckel 358411a96a Merge "Use drawable states for list positions instead of swapping drawables" into sc-dev 2021-06-16 09:34:21 +00:00
Jon Miranda 229c4c3235 App Shortcut menu bug fixes and polish.
- Widget is its own item.
- Change order of icon order.
- Update grab handle colors

Bug: 188095695
Test: long press on apps with/without widgets, long press apps on workspace/
      all apps/search

Change-Id: Iabb9b4b3f3a928103b9d62601f22e74ef2325d7c
2021-06-15 18:59:51 -07:00
Schneider Victor-tulias f6ae45e46d Merge "Skip item infos that fail session info verification." into sc-dev am: e00d88e32a
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14792907

Change-Id: I1014a006546982860e519dc1d23dd2321e86277e
2021-06-15 21:18:03 +00:00
Thiru Ramasamy e6f240bc12 Merge "Enable logging for 'Themed icons' setting." into sc-dev am: 640fc8b84d
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14983277

Change-Id: If40731963001b85a16505ad162e52aad2a971154
2021-06-15 21:17:03 +00:00
Jon Miranda 9d41499a33 Fix bug where preview item icon fades/disappears for a frame during
- Remove fade since we no longer clip icons.
- Ensures a clean handoff between drag view and folder icon preview item.

Bug: 175329686
Test: create folder / add items to folder
Change-Id: Iaab592410734b0b5239dbbddbb9b2ed5a9f5d8b0
2021-06-15 21:14:47 +00:00
Schneider Victor-tulias e00d88e32a Merge "Skip item infos that fail session info verification." into sc-dev 2021-06-15 20:54:23 +00:00
Thiru Ramasamy 640fc8b84d Merge "Enable logging for 'Themed icons' setting." into sc-dev 2021-06-15 20:47:23 +00:00
Samuel Fufa dfc274364e Add work toggle to work apps paused message
This also fixes scrolling issues in landscape

Bug: 186857875
Bug: 161929312
Bug: 189983516
Bug: 190567199
screenshot: https://screenshot.googleplex.com/BCjcyJFqJo6W4Tr
Test: local
Change-Id: I7bcf23cc4be2fca936eba41342731789eb8f3292
2021-06-15 14:58:05 -05:00
Schneider Victor-tulias 12e9345f4f Skip item infos that fail session info verification.
trichromelibrary.canary is failing session info verification, but is still being added as blank icon on the workspace in some cases. Added logic to skip apps that fail this verification until the root cause can be found.

Bug: 168788486
Test: none

Change-Id: I8a7fe76f321de493b2c6c67ba6922eae23067ff3
2021-06-15 12:12:07 -07:00
Samuel Fufa b93523ed3a Merge "Fix home settings landing page" into sc-dev am: 1bd6fdb6e3
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14965825

Change-Id: Iabc1f53aa9e10113dcc50df431f3c25736cbe4df
2021-06-15 18:52:21 +00:00
Samuel Fufa 1bd6fdb6e3 Merge "Fix home settings landing page" into sc-dev 2021-06-15 18:32:36 +00:00
Winson Chung 0c36935be9 Merge "Don't rely on intent to call back from activity tracker" into sc-dev am: 1b369c4763
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14909197

Change-Id: Ic05028f7cbd58bd4312b04c32f60f31ec33a1721
2021-06-15 18:16:19 +00:00
TreeHugger Robot 259960ae36 Merge "Remove IME visibility check before closing the keyboard" into sc-dev am: 9c25a4dd07
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14974657

Change-Id: I117540582ba10f3e47006238cfeaf76f335f7c4f
2021-06-15 18:16:13 +00:00
Winson Chung 1b369c4763 Merge "Don't rely on intent to call back from activity tracker" into sc-dev 2021-06-15 18:04:52 +00:00
TreeHugger Robot 9c25a4dd07 Merge "Remove IME visibility check before closing the keyboard" into sc-dev 2021-06-15 18:00:48 +00:00
Thiru Ramasamy 74a6d2ea55 Enable logging for 'Themed icons' setting.
Eldar: http://eldar/510864786
Bug: 191161241
Test: local - http://gpaste/5934701681311744 & http://gpaste/6715297709948928
Change-Id: I18ad97f68b372997e222f06dabf8bbe83f15d92f
2021-06-15 10:48:43 -07:00
Alina Zaidi b49556b21a Merge "Update bottom widget picker and pin widget dialog layout in landscape mode." into sc-dev am: b5459c9ba5
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14817823

Change-Id: Iaf5fb71dc31f9e94b053c74da4a148bef0f761da
2021-06-15 17:37:47 +00:00
Alina Zaidi b5459c9ba5 Merge "Update bottom widget picker and pin widget dialog layout in landscape mode." into sc-dev 2021-06-15 17:23:02 +00:00
Stevie Kideckel 803927bdae Use drawable states for list positions instead of swapping drawables
Replacing drawables interrupts touch feedback of ripples. Implementing
custom state lists allows altering the corner radius without cutting off
ripples and also means we reduce unnecessary object creation.

Fix: 190467676
Test: locally
Change-Id: I10eec042aae57d278f8254327d42df945767c7ac
2021-06-15 16:32:36 +00:00
Santhosh Thangaraj 8134028a3a Merge "Fix the page number based Seen impression." into sc-dev am: 4d61c56200
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14905388

Change-Id: I0d3e74f112da86eedc7d50bbe2bd9fa799473902
2021-06-15 15:22:29 +00:00
Santhosh Thangaraj 4d61c56200 Merge "Fix the page number based Seen impression." into sc-dev 2021-06-15 15:20:40 +00:00
Alina Zaidi dfa6aa828c Update bottom widget picker and pin widget dialog layout in landscape mode.
Bug: 189726613
Test: Manually tested
Change-Id: I048740f949571423ab53bbb01e7128d9981b1ce7
2021-06-15 14:27:57 +01:00
Hyunyoung Song 0ba45e4d5e Remove IME visibility check before closing the keyboard
Bug: 185890446
Test: manual

TL;DR;;
In racy condition, keyboard is not visible when the check happens
but in next frame, it becomes visible.

Change-Id: I3336f3c967804e5ccdea9110c363e92d83b7bc02
2021-06-14 23:15:52 -07:00
Winson Chung 1c2d522d1b Don't rely on intent to call back from activity tracker
- The intent is not updated in certain cases which means that the
  callback may not be made if Launcher gets recreated. Instead
  have the tracker manage the set of registered callbacks.
- This change allows AbsSwipeUpHandler to continue to receive
  onActivityInit calls even if Launcher restarts, and also to
  handle a case where restarting while waiting for a page-settling
  callback will continue to finish the gesture.

Bug: 183962705
Test: Force recreate at various points in the gesture

Change-Id: Ib5ead8c868e798e26e56776f57bd715c79d087cd
2021-06-14 20:57:40 -07:00
Jonathan Miranda 620c7d1854 resolve merge conflicts of bea8267854 to sc-v2-dev
Bug: 181901105
Change-Id: I4bbe6258e0d2e5f04931d2a3d8d1f784a90f91de
Merged-In: Ia904b8b96301042c900e0589f33fc625c1c1148b
2021-06-15 02:32:30 +00:00
Hyunyoung Song d4f7c9a666 Merge "Fix NPE inside REcyclerViewFastScroller" into sc-dev am: 8c0f8fba9c
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14966513

Change-Id: I6bab2c6eb3c2e2ba1a6566d296752717b121cb33
2021-06-15 01:03:46 +00:00
Jonathan Miranda ce4397aafe Merge "resolve merge conflicts of 11bf817e86 to sc-v2-dev" into sc-v2-dev 2021-06-15 01:02:25 +00:00
Jonathan Miranda bea8267854 Merge "Address LAUNCHER_APP_LAUNCH_FROM_ICON jank." into sc-dev 2021-06-15 00:32:40 +00:00
Jon Miranda 0750f03c96 Address LAUNCHER_APP_LAUNCH_FROM_ICON jank.
- Delay app launch animations by a frame, and skip logic to skip the first frame.
- Note the icon pressed state animation still occurs, so there is still some
  visual feedback for the user that something is happening.

Bug: 181901105
Test: ensure animation still looks smooth (using window animation scale & record in slow mo)
Change-Id: Ia904b8b96301042c900e0589f33fc625c1c1148b
Merged-In: Ia904b8b96301042c900e0589f33fc625c1c1148b
2021-06-14 23:29:29 +00:00
Brian Isganitis 0058f293eb Merge "Add flag for widgets in Launcher preview" into sc-v2-dev 2021-06-14 23:23:29 +00:00
Hyunyoung Song 8c0f8fba9c Merge "Fix NPE inside REcyclerViewFastScroller" into sc-dev 2021-06-14 23:18:22 +00:00
Steven Ng a5e1453779 Reattach LauncherAppWidgetHostView to its parent after canceling drag
onDrop isn't called if the drag is canceled at Launcher.onPause. Let's
also reattach LauncherAppWidgetHostView to its parent in this case.

Test: long press and hold a widget and, at the same time, press the
      power button. Don't let go of the long press and press the power
      button. No crash observed.
Fix: 190950646
Change-Id: Id52a51291863b7ef63c861eb6dc23b015484be65
2021-06-15 00:01:04 +01:00
Jonathan Miranda 7e8b2742c9 resolve merge conflicts of 11bf817e86 to sc-v2-dev
Bug: 190210234
Bug: 190164147
Test: manual

Change-Id: I155ee7efdbda10c05f87001ac4eaf07017a6d456
Merged-In: I230c33d7e4e1871d8d702737c56c79ce46504b8f
2021-06-14 20:32:58 +00:00
Jonathan Miranda 11bf817e86 Merge "Folder polish - update color extraction, fix contrast issues." into sc-dev 2021-06-14 20:11:50 +00:00