Commit Graph

16456 Commits

Author SHA1 Message Date
Steven Ng fbe1836627 Extract common measurement in widgets pickers to its base class
Bug: 191644950
Test: 1. Open the full widget picker. Observe the clock widgets'
         previews are shown properly. Then, rotate the screen and
         observe the clock widgets' previews are shown properly.
      2. Open the bottom widgets picker for clock. Observe the
         clock widgets' previews are shown properly. Then, rotate
         the screen and observe the clock widgets' previews are shown
         properly.
      3. Repeat 1, 2 after changing the system navigation from button
         to gesture.
Change-Id: I564fc2ce0baf3103ae77499380ad69ec38ac6930
2021-06-28 14:55:27 +01:00
Hyunyoung Song 878dedfb84 Don't use ProxyActivity when launching from SearchActionItemInfo intent
Bug: 188490184
Test: Manual
Change-Id: I9b1b17dfb7e896025a01245414cdab11cf3125cb
2021-06-28 06:34:48 -07:00
Hyunyoung Song 58f49418ff RecyclerView Scrollbar is easier to target
Bug: 191666122
Test: manual

TL;DR;;
1) Allow some x offset when determining touch points are hitting the track
2) reduce the timeout to consider dragging state

Change-Id: Iebcbbbd1e50b602119795c57fc04c4c2a5ccdde5
2021-06-27 22:57:55 -07:00
Steven Ng a3df3b8bf2 Merge "Fix rounded corners for shortcut & generated preview shadow box" into sc-dev am: bf60673bbb
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15098570

Change-Id: Ia04afd31b5f225fd0020c50f19b55125f6a8bdef
2021-06-26 22:47:47 +00:00
Steven Ng 3bf38cb556 Merge "Refine widgets removal logging" into sc-dev am: 57072af106
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15106953

Change-Id: I39f50ba31e70131c9709096a822f7894a245db44
2021-06-26 22:47:42 +00:00
Steven Ng bf60673bbb Merge "Fix rounded corners for shortcut & generated preview shadow box" into sc-dev 2021-06-26 22:38:51 +00:00
Steven Ng 57072af106 Merge "Refine widgets removal logging" into sc-dev 2021-06-26 22:37:35 +00:00
Hyunyoung Song 5d52dc0201 Merge "When KEYCODE_BACK is received, hide keyboard" into sc-dev am: 24c8ebd88d
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15107283

Change-Id: I53d61df02679024e2362e8e63a02de37b0bbe95a
2021-06-26 20:24:11 +00:00
Hyunyoung Song 24c8ebd88d Merge "When KEYCODE_BACK is received, hide keyboard" into sc-dev 2021-06-26 20:08:55 +00:00
Alina Zaidi b06e92fc83 Merge "Compare maxSpanSize for WidgetsListContentEntries when updating visible entries in widget picker." into sc-dev am: 50401e31bd
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15052492

Change-Id: Id36a1ed53de7fc45cb8f7f9fc2f295f23ca3643d
2021-06-26 18:13:24 +00:00
Alina Zaidi de30ace4db Merge "Remove scrim from navigation bar from full widget picker." into sc-dev am: 57cdcceb07
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15095782

Change-Id: Ia60f26b7a13c8404ad26701c824921ae8da5ec37
2021-06-26 18:13:14 +00:00
Alina Zaidi 50401e31bd Merge "Compare maxSpanSize for WidgetsListContentEntries when updating visible entries in widget picker." into sc-dev 2021-06-26 18:04:19 +00:00
Alina Zaidi 57cdcceb07 Merge "Remove scrim from navigation bar from full widget picker." into sc-dev 2021-06-26 18:01:23 +00:00
Jonathan Miranda 9f113f76fa Merge "Update colors for non-v31 devices." into sc-dev am: 7a582f2d7d
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15096360

Change-Id: Ib926073532c53a4db19e9930ade8c9efd776796d
2021-06-26 15:10:27 +00:00
Jonathan Miranda ca670425a8 Merge "Fix folder icon text alignment." into sc-dev am: 48dbfcd1c8
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15111651

Change-Id: I17cf64b9aa733dbe045626d66b287cbe085edbf5
2021-06-26 15:10:14 +00:00
Hilary Huo 40a75363a1 Merge "[settings-pixel-search] Flag guard slice logging." into sc-dev am: 7a5a96ea73
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15084513

Change-Id: Id2f7128634bfe31987e9822426bf786b007f16de
2021-06-26 15:09:52 +00:00
Jonathan Miranda 7a582f2d7d Merge "Update colors for non-v31 devices." into sc-dev 2021-06-26 00:09:59 +00:00
Jonathan Miranda 48dbfcd1c8 Merge "Fix folder icon text alignment." into sc-dev 2021-06-25 22:31:46 +00:00
Schneider Victor-tulias 9617332f60 Remove expensive logging.
Removed expensive logs added for debugging. Removed unused code.

Fixes: 168788486
Test: none
Change-Id: I0579275633361d2d67399c773e6376af74c9f1b1
2021-06-25 11:48:15 -07:00
Jon Miranda 2be425b6b0 Fix folder icon text alignment.
- We set the parent view padding to be cellYPadding, so we no longer need to
  account for it when setting the text LayoutParams.

Bug: 191954558
Test: grid where scalableGrid=true and scalableGrid=false (4x5, and 5x5)
Change-Id: I8d7578b2589f801ceef229b663446d868d135ad0
2021-06-25 10:33:20 -07:00
Yogisha Dixit 3893eefe75 resolve merge conflicts of 1491ec31c5 to sc-v2-dev
Test: manual
Bug: 192076258
Change-Id: I44e02383cd8ce386811e24a1c4fd6ce62e38f90f
2021-06-25 17:23:22 +00:00
Hilary Huo 7a5a96ea73 Merge "[settings-pixel-search] Flag guard slice logging." into sc-dev 2021-06-25 16:54:59 +00:00
Steven Ng 0d4e57d4f0 Merge "Extra logging related to widget removal upon restore" into sc-dev am: 408a73ea76
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15098572

Change-Id: I5bf17c3b4344b91fee64eab63bf013ea7ab94550
2021-06-25 16:30:53 +00:00
TreeHugger Robot 1491ec31c5 Merge "Update widget manipulation colors." into sc-dev 2021-06-25 15:18:45 +00:00
Alina Zaidi 0b320545f8 Compare maxSpanSize for WidgetsListContentEntries when updating visible
entries in widget picker.

This is so that widgets are rearranged according to maxSpanSize in
widget table

Bug: 191336852
Test: Manually rotated widget picker with one of the headers expanded
and checked that widgets in widget table adjust according to screen's
horizontal size.

Change-Id: I2406ca9eccd18f4bb32b396acaa188c37f0059ee
2021-06-25 13:46:03 +01:00
Steven Ng acd9d79932 Refine widgets removal logging
Test: N/A
Bug: 190565858
Change-Id: I7fb20eaf727db19787fa9b1fb36eeb5d1392e50c
2021-06-25 11:51:44 +01:00
Pinyao Ting bbb9a9c033 Extra logging related to widget removal upon restore
As observed in b/187799223, widgets are removed after restore. We cannot
identify the root cause from the bugreport. This CL includes more
logging in the hope of identifying the root cause.

Bug: 18779922
Bug: 190565858
Test: manual
Change-Id: Ibdc9876716028592d17beac4542e1d8c498f9e4c
(cherry picked from commit 655ac082c2)
2021-06-25 09:22:33 +00:00
Yogisha Dixit c0ac1dda74 Update widget manipulation colors.
Spec:
* Resize frame: https://docs.google.com/presentation/d/1UxdDh8EFhPbdRWRwzjbpgL-j02ew4Ew3eG3XBCeoYdo/edit#slide=id.OeO4S0j
* Drop target bar: https://docs.google.com/presentation/d/1UxdDh8EFhPbdRWRwzjbpgL-j02ew4Ew3eG3XBCeoYdo/edit#slide=id.vXfwHn8

Test: manual
Bug: 187910396
Change-Id: I6fd433796970c428841ee96e45ee4fca1ded3665
Merged-In: I6fd433796970c428841ee96e45ee4fca1ded3665
2021-06-25 08:43:29 +00:00
Hyunyoung Song 011f438c97 When KEYCODE_BACK is received, hide keyboard
Bug: 191845409
Bug: 190351740

Test: manual
Change-Id: I9e3a55f7eb81b2c2a668532ebb991cefbf248163
2021-06-25 01:28:27 -07:00
Hilary Huo b4538d1ef4 [settings-pixel-search] Flag guard slice logging.
Test: m
Bug: 191297465
Change-Id: I3f5f1ef5ad295e5d8ccedac00f290080653df5a3
2021-06-24 16:08:09 -07:00
Jonathan Miranda 7a273e2a8b resolve merge conflicts of a754e678a7 to sc-v2-dev
Move qsb according to spec.

Bug: 175329686
Test: visual test
      checked 5x5 and confirmed no visual change
      checked 4x5 and confirmed visual change
      - tested various display sizes to ensure no overlapping is caused


Change-Id: I5e00fcf57ffde597c6af08c6464ddfd7e8456bca
Merged-In: I95a80b484516f634fa13347534810c7a51cecc8d
2021-06-24 21:29:51 +00:00
Jonathan Miranda a754e678a7 Merge "Move qsb according to spec." into sc-dev 2021-06-24 21:14:11 +00:00
Steven Ng 3ff0ee1a95 Fix rounded corners for shortcut & generated preview shadow box
Test: Open the widgets picker and locate shortcuts. Rounded corners are
      rendered on the rectangular box of a shortcut
Fix: 191948061
Change-Id: I24e4dc4c4a9c9c7e875444db5294f6c33f50db85
2021-06-24 21:17:13 +01:00
Alina Zaidi e92c63f45b Remove scrim from navigation bar from full widget picker.
Bug: 191926325
Test: Manually tested
Change-Id: Idc5fded9e8227a6aa9cf58c9e2cce146dc52a2c6
2021-06-24 20:20:05 +01:00
TreeHugger Robot 55bdce183e Merge "Measure WidgetsBottomPicker again when the number of spans changes" into sc-dev am: 6604eb54bf
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15095550

Change-Id: I5b5bf85f123ecc1423b74f52a7b33328e1bb4e6e
2021-06-24 19:13:32 +00:00
Jon Miranda 8bdb222a18 Move qsb according to spec.
Bug: 175329686
Test: visual test
      checked 5x5 and confirmed no visual change
      checked 4x5 and confirmed visual change
      - tested various display sizes to ensure no overlapping is caused

Change-Id: I95a80b484516f634fa13347534810c7a51cecc8d
Merged-In: I95a80b484516f634fa13347534810c7a51cecc8d
2021-06-24 18:51:46 +00:00
TreeHugger Robot 6604eb54bf Merge "Measure WidgetsBottomPicker again when the number of spans changes" into sc-dev 2021-06-24 18:43:32 +00:00
Jon Miranda 6a936e3ec4 Update colors for non-v31 devices.
Also renamed to popup color to popup shade to better differentiate
between the primary/secondary/tertirary popup colors.

Bug: 191496301
Test: Removed v31 colors to verify the non-v31 colors, that the shades are as expected
      Tested on wallpapaper with light text, again with dark mode
      Tested on wallpaper with dark text, and then again with dark mode

Change-Id: I3ec9ee7f85696ee48224740a1ec7f4abe42348ee
2021-06-24 11:07:52 -07:00
Steven Ng 53e8b46f66 Measure WidgetsBottomPicker again when the number of spans changes
Bug: In onMeasure, we calculate the number of spans that can be fit
horizontally. If the number of spans has changed, we re-organize
widgets shown in the table. However, after that, we didn't measure
WidgetsBottomPicker and its children again. As a result, the newly
added widget previews' dimensions are never measured.

Test: Long press clock app and then click widgets. Rotates the screen
      and observe widgets correctly shown.
Fix: 191644950
Change-Id: Iae94fba5b137807483e061d785b18d59defb013e
2021-06-24 18:16:05 +01:00
Jonathan Miranda dc01385cc2 Merge "Update popup colors. Add local color extraction behind a flag." into sc-dev am: bd51e6e3f3
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15065087

Change-Id: I900c337c3fb3bd6296b95102ec55d4e6c7057e29
2021-06-23 23:10:11 +00:00
Jonathan Miranda bd51e6e3f3 Merge "Update popup colors. Add local color extraction behind a flag." into sc-dev 2021-06-23 22:51:20 +00:00
Hilary Huo cb4475f7d8 Merge "[settings-pixel-search] Add ww logging to track slice fetching timeout" into sc-dev am: 08843d8e37
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15068624

Change-Id: I58da46b9fc9fd83205c352996c78453885666397
2021-06-23 22:29:13 +00:00
Steven Ng be2dc65f08 Refine all apps tabs alignment & remove ripple effect from tabs
Test: Open all apps and observe the position of tabs alignment.
       Click a tab and observe the fade in color effect.
Fix: 191387242
Change-Id: Ie23a092268ce62eba29059eb5bd266a46ca652a5
2021-06-23 23:25:13 +01:00
Hilary Huo 08843d8e37 Merge "[settings-pixel-search] Add ww logging to track slice fetching timeout" into sc-dev 2021-06-23 22:18:00 +00:00
Jon Miranda 27de7d2643 Update popup colors. Add local color extraction behind a flag.
- Also updating folder backgrounds, lStar only works in ColorStateList.

Bug: 191496301
Test: test wallpaper with light text, in light mode
      test again in dark mode
      test wallpaper with dark text, in light mode
      test again in dark mode

Change-Id: I2d43d874e7e2fad6a9a0e039058beb58b204fa96
2021-06-23 14:18:25 -07:00
Steven Ng 1579854153 Merge "Use default spans as min spans if the min spans > default spans" into sc-dev am: fa9f70be03
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15081332

Change-Id: I64311aa17528c8c968a8cd2f032992c6e00225d7
2021-06-23 21:17:55 +00:00
Steven Ng f5555fcb8e Merge "Add null check before detach content view from dragView at onDropComplete" into sc-dev am: 5b786ca88d
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15042822

Change-Id: Idc12dd2613200ce6e9901856b14c4ce0c5946fb6
2021-06-23 21:17:48 +00:00
Steven Ng fa9f70be03 Merge "Use default spans as min spans if the min spans > default spans" into sc-dev 2021-06-23 21:05:43 +00:00
Steven Ng 5b786ca88d Merge "Add null check before detach content view from dragView at onDropComplete" into sc-dev 2021-06-23 21:01:57 +00:00
Samuel Fufa 6c2c69cd97 Merge "Polish work for work profile" into sc-dev am: 1e70c235cf
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15031833

Change-Id: Ie9cf60cd89c805c7341e2725259152215edea889
2021-06-23 19:00:41 +00:00