Commit Graph

16456 Commits

Author SHA1 Message Date
Sebastián Franco 73049b14b9 Merge "Prevent double touch inputs in the BaseDragLayer" into tm-qpr-dev 2022-10-11 20:22:45 +00:00
Alex Chau 517131ae1c Enable taskbar in overview by default
- Also changed expectation in test that taskbar is visible in overview

Fix: 245320601
Test: presubmit
Change-Id: If1ed44f542e5907860f7ab8182e4b45172346f3f
2022-10-11 18:48:45 +01:00
Alex Chau de1d8456d3 Merge "Fix positioning of split instruction and share targets with taskbar in overview" into tm-qpr-dev am: e2791f0cf6 am: 94183eeaf9
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20132885

Change-Id: I67023a798eeba419834cdc91a89b3dc2e3b9aee1
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-11 15:05:01 +00:00
Sebastian Franco 68fc44ffad Prevent double touch inputs in the BaseDragLayer
If you hold a long press and while pressing you start another
long press again with another finger, then a new onLongPress event
will trigger and in some cases we are not processing that case.

By ignoring the evetns with the flag ACTION_OUTSIDE we can prevent
such cases.

Fix: 247477725
Test: ReorderWidgets
Change-Id: I31833bc54db2771809562bd1f92c8523eb2f05ab
2022-10-11 09:54:46 -05:00
Alex Chau e2791f0cf6 Merge "Fix positioning of split instruction and share targets with taskbar in overview" into tm-qpr-dev 2022-10-11 14:04:57 +00:00
Alex Chau 0733ebd3c1 Run setCurrentPage in applyLoadPlan after scroll initialized
- Also combined the 2 setCurrentPage call in applyLoadPlan into 1
- Otherwise setCurrentTask may set to page 1 unexpectedly due to page 0's scroll being invalid and out of range

Bug: 246283207
Bug: 238461210
Test: Split screen with 2 apps, click back, go to overview again, should snap to focsued task
Change-Id: I3b57655c810668fe244659437fbd4a745ca02d21
2022-10-11 12:36:35 +01:00
Jon Miranda 23252222e7 Add ENABLE_TRANSIENT_TASKBAR feature flag. am: efd41a717e am: 0a69f652ff
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20159824

Change-Id: I547e3fd9770bf965cdadeb69c8decffdd81bbe61
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-11 06:00:03 +00:00
Jon Miranda efd41a717e Add ENABLE_TRANSIENT_TASKBAR feature flag.
Bug: 252905206
Test: N/A
Change-Id: I7995e4fc0a181aee6932e0bee041b74a4241053e
2022-10-10 18:46:19 -07:00
Ats Jenk 3c59d9b345 Desktop tile that is a snapshot of desktop
Create a desktop recents tile that shows a snapshot of the freeform
tasks running on desktop.
Scales them down and positions them in the same location as they would
be on the desktop.

Bug: 244348395
Test: manual
Change-Id: Ieb5830a331691844769003189f557c4b7e4cd35c
2022-10-10 15:50:31 -07:00
Federico Baron 55dfd41b6d Merge "Add flags for new home gardening mode" into tm-qpr-dev am: 3c8ae3efff am: 71f32b4f20
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20123118

Change-Id: I483a2742d4d5efe1b33dd6fcf62eb0437de01ac4
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-10 21:35:19 +00:00
TreeHugger Robot d2ee73ff28 Merge "Round split layout values instead of using int cast" into tm-qpr-dev am: 803f88b89e am: b3d89f0fbe
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20142330

Change-Id: I91f232509bdfe56a3c848edb9fcb836b3fbd448e
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-10 21:35:09 +00:00
Vinit Nayak 2d0d43ceb7 Merge "Improve splitscreen recents animation in seascape" into tm-qpr-dev am: 8addaad158 am: 9388213c9d
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20105878

Change-Id: I3fde4dfb5611f854d7a52e7f793295379575c879
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-10 21:34:40 +00:00
TreeHugger Robot 461d85dcfa Merge "Fix repeated empty workspaces after changing the grid size." into tm-qpr-dev am: 1f7b2f9a7a am: ec7229e94b
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18470799

Change-Id: If60cb3b2c0de474134356dc768c8e65d2c250735
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-10 21:32:49 +00:00
Luca Zuccarini 7a321c4df5 Merge "[Toast] Switch to using device config to control keyboard sync." into tm-qpr-dev am: 82469ea23b am: bf7afbcfc8
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20085413

Change-Id: I9159a788f74f6b108d90f3814645453bd956b097
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-10 21:30:39 +00:00
Federico Baron 3c8ae3efff Merge "Add flags for new home gardening mode" into tm-qpr-dev 2022-10-10 19:59:14 +00:00
TreeHugger Robot 803f88b89e Merge "Round split layout values instead of using int cast" into tm-qpr-dev 2022-10-10 17:51:52 +00:00
Vinit Nayak 8addaad158 Merge "Improve splitscreen recents animation in seascape" into tm-qpr-dev 2022-10-10 17:49:54 +00:00
TreeHugger Robot 1f7b2f9a7a Merge "Fix repeated empty workspaces after changing the grid size." into tm-qpr-dev 2022-10-10 16:57:59 +00:00
Alex Chau 21064ef82a Merge "Fix flaky/failing two panel TAPL tests" into tm-qpr-dev 2022-10-10 15:59:37 +00:00
Andras Kloczl 0e4f04d85f Fix flaky/failing two panel TAPL tests
Since Cuttlefish emulators are quite slow, some
of the two panel related TAPL tests were failing
due to multiple page changes instead of single ones.

Test: atest -c NexusLauncherTests:com.android.launcher3.ui.workspace.TwoPanelWorkspaceTest
Bug: 236136463
Fix: 252747355
Change-Id: Ib154cf97040fcea3b4d2d7082352c06de74f8c2a
(cherry picked from commit 486f7c8766)
Merged-In: Ib154cf97040fcea3b4d2d7082352c06de74f8c2a
2022-10-10 10:52:16 +00:00
Luca Zuccarini 82469ea23b Merge "[Toast] Switch to using device config to control keyboard sync." into tm-qpr-dev 2022-10-10 10:22:27 +00:00
Brandon Dayauon f18f58c438 Merge "Add variable to check if button should apply keyboard insets" into tm-qpr-dev am: 926d04ec14 am: b38f5045ee
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20129357

Change-Id: I3a04e0e5930e10280345d7d0a28dac47e2f9e2c2
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-08 13:23:14 +00:00
Brandon Dayauon 926d04ec14 Merge "Add variable to check if button should apply keyboard insets" into tm-qpr-dev 2022-10-08 12:15:26 +00:00
Alex Chau 8949c583ee Fix positioning of split instruction and share targets with taskbar in overview
- When taskbar is in overview, overview actions has dedicated space and no need to align to nav buttons
- Add a bottom margin to split instruction and share targetse that is equal to the space below overview actions

Bug: 245320601
Test: Test split select and share target with different screen sizes
Change-Id: I6aec325da9cc4c43c84ba8bed5f0e087c57d6925
2022-10-08 10:15:58 +01:00
Holly Sun 9b024eb01f [QL-v2] Use subtitle as hint if title doesn't apply.
Test: manual
Change-Id: Ib5ace9acda9618de905a85854d92e6f865f5fad0
2022-10-07 16:40:38 -07:00
Brandon Dayauon b1840e3f36 Add variable to check if button should apply keyboard insets
bug: 251460671
test: manual
Change-Id: I90045c96c0fbf385ad8dd5978089491f3f106dd8
2022-10-07 15:32:23 -07:00
Vinit Nayak 8f54d597bf Round split layout values instead of using int cast
* Silly us, we forgot that int casting always floors.
Math.round() does a mathematical round.

Fixes: 248575056
Test: Wallpaper no longer bleeds through on split
animation.

Change-Id: I068c030ce6b86fc12faee7778c0d87a0d5aea487
2022-10-07 14:46:25 -07:00
Andy Wickham 09e4c86b4c Merge "Differentiate between app row and shortcut icons." into tm-qpr-dev am: 1874371aab am: 299b025b9f
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20119299

Change-Id: Ic4188160e10e6c394be66a31ece6162d881a6351
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-07 21:38:56 +00:00
Andy Wickham 1874371aab Merge "Differentiate between app row and shortcut icons." into tm-qpr-dev 2022-10-07 20:42:51 +00:00
Andy Wickham 22a2af82be Merge "Hide FloatingHeaderView while in Search state." into tm-qpr-dev am: 2c5f545d0b am: b089ed4d94
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20104878

Change-Id: Ia0517f6eea842155ac62a5de95929d1fd7d2cacd
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-07 18:38:59 +00:00
Holly Jiuyu Sun 6705c89207 Merge "Quick launch v2." into tm-qpr-dev am: 6fa0562aee am: 3760ce9774
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20075881

Change-Id: Id851534638fe499513e1ce0e47d17a4186c21d8e
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-07 17:25:32 +00:00
Andy Wickham 2c5f545d0b Merge "Hide FloatingHeaderView while in Search state." into tm-qpr-dev 2022-10-07 17:20:12 +00:00
Holly Jiuyu Sun 6fa0562aee Merge "Quick launch v2." into tm-qpr-dev 2022-10-07 16:38:14 +00:00
Alex Chau b7b88b66bb Merge "Add logging to help debug flake when swiping home to overview." into tm-qpr-dev 2022-10-07 11:24:43 +00:00
Vinit Nayak c7d676ce15 Improve splitscreen recents animation in seascape
* We need to swap the primary and secondary thumbnail
positions in fake seascape since the primary is the
visually left app (which is the bottom in portrait)

Bug: 249693334
Change-Id: I325133ab86e4fcd26c6162a3de007d68e9ba6bf1
2022-10-06 21:32:20 -07:00
TreeHugger Robot 8527e5c623 Merge "Include additional error log around widget removal" into tm-qpr-dev am: 78ec4e0890 am: b415cd1e24
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20105908

Change-Id: Ibfa9e8a2e7466d379cb240d2ed779e77715c11a4
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-06 22:19:45 +00:00
TreeHugger Robot 78ec4e0890 Merge "Include additional error log around widget removal" into tm-qpr-dev 2022-10-06 21:31:10 +00:00
Holly Sun 2b17c4b9d0 Quick launch v2.
Set auto-append text in selected text mode. Clicking enter key launches the app. Delete the selected text to remove auto-append text and highlight. Clicking enter key sends raw query to search.

Test: manual
Bug: 210661150
Change-Id: Iee8e716b81a2dde64e60462fd33d4a6eb4abcf01
2022-10-06 10:38:26 -07:00
Pat Manning 24b9554086 Add logging to help debug flake when swiping home to overview.
Bug: 238461210
Bug: 246283207
Test: TaplTestsQuickstep#testSwitchToOverview
Change-Id: I8ee9af4f4a331c43761ba3738e12acb376ababc2
(cherry picked from commit 1edba8b0a6)
Merged-In: I8ee9af4f4a331c43761ba3738e12acb376ababc2
2022-10-06 15:37:47 +00:00
Luca Zuccarini bda972b2c9 [Toast] Switch to using device config to control keyboard sync.
Bug: 234812580
Test: followed the existing pattern and tested by manually setting and
unsetting the flag through command line - `adb shell device_config put
launcher enable_web_suggest_on_default_browser <true|false>`

Change-Id: Idd479e93b628b78fdf55d826c56f69c5cfdaf46e
2022-10-06 10:26:42 +00:00
Federico Baron dafd14d9dc Add flags for new home gardening mode
We're going to follow this new design for the home screen edit mode (home gardening): https://docs.google.com/presentation/d/1FOmmCdmGmSMR77_901IOMbvbPVxPmjaAdxZjy-D9tw0/edit#slide=id.g11f697f283a_0_0. This new design will be guarded by this flag.

Bug: 251259222
Test: manual
Change-Id: I36d0d1dddb463154140802b945dd092b072d6eaf
2022-10-05 14:51:37 -07:00
Nick Chameyev 09241680a7 Merge "Extract PreviewPositionHelper to shared library" into tm-qpr-dev am: 3e7c611358 am: 40497595fe
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20034765

Change-Id: Iae3e4e2373ef9918f541bfade1654808fa2a1864
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-05 17:21:11 +00:00
Federico Baron 471e2178f8 Fix page indicator dots height in workspace
In workspace, the page indicator dots end up in the bottom because we were missing a setInsets method (WorkspacePageInidcator.java uses this method to set the page indicator to the right height).

Bug: 249773534
Test: manual
Change-Id: I03636e28244f329b249453a6d22eb0ec7d85c45f
2022-10-05 09:31:55 -07:00
Federico Baron 7539d7649c Change delightful pagination flag and use it for workspace
Before the flag name would only fit 'delightful pagination' for folders, but now we're adding that feature to workspace also, hence the flag rename.
The flag is now also used in launcher to show the new XML file that uses PageIndicatorDots rather than WorkspacePageIndicator

Bug: 249773534
Test: manual
Change-Id: I6cf6d52e76ad1ec60ecb54c5cca204e9ac35cc39
2022-10-05 09:31:43 -07:00
Alex Chau 8a1237bf0d Merge "Taskbar in overview" into tm-qpr-dev am: 5e47e78a17 am: 6db97df61b
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19866366

Change-Id: I1ef4ad30d59bf9422eead0bbc768bf9727a1d667
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-05 10:13:28 +00:00
Nick Chameyev cbfb35edc7 Extract PreviewPositionHelper to shared library
Moves Launcher's PreviewPositionHelper to shared
library between SystemUI and Launcher to reuse
it in the future in the partial screensharing
recents selector.

There should be no functional changes in the
code itself.

Bug: 240924926
Test: presubmit
Change-Id: Ib38b6f9db91e63a2598bf81229e3cd3e1a49ca60
2022-10-05 10:23:54 +01:00
Alex Chau 5e47e78a17 Merge "Taskbar in overview" into tm-qpr-dev 2022-10-05 08:58:31 +00:00
Andy Wickham 0d3c3d8fc5 Differentiate between app row and shortcut icons.
This is a simplified version of ag/20118087. It fixes the bug
with rows of shortcuts being in the search results (e.g. Gmail
and WhatsApp conversations), but it will not handle cases where
there are multiple rows of app icons. Currently I do not know of
any cases where that would happen.

Test: Manual with and without inject_web_top (which moves app row)
for WhatsApp and Gmail with AiAi fishfood.
Bug: 239927522

Change-Id: Ie9c62c0ee81086801942328c8770f37d5bf622c3
2022-10-05 00:57:09 -07:00
Tracy Zhou b2d7f05bad Merge "Remove ENABLE_QUICKSTEP_LIVE_TILE flag" into tm-qpr-dev am: d7a7bfc304 am: b2cd75e5df
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20079254

Change-Id: Id23f4091da4d7216de27615c7e97f7139a37d392
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-04 21:07:54 +00:00
Tracy Zhou d7a7bfc304 Merge "Remove ENABLE_QUICKSTEP_LIVE_TILE flag" into tm-qpr-dev 2022-10-04 20:02:30 +00:00