Commit Graph

16456 Commits

Author SHA1 Message Date
Federico Baron a3e6ee5f88 Merge "Set smartspace to 30% visibility on workspace edit for home gardening" into tm-qpr-dev am: 2c97e58933
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20193069

Change-Id: I9043741edf0af77bea640767ca95f8dc46a14f73
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-24 20:14:21 +00:00
Federico Baron 2c97e58933 Merge "Set smartspace to 30% visibility on workspace edit for home gardening" into tm-qpr-dev 2022-10-24 19:17:29 +00:00
Sunny Goyal 1baaac662b Merge "Revert "Revert "Updating the scroll calculation from recyclerView to avoid view inflation""" into tm-qpr-dev am: 0cf401d0eb
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20260484

Change-Id: Id4c1db6904257ca67756dde0ea198c907f0d0e79
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-24 18:11:33 +00:00
Mady Mellor 344a5974cd Merge "Hide launcher when freeform tasks are visible" into tm-qpr-dev am: b5c2565447 am: f602559b25
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20017950

Change-Id: Ie285233ddb6e8bf53c1482c7385a04b9629519b3
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-24 18:04:24 +00:00
Sunny Goyal 0cf401d0eb Merge "Revert "Revert "Updating the scroll calculation from recyclerView to avoid view inflation""" into tm-qpr-dev 2022-10-24 17:38:42 +00:00
Mady Mellor f602559b25 Merge "Hide launcher when freeform tasks are visible" into tm-qpr-dev am: b5c2565447
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20017950

Change-Id: I1605450eac52bed58566c55259246009c59b27b5
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-24 17:21:45 +00:00
Mady Mellor b5c2565447 Merge "Hide launcher when freeform tasks are visible" into tm-qpr-dev 2022-10-24 16:04:59 +00:00
Sunny Goyal f34811d3a3 Revert "Revert "Updating the scroll calculation from recyclerView to avoid view inflation""
Test: ABTD
https://android-build.googleplex.com/builds/abtd/run/L52600000956969786

This reverts commit cee6ddf3de.

Reason for revert: Fixed in ag/20239136

Change-Id: I0e8446e66d9a86a94b40fcbd6de14da07abe8e5c
2022-10-22 15:37:47 +00:00
Tracy Zhou daad3fefea Support swipe gesture on trackpad to swipe up from app
Bug: 254783214
Test: https://recall.googleplex.com/projects/3388b17c-d22f-46f8-b140-a102690377b4/sessions/92d385dd-bad5-49ea-a0b4-b4bf4010aabb
Change-Id: I74ba4a9e5c5096aaf6475f9cb8f1dc30de48024d
2022-10-22 07:18:16 +00:00
Becky Qiu 4ed3dfc28a [Toast] Use a BaseSearchConfig for launcher3 to read allapps device config.
Bug: 251387263
Test: local
Change-Id: I92c52caff377e627305bc7999ae0205fe6269968
2022-10-21 17:11:38 -07:00
Ling Wo 7c35298a40 Merge "Add enable-suggestion option via TestProcotol so that test can opt-in to show live suggestion" into tm-qpr-dev am: ac29981a42 am: 12949e8abb
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20158848

Change-Id: I3f79292d7c813808a61ca82ea31121daa5ee3eba
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-21 22:44:45 +00:00
Ling Wo 12949e8abb Merge "Add enable-suggestion option via TestProcotol so that test can opt-in to show live suggestion" into tm-qpr-dev am: ac29981a42
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20158848

Change-Id: I6cf20bc024261f138bc845e17a40d330f6ecb524
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-21 21:58:07 +00:00
Ling Wo ac29981a42 Merge "Add enable-suggestion option via TestProcotol so that test can opt-in to show live suggestion" into tm-qpr-dev 2022-10-21 21:44:35 +00:00
Sunny Goyal 64453ae482 Introducing feature flag for optimizing overlay service connection
Bug: 254903450
Test: n/a
Change-Id: I2286be8583cc6dc46921b9ba8ef5505e5b8f0bf8
2022-10-21 14:07:16 -07:00
Sunny Goyal 2e0bdd4f49 Merge "Optimizing some icon generation code:" into tm-qpr-dev am: 415fe0c183 am: ef188e8c23
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20040405

Change-Id: Ia9595c728b3ab46b8530a689598bb6cc7c433477
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-21 20:04:34 +00:00
Federico Baron 0abfda8f2f Rename first page pinned widget to mFirstPagePinnedWidget
mQsb is the name used for the first page pinned widget. This variable name is bad since in some launchers the first page pinned widget is a qsb but sometimes it is a smartspace. Renaming the variable to mFirstPagePinnedWidget is a more accurate name for this variable.

Bug: 251259222
Test: N/A
Change-Id: I6d3c74163995d2267510ee546924917062c4955c
2022-10-21 13:01:24 -07:00
Federico Baron a56f08e677 Set smartspace to 30% visibility on workspace edit for home gardening
Here we set the smartspace to have 30% visibility to follow the guidelines set by https://docs.google.com/presentation/d/1FOmmCdmGmSMR77_901IOMbvbPVxPmjaAdxZjy-D9tw0/edit#slide=id.g159289e55db_0_229

Bug: 251259222
Test: Enter drag mode in workspace with SHOW_HOME_GARDENING flag on to see the changes
Change-Id: Ia2ef4f1a49549fef9f8fbea7c007db8b81972f71
2022-10-21 13:00:58 -07:00
Sunny Goyal ef188e8c23 Merge "Optimizing some icon generation code:" into tm-qpr-dev am: 415fe0c183
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20040405

Change-Id: Id325662e61d5cdcc625923536a8458eb44fdd9b9
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-21 19:17:35 +00:00
Schneider Victor-tulias ee0bc03d58 Decrease TAPL All Apps scrolling flakiness
scrolling in all apps did not factor in additional top padding in the all apps list recycler. This made it so that apps could occasionally scroll and be obcured by that top padding, making them un-tappable. Added this padding to the scrolling logic to make scrolling less flaky.

Test: TaplTestsTaskbar, TaplTestsLauncher3 and presubmit
Fixes: 248064856
Change-Id: Id76b92b4bc354917f3688ac53673d0ed7a905f02
2022-10-21 12:12:38 -07:00
Sunny Goyal 415fe0c183 Merge "Optimizing some icon generation code:" into tm-qpr-dev 2022-10-21 18:27:54 +00:00
Federico Baron 79cc65d133 Autohide and autoshow pagination in workspace
Added code similar to WorkspacePageIndicator.java in order to autoshow and autohide the pagination in Workspace using PageIndicatorDots.java

Bug: 249773534
Test: Manual
Change-Id: I3b26d929d71510cf2f9d5342ee4c59007b8429cd
2022-10-21 10:55:26 -07:00
Mady Mellor 9a90c2d521 Hide launcher when freeform tasks are visible
This CL introduces a new controller to manage the visibility of the
launcher workspace when desktop mode is active and freeform tasks
are visible.

This controller will be notified when the sysui state flag related
to freeform task visibility is changed.

The controller will modify the workspace visibility as well as
the flags on the activity indicating if it's been paused / resumed
based on freeform tasks being visible or not.

Bug: 245569277
Test: manual -  enable desktop mode and open some freeform tasks
             => observe that the contents of launcher is hidden and
                taskbar shows
             -  remove all of the freeform tasks
             => observe that the contents of launcher reappears along
                with the hotseat.
Change-Id: I378ab97b40cbb954a06f4e2426b195efddad905c
2022-10-21 10:06:54 -07:00
Vinit Nayak 61d94834f7 Merge "Improve TaskMenuView layouts for split pairs" into tm-qpr-dev am: b9b7c38d55 am: 05e238ff32
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20169868

Change-Id: I5c1a164b627794f1f25007ce467bd33bcc26c84f
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-21 01:16:27 +00:00
Vinit Nayak 05e238ff32 Merge "Improve TaskMenuView layouts for split pairs" into tm-qpr-dev am: b9b7c38d55
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20169868

Change-Id: I2d4308adb3a6396732b663a2f05e9af115318261
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-21 00:43:22 +00:00
Vinit Nayak b9b7c38d55 Merge "Improve TaskMenuView layouts for split pairs" into tm-qpr-dev 2022-10-21 00:07:53 +00:00
Treehugger Robot 5f65096bfe Merge "Fix errorprone warnings that should be errors" am: 35157974d4 am: 533b937fd3 am: 14946c1fa3
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/2254242

Change-Id: Id765742b2e4767888137a01116f2bad1bba859a3
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-20 23:32:40 +00:00
Brian Isganitis 7ed3c82636 Merge "Fix crash on long press of prediction row icons" into tm-qpr-dev am: 2bcc3f8599
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19930974

Change-Id: Id1010f7f19454d51b19a11b1d5ed72fe39632332
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-20 23:31:44 +00:00
Vinit Nayak eba71a1c8f Merge "Scale screenWidth for split proportionally for thumbnail matrix" into tm-qpr-dev am: e690ef7f80 am: c136a1f837
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20232996

Change-Id: If5447ddb1e7b0c8f2bad456c82a6993e56f97a7d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-20 23:18:29 +00:00
Treehugger Robot 14946c1fa3 Merge "Fix errorprone warnings that should be errors" am: 35157974d4 am: 533b937fd3
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/2254242

Change-Id: I748f2372116aa8bba282a0f1925e3968a9fed0ad
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-20 23:16:08 +00:00
Sukesh Ram c6d4df87f0 Added Tests for Secondary Display Launcher
These UIAutomator tests for secondary display launcher cover app drawer, drag-n-drop functionality, app predictions, pin/unpinning icons, and correct back press behavior.

We are deviating from  go/modify-tapl due to the time constraints of this project as outlined here (https://docs.google.com/document/d/1wLb2h8qCPGur-VsufCH4mLnnuLDLcmMq0FrCo7ichu8/edit#heading=h.brf6af3bno4g).

A preliminary design document has also been created to reference for future TAPL integration (https://docs.google.com/document/d/1H642SSu5DCM_zSXTsvTWumgm3OHIxsKEXvTlTeC4y54/edit?resourcekey=0-M9sTxdyQBi8bUy5cpjmJNA#heading=h.90f2s4sc5ic9).

Before TAPL integration, we need to follow up on test rewrite to eliminate antipatterns in the following bug: b/242776943.

Bug: 241166788
Test: Run Locally, on presubmit, and on a test on a cuttlefish emulator
Change-Id: I556a47b93a7ea3b2583dbc1efd2de7623d820e2a
Merged-In: I556a47b93a7ea3b2583dbc1efd2de7623d820e2a
2022-10-20 22:58:46 +00:00
Brian Isganitis 2bcc3f8599 Merge "Fix crash on long press of prediction row icons" into tm-qpr-dev 2022-10-20 22:54:06 +00:00
Vinit Nayak e690ef7f80 Merge "Scale screenWidth for split proportionally for thumbnail matrix" into tm-qpr-dev 2022-10-20 22:49:57 +00:00
Treehugger Robot 533b937fd3 Merge "Fix errorprone warnings that should be errors" am: 35157974d4
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/2254242

Change-Id: I6b47e8706afe05f5fdac403e79c87a533fbcc2c8
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-20 22:45:27 +00:00
Jeremy Sim 9c6a7abf9c Merge "Prevent doubling up on split placeholder insets" into tm-qpr-dev am: 8edca84cd5 am: 0c1d05a636
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20155090

Change-Id: I849721e96b7ba080b2367d1dddfd057878108776
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-20 22:02:28 +00:00
Jeremy Sim 8edca84cd5 Merge "Prevent doubling up on split placeholder insets" into tm-qpr-dev 2022-10-20 20:59:49 +00:00
Sukesh Ram aee55077cc Fix crash on long press of prediction row icons
Changed icon long click listener to use secondary display's long
click listener instead of launcher's.

Bug: 239616635
Test: Manual
Change-Id: I9a4679ba82cacb5e2648481274876dbfc95d80ce
Merged-In: I9a4679ba82cacb5e2648481274876dbfc95d80ce
2022-10-20 18:11:15 +00:00
Brian Isganitis ddbe35cc87 Merge "Drag from appDrawer & pin onto secondary display homescreen" into tm-qpr-dev 2022-10-20 18:08:07 +00:00
Sunny Goyal fc1928e324 Optimizing some icon generation code:
1) Fixing missing shadow from shortcut icons
2) Chaning all-apps icon rendering to draw background/foreground separately
   This allows us to reuse the bitmap generated for themed icons, instead of
   creating a new everytime

Bug: 248308987
Test: Verified on device
Change-Id: Ia3cbefb21a2ce676d6bb2df3d9375d61b5bed61b
2022-10-20 10:40:54 -07:00
Thales Lima ed8c69baca Make all handheld grids scalable
Also increase the icon size in the XML until the icon is sized correctly.

Fix: 239419094
Bug: 235886078
Test: manual
Change-Id: I0c7d75181a61177cc5993ba7002c3ccc8fd60fbf
2022-10-20 11:51:59 +01:00
Vinit Nayak 981034687a Scale screenWidth for split proportionally for thumbnail matrix
* Instead of passing in screenWidth to be that
of entire screen when using split, scale screenWidth
to that of only the amount that the given split app
is taking.
* Created TODO(b/254378592) to consolidate different
SplitBounds classes

Fixes: 250817893
Test: Checked phone/tablet swiping quickswitching
portrait and landscape

Change-Id: I5c3b2076110e358366284b2c794fd8df8a79f034
2022-10-19 21:39:50 -07:00
TreeHugger Robot 771c658e94 Merge "Add scroll up and scroll down logging." into tm-qpr-dev am: 821ef94974 am: 0967d53cf5
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20181861

Change-Id: I476bfd2bf672e4c840e87e1a29aee14bcbdd827c
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-19 21:47:35 +00:00
Federico Baron 50b9039137 Merge changes I03636e28,I6cf6d52e into tm-qpr-dev am: 41235d529b am: 5ff03db6a6
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20095896

Change-Id: Ia3bc6db3d148ca74ff863b43fcec8aac0cb5cd57
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-19 20:33:40 +00:00
TreeHugger Robot 821ef94974 Merge "Add scroll up and scroll down logging." into tm-qpr-dev 2022-10-19 20:31:54 +00:00
Federico Baron 41235d529b Merge changes I03636e28,I6cf6d52e into tm-qpr-dev
* changes:
  Fix page indicator dots height in workspace
  Change delightful pagination flag and use it for workspace
2022-10-19 19:33:18 +00:00
Andy Wickham 88b795e54c Merge "More robust fix to BubbleTextViews appearing on multiple rows." into tm-qpr-dev am: a57bff8473 am: f4abbadb21
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20105877

Change-Id: Iae7177d1cb278930881e56c4a087aa7e7e11cc1a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-19 18:34:20 +00:00
Sukesh Ram b066f41fa3 Drag from appDrawer & pin onto secondary display homescreen
Bug: 239246505
Test: Manual
Change-Id: I817d8ef700f2d7caec6fa63123935502f17f2d2f
Merged-In: I817d8ef700f2d7caec6fa63123935502f17f2d2f
2022-10-19 18:22:01 +00:00
Anushree Ganjam 0de35265c1 Add scroll up and scroll down logging.
Bug: 247601175
Test: Manual. https://paste.googleplex.com/5757099224072192

Change-Id: Iec1697e1580c75572c9e77ec349942301ee87694
2022-10-19 18:00:45 +00:00
Andy Wickham a57bff8473 Merge "More robust fix to BubbleTextViews appearing on multiple rows." into tm-qpr-dev 2022-10-19 17:40:52 +00:00
TreeHugger Robot 1aaca4097e Merge "Implement overlay window for Taskbar EDU and All Apps." into tm-qpr-dev am: c9928a1ddf am: 08092b2cfb
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20154536

Change-Id: Ifad418ad73a6bf4a98d6bdfce80d0cbbdfb90790
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-19 15:00:57 +00:00
Pat Manning 4b1961c76e Merge "Add launcher metrics for tracking kids nav mode change events." into tm-qpr-dev am: ded9a7485e am: 986e5dde13
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19697622

Change-Id: I388e72836de3213a06e638f8c329836c79fc3296
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-19 15:00:08 +00:00