Commit Graph

16456 Commits

Author SHA1 Message Date
Andy Wickham e5a49f4b48 Hide FloatingHeaderView while in Search state.
This prevents touches on the profile buttons (which were already
hidden due to the header view having alpha 0, but touches were
still registered).

Fix: 248338523
Test: Manually tap where the work profile button is before and
after this change. Before: switches to work profile. Afer: does
nothing in 0 state; otherwise launches item at that position.

Change-Id: Ie30661146d25740000d7a9cbe79234ac15347253
2022-10-03 23:38:49 -07:00
Pinyao Ting 7fd7e51fa2 Include additional error log around widget removal
As observed in b/248291728, widgets are disappeared after OTA update,
this CL includes additional logging to reveal more information.

Bug: 248291728
Test: manual
Change-Id: I5cf968efc358c3315e5e6ecc4861d5bc888569f1
2022-10-03 17:46:03 -07:00
Alex Chau d67ddc4920 Taskbar in overview
- Behind ENABLE_TASKBAR_IN_OVERVIEW which is disabled by defualt
- Make taskbar unstashed in overview with background visible
- Ensure taskbar is touchable in overview

Bug: 245320601
Test: Home<->Overview, Home<->App, App<->Overview, Home->Overview->App->Home, Home->App->Overview->Home, Overview->Home->App->Overview, Overview->App->Home->Overview, App->Overview->Home->App, App->Home->Overview->App
Test: Go to AllApps, call KEYCODE_HOME, go to app and taskbar should be there
Test: App->Overview->Select->Home->App
Test: QuickSwitch -> App
Test: Repeat above with ENABLE_TASKBAR_IN_OVERVIEW x taskbarStashed on/off
Test: Repeat above with gesture and 3-button
Change-Id: Ib25d68f68e89564851b226536e456d0b2f6306f8
2022-10-03 20:15:12 +01:00
Federico Baron 226ad3d58c Merge "Fix the entry animation for delightful pagination in folders" into tm-qpr-dev am: 1aa91f0f7a am: bb74f1fce7
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20059409

Change-Id: I834ca656ffdbfa108f96e86fc841e3c247d3dab9
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-01 08:13:02 +00:00
Federico Baron 1aa91f0f7a Merge "Fix the entry animation for delightful pagination in folders" into tm-qpr-dev 2022-10-01 07:21:53 +00:00
Andy Wickham 2091a2e0a0 Merge "Fix layout for multi-element rows (e.g. Screenshots)." into tm-qpr-dev am: 7f31d4c0ec am: d74a679987
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20040589

Change-Id: I6786cbcc32af51cffb2a4882b904b54b0b62d2bc
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-29 22:12:43 +00:00
Andy Wickham 7f31d4c0ec Merge "Fix layout for multi-element rows (e.g. Screenshots)." into tm-qpr-dev 2022-09-29 21:08:20 +00:00
Andy Wickham 4c96814b1c Fix layout for multi-element rows (e.g. Screenshots).
Demo with standard 3 element row and overflowing 2 element row:
https://drive.google.com/drive/folders/1o1gvD3mOxFmVW2vqjn3D1Gukz-ie_kmW?resourcekey=0-bHRsdqpUWITEUo39tAMJDg&usp=sharing

Test: Manually with 1, 2, 3, and 4 length rows of 3 screenshots
and putting web suggestions into 2 columns.
Fix: 247837336
Bug: 239927522

Change-Id: I391beb7a24f189b5e55cb7b65c5ffc8349c83cfc
2022-09-29 10:38:20 -07:00
Tracy Zhou c0095e81ae Remove ENABLE_QUICKSTEP_LIVE_TILE flag
Fixes: 249627137
Test: manual - (1) swipe up from app (2) swipe home (3) quick switch (4) split in overview
Change-Id: Ibe56ba3824b379b20fb3f0aa09be4d6bdb5abaa1
2022-09-29 04:58:52 +00:00
Federico Baron 0602e93426 Fix the entry animation for delightful pagination in folders
Here we fix the animation that was broken in earlier CL's for delightful pagination, now the page indicator has the same smooth entry animation as the dots

Bug: 247561880
Test: manual
Change-Id: I3e2099ba4f5ccfdbc9b4dfe5b48a1c44dbdeda1e
2022-09-28 16:17:51 -07:00
Holly Jiuyu Sun a81200b8ee Merge "Add flag to control show/hide keyboard suggestion strip." into tm-qpr-dev am: 0c7d83bb14 am: 770e65305f
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20029264

Change-Id: Id17b7fdb1c66e8b317df1c77e0c49da3a1197aab
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-28 01:21:57 +00:00
Holly Jiuyu Sun 0c7d83bb14 Merge "Add flag to control show/hide keyboard suggestion strip." into tm-qpr-dev 2022-09-27 23:49:53 +00:00
Sebastian Franco fa37a0ad9b Fix repeated empty workspaces after changing the grid size.
There are specific scenarios when you can force an extra empty
workspace after changing the grid, fortunately there is a
function that removes empty workspaces.

Fix:229349287
Test: Add a widget in a new empty workspace page, change the
grid then remove the widget in the new grid size then return
to the previous grid and it shouldn't have an empty workspace.

Change-Id: I7b73ae2ca058bc84b3b361930e3dc856c045281b
2022-09-27 21:51:17 +00:00
Federico Baron 810fd0cee7 Merge "Replace drawRect with drawable for delightful pagination" into tm-qpr-dev am: d8b78523ca am: b4388e3ef2
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20017949

Change-Id: I8c8743f8e88c26fa75b120a4e75249219fe5d4d7
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-27 04:25:55 +00:00
Federico Baron d8b78523ca Merge "Replace drawRect with drawable for delightful pagination" into tm-qpr-dev 2022-09-27 03:31:09 +00:00
Brian Isganitis 80014b118a Merge "Properly color taskbar nav buttons when slide-in view is shown." into tm-qpr-dev am: 815018be9a am: 7fc8bf0c25
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20040590

Change-Id: I4b1e3d676569c0f06f4963b3c83727d534fd40f8
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-26 23:31:49 +00:00
Brian Isganitis 815018be9a Merge "Properly color taskbar nav buttons when slide-in view is shown." into tm-qpr-dev 2022-09-26 22:56:06 +00:00
Federico Baron 4f5e573d3a Replace drawRect with drawable for delightful pagination
In order to eventually use the shape referenced in the task (https://docs.google.com/presentation/d/1V9-1C3mJ3zRGsuzzzYExisr9vLYecgADa1FucMoW_aw/edit#slide=id.g14256d0c614_0_311) we need to use a drawable. This CL adds the drawable that will be changed to that shape and uses it in PageIndicatorDots.java instead of using drawRect.

Bug: 247561880
Test: manual
Change-Id: I01e10bd9ddc7e378f2dcfdee0f84ba7443c3b9d3
2022-09-26 15:51:33 -07:00
Brian Isganitis 731ef0c301 Properly color taskbar nav buttons when slide-in view is shown.
Supports overriding the current nav bar color with one that would be
visible over a slide-in view.

Demo:
https://drive.google.com/file/d/1MB26QM5qeeyVB6Bj14IGoPCWVT_P7K-3/view?usp=sharing&resourcekey=0-wnMgciNrUXC_l7gI3JFm8A

Test: Manually with light and dark themes, as well as All Apps and EDU
views.
Fix: 248359789

Change-Id: I134ae719b10f3de78ea18220a835de56a82ecb02
2022-09-26 11:41:38 -07:00
Federico Baron 36c0389d67 Rename alpha and refactor the way alpha is set in PageIndicator am: cdadbaa225 am: b5ed62b8fc
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20010024

Change-Id: I2d607e9997b237c8c72eca0237f19cf600cc77d3
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-26 18:07:06 +00:00
Federico Baron cdadbaa225 Rename alpha and refactor the way alpha is set in PageIndicator
Here we rename DOT_INACTIVE_ALPHA and DOT_ACTIVE_ALPHA to reflect the new code, and we also use mPaginationPaint.setAlpha a bit differently

Bug: 247561880
Test: Manual
Change-Id: I5ee25ee3fb36715d54f9ed86c0d59448829d7260
2022-09-26 09:34:11 -07:00
Andy Wickham fafa374dcc Merge "Reduces search clipping when work profile is not present." into tm-qpr-dev am: 59cd0e0228 am: 914aae1860
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19981474

Change-Id: Iba2790e13875037161f4a8967ef9147af8043eef
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-24 18:57:15 +00:00
Andy Wickham 59cd0e0228 Merge "Reduces search clipping when work profile is not present." into tm-qpr-dev 2022-09-24 18:04:52 +00:00
Andy Wickham 14101659f7 Reduces search clipping when work profile is not present.
Basically, adds the spacing that is otherwise included by
the tab protection (which is about 4dp less than the spacing
that was previously being added).

Adds a compile-time flag to render the header at all times to
help visualize issues like this in the future. Check the
screenshots below to see some examples of this.

Screenshots: https://drive.google.com/drive/folders/1n4wwtjMwOR-eDIE1xAoG3oLXO7txpoT_?resourcekey=0-WP0RNbp7vFh2Yw1wUBZTaA&usp=sharing

Bug: 240672593
Bug: 243728487
Test: Manually checked search transition, scrolling behavior, and
highlight of the search results with and without a work profile.

Change-Id: I166d136e568c5621c81378fa09021666d95f0ffc
2022-09-23 19:36:44 -07:00
Federico Baron 469e34e02b Merge "Add rotation to folder pagination for delightful pagination" into tm-qpr-dev am: 178a45a5ab am: 8349c1f027
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19993513

Change-Id: I04aa502db032eef47288b341ddf91b98ec7b2b17
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-23 22:31:08 +00:00
Becky Qiu 05a630a991 Merge "[Toast] Change toast qpr1 feature flags to all apps device config." into tm-qpr-dev am: dd002b87e0 am: 9c2e5f509c
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19978762

Change-Id: I1168bd5b3d809fe3382d3ee562e3da8ec8c139d5
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-23 22:29:59 +00:00
Federico Baron 178a45a5ab Merge "Add rotation to folder pagination for delightful pagination" into tm-qpr-dev 2022-09-23 21:40:48 +00:00
Becky Qiu dd002b87e0 Merge "[Toast] Change toast qpr1 feature flags to all apps device config." into tm-qpr-dev 2022-09-23 21:31:15 +00:00
Becky Qiu 3aec5d59dc [Toast] Change toast qpr1 feature flags to all apps device config.
Bug: 247122218
Test: local
Change-Id: I096f9fe4f8d071ea4b3292c6245da0c0ec509077
2022-09-23 11:59:56 -07:00
Federico Baron bdcc17c2aa Add rotation to folder pagination for delightful pagination
Here we add rotation for the page indicator in order to make it align with the new animation design.

Bug: 247561880
Test: manual
Change-Id: I91202c8ac259d4876f6182938db79c466f99c6ed
2022-09-23 11:30:00 -07:00
Brandon Dayauon 83095afdfd Merge "Fix pause work apps overlapping IME" into tm-qpr-dev am: 7f98856395 am: 1d8912d37b
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20009124

Change-Id: I80f6a37daf96f412237de1927dcf693618635989
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-23 17:55:15 +00:00
TreeHugger Robot 06c90832d1 Merge "Adding flag for material U popup" into tm-qpr-dev am: 07bcfaa72a am: acc0a729bb
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20002183

Change-Id: I5c59e44ec777e88b815499a1d404e91bf6328a5d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-23 17:54:47 +00:00
Raj Garg 4b90dbe967 Revert "Introducing new variable to enable/disable shortcuts."
Revert "Introducing new variable to enable/disable shortcuts."

Revert submission 19632697-cherrypick-GO-DISABLE-SHORTCUTS-tyyzrpy9oe

Reason for revert: Reverting changes for the recent feature built by me. This CL was a part of the feature. Please take a call if we should revert it or not.
Reverted Changes:
Ib373b042f:Introducing new variable to enable/disable shortcu...
I4274cb468:Introducing new variable to enable/disable shortcu...

Change-Id: I81f338be71185cb008e81b020c5b3a7b01b64c58
2022-09-23 17:04:29 +00:00
Brandon Dayauon 7f98856395 Merge "Fix pause work apps overlapping IME" into tm-qpr-dev 2022-09-23 17:00:25 +00:00
TreeHugger Robot 07bcfaa72a Merge "Adding flag for material U popup" into tm-qpr-dev 2022-09-23 16:56:42 +00:00
Anushree Ganjam 99dc3b08e5 Merge "Add Ime transition type, Controlled and Atomic to LatencyType." into tm-qpr-dev am: 65e73ce5b3 am: 56e941b5a5
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20017952

Change-Id: I3beba5496a348bc9b35de99f0df738ae58ee9d77
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-23 07:45:48 +00:00
Andy Wickham 549c93ca2f Merge "Removes search animation when tapping home screen QSB." into tm-qpr-dev am: 0f7b01c775 am: 99d8b992c7
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20010025

Change-Id: I35a70aed2a0e662164ac883d1c4ffcc610a3cf33
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-23 07:45:31 +00:00
Anushree Ganjam 0dc2b99c80 Merge "HideKeyboard when animations are disabled." into tm-qpr-dev am: ae81433665 am: 3aa7d90ff3
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20004646

Change-Id: Ieb6124cb8688f71d6717c7cf261ec0a1f43a948b
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-23 07:45:16 +00:00
Schneider Victor-tulias dcbd4917e3 Merge "Allow Taskbar stashing for external tests" into tm-qpr-dev am: 418b1f8e82 am: d496c3d20d
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19611434

Change-Id: Ic6677741689b4c609ef2fd86aa2832730dd479f0
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-23 06:27:32 +00:00
Hyunyoung Song fa5052e4db Merge "Fix the case of the missing header." into tm-qpr-dev am: 64d5e25ab7 am: 0564ea24f8
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20016944

Change-Id: I8e5ca4967eb65d6b87d12cef8762e970f9bfc8c0
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-23 06:27:13 +00:00
Anushree Ganjam 65e73ce5b3 Merge "Add Ime transition type, Controlled and Atomic to LatencyType." into tm-qpr-dev 2022-09-22 23:32:45 +00:00
Brandon Dayauon 23ff6774b7 Fix pause work apps overlapping IME
The bottom margin for button in gesture navigation is wrong.
The bottom margin for the button is supposed to be 20dp from the gesture nav bar,
not 20dp from the bottom of the screen. The calculation was correct for 3 button nav but
was forgotten to be applied to gesture nav.

bug: 246243359
test: Manual - after: https://hsv.googleplex.com/5763335673872384
Change-Id: If678a70b4ad43791cf9e66390164e1ab25a6e366
2022-09-22 13:35:01 -07:00
Holly Sun cd9e261014 Add flag to control show/hide keyboard suggestion strip.
Test: manual
Bug: 247895327
Change-Id: I9425be72a1bd946a16d3327cbb10d56d2e2250b9
2022-09-22 13:32:00 -07:00
Andy Wickham 0f7b01c775 Merge "Removes search animation when tapping home screen QSB." into tm-qpr-dev 2022-09-22 19:01:12 +00:00
Anushree Ganjam ae81433665 Merge "HideKeyboard when animations are disabled." into tm-qpr-dev 2022-09-22 18:03:52 +00:00
Schneider Victor-tulias 418b1f8e82 Merge "Allow Taskbar stashing for external tests" into tm-qpr-dev 2022-09-22 17:25:24 +00:00
Hyunyoung Song 64d5e25ab7 Merge "Fix the case of the missing header." into tm-qpr-dev 2022-09-22 15:45:22 +00:00
Federico Baron 7110a274b6 Merge "Adding 'delightful pagination' to folders, removed old animation and now have regular scrolling for navigating pages." into tm-qpr-dev am: 06c0f35c4e am: 34a5c7fdb2
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19971348

Change-Id: I2544fe9e091688272e1c10a8f77e6970db425221
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-22 02:49:48 +00:00
Stefan Andonian 22f1eb2db4 Merge "Correctly position the landscape / rtl FloatingIconView's background drawable when swiping back to home." into tm-qpr-dev am: beccfe5928 am: 22683b1288
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19583216

Change-Id: If2ea6c55a61e3b0d2063bca92e4eb1393f70cfa7
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-22 02:21:58 +00:00
Federico Baron 06c0f35c4e Merge "Adding 'delightful pagination' to folders, removed old animation and now have regular scrolling for navigating pages." into tm-qpr-dev 2022-09-22 01:10:48 +00:00