Commit Graph

16456 Commits

Author SHA1 Message Date
Sebastian Franco 9cab1c3ece No code changes, this cl only reorganizes the functions
This is done such that future cls are easier to visualize.

Bug: 188081026
Test: atest ReorderWidgets
Change-Id: I749d21b517dada97887d5b5e7cb5e2ac644d0030
2022-11-01 18:24:43 +00:00
Federico Baron b66773656e Merge "Tapping on a "folder" on the Homescreen right after returning home results in it starting to open, then canceling." into tm-qpr-dev am: 120c99f440
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20068658

Change-Id: Ic0c4c3428ca226a6dbd2a12a8ae9254f40b1aad0
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-01 18:19:52 +00:00
Federico Baron 120c99f440 Merge "Tapping on a "folder" on the Homescreen right after returning home results in it starting to open, then canceling." into tm-qpr-dev 2022-11-01 17:56:50 +00:00
Tracy Zhou ac9a011062 Merge "Support split from fullscreen with shortcuts" into tm-qpr-dev am: 0c853991fd
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20206366

Change-Id: I0709750372123eeaafb66477fd9c6d78f258fad2
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-01 17:41:10 +00:00
Tracy Zhou 0c853991fd Merge "Support split from fullscreen with shortcuts" into tm-qpr-dev 2022-11-01 17:17:33 +00:00
Luca Zuccarini 350fdc6ec6 Merge "Make sure that PropertySetter applies the final state." into tm-qpr-dev am: 938dde8111 am: a20c6df786
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20298523

Change-Id: Iae18b1b3bacca6ccebe7905f10dd7538603b3ba2
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-01 13:36:12 +00:00
Luca Zuccarini a20c6df786 Merge "Make sure that PropertySetter applies the final state." into tm-qpr-dev am: 938dde8111
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20298523

Change-Id: Iea1793aa1d7f0f7f037f36fe7b3b3318e9be49d3
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-01 13:04:04 +00:00
Luca Zuccarini 938dde8111 Merge "Make sure that PropertySetter applies the final state." into tm-qpr-dev 2022-11-01 12:28:54 +00:00
TreeHugger Robot f56fe1758b Merge "Move DropTargetBar to bottom" into tm-qpr-dev am: 86dc1edbf8 am: 004c11d7d4
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20283568

Change-Id: I9279dcd7805b5cc5110e46fd462b189b819c7a3f
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-01 08:26:10 +00:00
TreeHugger Robot 004c11d7d4 Merge "Move DropTargetBar to bottom" into tm-qpr-dev am: 86dc1edbf8
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20283568

Change-Id: Ia9c7815cf47463ebaba1170e1c5bc27c8bae8f7c
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-01 07:52:04 +00:00
TreeHugger Robot 86dc1edbf8 Merge "Move DropTargetBar to bottom" into tm-qpr-dev 2022-11-01 07:21:31 +00:00
TreeHugger Robot a09e7f49dd Merge "Add dot pagination in workspace" into tm-qpr-dev am: d20e6676b1 am: b4293273df
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20251840

Change-Id: I76fcda067c80cea327ab732191e3db32d7e20638
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-01 05:26:46 +00:00
TreeHugger Robot b4293273df Merge "Add dot pagination in workspace" into tm-qpr-dev am: d20e6676b1
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20251840

Change-Id: Icaba792ef48f244f08f35bb68a87db217b0739b8
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-01 04:53:10 +00:00
TreeHugger Robot d20e6676b1 Merge "Add dot pagination in workspace" into tm-qpr-dev 2022-11-01 04:33:29 +00:00
Tracy Zhou ba0b5952c8 Support split from fullscreen with shortcuts
Recording: https://recall.googleplex.com/projects/f46cfe9c-8076-4efe-bf8a-b1cc4f1f5e1b/sessions/978a3a55-2982-4026-9726-2a73cb694258

TODO: improve transition animation

Bug: 246661484
Test: manual
Change-Id: Id0d1aec0685bc18f4b273f8e466996efc1d9a3d8
Merged-In: Id0d1aec0685bc18f4b273f8e466996efc1d9a3d8
2022-11-01 04:30:39 +00:00
Tracy Zhou 5b07f1d145 Merge "Support split from fullscreen with shortcuts" 2022-11-01 04:29:29 +00:00
Sebastián Franco f5615dda63 Merge "Decoupling finding the solution and animation of a reorder in CellLayout" into tm-qpr-dev am: 0c3f990b34 am: c55ae777db
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20284695

Change-Id: I73db3a8b39044d308f9cf91ae3c6449f5ad92477
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-01 00:11:45 +00:00
Sebastián Franco c55ae777db Merge "Decoupling finding the solution and animation of a reorder in CellLayout" into tm-qpr-dev am: 0c3f990b34
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20284695

Change-Id: Ib528d4b9ee676cd2da976eeaeaa5f82c60fa2ab7
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-31 23:39:14 +00:00
Sebastián Franco 0c3f990b34 Merge "Decoupling finding the solution and animation of a reorder in CellLayout" into tm-qpr-dev 2022-10-31 23:02:44 +00:00
Federico Baron 8bf1bca59a Tapping on a "folder" on the Homescreen right after returning home results in it starting to open, then canceling.
Fix: 243531200, 253264925
Test: manual
Change-Id: I180300e8333536346ad07ce7bc9956d3b84d82e6
2022-10-31 15:12:17 -07:00
Holly Jiuyu Sun 1194a6156c Merge "Log sub event type to latency logger." into tm-qpr-dev am: c5f43eb9f7 am: 1acb878078
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20296334

Change-Id: Ief1c24b7af455e0e1daba155f3cf8291e91bb564
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-31 20:57:29 +00:00
Holly Jiuyu Sun 1acb878078 Merge "Log sub event type to latency logger." into tm-qpr-dev am: c5f43eb9f7
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20296334

Change-Id: Ib77b601b328cdc102beb57cb8c4c0674e9a4cd30
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-31 20:25:58 +00:00
Holly Jiuyu Sun c5f43eb9f7 Merge "Log sub event type to latency logger." into tm-qpr-dev 2022-10-31 19:28:27 +00:00
Sunny Goyal 66a2d8cf67 Merge "Fixing flakyness in widget tests" into tm-qpr-dev am: 276e72c249 am: d23fc2405f
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20312118

Change-Id: Iaec13e95b7c8793705e4b9a7cde7eb85da17da3a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-31 17:25:55 +00:00
Sebastian Franco c8392ea881 Return the right radius to start reorder when dragging a Widget
Currently the radius is only one cell but in the case of a widget
we want the radius of the whole widget.

Fix: 255421400
Test: this case only happens when dagging comming from outside of the cell layuot in the corners dragging a widget
Change-Id: I3fe294d18283dbecb27df1a2d4748dd44db9b956
2022-10-31 10:20:53 -07:00
Sunny Goyal d23fc2405f Merge "Fixing flakyness in widget tests" into tm-qpr-dev am: 276e72c249
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20312118

Change-Id: I94f52325e89138ecdd9352e6b18e350a6b44ad94
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-31 16:53:12 +00:00
Sunny Goyal 276e72c249 Merge "Fixing flakyness in widget tests" into tm-qpr-dev 2022-10-31 16:23:08 +00:00
Tracy Zhou b9baae22bc Support split from fullscreen with shortcuts
Recording: https://recall.googleplex.com/projects/f46cfe9c-8076-4efe-bf8a-b1cc4f1f5e1b/sessions/978a3a55-2982-4026-9726-2a73cb694258

TODO: improve transition animation

Bug: 246661484
Test: manual
Change-Id: Id0d1aec0685bc18f4b273f8e466996efc1d9a3d8
2022-10-31 06:36:26 +00:00
Jeff Sharkey 1090fe96cf Merge "RemoteActionShortcut: try avoiding Activity leaks." 2022-10-29 15:25:25 +00:00
Jeff Sharkey d081c041c3 RemoteActionShortcut: try avoiding Activity leaks.
Hold a WeakReference into the closure, allowing the Activity to be
GC'ed if nobody else is keeping it alive.

Bug: 255833934
Test: atest --rerun-until-failure 100 NexusLauncherTests:WellbeingTests
Change-Id: Ica06d10a442390fe499d4d75e985d3510e2e63e1
2022-10-28 19:56:16 -06:00
Holly Jiuyu Sun 2750fa19bc Merge "[QL-v2] Use subtitle as hint if title doesn't apply." into tm-qpr-dev am: 35b0378d45 am: c9196b45d4
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20142072

Change-Id: I950807bb528f6afb1d52c00ebfb4e164bcbfc63b
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-28 21:06:32 +00:00
Holly Jiuyu Sun c9196b45d4 Merge "[QL-v2] Use subtitle as hint if title doesn't apply." into tm-qpr-dev am: 35b0378d45
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20142072

Change-Id: I35ea0bf09957566e42319c418977811c96a5e87c
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-28 20:34:38 +00:00
Holly Jiuyu Sun 35b0378d45 Merge "[QL-v2] Use subtitle as hint if title doesn't apply." into tm-qpr-dev 2022-10-28 19:35:33 +00:00
Sunny Goyal 1d76159de4 Fixing flakyness in widget tests
For some predicted app widgets, the layout happens before the recyclerView
can layout completely (because of preview layout invalidation), causing the
scroll cache to get in a wrong state.
Checking for scroll cache validity everytime instead of only during
data changes

Bug: 255797215
Test: Verified by hardcoing the chrome widget as predicted widget
Change-Id: Id2c68560baa45de89e08c53bdb9ee6820eab68c4
2022-10-28 12:25:04 -07:00
Sebastian Franco 53a15a4b1f Decoupling finding the solution and animation of a reorder in CellLayout
Adding new functions to CellLayout, two of them return a solution
(calculateReorder, getSimpleReorder) and the other one takes a
solution and animates that solution (void performReorder) and it can
either submit the solution or just show it for a preview.

Right now this two things are done under the same function:
int[] performReorder. The need to separate this two functions is
because to add this functionality b/188081026 which needs to find
soluion without animation and animation solutions that can be
calculated in another place.

Bug: 188081026
Test: atest ReorderWidgets
Change-Id: Ib519d4346f58f9b55aff5008cd3ccbcfe8443d2d
2022-10-28 11:55:50 -07:00
Holly Sun 4d6fa05c83 Log sub event type to latency logger.
Bug: 255355348
Test: build
Change-Id: Idac85b5e31e2abdd98f6fd1bed4ec687d8bb5cd5
2022-10-27 16:37:18 -07:00
Federico Baron 626d51c68c Move DropTargetBar to bottom
The DropTargetBar has "Remove" and "Uninstall" buttons for workspace edit mode. We are moving them to the bottom for workspace home gardening

Bug: 251259222
Test: Turn on flag HOME_GARDENING_WORKSPACE_BUTTONS and enter spring loaded mode (edit workspace), notice the buttons are now at the bottom
Change-Id: I739162bdd5764dd8367a63a67fae0fe5c7329b0a
2022-10-27 14:18:00 -07:00
Holly Sun 786bdce214 [QL-v2] Add logging for quick launch.
Move logging to DeviceSearchAdapterProvider to take advantage of View so we can log more info attached to the quick launch event. Another reason is currently we can't dynamically change the enter key icon so we can't really distinguish whether it's a quick search or quick launch using the icon (we are working with gboard team to fix this issue).

Bug: 256010819
Test: see wwlogging https://paste.googleplex.com/5668268562972672
Change-Id: I38aad2ae97c9b372f3d76222a82de45fc3bf3eed
2022-10-27 13:18:19 -07:00
Sihua Ma ce1b37ccd4 Merge "Created LauncherWidgetHolder as a wrapper for LauncherAppWidgetHost" into tm-qpr-dev am: 17137e8bce am: fe121a99c6
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20106227

Change-Id: I67fff40251e2feb6beaf0b45e5352dd5dae642de
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-27 19:01:32 +00:00
Sihua Ma fe121a99c6 Merge "Created LauncherWidgetHolder as a wrapper for LauncherAppWidgetHost" into tm-qpr-dev am: 17137e8bce
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20106227

Change-Id: Id6e14023d7c3ca6440517165fe10186601249083
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-27 18:24:31 +00:00
Sihua Ma 17137e8bce Merge "Created LauncherWidgetHolder as a wrapper for LauncherAppWidgetHost" into tm-qpr-dev 2022-10-27 17:53:28 +00:00
Alex Chau 0b799ce367 Merge "Update pullback animation to use reset FloatProperty for non-active state" into tm-qpr-dev am: b3ab6f5014 am: 37ccd255b7
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19949846

Change-Id: Ia01c47fb5d2f7695b1da16f76f9e835c0164ce34
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-27 13:53:21 +00:00
Alex Chau 37ccd255b7 Merge "Update pullback animation to use reset FloatProperty for non-active state" into tm-qpr-dev am: b3ab6f5014
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19949846

Change-Id: I9725ae0833648484589bb663b94fd93994a626bf
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-27 13:17:00 +00:00
Alex Chau b3ab6f5014 Merge "Update pullback animation to use reset FloatProperty for non-active state" into tm-qpr-dev 2022-10-27 12:38:15 +00:00
Luca Zuccarini 05d19dc261 Make sure that PropertySetter applies the final state.
In some tests with animations disabled, NO_ANIM_PROPERTY_SETTER wasn't
applying the correct final value. See ag/20139786 for more context.

Bug: 251769927
Test: see other CL in topic, plus manual
Change-Id: I296de1a0d64768c43608839745cc7e955ecd2076
2022-10-27 09:31:57 +00:00
Becky Qiu efe95a2b52 Merge "[Toast] Use a BaseSearchConfig for launcher3 to read allapps device config." into tm-qpr-dev am: 6a2dd438da am: de2172bedf
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20240555

Change-Id: I0fde7b59db5ac04132a81509a3d1d1456b7c5853
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-26 21:49:17 +00:00
Becky Qiu de2172bedf Merge "[Toast] Use a BaseSearchConfig for launcher3 to read allapps device config." into tm-qpr-dev am: 6a2dd438da
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20240555

Change-Id: I485e5c71e8ee89d1e5bac3f6d31dc3dce8145689
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-26 21:11:17 +00:00
Becky Qiu 6a2dd438da Merge "[Toast] Use a BaseSearchConfig for launcher3 to read allapps device config." into tm-qpr-dev 2022-10-26 20:33:05 +00:00
Sihua Ma 6f9a09d9d1 Merge "Correctly show the widget in the recommendation table" into tm-qpr-dev am: e53245fbc7 am: 9525bb2b1d
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20076327

Change-Id: I92baf8c76cb67c7e3246c2180fff5585f25fc7be
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-26 19:52:58 +00:00
Tracy Zhou 15f54194c9 Merge "Allow two finger gesture from trackpad to pull down notification from home" 2022-10-26 19:21:27 +00:00