PawletOS/Lawnchair
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity
60,459 Commits 1 Branch 0 Tags
4f69ca52efa7a94de67a2b9c4956e233dfb23d92
Commit Graph

16456 Commits

Author SHA1 Message Date
Luca Zuccarini 56ccb4eda5 Merge "[Toast] Update A-Z <-> Toast transition for drawable backgrounds." into tm-qpr-dev 2022-11-15 10:54:03 +00:00
TreeHugger Robot 7936906716 Merge "Reorder widgets no longer overlaps when no space is available" into tm-qpr-dev am: e2334d76fe am: 1660639dc0 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20413617

Change-Id: I14b439ed928a6418e29dd11299a16e91ebb822ae
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2022-11-15 10:37:14 +00:00
TreeHugger Robot 1660639dc0 Merge "Reorder widgets no longer overlaps when no space is available" into tm-qpr-dev am: e2334d76fe 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20413617

Change-Id: Ib60f471012fb310366f82e55653cdc65c2e7dd5a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2022-11-15 10:15:55 +00:00
TreeHugger Robot e2334d76fe Merge "Reorder widgets no longer overlaps when no space is available" into tm-qpr-dev 2022-11-15 09:53:02 +00:00
Saumya Prakash a836e9ba00 Merge "Add a flag for the redesigned Gesture Nav Tutorial" into tm-qpr-dev am: 59a3c51a43 am: b67ffcb04b 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20470536

Change-Id: Ic89466fcf8349427af5b618afacab5d490ab2dfc
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2022-11-15 03:10:37 +00:00
Saumya Prakash b67ffcb04b Merge "Add a flag for the redesigned Gesture Nav Tutorial" into tm-qpr-dev am: 59a3c51a43 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20470536

Change-Id: Iaad0a7624aa157f982c8156c993d5b98faac8c4d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2022-11-15 03:06:02 +00:00
Saumya Prakash 7eac37254b Add a flag for the redesigned Gesture Nav Tutorial 
We plan to improve the gesture navigation education tutorial as
discussed and shown in go/gesture-nav-education.

Test: N/A
Bug: 241813570
Change-Id: I2ad8d12cf14c1b3f0eec3208ad12a24ac54b9dbc
 2022-11-14 22:38:21 +00:00
Alex Chau 2426514bf6 Put IDP.getDeviceProfile logging behind a feature flag 
- To avoid memory regression in performance testse

Fix: 257359801
Test: manual
Change-Id: I5ed768d90dba149eeb8f7be7d1d229b0b599a485
 2022-11-14 21:19:44 +00:00
Sihua Ma 7a382f139d Making talkback focus on the widget after the resize 
Fix: 216386890
Test: Manual
Change-Id: I79b0280c0f24a81be44e1578755ed90cf3343f88
 2022-11-14 13:12:44 -08:00
Federico Baron 61dbfde9ed Merge "Add flag for 'Improve widget picker UX on large display form factor'" into tm-qpr-dev am: e779a8c783 am: 9b30b84879 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20341701

Change-Id: I7f4c1c4f43d2132714a98cd3429e7413dbd358b7
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2022-11-14 19:39:06 +00:00
Federico Baron 9b30b84879 Merge "Add flag for 'Improve widget picker UX on large display form factor'" into tm-qpr-dev am: e779a8c783 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20341701

Change-Id: I63d9f134fe7c428d1dfe1dc02dcd6e418f6b98f0
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2022-11-14 19:06:46 +00:00
Tracy Zhou 0b96f63514 Merge "Use movement on the trackpad instead of on screen for trackpad gestures used for gesture nav" 2022-11-11 22:31:35 +00:00
Federico Baron c0dc93d384 Add flag for 'Improve widget picker UX on large display form factor' 
here's how we plan on improving widget picker under this flag: https://docs.google.com/presentation/d/1mcdjJWutr-ZGbPOndhe1D8YCdCh6EbO8eNyK3YMMVEY/edit#slide=id.g1571d496dda_0_145
Test: N/A
Bug: 256684299

Change-Id: I365516b43e70a37c7b93e089b6822c58a0f81540
 2022-11-11 22:24:18 +00:00
Anushree Ganjam c36593139c Introduce imeHeight in KeyboardStateManager. 
Bug: 204781396
Test: Manual
Change-Id: If9dc9427a73ab22d6418edb9c954e79fd0958395
 2022-11-11 19:20:16 +00:00
Anushree Ganjam 6024013953 Add SearchResultCode to onSearchResult() 
Bug: 204781396
Test: Manual
Change-Id: Ia776be0fdd42e1d5fa405911e28d9b0a12c1fdde
 2022-11-11 18:26:58 +00:00
Anushree Ganjam 96c72745ae Add ImpressionLogger to StatsLogManager 
go/toast-search-impression-logging

Bug: 204781396
Test: Manual
Change-Id: If00027581000d315590ce2fac46428cbf173da49
 2022-11-11 18:23:25 +00:00
Tracy Zhou aef9d75f78 Use movement on the trackpad instead of on screen for trackpad gestures used for gesture nav 
Bug: 254783214
Test: https://recall.googleplex.com/projects/3388b17c-d22f-46f8-b140-a102690377b4/sessions/f3311fbc-d8cf-4f19-b83c-8626aa285452
Change-Id: Iad2da5831af85dd3647e1e31b42fea0a6302b49c
 2022-11-11 00:05:03 -08:00
Sebastian Franco 592e2691f6 Fix the wiggle reorder aniamtion stopping if dragging 
We were using the minimum span to calculate the cell position
of the widget and if you move slightly because the minimum is usually smaller than the current size it would calculate wrong cell positions
that are change more frequently because it's smaller.

Also, I went back and moved
performReorder(... CellLayout.MODE_SHOW_REORDER_HINT) with the
alarm if block as it was before one of my refactors, it still works
if they are separate but is harder to think about the logic if they
are divided so it's better to all be in one block.

Fix: 255421416
Test: manual testing, reordering and making sure the animation is playing well.
Test: atest ReorderWidgets (to make sure the reorder is not broken)
Change-Id: I3eff5bc9f21fda8f2f8908380397d8639ac15ff9
 2022-11-10 21:53:33 +00:00
Anushree Ganjam 9aa386cde2 Merge "Add ENABLE_TOAST_IMPRESSION_LOGGING to FeatureFlags." into tm-qpr-dev am: b63cc3f113 am: 9d77abc3f4 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20432435

Change-Id: Ifd258e36efa3b175292b7698a4233934abd7fad8
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2022-11-10 20:44:23 +00:00
Anushree Ganjam 5fc563b2b5 Merge "Add OnLayoutCompleted() Listener." into tm-qpr-dev am: fd7afb707a am: 04c268daef 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20432434

Change-Id: If48dabaf57308b293b7e9b211b04a50ce01420ad
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2022-11-10 20:44:15 +00:00
Anushree Ganjam 9d77abc3f4 Merge "Add ENABLE_TOAST_IMPRESSION_LOGGING to FeatureFlags." into tm-qpr-dev am: b63cc3f113 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20432435

Change-Id: If02f87ef74c73321afa3427d845ad80539292b30
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2022-11-10 20:43:32 +00:00
Anushree Ganjam 04c268daef Merge "Add OnLayoutCompleted() Listener." into tm-qpr-dev am: fd7afb707a 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20432434

Change-Id: I21481a4769668479d161f5557caddaa8b7b85edf
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2022-11-10 20:43:22 +00:00
TreeHugger Robot 5a84fe1817 Merge "Create test for default grid" into tm-qpr-dev am: 267d7179cd am: ed50adb7b4 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20347132

Change-Id: I00abba38b3cd56d73bdef126493c1b7c601ad380
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2022-11-10 20:42:43 +00:00
Anushree Ganjam b63cc3f113 Merge "Add ENABLE_TOAST_IMPRESSION_LOGGING to FeatureFlags." into tm-qpr-dev 2022-11-10 20:31:01 +00:00
Anushree Ganjam fd7afb707a Merge "Add OnLayoutCompleted() Listener." into tm-qpr-dev 2022-11-10 20:19:42 +00:00
Vinit Nayak 27d004d369 Merge "Improve Split portrait gesture animation" into tm-qpr-dev am: 2ca82f38e4 am: 4b6c05c2ef 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20330754

Change-Id: Ib1e9cf31c70edb187f6bc8467f7a2d5ddaa9bb1e
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2022-11-10 20:18:10 +00:00
TreeHugger Robot ed50adb7b4 Merge "Create test for default grid" into tm-qpr-dev am: 267d7179cd 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20347132

Change-Id: I6cb50a223aa63323812133b50499fb84b6c19698
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2022-11-10 20:09:29 +00:00
TreeHugger Robot 267d7179cd Merge "Create test for default grid" into tm-qpr-dev 2022-11-10 19:37:11 +00:00
Vinit Nayak 4b6c05c2ef Merge "Improve Split portrait gesture animation" into tm-qpr-dev am: 2ca82f38e4 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20330754

Change-Id: I6cd4962097e2c72762cf28f8c4feb01efa66f22b
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2022-11-10 19:28:59 +00:00
Vinit Nayak 2ca82f38e4 Merge "Improve Split portrait gesture animation" into tm-qpr-dev 2022-11-10 19:19:39 +00:00
Jon Miranda f0349354ec Revert "Revert "Add TaskbarModeSwitchRule to test both transient/persistent taskbar."" 
This reverts commit e7011d2b87.

Reason for revert: attempt to fix test issues

- Instead of using SharedPrefs which can be flaky anyways,
  we pass along a boolean to test transient taskbar when
  we are in the test harness

Bug: 257549303
Test: TaplTestsTaskbar
Change-Id: I7c15a97363adc377f29853c1fe60b1960c77bfc3
 2022-11-10 11:11:14 -08:00
Anushree Ganjam 29eb74f9bd Add ENABLE_TOAST_IMPRESSION_LOGGING to FeatureFlags. 
Bug: 204781396
Test: Manual
Change-Id: Icd1170d8fc349ca3a50836ef0d1d0c9a0c793002
 2022-11-10 17:41:20 +00:00
Anushree Ganjam f213afc0a7 Add OnLayoutCompleted() Listener. 
OnLayoutCompleted() Listener for RecyclerView.LayoutManager#onLayoutCompleted(RecyclerView.State) so we can do impression logging when RecyclerView has finished laying out the items.

Bug: 204781396
Test: Manual
Change-Id: I59b81e98415b2b0c6f3b26d2c41d348242342048
 2022-11-10 17:38:59 +00:00
Luca Zuccarini 431f05b3a0 [Toast] Update A-Z <-> Toast transition for drawable backgrounds. 
This and the other change in the topic are protected by a new feature
flag (included here).

Bug: 229297414
Bug: 248006105
Test: manual (see screenshots and recordings in the second bug)
Change-Id: I3478d7e194ee5d3bc4f8affdadbec969c033d084
 2022-11-10 14:43:20 +00:00
Thales Lima b67bfa7512 Create test for default grid 
Fixes: 256044695
Test: DeviceDefaultGridTest
Change-Id: Ie0a4de12f777ad3d15020252b2f67b575cc0eca9
 2022-11-09 14:00:44 +00:00
Luca Zuccarini f58fac5d65 Merge "Fix IME sync flicker with 3-button navigation." into tm-qpr-dev am: 3d69d9bd98 am: de9d08fc64 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20175703

Change-Id: I036cb81d3fd679959128baa6e6abdad76ba4f584
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2022-11-09 11:40:41 +00:00
Luca Zuccarini de9d08fc64 Merge "Fix IME sync flicker with 3-button navigation." into tm-qpr-dev am: 3d69d9bd98 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20175703

Change-Id: I5679849bbf272da9fa66060ac09773cabd55d8d0
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2022-11-09 10:52:56 +00:00
Luca Zuccarini 3d69d9bd98 Merge "Fix IME sync flicker with 3-button navigation." into tm-qpr-dev 2022-11-09 10:19:30 +00:00
TreeHugger Robot 195e9ef499 Merge "Revert "Add TaskbarModeSwitchRule to test both transient/persistent taskbar."" into tm-qpr-dev am: 8dd01f3ac2 am: b5c134d72c 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20416308

Change-Id: Ie5d094942e3e476a8be47de609a47cf52049e621
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2022-11-09 02:19:58 +00:00
TreeHugger Robot b5c134d72c Merge "Revert "Add TaskbarModeSwitchRule to test both transient/persistent taskbar."" into tm-qpr-dev am: 8dd01f3ac2 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20416308

Change-Id: I1c271f89300a0483af71aac53dafebfe7c45429e
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2022-11-09 01:32:38 +00:00
TreeHugger Robot 8dd01f3ac2 Merge "Revert "Add TaskbarModeSwitchRule to test both transient/persistent taskbar."" into tm-qpr-dev 2022-11-09 01:07:11 +00:00
Jon Miranda 5cedbe2cab Merge "Proposal to move Developer Options to top of Home settings if studio build." into tm-qpr-dev am: e76c4b1a43 am: 344fb4d230 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20413621

Change-Id: Ia41c66c04bd79cc8249996e1958092c8a124a9cd
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2022-11-09 00:19:23 +00:00
Jon Miranda 344fb4d230 Merge "Proposal to move Developer Options to top of Home settings if studio build." into tm-qpr-dev am: e76c4b1a43 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20413621

Change-Id: I099457c70b97fdc39bd6e1ec7f3bcec76baa0fcc
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2022-11-09 00:16:11 +00:00
Jon Miranda e7011d2b87 Revert "Add TaskbarModeSwitchRule to test both transient/persistent taskbar." 
This reverts commit d5a6b5f688.

Reason for revert: Breaks tests due to "SharedPreferences in credential encrypted storage are not available until after user is unlocked"

Bug: 258256906
Change-Id: I1de69249685f9d2e71183357cf3eda8d443c7d97
 2022-11-08 21:56:52 +00:00
Jon Miranda 3153cd9b97 Proposal to move Developer Options to top of Home settings if studio build. 
- Increases developer efficiency by avoiding the need to scroll

Bug: 258263867
Test: manual
Change-Id: I6cb46fdd12b51f8c45017f823dd4b2458e21fc72
 2022-11-08 20:50:42 +00:00
Vinit Nayak 29e71bdd72 Improve Split portrait gesture animation 
* Crop out taskbar from bottom thumbnail for vertical split
* TODO: Need to re-calculate thumbnail sizes if taskbar
 is stashed. There's also a very slight rounding error
 somewhere even in the unstashed case that needs to be
 revisited

Bug: 219411750
Test: Start gesture animation in split in potrait
Change-Id: I35f2415e13af7467e0735ac8865cee0e3e3d27f8
 2022-11-08 11:33:08 -08:00
Sebastian Franco 893615f241 Reorder widgets no longer overlaps when no space is available 
In the previous refactor I got confused between findNearestVacantArea
and findNearestArea thinking the later did the former. So it ignored the occupied spaces and treat it as a solution.

Changed the names to prevent further confusion.

Fix: 258023561
Test: manual, need to add this case to ReorderWidgets
Change-Id: I04b262ecce168d5c93a9d66ef62d5b0e148e38b6
 2022-11-08 19:02:15 +00:00
Alex Chau 8aa9f9f25b Merge "Improve spaces for folders" into tm-qpr-dev am: 1feadf7d81 am: 60ae676568 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19866978

Change-Id: I4f196ef56f8ffaa70760464ac567fc8c7784e883
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2022-11-08 17:58:32 +00:00
Luca Zuccarini 81f5cee2cb Fix IME sync flicker with 3-button navigation. 
With keyboard sync, the dismissal is handled by the animator. Calling
hideKeyboard() on top of that causes the two signals to conflict with
each other, resulting in the visible flicker and extra delayed hiding
animation.

Fixes: 251185052
Test: manual, see videos in the bug

Change-Id: Ic12ad304ef9e4b6a51279ce18d6c09ba93bd59be
 2022-11-08 17:26:46 +00:00
Alex Chau 60ae676568 Merge "Improve spaces for folders" into tm-qpr-dev am: 1feadf7d81 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19866978

Change-Id: Idca5b77b8756de2865a332798831b4bbd38bd689
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2022-11-08 17:24:24 +00:00