Commit Graph

47938 Commits

Author SHA1 Message Date
Vinit Nayak 95686cd9be Merge "Ensure starting split animation scale is always 1" 2022-02-16 18:49:40 +00:00
TreeHugger Robot 64162f1e05 Merge "Update TAPL object hierarchy in preparation for Taskbar TAPL tests" 2022-02-16 18:20:06 +00:00
TreeHugger Robot b63aad9de8 Merge "Use correct text size for settings collapsed toolbar in landscape." 2022-02-16 18:01:39 +00:00
Presubmit Automerger Backend 21e44c56bb [automerge] Prevent lingering divider animators in AbsSwipeUpHandler 2p: 7faaffa56a
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16693066

Bug: 213403679
Change-Id: I628b14fb01461a103dd0cdd7168835197a28f1c5
Merged-In: I078a7d0f22c2ef2ba847796ec79e740c789ce1ae
2022-02-16 17:13:58 +00:00
Winson Chung 7faaffa56a Prevent lingering divider animators in AbsSwipeUpHandler
- Refactor the util method to create the animator and track the existing
  animation in AbsSwipeUpHandler to be able to cancel it if another call
  to change the visbility comes in.  Note that this doesn't address
  the case where the launch animation overlaps with swipe up (though that
  hopefully shouldn't happen in normal usage)

Bug: 213403679
Test: Tap in the gesture space while split
Change-Id: I078a7d0f22c2ef2ba847796ec79e740c789ce1ae
Merged-In: I078a7d0f22c2ef2ba847796ec79e740c789ce1ae
2022-02-16 17:13:48 +00:00
TreeHugger Robot 19fff8cb74 Merge "Do not theme icons when the original view is not themed." 2022-02-16 17:13:10 +00:00
Andras Kloczl 659cfbe1f6 Fix two panel tapl test dragging issue
It seems if the dragging target position's X coordinate is 0
then there is a weird bug in portrait mode.

Test: atest TwoPanelWorkspaceTest
Bug: 197631877
Change-Id: I7d8702b06e5ed396814339080f8e814e9f8a6a65
2022-02-16 13:47:50 +00:00
Tony Huang b39ef58493 Merge "Refactor startIntentAndTaskWithLegacyTransition" 2022-02-16 03:45:02 +00:00
Brian Isganitis 860e675abe Merge "Remove popup container drag listener on close complete." 2022-02-16 03:33:49 +00:00
TreeHugger Robot 770bd08b6b Merge "Reverse order of long-press menu." 2022-02-15 23:49:15 +00:00
TreeHugger Robot 940e5c7328 Merge "Cover thumbnail view instead of TaskView for split animation" 2022-02-15 23:22:32 +00:00
Brian Isganitis 6f1bd180f0 Use correct text size for settings collapsed toolbar in landscape.
Test: Manual
Fix: 213919433
Change-Id: I159015f425ae615d0abac076f04a100057a7237f
2022-02-15 15:12:02 -08:00
Evan Rosky 0a2f5b0baa Merge "Switch pip to fixed-rotation in shell transitions" 2022-02-15 22:34:34 +00:00
TreeHugger Robot da762c6ba3 Merge "Add null check for mRemoteTargetHandles for side task launch" into sc-v2-dev am: a6c2e3f263 am: 949f9763bb
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16828915

Change-Id: I85480ddb976bf34f2759ddbd6ad8f8a235716ae9
2022-02-15 22:33:42 +00:00
TreeHugger Robot 949f9763bb Merge "Add null check for mRemoteTargetHandles for side task launch" into sc-v2-dev am: a6c2e3f263
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16828915

Change-Id: Ibec0c5987cecc92827896f41031f2359010955dd
2022-02-15 22:33:08 +00:00
TreeHugger Robot 451e468678 Merge changes from topic "presubmit-am-cc24ad26c93446a690f8a34ffde58aa3" into sc-v2-dev-plus-aosp am: 3a6a78f7b0
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16828915

Change-Id: Icfc37fdb5858352e77628959ed7e627712620cdd
2022-02-15 22:32:43 +00:00
TreeHugger Robot a6c2e3f263 Merge "Add null check for mRemoteTargetHandles for side task launch" into sc-v2-dev 2022-02-15 22:12:28 +00:00
TreeHugger Robot 3a6a78f7b0 Merge changes from topic "presubmit-am-cc24ad26c93446a690f8a34ffde58aa3" into sc-v2-dev-plus-aosp
* changes:
  [automerge] Add null check for mRemoteTargetHandles for side task launch 2p: 90e0fe3923
  Add null check for mRemoteTargetHandles for side task launch
2022-02-15 22:12:27 +00:00
Schneider Victor-tulias d6279ae641 Update TAPL object hierarchy in preparation for Taskbar TAPL tests
See design at: go/taskbar-tapl-tests

Test: Ran tests remotely
Bug: 215218813
Change-Id: I1c2ceac8954973ea3ae5b2f797fdfb96ba7a6ec4
2022-02-15 13:33:26 -08:00
Brian Isganitis 8350fbdc39 Reverse order of long-press menu.
Test: Manual
Bug: 219777079
Change-Id: I161f10a5e7491aaa3926eba714ae2b46a10a2e62
2022-02-15 13:31:40 -08:00
Brian Isganitis 1f7afc7740 Remove popup container drag listener on close complete.
The drag listener is never removed causing a memory leak over time.

Bug: 217162588
Test: Verified removal once drag is finished and close complete is
called.

Change-Id: Iff7bac8724e76e5dec98edaffe2d8853516f6c87
2022-02-15 13:24:09 -08:00
Jon Miranda 0aa263c5a0 Do not theme icons when the original view is not themed.
Fixes bug where animations uses themed icons in All Apps, where the
icons are not themed.

We want the DragView themed since all valid drop locations will have it
appear themed.

Bug: 215650713
Test: open/close an app from All Apps
Change-Id: I9969ce4921831dd12858ed9b0fe64379e9e3b188
2022-02-15 13:16:22 -08:00
Vinit Nayak 12a24dca8d Cover thumbnail view instead of TaskView for split animation
Fixes: 219622592
Test: Slowed down animation and verified same as before
refactor was done.

Change-Id: Iec8dc9ea1d7925575c3a3b84e12653829a00d8dd
2022-02-15 12:41:11 -08:00
Vinit Nayak 181f4b2c40 Ensure starting split animation scale is always 1
Bug: 194414938
Test: After second app selected, first split placeholder
view doesn't jumpcut to arbitrary Y bounds.

Change-Id: Ic8b809f147bf38f78198ef4224d810faf5e3c5ba
2022-02-15 12:01:37 -08:00
Brian Isganitis 7b046e7e27 Merge "Add predictions row to taskbar all apps." 2022-02-15 19:24:53 +00:00
TreeHugger Robot fccae60a24 Merge "Add Z scaling during unfold to launcher" 2022-02-15 17:49:11 +00:00
Nicolo' Mazzucato 12131a40fe Add Z scaling during unfold to launcher
The unfold progresses are mapped to 0.85 - 1 range and set as a scale for launcher.

In case of multiple scale animations for workspace and hotseat, they are combined using MultiScaleProperty (e.g. opening an app while unfolding/going to all apps while unfolding). Note that this is a pretty difficult scenario to be in. If that happens, we multiply all values and bound the result between the max and min values.

Bug: 217368525
Test: atest MultiScalePropertyTest and manually
Change-Id: I6131c39f36deade0b7280c72edda2d72045344e9
2022-02-15 17:02:36 +01:00
Tony Huang 3a2d621429 Refactor startIntentAndTaskWithLegacyTransition
Param intentFirst is not necessary because we could use stagePosition
to ensure intent side is left or right.
Remove it and ensure start task on main stage at split side.

Bug: 218613028
Test: pass existing tests
Test: manual
Change-Id: I3b8fc74b18c4d48fe73b501be696c3d59677183b
2022-02-15 15:57:02 +08:00
Jon Miranda baf1ef55ab Revert "Clear all DragView in onSaveInstanceState"
This reverts commit 14d6771aae
to fix bootline regression.

Bug: 210383463
Test: manual
Change-Id: I5a0dadee59bfd6b5a164fd2ca3ecdd1885cb4134
2022-02-14 20:26:40 -08:00
TreeHugger Robot b70131e1dd Merge "Use config_imeDrawsImeNavBar in Launcher" 2022-02-15 02:50:21 +00:00
Benno Lin 978d646864 Merge "Implemnet methods to drag a icon to given Workspace cell" 2022-02-15 01:49:21 +00:00
Benno Lin 7738cac424 Implemnet methods to drag a icon to given Workspace cell
The CL implements public methods to drag an Icon from AllApps to a
given cell in the workspace.

Bug: 199120092
Test: Launcher3Tests:com.android.launcher3.ui.TaplTestsLauncher3#testDragAppIconToWorkspaceCell
Test: https://android-build.googleplex.com/builds/abtd/run/L89300000953052361
Test: https://android-build.googleplex.com/builds/abtd/run/L44500000953013792
Change-Id: Ife16d1f1b55b809763dd40f5afee6711049a4729
2022-02-15 01:48:45 +00:00
Jon Miranda cd191165c4 Merge "Init FloatingIconView properties before fetching drawable. & Make sure properties are reset when recycled." 2022-02-15 01:10:54 +00:00
Xin Li 652b9b55d8 [automerger skipped] Merge SP2A.220305.012 am: 11a0454879 -s ours am: 2f4f77fdbc -s ours
am skip reason: Merged-In I51cb81718a489ad7568c5e05ace0b3dbc6ca5443 with SHA-1 0077caa15d is already in history

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16872102

Change-Id: Ifb4f453ee15abcbd88169810dac11164a9cc8a20
2022-02-15 00:35:24 +00:00
Xin Li 2f4f77fdbc [automerger skipped] Merge SP2A.220305.012 am: 11a0454879 -s ours
am skip reason: Merged-In I51cb81718a489ad7568c5e05ace0b3dbc6ca5443 with SHA-1 0077caa15d is already in history

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16872102

Change-Id: Ife61a6188c19b497fda7df645caa549e4d90835a
2022-02-15 00:14:51 +00:00
Android Build Coastguard Worker 62d30d71f4 Merge cherrypicks of [16685428, 16688543, 16684091] into sc-v2-release.
Change-Id: If86b1acade6ad30900ecf35f9dc7b9afa223723e
2022-02-14 23:13:59 +00:00
Jon Miranda e44c403710 Fix bug where back swipe to icon in All Apps search result.
Issue is that All Apps is scaling during the animation, so when
FloatingIconView looks for it in the view hierarchy,
it's not in its final position.

This would be the cleanest approach for a scv2 fix

Bug: 213306709
Test: manual
Change-Id: Iaec77d15c9533edccd9c82164143af8fa522158f
Merged-In: Iaec77d15c9533edccd9c82164143af8fa522158f
(cherry picked from commit db767aa575)
Merged-In:Iaec77d15c9533edccd9c82164143af8fa522158f
2022-02-14 23:13:13 +00:00
Winson Chung 3db7cd137e Add fallback for missing remote animation callbacks
- In some cases WM won't callback the remote animation callbacks (neither
  start nor cancel) and Launcher never finishes executing the pending
  command (preventing the subsequent commands from running).  For the time
  being, just cancel the current state to allow the commands to be
  processed.

Bug: 194011186
Test: Mash on overview and home buttons with a 3p launcher

Signed-off-by: Winson Chung <winsonc@google.com>
Change-Id: I1b1296fab316b979f441ebb474d1475e3fa68f95
Merged-In: I1b1296fab316b979f441ebb474d1475e3fa68f95
(cherry picked from commit bb530e9058)
Merged-In:I1b1296fab316b979f441ebb474d1475e3fa68f95
2022-02-14 23:13:10 +00:00
Winson Chung ab5f39bdc0 Dispatch hover events through the input consumer proxy
- Touch explore uses hover events to focus views for accessibility, but
  we were dropping these events when handling them through the input
  consumer proxy.  The reason this changed is that in sc-v2 we moved the
  recents input consumer to the top of the task display area to ensure
  that it was always above any of the tasks in splitscreen, but by doing
  so, it was always above launcher even after settling in overview.  The
  existing path for handling motion events is heavily tied to touch
  handling (action down/move/up) so we just add a separate path for
  dispatching hover events through the normal mechanism to launcher via
  the consumer.

Bug: 197043796
Change-Id: I5f8cfd357ff13971fe172ce1d0179535479cd26c
(cherry picked from commit eff9a120c6)
Merged-In:I5f8cfd357ff13971fe172ce1d0179535479cd26c
2022-02-14 23:13:07 +00:00
Jon Miranda b2670d2051 Init FloatingIconView properties before fetching drawable.
& Make sure properties are reset when recycled.

This fixes the bug that causes BubbleTextView drawable not to get set.

Bug: 207389002
Test: locally disable loading AdaptiveIcons, ensure BubbleTextView
      drawable always gets drawn for closing animation

Change-Id: Ifdbf3e733e27918c57a5e9b23e5a11b65f8f338c
2022-02-14 14:43:32 -08:00
Xin Li 11a0454879 Merge SP2A.220305.012
Bug: 219523960
Merged-In: I51cb81718a489ad7568c5e05ace0b3dbc6ca5443
Change-Id: Icf0cc432ab3a97614b27efcf6fc9d18ea423a743
2022-02-14 20:06:39 +00:00
Brian Isganitis 099945b075 Add predictions row to taskbar all apps.
- We need to listen to DeviceProfile changes in case the number of
  columns changes in the grid. I made an interface/mixin separate from
  ActivityContext to avoid polutting the latter with too many things. I
  also applied this change to existing taskbar A-Z grid.
- Added all apps visited count to onboarding preferences for only
  showing "All Apps" label in place of divider 20 times. Label is also
  tracked on taskbar side and should be kept in sync.

Test: Manual
Fix: 216843395
Bug: 174174514
Change-Id: I97aa91397c334123626caf18251f19e17c7104fb
2022-02-14 11:24:16 -08:00
Alex Chau 8c3cb4e324 Merge "Fix restore not migrating to new grid" 2022-02-14 18:57:47 +00:00
TreeHugger Robot 4bbfcbd337 Merge "Not postponing expecting Pilfer when swiping to overview." 2022-02-14 18:35:20 +00:00
Xin Li 52bbb8d1ba [automerger skipped] Merge sc-v2-dev-plus-aosp-without-vendor@8084891 am: bbd9e79bf2 -s ours am: 75cf4399c8 -s ours
am skip reason: Merged-In Iec90538bf8dd18fede035d7f548a71b757d2356c with SHA-1 88c671ee71 is already in history

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16845246

Change-Id: I2b7748f05b6ef762d4b16a7646d610caaa01f607
2022-02-14 18:20:51 +00:00
Xin Li 75cf4399c8 [automerger skipped] Merge sc-v2-dev-plus-aosp-without-vendor@8084891 am: bbd9e79bf2 -s ours
am skip reason: Merged-In Iec90538bf8dd18fede035d7f548a71b757d2356c with SHA-1 88c671ee71 is already in history

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16845246

Change-Id: I37bb26275648a1835ef15bfb2b9175c60df6e504
2022-02-14 18:03:27 +00:00
TreeHugger Robot bf96683e46 Merge "Fix taskbar hotseat alignment" 2022-02-14 13:03:46 +00:00
Alex Chau bf63e9cf2b Merge "Add debug logs for testPromiseIcon_addedFromEligibleSession" 2022-02-14 11:38:57 +00:00
Tom Natan 7823e8b5b6 Merge "[11/n] Letterbox Education: set LAUNCHER_TASKBAR_EDUCATION_SHOWING." 2022-02-13 12:20:57 +00:00
Tony Wickham 1c51edcef3 Merge "Only show unstash feedforward hint when long press will unstash" 2022-02-12 20:22:38 +00:00