Commit Graph

47938 Commits

Author SHA1 Message Date
Tony Wickham 9b2b607a09 Fix taskbar hotseat alignment
- Use hotseatBorderSpace instead of cellLayoutBorderSpace
- Also divide by 2f instead of 2 because AS was complaining. May or may not potentially address off by 1 pixel issues.

Test: locally set alignment = 1, ensure perfectly aligned
Fixes: 218880076
Change-Id: Ifec30e6727f62985427b65b6c0b0810e7f7cd695
2022-02-12 19:23:23 +00:00
vadimt 2dd23a0466 Not postponing expecting Pilfer when swiping to overview.
TAPL was expecting pilfer upon UP in the swipe-pause-to-overview gesture.
Actual Pilfer happens earlier, which resulted in wrong sequence-mismatch diags if the gesture fails before UP.
Now expecting Pilfer earlier.

Also fixing a problem that sneaked through earlier reviews when even down time was passed incorrectly.

Bug: 187761685
Test: presubmit
Change-Id: If4289a011247bf7801405ecaac8befa8461e8a37
2022-02-12 01:57:13 +00:00
Thiru Ramasamy 5ed87e4c96 Populate search attributes only if the atom's has DeviceSearchResultContainer.
Bug: 199495917, 218973952
Test: https://android-build.googleplex.com/builds/abtd/run/L37100000953023420
Change-Id: I355b4ec0806755f6c72d59b04555b970ca1578f5
2022-02-12 00:57:33 +00:00
Thiru Ramasamy 84a7fee8af Reverting the change that causes test breakage
Bug: 218973952
Test: wwdebug && wwlogcat
Change-Id: I494608ba3df31e9129dc47fc016a7e077e506165
2022-02-11 11:03:09 -08:00
Alex Chau 29a96adaab Fix restore not migrating to new grid
- In reinitializeAfterRestore, use db path instead of grid name to check if migration is necessary, so migration will still happen if grid names are renamed. Also, only remove the target db path instead of all non source db paths, which are not necessary to be removed.
- In LauncherBackupAgent, remove old files before restoring to avoid old files from overriding restored files e.g. grid name in shared preferences
- Make sure InvariantDeviceProfile is intialize before we set pending to false, so unsupported grids can still be initialized and then be migratead
- Renamed 6x5 grid so it no longer collides with 4x4

Fix: 218500583
Test: Restore backup from supported and unsupported grids
Change-Id: Ic78e0bc7dc44ad86bd217c736b88708ad488ac0b
2022-02-11 18:15:06 +00:00
Alex Chau bf57c15750 Merge "Avoid AllApps bottom sheet from being and add collapse handle" 2022-02-11 11:07:25 +00:00
tomnatan 9f12373bdd [11/n] Letterbox Education: set LAUNCHER_TASKBAR_EDUCATION_SHOWING.
The setting is set to 1 if the taskbar education should be shown as soon as the animation for opening an app starts and is set back to 0 when the taskbar education window is detached from the window.

Bug: 214590804
Test: N/A
Change-Id: Id26e3051a6e0ef1f9c2dcbeef98710efbb4df54f
2022-02-11 10:28:51 +00:00
Xin Li bbd9e79bf2 Merge sc-v2-dev-plus-aosp-without-vendor@8084891
Bug: 214455710
Merged-In: Iec90538bf8dd18fede035d7f548a71b757d2356c
Change-Id: Icfcc0dcab0a30472a6faff67e67e364386b98d41
2022-02-11 07:28:32 +00:00
Riddle Hsu adfdfd8868 Merge "Set launch source info for shell recents animation" 2022-02-11 06:33:18 +00:00
Jeremy Sim b84462a6b4 Merge "Fix DWB placement in grouped task view" 2022-02-11 06:22:40 +00:00
TreeHugger Robot b82a517fee Merge "Adding ripple effect to the "All Apps tab" buttons." into sc-v2-dev am: 3ba95852f3 am: 5cf55827da
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16359044

Change-Id: I043288685528d6430f38b93e19e468069071a503
2022-02-11 02:45:13 +00:00
TreeHugger Robot 5cf55827da Merge "Adding ripple effect to the "All Apps tab" buttons." into sc-v2-dev am: 3ba95852f3
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16359044

Change-Id: I01ee5a75a82798c002798d91538ecee0d455277b
2022-02-11 02:25:05 +00:00
TreeHugger Robot 3ba95852f3 Merge "Adding ripple effect to the "All Apps tab" buttons." into sc-v2-dev 2022-02-11 02:11:50 +00:00
Jon Miranda 701774d021 Add debug logs for testPromiseIcon_addedFromEligibleSession
Bug: 202985412
Test: PromiseIconUiTest
Change-Id: I160b9229bebe07015575f8184ac2d53bcbf2bad0
2022-02-10 17:26:11 -08:00
Tony Wickham 31a4c539d0 Only show unstash feedforward hint when long press will unstash
Test: Long press to unstash while in an app still works and shows feedforward; long pressing handle while in overview, all apps, or when IME is showing doesn't show anything.
Fixes: 218902248
Change-Id: I2c96570cab018c0e63c446793b84b210964bdb94
2022-02-11 00:29:56 +00:00
Evan Rosky 693f4e78bb Switch pip to fixed-rotation in shell transitions
Pip fixed-rotation should also be active when shell-transitions
is using fixed-rotation.

Bug: 217560545
Test: enter landscape pippable, enter pip (eg. via swipe-to-home)
Change-Id: I9bfbc1efc230a94dd9a480195e3a6ddf712ab353
2022-02-10 16:16:12 -08:00
Jeremy Sim c78ac6277c Fix DWB placement in grouped task view
In grouped task view, DWB banners will now rotate properly when phone is
in landscape or seascape orientation. Also fixes a couple of minor
existing issues with the bottom task not displaying correctly in the
first place.

Fixes: 208357326
Fixes: 216218406

Test: Tested locally on Pixel 6, using landscape, seascape, and
portrait. Double-checked with task proportions changed, RtL/LtR, and
split top/split left/split right initialization.

Change-Id: I945f9937d2d4d784c0c74a006c7d0680daf628c2
2022-02-11 00:13:13 +00:00
Thiru Ramasamy 70f3f86702 Merge "Populate LauncherUiChanged.search_attributes field." 2022-02-10 23:35:49 +00:00
Daniel Chapin 65fc27d5cb Merge "Work folder name is only fetched from activity, not ActivityContext" 2022-02-10 22:23:17 +00:00
Alex Chau fb54cf54e3 Avoid AllApps bottom sheet from being and add collapse handle
- Instead of using top margin, use top padding instead
- Add a separate LinearView for the bottom sheet background
- Added a handle to bottom sheet background that handle touches

Bug: 208599118
Test: phone, tablet and taskbar
Change-Id: Id8d3cb5ee6c58193926e2cf5ea7b0cb2280098be
2022-02-10 20:03:56 +00:00
Evan Rosky 19f7d988d1 Merge "Use fixed-rotation by default for shell transitions" 2022-02-10 19:51:45 +00:00
thiruram 103ccf1d87 Populate LauncherUiChanged.search_attributes field.
Test: Manual
Bug: 199495917
Change-Id: I9a7f9696d44b5b2af8d11e7f537b5c4ed78db060
2022-02-10 08:29:39 -08:00
Riddle Hsu 53e864d118 Set launch source info for shell recents animation
In legacy animation, it was set in RecentsAnimation
#startRecentsActivity. Now because shell transition use
startActivity, it can be set directly to the options.

Bug: 218847872
Test: adb shell setprop persist.debug.shell_transit 1; reboot
      Enable statsd log: "adb shell cmd stats print-logs"
      Swipe up gesture navigation bar from an app.
      adb logcat | grep statsd | grep "(48)"
      The line may contain 0x100000->4[I] 0x110000->20[I]
      that means 4=by recents and 20=latency 20ms.
Change-Id: Ia7bef23f8dc6cbf371cd1cdfb42f1f68d88d0787
2022-02-11 00:08:27 +08:00
Vinit Nayak 25e61b2606 [automerge] Add null check for null task in getItemInfo() 2p: 73c6288038
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16828919

Change-Id: I205452840d664917ad1b61d3daec717f211a8ef2
2022-02-10 00:01:19 +00:00
Vinit Nayak 73c6288038 Add null check for null task in getItemInfo()
* Pass back an empty WorkspaceItemInfo with correct
itemType set on it so at least it can be identified
if remaining fields are missing.

Fixes: 218625473
Test: Wasn't able to repro crash
Change-Id: If20d8fa648edf6c210ad5398905bf78e173b23a1
2022-02-09 15:59:13 -08:00
Vinit Nayak 5c6173a8b9 [automerge] Add null check for mRemoteTargetHandles for side task launch 2p: 90e0fe3923
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16828915

Change-Id: I8d41d76a5178c15beca5028291fc0a314a580de3
2022-02-09 23:31:57 +00:00
Vinit Nayak 90e0fe3923 Add null check for mRemoteTargetHandles for side task launch
* Other checks haven't changed, only pulled them out into
separate block

Fixes: 215699962
Test: Unable to repro the crash, I tried ending the
activity and starting via adb shell, but I was never
able to get into the original if-block that triggered the NPE

Change-Id: I83320634f1d059de610176f9031682ca287bd589
2022-02-09 15:30:19 -08:00
Winson Chung 6992855742 Merge "Add basic return animation when drag is canceled" 2022-02-09 19:32:22 +00:00
Winson Chung d937831791 Add basic return animation when drag is canceled
Bug: 179390870
Test: Drag, but don't drop to split an app from the taskbar and
      check that Launcher animates the surface back into place
Change-Id: I726855ff5bdffd1fc58d2839b3cc44b3fdb131e9
2022-02-09 06:44:21 +00:00
TreeHugger Robot e8b200eb6b Merge "Fix NPE when mRecentsView is null" 2022-02-09 05:04:57 +00:00
Jon Miranda 32319bf166 Merge "Move All Apps button to the left in RTL." 2022-02-09 01:55:36 +00:00
TreeHugger Robot fb1e592020 Merge "Prediction icons in Taskbar were updating when dragging icon in the same place" 2022-02-08 19:54:08 +00:00
Hyunyoung Song 57810aefa4 Work folder name is only fetched from activity, not ActivityContext
Bug: 217872881
Test: builds
Change-Id: I36bc9c386772c20fce2d10bf1bfaad565046d38f
2022-02-08 10:25:21 -08:00
Kholoud Mohamed 6974d39a44 Merge "Expose action that allows landing on the work tab" 2022-02-08 17:12:18 +00:00
Yohei Yukawa 697ae451d4 Use config_imeDrawsImeNavBar in Launcher
With this CL, the Launcher starts checking

  config_imeDrawsImeNavBar [1]

instead of

  config_navBarInteractionMode

when determining whether the IME should render the back and IME
switcher buttons or not.

There should be no observable behavior change as long as

  config_navBarInteractionMode

is set to true when the gestural navigation is enabled.

Bug: 216118048
Test: presubmit
Change-Id: Ia8269e240e0b18e1c7b8bd550dbb197ad58a6dbc
2022-02-08 07:47:29 -08:00
Alex Chau 449cd7226d Merge "Use less steps for home gesture" 2022-02-08 10:51:38 +00:00
Tony Wickham b1c3f88185 Fix NPE when mRecentsView is null
The NPE was in an unused variable, so also address the TODO to use it as log rank.

Test: wwdebug, wwlogcat, quickswitch and check rank field
Fixes: 218216440
Change-Id: I173ae607e9f73e58880c0fb1b6e8f2352469816f
2022-02-08 00:35:43 +00:00
Jon Miranda daa3150b9c Move All Apps button to the left in RTL.
Bug: 205803230
Test: verify LTR
      force RTL using developer option
      verify All Apps button is in the left
      verify All Apps button moves left before fading out

Change-Id: I2a5be9b37f471bfaa1a92f6819e04274e4dfb7a1
2022-02-07 14:08:47 -08:00
Thiru Ramasamy 40570799b3 Merge changes from topic "SuggestedResultAttribute"
* changes:
  [OneSearch] Add direct_match to SearchAttributes.
  [OneSearch] Deprecate CorrectedDeviceSearchResultContainer with SearchAttributes.
2022-02-07 20:36:38 +00:00
Sebastian Franco 5a6e08c3cd Prediction icons in Taskbar were updating when dragging icon in the same place
When dragging an icon in the Taskbar and dropping
it in the same spot it triggers new predictions when
it shouldn't. Basically, it was thinking that the icon
was moved outside of the taskbar which should trigger
new predictions. To fix it, it simply required to change
the order of the events, sending the UNPIN event before
the PIN event.

Bug: 202922907
Test: Have at least two prediction icons in the Taskbar, drag an app icon in the Taskbar, and drop it in the same place the prediction icon shouldn't change
Change-Id: I6079ff6eb69d7b1cb3c22bebc84511c0abd61cec
2022-02-07 19:10:55 +00:00
kholoud mohamed ceec31b17c Expose action that allows landing on the work tab
Bug: 217385869
Bug: 203531272
Test: manual
Change-Id: I68a6add9f603105e0a2ee01ebdc3059e18c9a050
2022-02-07 18:53:49 +00:00
Thiru Ramasamy c33c574698 [OneSearch] Add direct_match to SearchAttributes.
Captures if user acted on a search result that is not directly matched with search query, but instead related/suggested result.

Bug: 199495917
Test: Manual - http://gpaste/5167163338915840
Change-Id: Ib38244b1a82c502f551e8eb24dd14c14d8b375f2
2022-02-07 09:35:42 -08:00
Winson Chung b4bbec80b8 Merge "Prevent lingering divider animators in AbsSwipeUpHandler" 2022-02-07 17:09:49 +00:00
TreeHugger Robot 31abf9b014 Merge "Enable split from workspace / all apps" 2022-02-07 06:43:21 +00:00
Winson Chung 26031b0dd2 Prevent lingering divider animators in AbsSwipeUpHandler
- Refactor the util method to create the animator and track the existing
  animation in AbsSwipeUpHandler to be able to cancel it if another call
  to change the visbility comes in.  Note that this doesn't address
  the case where the launch animation overlaps with swipe up (though that
  hopefully shouldn't happen in normal usage)

Bug: 213403679
Test: Tap in the gesture space while split
Change-Id: I078a7d0f22c2ef2ba847796ec79e740c789ce1ae
2022-02-05 04:55:52 +00:00
TreeHugger Robot e3dea3458e Merge "Adds ENABLE_FLOATING_SEARCH_BOX flag for All Apps." 2022-02-05 04:41:43 +00:00
TreeHugger Robot b607781dbd Merge "Add tracking for widget creation" 2022-02-05 04:21:01 +00:00
Tracy Zhou 963c4b064f Enable split from workspace / all apps
Bug: 216829535
Test: N/A
Change-Id: I19deeebf2ced6b55f2af3d20fa2fd9f7d006453d
2022-02-04 14:28:03 -08:00
Thiru Ramasamy 441461c95c [OneSearch] Deprecate CorrectedDeviceSearchResultContainer with SearchAttributes.
Loggin query_corrected signal as field is more scalable than separate CorrectedDeviceSearchResultContainer for future usecases.

Test: Manual - http://gpaste/6343087535161344
Bug: 199495917
Change-Id: I6b3a410f4d977db2a058f337d1684f78763acbd2
2022-02-04 11:51:59 -08:00
Thiru Ramasamy 529fa34650 Merge "[OneSearch] Extract logging event for all apps entry into separate method." 2022-02-04 19:21:16 +00:00