Commit Graph

47938 Commits

Author SHA1 Message Date
Luca Zuccarini 5c65febbb6 Ensure that the Hotseat respects the margins of the QSB.
Before this change they were ignored by onMeasure(), so that the QSB
couldn't rely on margins for its positioning.

Bug: 217477426
Test: manual
Change-Id: Ifecd3d40ea584273b7857d19b25a90dbafe1c656
(cherry picked from commit 410c75a442)
2022-02-25 17:00:07 +00:00
Alex Chau 890e4a75c3 Dump DeviceProfile in TouchInteractionService dumpsys
- So DeviceProfile dumpsys will be available in bugreports, useful for debugging
- Only dump DeviceProfile in createdOverviewActivity if it's non-null

Fix: 221395133
Test: adb shell dumpsys activity service com.google.android.apps.nexuslauncher/com.android.quickstep.TouchInteractionService
Change-Id: Iaf7b7abd25771814be6cb918e96e042d1085debb
2022-02-25 12:46:27 +00:00
Nicolo' Mazzucato d986bbd0fa Register hinge angle sensor listener in a background thread
This was taking ~13ms on the ui thread

Bug: 221394115
Test: Manual
Change-Id: Ibadade5b1c3c8d33a292d36bb6a03dd8021861be
2022-02-25 12:37:44 +01:00
Winson Chung e479619836 Just return an empty list if the system returns null
Bug: 206648922
Test: Presubmit (unable to reproduce this)
Change-Id: I04a4759a1c237513ab314ece4acd542e1407edb1
2022-02-25 06:41:45 +00:00
TreeHugger Robot 2a431f4a79 Merge "Passing in the launch cookie for widget broadcast trampolines" into tm-dev 2022-02-25 00:21:27 +00:00
Adam Cohen f2f302bcf6 Fix DnD logic for determining current drag screen / panel
=> we want to use the extremum of finger location and object
   center for snapping to a new screen (max when snapping to right,
   min when snapping to left)
=> when selecting a panel within the current screen, we want to
   rely strictly on the object center to determine selection; there
   is plenty of space to be consistent here, and extremum logic
   could cause thrashing back and forth with no page movement.

Test: Manual. See videos in b/221104663. On two-panel and one-panel
      test dragging a widget between different screens with
      different starting positions of where the widget goes down.

Bug 221104663

Change-Id: I8f0f13f07b753752087a90c4bacb76cfbf7aa5bf
2022-02-24 16:13:12 -08:00
Winson Chung 78166e9337 Merge "1b/ Replace removed shared lib calls with direct calls" into tm-dev 2022-02-24 23:45:39 +00:00
Hyunyoung Song d68872426c Change the all apps atomic transition duration to 150 ms
Test: manual

TL;DR;; this value is used for tap on qsb all apps container
atomic transition. 320 is value that used to be used in R
when all apps travel distance used to be entire window height.
In S, we reduced the travel distance to 1/3 of the height.

Change-Id: Ib66f8a4408fd77350c31c5b894d9f8b2c889159f
2022-02-24 20:33:23 +00:00
Vadim Tryshev 2107f059cb Merge "Preparing to using "platform-test-rules" library from Launcher tests" into tm-dev 2022-02-24 20:10:00 +00:00
Sunny Goyal e2d9dde4b7 [automerge] Removing unnecessary AM.getTasks() call on every touch 2p: 8e5a164e05 am: c6aadf8a74
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17005155

Change-Id: I60a003fb87f5788576104fc43c65c33ed4146865
2022-02-24 19:53:56 +00:00
Sebastian Franco 5a9dce518e Combining the Thumbnail bitmap with the background to fix background spilling in the front.
What's happening is that we first draw a background,
on top of it, we then draw the Task and because we
have a curvature the corners have pixels with transparency,
and those pixels get combined with the background pixels.
Most tasks have a transparent background or background
of the same color as the task so we don't see this
but for example, Telegram has a white background and
you can see this in the corners.

Fixed by creating a bitmap, drawing the background on it
and then drawing the thumbnail on top of it then using
that bitmap to draw it on the canvas.

Test: Put Telegram in recent Task (shouldn't be the first one) and you won't see a white border. Also when a task was in multitask the backgroudn should be draw.
Fix: 146521490
Change-Id: Id02a64ef472eb07900b0c7c5522d931d5b08f94e
2022-02-24 19:11:55 +00:00
Winson Chung 871759483b 1b/ Replace removed shared lib calls with direct calls
Bug: 219861883
Test: Builds
Change-Id: I7831d0de14286c9fa39fed59b168535e0a70d94d
2022-02-24 18:04:02 +00:00
Sunny Goyal c6aadf8a74 [automerge] Removing unnecessary AM.getTasks() call on every touch 2p: 8e5a164e05
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17005155

Bug: 220906427
Change-Id: Iedf1d7086d1f9ee1ae167f2a975612de9c84521c
2022-02-24 17:41:01 +00:00
Sunny Goyal 8e5a164e05 Removing unnecessary AM.getTasks() call on every touch
Bug: 220906427
Test: Verified on device
Change-Id: I58ed22c4d6069f10198ec30ec02fa8c2f7c55cbe
(cherry picked from commit d2ec834fac)
2022-02-24 17:40:54 +00:00
Nicolo' Mazzucato 5a0a17f119 Fix scaling of workspace and hotseat with wrong pivots
Bug: 219962098
Test: Unfolded device
Change-Id: I7dd9f0579ea737cd67792e612657a043411ac70e
2022-02-24 17:53:40 +01:00
Bill Yi 3159d7759f [automerger skipped] [automerged blank] Import translations. DO NOT MERGE ANYWHERE 2p: a2ba15674c am: 0189c940d0 -s ours
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16939770

Change-Id: Ia367dc93a11aa301cac6ce1e137e9582c5bcc7ba
2022-02-24 13:52:40 +00:00
Alex Chau 21c63bc809 Merge "No longer stash taskbar when swiping up all apps" into tm-dev 2022-02-24 11:59:57 +00:00
Alex Chau 1c01af74c6 Merge "Fix incorrect accessibility announcement on two panel home" into tm-dev 2022-02-24 11:51:59 +00:00
Mady Mellor 57eab45996 Merge "Add a reason to the broadcast to collapse system dialogs" into tm-dev 2022-02-24 01:30:11 +00:00
TreeHugger Robot 582ab494dc Merge "Use color tokens for all apps entry buttons." into tm-dev 2022-02-24 00:07:47 +00:00
TreeHugger Robot dde28b487e Merge "Removing unnecessary AM.getTasks() call on every touch" into tm-dev 2022-02-23 23:38:14 +00:00
Andras Kloczl 2dacbee028 Fix incorrect accessibility announcement on two panel home
- Divide total pages by panelCount if two panel is active
- Increment target column when moving an item to right panel

Test: manual
Bug: 200009004
Change-Id: Ia8d2d760dc5e8b413e5b1150c049f7fa3ec26513
2022-02-23 22:35:12 +00:00
Tony Wickham 4fda59a0cc No longer stash taskbar when swiping up all apps
Instead, scale down hotseat behind all apps alongside workspace.

Test: Swipe up to all apps from home; all apps button in an app works as before
Fixes: 221094533
Change-Id: Ia6f1e7bac86849018dc8d0b1d95f0bab963835a8
2022-02-23 22:04:35 +00:00
Sunny Goyal d2ec834fac Removing unnecessary AM.getTasks() call on every touch
Bug: 220906427
Test: Verified on device
Change-Id: I58ed22c4d6069f10198ec30ec02fa8c2f7c55cbe
2022-02-23 13:35:25 -08:00
Sunny Goyal d4c4ad9212 Removing some unnecessary layout calls in TaskView
Bug: 221095750
Test: Presubmit
Change-Id: I277c1350109ce3bd0b29502c588482c737ab1e3d
2022-02-23 13:06:46 -08:00
TreeHugger Robot c089baa668 Merge "Remove Taskbar and Taskbar EDU flags." into tm-dev 2022-02-23 20:10:02 +00:00
Jon Miranda 48a2f7a0ac Use color tokens for all apps entry buttons.
Bug: 220356537
Bug: 205803230
Test: manual, dark mode, light mode
Change-Id: I0973d5aa9ab1ccbdcc78c1e411cbbf63953f2f94
2022-02-23 19:47:33 +00:00
Alex Chau d8f81e9bf4 Merge changes from topic "allapps_bottomsheet_motion" into tm-dev
* changes:
  Tune AllApps bottom sheet VisD and motion
  Put taskbar all apps in separate overlay window and stash taskbar.
2022-02-23 19:11:51 +00:00
Vinit Nayak 58c27cce73 Remove Taskbar and Taskbar EDU flags.
Bug: 219035565
Change-Id: I643b5d006b5759723418901ffeb463fa04a82cbc
(cherry picked from commit ec4adc1d5a)
2022-02-23 18:14:28 +00:00
Thales Lima bfb275bf21 Merge "Create new logic for grid migration" into tm-dev 2022-02-23 18:07:06 +00:00
Alex Chau b8c22e1155 Tune AllApps bottom sheet VisD and motion
- Make AllApps bottom sheet solid and appears from bottom
- Teleport AllApps bottom sheet as user drag to reduce drag range
  - Consider teleport interpolation for state transition sdetection
- Tuned workspace motions for AllApps bottom sheet (no translate, shrink)
- Add portrait vertical translate for tablet portrait including taskbar AllApps
- Updated bottom sheet handle and created common variables for other bottom sheets

Bug: 208599118
Test: manual on tablet AllApps, taskbar Allapps and handheld AllApps
Change-Id: I69dba5f155914cd012cc8ef3be1ef71fb2be5a40
2022-02-23 17:08:06 +00:00
Thales Lima 0a7ff8780f Create new logic for grid migration
Fixes 217564863
Test: manual, changing grids from Wallpaper & Style and checking against spec

Change-Id: I94cf77111b37810282527f1a212b6e4126d3eba1
2022-02-23 15:20:50 +00:00
Brian Isganitis a1370bfc5f Put taskbar all apps in separate overlay window and stash taskbar.
All apps should display below system UI components such as the
notification tray and power menu, so an overlay window is more
appropriate. As a result, all apps has a separate window activity
context, but some properties are delegated to the taskbar activity
context. Taskbar should also be stashed while all apps is open.

Change-Id: I593457708779d84a0ab8b949a966d247d0a2e1b7
Test: Manual
Bug: 216843189
Fix: 217383817
(cherry picked from commit 473b980bf9)
2022-02-23 15:06:56 +00:00
TreeHugger Robot 0f3b6511aa Merge "Fix Launcher icons not animated during unfold" into tm-dev 2022-02-23 14:03:39 +00:00
Alex Chau 82166fa6d8 Merge "Disable flakey fallback recents test" into tm-dev 2022-02-23 10:58:26 +00:00
wilsonshih a8fe8b448e Cancel recents animation when touch home key(2/2)
There should send an opening task transition to remote transition
handler to finish the recents animation. For now there is no opening
transition send to Shell because the exist home activity won't be
collected while start home activity.

To collect the home activity, do not set transient launch when start
recents animation if the top activity is home, so the home activity
would be paused. Then when user touch home key to cancel recents, the
home activity will be resumed so it can be collect to the transition.

When receive opening home activity while recents is running, enter
home and dismiss recents.

Bug: 207297486
Test: 1. Enable shell transition.
      2. Setup 3rd-party launcher as default home.
      3. Entering Recents from home.
      4. "adb shell input keyevent KEYCODE_HOME", verify recents
	 animation will be dismissed.
Test: atest NexusLauncherTests:com.android.quickstep.FallbackRecentsTest
Change-Id: I689032d1fa18aa9a923aaf89077dbd73c09721b7
2022-02-23 16:07:59 +08:00
Winson Chung 4c2e3310e6 Disable flakey fallback recents test
- Seems to be an existing failure in the recents animation not
  finishing, should disable to unblock folks

Bug: 218403080
Test: Presubmit
Change-Id: Ia42009666c67c29c1a78a2fe197bdce53dcb2ec8
2022-02-23 06:44:55 +00:00
TreeHugger Robot 49cb99a420 Merge "Fix jump in animation for hotseat while re-arranging icons" into tm-dev 2022-02-23 02:40:11 +00:00
Mady Mellor 411e862175 Add a reason to the broadcast to collapse system dialogs
Test: manual - see other CL in topic
Bug: 218517365
Change-Id: I9aa686bb95f11b4eeab0139833876abaf8b80cad
2022-02-22 14:14:34 -08:00
vadimt 13839e4cc6 Preparing to using "platform-test-rules" library from Launcher tests
I want to include some stuff (like android.platform.test.rule.CrashDetector) but I want to land just the dependency part and see if I get postsubmit build problems that sometimes appear in obscure AOSP targets.

Test: presubmit
Bug: 187761685
Change-Id: I334b9f1029edbe8621df940900f43d0c5059373e
Merged-In: I334b9f1029edbe8621df940900f43d0c5059373e
2022-02-22 21:39:35 +00:00
Schneider Victor-tulias 2763365eb6 Fix icon loading null pointer.
Filtering out icon itemInfos with null component names when loading icons in bulk

Test: manual
Fixes: 220380324
Fixes: 220345439
Change-Id: I0e6f9ae0a363d17497207c92eadcac64ca42693f
(cherry picked from commit 5597e4825d)
2022-02-22 18:38:07 +00:00
TreeHugger Robot 66ac96cd63 Merge "Fix crash when loading string cache" into tm-dev 2022-02-22 17:29:08 +00:00
Nicolo' Mazzucato 5765d42ada Fix jump in animation for hotseat while re-arranging icons
While re-arranging icons the hotseat remains in scale 1.0f, while the workspace reduces it's scale (as defined by SpringLoadedState.java). Previously, the code to aggregate animations was assuming hotseat and workspace always had the same scale.

MultiScaleProperty.get() was being used to set the starting value of the animation. Previously, it was returning the last aggregated value. However, this value was correct only for the workspace, but not for the hotseat. Returning the current view scale makes it always correct.

Bug: 220271046
Test: Dragged icons from hotseat to workspace, and verified animation didn't jump
Change-Id: Ic01776c1d8e3967624626ed7c44d194a06295790
2022-02-22 18:27:26 +01:00
Nicolo' Mazzucato d4a5bb244a Fix Launcher icons not animated during unfold
If icons are re-bound during the animation, they were not moved. I was able to reproduce this case 100% of times by folding, restarting launcher and unfolding. From a perfetto trace it seems that in this case `finishBindingItems` was called after the animation already started, therefore not registering any view.

With this cl, items are animated also after they are rebound.

Bug: 197834977
Test: folded -> restarted launcher -> unfolded -> verified icons are now moving towards the center
Change-Id: I5b001c502860c17d6ea5d54d099f04b2ddf1820a
2022-02-22 13:48:35 +01:00
Jordan Demeulenaere 78ef3a5348 Enable back gesture when a SyUI dialog is showing (2/2)
Test: Manual
Bug: 210270549
Change-Id: I8fbf9a90287cbd8d9ddad354e24bbc4d074bd0ef
2022-02-22 11:09:03 +01:00
Ming-Shin Lu cb60b65bc0 [ShellTransition]: invoke WMS#setRecentsAppBehindSystemBars to WM
With enabling shell-transition, in case of seeing status bar icon
blinking when hammer tapping on the navigation bar to trigger recents
animation quickly as CL[1] mentioned,

As the result, Launcher side still need to callback recents app
behind system bar status to signal WM if launcher should affect
system bar appearance with [1] introduced method
setRecentsAppBehindSystemBars.

Bug: 215504556
Test: manual as below steps
  1) Launching a app
  2) Hammer tapping on the navigation bar
  3) Expect the staus bar icon won't blinking

Change-Id: I4b41e06e559168a61a29fa6ea9f58b834a7f1a1c
2022-02-22 05:54:41 +00:00
Presubmit Automerger Backend a6118187c2 [automerge] Passing in the launch cookie for widget broadcast trampolines 2p: c519538bca
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16968688


Change-Id: I233643ee87042f59a104848d5b6e38a6ac3fa3a2
Merged-In: Ibfe9e5232317837f3111459212a4b016b5828ef4
2022-02-21 23:08:06 +00:00
Selim Cinek c519538bca Passing in the launch cookie for widget broadcast trampolines
The launch cookie can now be transfered via the broadcast

Fixes: 220290671
Test: add Photos widget, return properly to widget
Merged-In: Ibfe9e5232317837f3111459212a4b016b5828ef4
Change-Id: Ibfe9e5232317837f3111459212a4b016b5828ef4
2022-02-21 23:07:57 +00:00
Selim Cinek 46c8678447 Passing in the launch cookie for widget broadcast trampolines
The launch cookie can now be transfered via the broadcast

Fixes: 220290671
Test: add Photos widget, return properly to widget
Change-Id: Ibfe9e5232317837f3111459212a4b016b5828ef4
2022-02-21 11:42:09 +00:00
kholoud mohamed 9b38947b32 Fix crash when loading string cache
Crash was caused by a null context in ModelDelegate

Fixes: 218305827
Test: manual
Change-Id: I1b046e24427dbdc6752ac100f488c428838ac31f
2022-02-21 11:29:24 +00:00