Add NULL pointer checker (bug found with scan-build).

only need to deal with ascii.

.gitignore

@@ -1,45 +1,38 @@
-*~
+*.a
 *.bak
+*.core
+*.diff
+*.gmo
+*.header
+*.in
+*.la
+*.lo
 *.o
 *.out
-*.a
-*.gmo
-*.lo
-*.la
-*.core
+*.patch
+*.pot
 *.s
+*.sed
+*.sin
 *.stamp
-.libs
+*.swp
+*~
 .deps
-Makefile
-Makefile.in
-src/daemon/libgtop_daemon2
-src/daemon/libgtop_server2
-stamp-h1
-po/stamp-it
-po/POTFILES
-po/Makefile.in.in
-missing
-m4/
-ltmain.sh
-libtool
-libgtopconfig.h
-libgtop.spec
-libgtop-2.0.pc
-lib/lib.c
-lib/GTop-2.0.gir
-lib/GTop-2.0.typelib
+.libs
+ABOUT-NLS
 INSTALL
+Makefile
+Makevars.template
+Rules-quot
 aclocal.m4
 autom4te.cache/
+compile
 config.guess
 config.h
-config.h.in
 config.log
 config.status
 config.sub
 configure
-compile
 depcomp
 doc/libgtop2.info
 doc/mdate-sh
@@ -79,3 +72,20 @@ examples/timings
 examples/wd
 gtk-doc.make
 install-sh
+lib/GTop-2.0.gir
+lib/GTop-2.0.typelib
+lib/lib.c
+libgtop-2.0.pc
+libgtop.spec
+libgtopconfig.h
+libtool
+ltmain.sh
+m4/
+missing
+po/POTFILES
+po/stamp-it
+src/daemon/libgtop_daemon2
+src/daemon/libgtop_server2
+stamp-h1
+stamp-po
+tmp-*

NEWS

@@ -1,3 +1,25 @@
+20 March 2017: Overview of changes in 2.36.0
+================================================
+
+* Version bumped
+
+13 March 2017: Overview of changes in 2.35.92
+================================================
+
+* Better output format for arrays
+
+13 February 2017: Overview of changes in 2.35.90
+================================================
+
+* Linux:
+  - Use dynamically allocated cpu buffer
+  - Do not cache getpagesize()
+  - Use faster g_ascii_isspace in tokenization
+  - Ignore paragraphs not describing a CPU/core
+
+* Updated translations
+* Added more gettext options
+
 16 January 2017: Overview of changes in 2.34.2
 ================================================
 

configure.ac

@@ -3,8 +3,8 @@ dnl Configure script for the Gnome library
 dnl
 
 m4_define([libgtop_major_version], [2])
-m4_define([libgtop_minor_version], [34])
-m4_define([libgtop_micro_version], [2])
+m4_define([libgtop_minor_version], [36])
+m4_define([libgtop_micro_version], [0])
 m4_define([libgtop_version], [libgtop_major_version.libgtop_minor_version.libgtop_micro_version])
 
 dnl  increment if the interface has additions, changes, removals.

examples/pprint.c

@@ -28,10 +28,11 @@
 	   (unsigned long) buf_offsetof(ARRAY),				\
 	   (unsigned long) G_N_ELEMENTS(buf.ARRAY));			\
     for (i = 0; i < (SIZE); ++i) {					\
-      printf(".%u = " FORMAT ", ", i, buf.ARRAY[i]);			\
       if (!buf.ARRAY[i] && i < (SIZE - 1) && !buf.ARRAY[i + 1]) {	\
 	do { i++; } while (i < SIZE && !buf.ARRAY[i]);			\
 	printf("..., ");						\
+      } else {								\
+	printf(".%u = " FORMAT ", ", i, buf.ARRAY[i]);			\
       }									\
     }									\
     printf("}\n");							\
@@ -39,12 +40,12 @@
 
 #define PPRINT_ENTRY_ARRAY(ARRAY, SIZE) do { \
 size_t i; \
-printf("\t%4lu B %3lu " #ARRAY "[%lu] = { ", \
-(unsigned long) sizeof buf->ARRAY, 0,\
+printf("\t%4lu B " #ARRAY "[%lu/%lu] = { \n", \
+(unsigned long) sizeof buf->ARRAY, (unsigned long)(SIZE),	\
 (unsigned long) G_N_ELEMENTS(buf->ARRAY)); \
 for(i = 0; i < SIZE; ++i) { \
   if (buf->ARRAY[i].values) {			\
-    printf ("[ ");				\
+    printf ("\t[ ");				\
     PPRINT_HASHTABLE(buf->ARRAY[i].values);	\
     printf ("]\n");				\
   }						\
@@ -70,8 +71,8 @@ static void pprint_get_sysinfo(void)
 
   HEADER_PPRINT(glibtop_get_sysinfo);
   //PPRINT(flags, "%#llx");
-  //PPRINT(ncpu, "%llu");
-  PPRINT_ENTRY_ARRAY(cpuinfo, 4);
+  // PPRINT(ncpu, "%llu");
+  PPRINT_ENTRY_ARRAY(cpuinfo, buf->ncpu);
   FOOTER_PPRINT();
 }
 

po/hr.po

@@ -4,191 +4,193 @@
 msgid ""
 msgstr ""
 "Project-Id-Version: libgtop 0\n"
-"Report-Msgid-Bugs-To: \n"
-"POT-Creation-Date: 2016-04-26 22:07+0000\n"
-"PO-Revision-Date: 2009-06-30 04:01+0000\n"
-"Last-Translator: Ante Karamatić <ante.karamatic@canonical.com>\n"
+"Report-Msgid-Bugs-To: https://bugzilla.gnome.org/enter_bug.cgi?"
+"product=libgtop&keywords=I18N+L10N&component=general\n"
+"POT-Creation-Date: 2017-04-07 11:26+0000\n"
+"PO-Revision-Date: 2017-04-11 19:07+0200\n"
+"Last-Translator: gogo <trebelnik2@gmail.com>\n"
 "Language-Team: Croatian <lokalizacija@linux.hr>\n"
+"Language: hr\n"
 "MIME-Version: 1.0\n"
 "Content-Type: text/plain; charset=UTF-8\n"
 "Content-Transfer-Encoding: 8bit\n"
-"Plural-Forms: nplurals=3; plural=n%10==1 && n%100!=11 ? 0 : n%10>=2 && "
-"n%10<=4 && (n%100<10 || n%100>=20) ? 1 : 2;\n"
+"Plural-Forms: nplurals=3; plural=n%10==1 && n%100!=11 ? 0 : n%10>=2 && n"
+"%10<=4 && (n%100<10 || n%100>=20) ? 1 : 2;\n"
 "X-Launchpad-Export-Date: 2016-09-15 11:39+0000\n"
-"X-Generator: Launchpad (build 18186)\n"
-"Language: hr\n"
+"X-Generator: Poedit 1.8.7.1\n"
 
-#: ../lib/read.c:49
+#: lib/read.c:49
 #, c-format
 msgid "read %d byte"
 msgid_plural "read %d bytes"
-msgstr[0] "čitaj %d byte"
-msgstr[1] "čitaj %d bytea"
-msgstr[2] "čitaj %d byteova"
+msgstr[0] "čitaj %d bajt"
+msgstr[1] "čitaj %d bajta"
+msgstr[2] "čitaj %d bajtova"
 
-#: ../lib/read_data.c:49
+#: lib/read_data.c:49
 msgid "read data size"
-msgstr "veličina pročitanih podataka"
+msgstr "veličina podataka čitanja"
 
-#: ../lib/read_data.c:66
+#: lib/read_data.c:66
 #, c-format
 msgid "read %lu byte of data"
 msgid_plural "read %lu bytes of data"
-msgstr[0] "čitaj %lu byte podataka"
-msgstr[1] "čitaj %lu bytea podataka"
-msgstr[2] "čitaj %lu byteova podataka"
+msgstr[0] "čitaj %lu bajt podataka"
+msgstr[1] "čitaj %lu bajta podataka"
+msgstr[2] "čitaj %lu bajta podataka"
 
-#: ../lib/write.c:49
+#: lib/write.c:49
 #, c-format
 msgid "wrote %d byte"
 msgid_plural "wrote %d bytes"
-msgstr[0] "zapisao %d byte"
-msgstr[1] "zapisao %d bytea"
-msgstr[2] "zapisao %d byteova"
+msgstr[0] "zapisan %d bajt"
+msgstr[1] "zapisano %d bajta"
+msgstr[2] "zapisano %d bajtova"
 
-#: ../src/daemon/gnuserv.c:456
+#: src/daemon/gnuserv.c:456
 msgid "Enable debugging"
-msgstr "Omogućavanje debugiranja"
+msgstr "Omogući otklanjanje grešaka"
 
-#: ../src/daemon/gnuserv.c:458
+#: src/daemon/gnuserv.c:458
 msgid "Enable verbose output"
-msgstr "Omogući opširni izlaz"
+msgstr "Omogući opširniji ispis"
 
-#: ../src/daemon/gnuserv.c:460
+#: src/daemon/gnuserv.c:460
 msgid "Don't fork into background"
-msgstr "Bez forkanja u pozadini"
+msgstr "Bez grananja u pozadini"
 
-#: ../src/daemon/gnuserv.c:462
+#: src/daemon/gnuserv.c:462
 msgid "Invoked from inetd"
 msgstr "Pozvano iz inetda"
 
-#: ../src/daemon/gnuserv.c:498
+#: src/daemon/gnuserv.c:498
 #, c-format
 msgid ""
 "Run '%s --help' to see a full list of available command line options.\n"
 msgstr ""
-"Pokrenite naredbu '%s --help' kako biste vidjeli popis dostupnih opcija.\n"
+"Pokrenite '%s --help' kako bi vidjeli potpun popis mogućnosti "
+"naredbenog redka.\n"
 
-#: ../sysdeps/osf1/siglist.c:27 ../sysdeps/sun4/siglist.c:27
+#: sysdeps/osf1/siglist.c:27 sysdeps/sun4/siglist.c:27
 msgid "Hangup"
-msgstr "Prekidanje veze"
+msgstr "Prekini vezu"
 
-#: ../sysdeps/osf1/siglist.c:28 ../sysdeps/sun4/siglist.c:28
+#: sysdeps/osf1/siglist.c:28 sysdeps/sun4/siglist.c:28
 msgid "Interrupt"
 msgstr "Prekid"
 
-#: ../sysdeps/osf1/siglist.c:29 ../sysdeps/sun4/siglist.c:29
+#: sysdeps/osf1/siglist.c:29 sysdeps/sun4/siglist.c:29
 msgid "Quit"
-msgstr "Izlaz"
+msgstr "Zatvori"
 
-#: ../sysdeps/osf1/siglist.c:30 ../sysdeps/sun4/siglist.c:30
+#: sysdeps/osf1/siglist.c:30 sysdeps/sun4/siglist.c:30
 msgid "Illegal instruction"
 msgstr "Nedopuštena instrukcija"
 
-#: ../sysdeps/osf1/siglist.c:31 ../sysdeps/sun4/siglist.c:31
+#: sysdeps/osf1/siglist.c:31 sysdeps/sun4/siglist.c:31
 msgid "Trace trap"
 msgstr "Prati trap"
 
-#: ../sysdeps/osf1/siglist.c:32 ../sysdeps/sun4/siglist.c:32
+#: sysdeps/osf1/siglist.c:32 sysdeps/sun4/siglist.c:32
 msgid "Abort"
-msgstr "Odustani"
+msgstr "Prekini"
 
-#: ../sysdeps/osf1/siglist.c:33 ../sysdeps/sun4/siglist.c:33
+#: sysdeps/osf1/siglist.c:33 sysdeps/sun4/siglist.c:33
 msgid "EMT error"
 msgstr "EMT greška"
 
-#: ../sysdeps/osf1/siglist.c:34 ../sysdeps/sun4/siglist.c:34
+#: sysdeps/osf1/siglist.c:34 sysdeps/sun4/siglist.c:34
 msgid "Floating-point exception"
 msgstr "Iznimka pomičnog zareza"
 
-#: ../sysdeps/osf1/siglist.c:35 ../sysdeps/sun4/siglist.c:35
+#: sysdeps/osf1/siglist.c:35 sysdeps/sun4/siglist.c:35
 msgid "Kill"
 msgstr "Ubij"
 
-#: ../sysdeps/osf1/siglist.c:36 ../sysdeps/sun4/siglist.c:36
+#: sysdeps/osf1/siglist.c:36 sysdeps/sun4/siglist.c:36
 msgid "Bus error"
-msgstr "Sabirnička greška"
+msgstr "Greška sabirnice"
 
-#: ../sysdeps/osf1/siglist.c:37 ../sysdeps/sun4/siglist.c:37
+#: sysdeps/osf1/siglist.c:37 sysdeps/sun4/siglist.c:37
 msgid "Segmentation violation"
-msgstr "Povreda segmenta"
+msgstr "Segmentacijska povreda"
 
-#: ../sysdeps/osf1/siglist.c:38 ../sysdeps/sun4/siglist.c:38
+#: sysdeps/osf1/siglist.c:38 sysdeps/sun4/siglist.c:38
 msgid "Bad argument to system call"
-msgstr "Neispravan argument za sistemski poziv"
+msgstr "Neispravan argument za poziv sustava"
 
-#: ../sysdeps/osf1/siglist.c:39 ../sysdeps/sun4/siglist.c:39
+#: sysdeps/osf1/siglist.c:39 sysdeps/sun4/siglist.c:39
 msgid "Broken pipe"
-msgstr "Prekinut kanal"
+msgstr "Prekinut slivnik"
 
-#: ../sysdeps/osf1/siglist.c:40 ../sysdeps/sun4/siglist.c:40
+#: sysdeps/osf1/siglist.c:40 sysdeps/sun4/siglist.c:40
 msgid "Alarm clock"
-msgstr "Budilica"
+msgstr "Sat alarma"
 
-#: ../sysdeps/osf1/siglist.c:41 ../sysdeps/sun4/siglist.c:41
+#: sysdeps/osf1/siglist.c:41 sysdeps/sun4/siglist.c:41
 msgid "Termination"
-msgstr "Završetak"
+msgstr "Prekidanje"
 
-#: ../sysdeps/osf1/siglist.c:42 ../sysdeps/sun4/siglist.c:42
+#: sysdeps/osf1/siglist.c:42 sysdeps/sun4/siglist.c:42
 msgid "Urgent condition on socket"
-msgstr "Hitno stanje na socketu"
+msgstr "Hitno stanje na priključnici"
 
-#: ../sysdeps/osf1/siglist.c:43 ../sysdeps/sun4/siglist.c:43
+#: sysdeps/osf1/siglist.c:43 sysdeps/sun4/siglist.c:43
 msgid "Stop"
 msgstr "Zaustavi"
 
-#: ../sysdeps/osf1/siglist.c:44 ../sysdeps/sun4/siglist.c:44
+#: sysdeps/osf1/siglist.c:44 sysdeps/sun4/siglist.c:44
 msgid "Keyboard stop"
 msgstr "Zaustavljanje tipkovnice"
 
-#: ../sysdeps/osf1/siglist.c:45 ../sysdeps/sun4/siglist.c:45
+#: sysdeps/osf1/siglist.c:45 sysdeps/sun4/siglist.c:45
 msgid "Continue"
 msgstr "Nastavi"
 
-#: ../sysdeps/osf1/siglist.c:46 ../sysdeps/sun4/siglist.c:46
+#: sysdeps/osf1/siglist.c:46 sysdeps/sun4/siglist.c:46
 msgid "Child status has changed"
-msgstr "Status djeteta je promijenjen"
+msgstr "Nadređeno stanje je promijenjeno"
 
-#: ../sysdeps/osf1/siglist.c:47 ../sysdeps/sun4/siglist.c:47
+#: sysdeps/osf1/siglist.c:47 sysdeps/sun4/siglist.c:47
 msgid "Background read from tty"
 msgstr "Pozadinsko čitanje iz tty-a"
 
-#: ../sysdeps/osf1/siglist.c:48 ../sysdeps/sun4/siglist.c:48
+#: sysdeps/osf1/siglist.c:48 sysdeps/sun4/siglist.c:48
 msgid "Background write to tty"
-msgstr "Pozadinsko pisanje na tty"
+msgstr "Pozadinsko zapisivanje na tty"
 
-#: ../sysdeps/osf1/siglist.c:49 ../sysdeps/sun4/siglist.c:49
+#: sysdeps/osf1/siglist.c:49 sysdeps/sun4/siglist.c:49
 msgid "I/O now possible"
 msgstr "U/I je sada moguć"
 
-#: ../sysdeps/osf1/siglist.c:50 ../sysdeps/sun4/siglist.c:50
+#: sysdeps/osf1/siglist.c:50 sysdeps/sun4/siglist.c:50
 msgid "CPU limit exceeded"
-msgstr "CPU granica iskorištena"
+msgstr "CPU ograničenje iskorišteno"
 
-#: ../sysdeps/osf1/siglist.c:51 ../sysdeps/sun4/siglist.c:51
+#: sysdeps/osf1/siglist.c:51 sysdeps/sun4/siglist.c:51
 msgid "File size limit exceeded"
-msgstr "Prekoračeno ograničenje veličine spisa"
+msgstr "Ograničenje veličine datoteke prekoračeno"
 
-#: ../sysdeps/osf1/siglist.c:52 ../sysdeps/sun4/siglist.c:52
+#: sysdeps/osf1/siglist.c:52 sysdeps/sun4/siglist.c:52
 msgid "Virtual alarm clock"
-msgstr "Virtualni alarmni sat"
+msgstr "Virtualni sat alarma"
 
-#: ../sysdeps/osf1/siglist.c:53 ../sysdeps/sun4/siglist.c:53
+#: sysdeps/osf1/siglist.c:53 sysdeps/sun4/siglist.c:53
 msgid "Profiling alarm clock"
 msgstr "Profiliranje sata alarma"
 
-#: ../sysdeps/osf1/siglist.c:54 ../sysdeps/sun4/siglist.c:54
+#: sysdeps/osf1/siglist.c:54 sysdeps/sun4/siglist.c:54
 msgid "Window size change"
 msgstr "Promjena veličine prozora"
 
-#: ../sysdeps/osf1/siglist.c:55 ../sysdeps/sun4/siglist.c:55
+#: sysdeps/osf1/siglist.c:55 sysdeps/sun4/siglist.c:55
 msgid "Information request"
 msgstr "Zahtjev za informacijom"
 
-#: ../sysdeps/osf1/siglist.c:56 ../sysdeps/sun4/siglist.c:56
+#: sysdeps/osf1/siglist.c:56 sysdeps/sun4/siglist.c:56
 msgid "User defined signal 1"
-msgstr "Korisnički definiran signal 1"
+msgstr "Korisnički određen signal 1"
 
-#: ../sysdeps/osf1/siglist.c:57 ../sysdeps/sun4/siglist.c:57
+#: sysdeps/osf1/siglist.c:57 sysdeps/sun4/siglist.c:57
 msgid "User defined signal 2"
-msgstr "Korisnički definiran signal 2"
+msgstr "Korisnički određen signal 2"

sysdeps/common/error.c

@@ -46,7 +46,7 @@ print_message (const glibtop *server, int message_level, const char *format, int
 
 	g_string_printf(message, "%s", (server && server->name ? server->name : DEFAULT_NAME));
 
-	if (server->pid) {
+	if (server && server->pid) {
 		g_string_append_printf(message, "(c=%u/s=%u)", getpid(), server->pid);
 	}
 	else {

sysdeps/linux/glibtop_private.c

@@ -51,7 +51,7 @@ char *
 skip_token (const char *p)
 {
 	p = next_token(p);
-	while (*p && !isspace(*p)) p++;
+	while (*p && !g_ascii_isspace(*p)) p++;
 	p = next_token(p);
 	return (char *)p;
 }
@@ -178,20 +178,6 @@ get_boot_time(glibtop *server)
 }
 
 
-size_t
-get_page_size(void)
-{
-	static size_t pagesize = 0;
-
-	if(G_UNLIKELY(!pagesize))
-	{
-		pagesize = getpagesize();
-	}
-
-	return pagesize;
-}
-
-
 
 gboolean
 check_cpu_line(glibtop *server, const char *line, unsigned i)

sysdeps/linux/glibtop_private.h

@@ -37,7 +37,7 @@ G_BEGIN_DECLS
 static inline char*
 next_token(const char *p)
 {
-	while (isspace(*p)) p++;
+	while (g_ascii_isspace(*p)) p++;
 	return (char*) p;
 }
 
@@ -122,10 +122,6 @@ unsigned long
 get_boot_time(glibtop *server);
 
 
-size_t
-get_page_size(void);
-
-
 gboolean
 check_cpu_line(glibtop *server, const char *line, unsigned n);
 

sysdeps/linux/procmem.c

@@ -82,7 +82,7 @@ void
 glibtop_get_proc_mem_s (glibtop *server, glibtop_proc_mem *buf, pid_t pid)
 {
 	char buffer [BUFSIZ], *p;
-	const size_t pagesize = get_page_size();
+	const size_t pagesize = getpagesize();
 
 	memset (buf, 0, sizeof (glibtop_proc_mem));
 

sysdeps/linux/procsegment.c

@@ -53,7 +53,7 @@ glibtop_get_proc_segment_s (glibtop *server, glibtop_proc_segment *buf,
 			    pid_t pid)
 {
 	char buffer [BUFSIZ], *p;
-	const size_t pagesize = get_page_size();
+	const size_t pagesize = getpagesize();
 
 	memset (buf, 0, sizeof (glibtop_proc_segment));
 

sysdeps/linux/sysinfo.c

@@ -36,23 +36,34 @@ static glibtop_sysinfo sysinfo = { .flags = 0 };
 static void
 init_sysinfo (glibtop *server)
 {
-	char buffer [65536];
+	char* buffer;
 	gchar ** processors;
 
 	if(G_LIKELY(sysinfo.flags)) return;
 
-	file_to_buffer(server, buffer, sizeof buffer, FILENAME);
+	if (!g_file_get_contents(FILENAME, &buffer, NULL, NULL)) {
+		glibtop_error_io_r(server, "g_file_get_contents(%s)", FILENAME);
+	}
 
 	/* cpuinfo records are seperated by a blank line */
 	processors = g_strsplit(buffer, "\n\n", 0);
 
-	for(sysinfo.ncpu = 0;
-	    sysinfo.ncpu < GLIBTOP_NCPU && processors[sysinfo.ncpu] && *processors[sysinfo.ncpu];
-	    sysinfo.ncpu++) {
+	g_free(buffer);
+
+	sysinfo.ncpu = 0;
+	for (char** this_proc = &processors[0]; *this_proc && **this_proc; this_proc++) {
+
+		if (sysinfo.ncpu >= GLIBTOP_NCPU) {
+			glibtop_warn_r(server, "Cannot deal with more than %d CPUs", GLIBTOP_NCPU);
+			break;
+		}
 
 		gchar **parts, **p;
-        if (g_strrstr (processors[sysinfo.ncpu], "processor" ) == NULL) 
-            continue;
+		if (g_strrstr (*this_proc, "processor" ) == NULL) {
+		  /* skip unknown paragraph */
+		  continue;
+		}
+
 		glibtop_entry * const cpuinfo = &sysinfo.cpuinfo[sysinfo.ncpu];
 
 		cpuinfo->labels = g_ptr_array_new ();
@@ -64,7 +75,7 @@ init_sysinfo (glibtop *server)
 							g_free, g_free);
 
 		/* "<key>    : <value>" */
-		parts = g_strsplit_set(processors[sysinfo.ncpu], ":\n", 0);
+		parts = g_strsplit_set(*this_proc, ":\n", 0);
 
 		for(p = parts; *p && *(p+1); p += 2) {
 
@@ -85,6 +96,7 @@ init_sysinfo (glibtop *server)
 
 		g_free(parts);
 
+		sysinfo.ncpu++;
 	}
 
 	g_strfreev(processors);