lib/log.c: Replace strncpy(3) call by STRTCPY()
This call was too clever. It relied on the last byte of ll_line being 0 due to a previous memzero() and not writing to it later. Write an explicit terminating null byte, by using STRTCPY(). Signed-off-by: Alejandro Colomar <alx@kernel.org>
This commit is contained in:
committed by
Serge Hallyn
parent
09957c6d27
commit
81f0e6a30f
@@ -19,6 +19,8 @@
|
||||
#include <lastlog.h>
|
||||
#include "memzero.h"
|
||||
#include "prototypes.h"
|
||||
#include "strtcpy.h"
|
||||
|
||||
|
||||
/*
|
||||
* dolastlog - create lastlog entry
|
||||
@@ -78,7 +80,7 @@ void dolastlog (
|
||||
ll_time = newlog.ll_time;
|
||||
(void) time (&ll_time);
|
||||
newlog.ll_time = ll_time;
|
||||
strncpy (newlog.ll_line, line, sizeof (newlog.ll_line) - 1);
|
||||
STRTCPY(newlog.ll_line, line);
|
||||
#if HAVE_LL_HOST
|
||||
strncpy (newlog.ll_host, host, sizeof (newlog.ll_host) - 1);
|
||||
#endif
|
||||
|
||||
Reference in New Issue
Block a user