From 81f0e6a30fe27cc20a8a65e1d74eee589e548bb8 Mon Sep 17 00:00:00 2001 From: Alejandro Colomar Date: Thu, 16 Nov 2023 00:08:47 +0100 Subject: [PATCH] lib/log.c: Replace strncpy(3) call by STRTCPY() This call was too clever. It relied on the last byte of ll_line being 0 due to a previous memzero() and not writing to it later. Write an explicit terminating null byte, by using STRTCPY(). Signed-off-by: Alejandro Colomar --- lib/log.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/lib/log.c b/lib/log.c index 8b3e564e..9457b1cd 100644 --- a/lib/log.c +++ b/lib/log.c @@ -19,6 +19,8 @@ #include #include "memzero.h" #include "prototypes.h" +#include "strtcpy.h" + /* * dolastlog - create lastlog entry @@ -78,7 +80,7 @@ void dolastlog ( ll_time = newlog.ll_time; (void) time (&ll_time); newlog.ll_time = ll_time; - strncpy (newlog.ll_line, line, sizeof (newlog.ll_line) - 1); + STRTCPY(newlog.ll_line, line); #if HAVE_LL_HOST strncpy (newlog.ll_host, host, sizeof (newlog.ll_host) - 1); #endif