Compare commits

..

7 Commits
48.2 ... 48.3

Author SHA1 Message Date
Florian Müllner
2dd9ae80ca Bump version to 48.3
Update NEWS.
2025-06-29 12:56:57 +02:00
Florian Müllner
00b30c1a47 cleanup: Remove unused eslint-disable directives
The 'camelcase' rule only applies to variables and properties,
not to function names are getter/setter.

Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell-extensions/-/merge_requests/413>
(cherry picked from commit 9e11ec9940)
2025-06-29 01:52:59 +02:00
Florian Müllner
5f68dd5645 cleanup: Remove unused catch bindings
Optional catch bindings have been supported for quite a while now,
so we can treat unused error bindings in catch statements like
any other unused variable.

Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell-extensions/-/merge_requests/413>
(cherry picked from commit 3a76b9eec4)
2025-06-29 01:52:53 +02:00
Florian Müllner
752ed054fe workspace-indicator: Remove left-over variable
Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell-extensions/-/merge_requests/405>
(cherry picked from commit 53ba3ce620)
2025-06-29 01:52:39 +02:00
Florian Müllner
88c420f8f2 lint: Require dangling comma in multi-line imports
This keeps the config in line with gjs, which added the option
in gjs@f7d3b5d4c8.

Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell-extensions/-/merge_requests/411>
(cherry picked from commit 301017904b)
2025-06-29 01:52:34 +02:00
Florian Müllner
0e31708227 window-list: Only remove fullscreen tracking in overview
Since commit 981e8e42e2, we untrack chrome in the overview to avoid
fullscreen tracking interfering with hiding the window list in the
overview.

However this also means that we no longer contribute to the struts
while in the overview, which can lead to unwanted window resizes
around the transition.

So instead of fully untracking the actor, retrack without fullscreen
tracking.

Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell-extensions/-/merge_requests/409>
(cherry picked from commit 0ad959de1e)
2025-06-29 01:52:20 +02:00
Florian Müllner
5ec6daa8e5 Revert "window-list: Fix initial visibility"
Since we no longer track fullscreen state in the overview,
the workaround is no longer necessary.

This reverts commit 6ee4205f1e.

Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell-extensions/-/merge_requests/409>
(cherry picked from commit a3ff3c79b2)
2025-06-29 01:51:57 +02:00
6 changed files with 28 additions and 13 deletions

7
NEWS
View File

@@ -1,3 +1,10 @@
48.3
====
* Misc. bug fixes and cleanups [Florian; !409, !411, !405, !413]
Contributors:
Florian Müllner
48.2
====
* windowsNavigator: Fix handling keyboard shortcuts [Daniel; !395]

View File

@@ -488,7 +488,7 @@ class ApplicationsButton extends PanelMenu.Button {
let id;
try {
id = entry.get_desktop_file_id(); // catch non-UTF8 filenames
} catch (e) {
} catch {
continue;
}
let app = appSys.lookup_app(id);

View File

@@ -432,12 +432,10 @@ class BaseButton extends DashItemContainer {
return this._button.has_style_class_name('focused');
}
// eslint-disable-next-line camelcase
get ignore_workspace() {
return this._ignoreWorkspace;
}
// eslint-disable-next-line camelcase
set ignore_workspace(ignore) {
if (this._ignoreWorkspace === ignore)
return;
@@ -983,11 +981,20 @@ class WindowList extends St.Widget {
() => this._onWorkspaceMenuSet(), this);
this._onWorkspaceMenuSet();
const chromeOptions = {
const inOverview = Main.overview.visible ||
(Main.layoutManager._startingUp && Main.sessionMode.hasOverview);
const overviewChromeOptions = {
affectsStruts: true,
};
const chromeOptions = {
...overviewChromeOptions,
trackFullscreen: true,
};
Main.layoutManager.addChrome(this, chromeOptions);
Main.layoutManager.addChrome(this, inOverview
? overviewChromeOptions
: chromeOptions);
Main.uiGroup.set_child_above_sibling(this, Main.layoutManager.panelBox);
Main.ctrlAltTabManager.addGroup(this, _('Window List'), 'start-here-symbolic');
@@ -1024,20 +1031,17 @@ class WindowList extends St.Widget {
Main.overview.connectObject(
'showing', () => {
Main.layoutManager.untrackChrome(this);
this._retrackChrome(overviewChromeOptions);
this.hide();
this._updateKeyboardAnchor();
},
'hidden', () => {
Main.layoutManager.trackChrome(this, chromeOptions);
this._retrackChrome(chromeOptions);
this.visible = !this._monitor.inFullscreen;
this._updateKeyboardAnchor();
}, this);
global.display.connectObject('in-fullscreen-changed', () => {
// Work-around for initial change from unknown to !fullscreen
if (Main.overview.visible)
this.hide();
this._updateKeyboardAnchor();
}, this);
@@ -1103,6 +1107,11 @@ class WindowList extends St.Widget {
this._monitor.y + this._monitor.height - this.height);
}
_retrackChrome(options) {
Main.layoutManager.untrackChrome(this);
Main.layoutManager.trackChrome(this, options);
}
_updateWorkspaceIndicatorVisibility() {
let workspaceManager = global.workspace_manager;
let hasWorkspaces = this._mutterSettings.get_boolean('dynamic-workspaces') ||

View File

@@ -459,8 +459,6 @@ export class WorkspaceIndicator extends PanelMenu.Button {
this._thumbnails = new WorkspacePreviews();
container.add_child(this._thumbnails);
this._workspacesItems = [];
workspaceManager.connectObject(
'workspace-switched', this._onWorkspaceSwitched.bind(this), GObject.ConnectFlags.AFTER,
this);

View File

@@ -30,6 +30,7 @@ rules:
- error
- arrays: always-multiline
objects: always-multiline
imports: always-multiline
functions: never
comma-spacing:
- error

View File

@@ -4,7 +4,7 @@
project(
'gnome-shell-extensions',
version: '48.2',
version: '48.3',
meson_version: '>= 1.1.0',
license: 'GPL-2.0-or-later',
)