VesperOS/gnome-shell-extensions
6
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
1,497 Commits 15 Branches 450 Tags
3.33.2
Commit Graph

532 Commits

Author SHA1 Message Date
Florian Müllner
ad914441a2 window-list: Reindent to conform with new style 
Instead of aligning arguments like we used to do, use a consistent
four-space indent as mandated by gjs' current style guide.

https://gitlab.gnome.org/GNOME/gnome-shell-extensions/merge_requests/66
 2019-05-22 20:40:19 +02:00
Florian Müllner
200d337769 apps-menu: Reindent to conform with new style 
Instead of aligning arguments like we used to do, use a consistent
four-space indent as mandated by gjs' current style guide.

https://gitlab.gnome.org/GNOME/gnome-shell-extensions/merge_requests/66
 2019-05-22 20:40:19 +02:00
Florian Müllner
e56f1a976e native-window-placement: Reindent to conform with new style 
Instead of aligning arguments like we used to do, use a consistent
four-space indent as mandated by gjs' current style guide.

https://gitlab.gnome.org/GNOME/gnome-shell-extensions/merge_requests/66
 2019-05-22 20:40:19 +02:00
Florian Müllner
6a66cd4fa6 places-menu: Reindent to conform with new style 
Instead of aligning arguments like we used to do, use a consistent
four-space indent as mandated by gjs' current style guide.

https://gitlab.gnome.org/GNOME/gnome-shell-extensions/merge_requests/66
 2019-05-22 20:40:19 +02:00
Florian Müllner
55c493389a auto-move-windows: Reindent to conform with new style 
Instead of aligning arguments like we used to do, use a consistent
four-space indent as mandated by gjs' current style guide.

https://gitlab.gnome.org/GNOME/gnome-shell-extensions/merge_requests/66
 2019-05-22 20:40:18 +02:00
Florian Müllner
06f1303834 drive-menu: Reindent to conform with new style 
Instead of aligning arguments like we used to do, use a consistent
four-space indent as mandated by gjs' current style guide.

https://gitlab.gnome.org/GNOME/gnome-shell-extensions/merge_requests/66
 2019-05-22 20:40:18 +02:00
Florian Müllner
3d5687ae3c workspace-indicator: Reindent to conform with new style 
Instead of aligning arguments like we used to do, use a consistent
four-space indent as mandated by gjs' current style guide.

https://gitlab.gnome.org/GNOME/gnome-shell-extensions/merge_requests/66
 2019-05-22 20:40:18 +02:00
Florian Müllner
cdd3fba593 screenshot-window-sizer: Reindent to conform with new style 
Instead of aligning arguments like we used to do, use a consistent
four-space indent as mandated by gjs' current style guide.

https://gitlab.gnome.org/GNOME/gnome-shell-extensions/merge_requests/66
 2019-05-22 20:40:18 +02:00
Florian Müllner
7c412ca7d9 window-list: Don't use anchor point 
It is deprecated and we can easily replace it with a translation.

https://gitlab.gnome.org/GNOME/gnome-shell-extensions/merge_requests/64
 2019-04-28 11:08:02 +00:00
Adrien Plazas
5b43d4733c screenshot-window-sizer: Add phone screenshot sizes 
This is going to be convenient to take fake screenshots for phones like
the Librem 5.

https://gitlab.gnome.org/GNOME/gnome-shell-extensions/merge_requests/65
 2019-04-12 14:31:53 +02:00
Florian Müllner
3671d5a299 cleanup: Use an extension object instead of globals 
https://gitlab.gnome.org/GNOME/gnome-shell-extensions/issues/143
 2019-04-08 06:00:29 +00:00
Florian Müllner
a024d9f005 windowsNavigator: Use subclasses instead of injections 
gnome-shell moved to ES6 classes, which means the constructor is
no longer a regular method that we can swap out with an injected
version.

Instead, do our modifications in subclasses and use them to replace
the original classes.

https://gitlab.gnome.org/GNOME/gnome-shell-extensions/issues/143
 2019-04-08 06:00:29 +00:00
Florian Müllner
a26380d56e user-theme: Clarify some code 
Commit 2582ab accidentally pointed out that the current theme loading code
obfuscates which directories are searched for themes. Rewrite it with modern
JS features to make it more obvious.

https://gitlab.gnome.org/GNOME/gnome-shell-extensions/merge_requests/60
 2019-03-04 19:35:18 +01:00
Florian Müllner
ab334d95e0 Revert "User theme: compatibility with XDG Base Directory" 
We already handled themes in XDG_DATA_HOME before commit 2582ab
by prepending it to the system dirs.

This reverts commit 2582ab4fd0.

https://gitlab.gnome.org/GNOME/gnome-shell-extensions/merge_requests/60
 2019-03-04 19:35:10 +01:00
Florian Müllner
7e5726e632 apps-menu: Promisify marking file as trusted 
Use async/await to make nested operations easier to read.

https://gitlab.gnome.org/GNOME/gnome-shell-extensions/merge_requests/60
 2019-03-04 19:35:10 +01:00
Florian Müllner
95b40069bf apps-menu: Remove unnecessary check 
The function is always called with an array parameter (albeit it may
be empty), so remove the unnecessary check and cut down on indentation.

https://gitlab.gnome.org/GNOME/gnome-shell-extensions/merge_requests/60
 2019-03-04 19:35:10 +01:00
Florian Müllner
bd9f1cfd91 apps-menu: Avoid deep nesting 
https://gitlab.gnome.org/GNOME/gnome-shell-extensions/merge_requests/60
 2019-03-04 19:35:10 +01:00
Florian Müllner
81548ced69 native-window-placement: Clarify some code 
Add some intermediate variables for better legibility.

https://gitlab.gnome.org/GNOME/gnome-shell-extensions/merge_requests/60
 2019-03-04 19:35:10 +01:00
Florian Müllner
a378e5fc34 placesDisplay: Promisify launching 
Use async/await to make nested async operations easier to read.

https://gitlab.gnome.org/GNOME/gnome-shell-extensions/merge_requests/60
 2019-03-04 19:35:10 +01:00
Florian Müllner
56d19ad480 placesMenu: Add early return to reduce indentation level 
https://gitlab.gnome.org/GNOME/gnome-shell-extensions/merge_requests/60
 2019-03-04 19:35:10 +01:00
Florian Müllner
a071685c13 auto-move-windows: Clarify some code 
Apply some tricks to align column numbers with their corresponding
values for better legibility.

https://gitlab.gnome.org/GNOME/gnome-shell-extensions/merge_requests/60
 2019-03-04 19:35:10 +01:00
Florian Müllner
599428d292 auto-move-windows: De-duplicate row appending 
https://gitlab.gnome.org/GNOME/gnome-shell-extensions/merge_requests/60
 2019-03-04 19:35:10 +01:00
Florian Müllner
1f1f9664a6 cleanup: Share unmount/eject arugments 
Besides the callback, eject and unmount share the same arguments.
Make this explicit by sharing the common arguments between branches.

https://gitlab.gnome.org/GNOME/gnome-shell-extensions/merge_requests/60
 2019-03-04 19:35:10 +01:00
Florian Müllner
fb039c0fb5 cleanup: Use Meta.MaximizeFlags.BOTH 
This shorthand has been around for a long time, use it make (un)maximize
code more readable.

https://gitlab.gnome.org/GNOME/gnome-shell-extensions/merge_requests/60
 2019-03-04 19:35:10 +01:00
Florian Müllner
d83d6e857a style: Use single-quotes for translated strings 
The coding style of using double quotes for translatable strings
and single quotes otherwise is unnecessarily complex and cannot
be enforced with an eslint rule.

Simply use single quotes consistently for all strings.

https://gitlab.gnome.org/GNOME/gnome-shell-extensions/merge_requests/57
 2019-02-28 23:29:31 +01:00
Florian Müllner
db35d7ae7c style: Change indentation style of object literals 
Instead of keeping the first property on the same line as the opening
brace and aligning the properties, use a four-space indent. This brings
us closer to gjs' coding style, and as a bonus helps keeping lines in
the soft 80 character limit.

https://gitlab.gnome.org/GNOME/gnome-shell-extensions/merge_requests/57
 2019-02-28 23:29:24 +01:00
Florian Müllner
d34b5030b9 style: Use a consistent style for array literals 
Most array literals already use a four-space indent, except the ones in
GObject metainfo and function parameters. Reindent those as well to make
the style consistent and bring it closer to gjs' coding style.

https://gitlab.gnome.org/GNOME/gnome-shell-extensions/merge_requests/57
 2019-02-28 23:29:14 +01:00
Florian Müllner
7f8f1234ae style: Stop using braces for single-line arrow functions 
Braces are optional for single-line arrow functions, but there's a
subtle difference:
Without braces, the expression is implicitly used as return value; with
braces, the function returns nothing unless there's an explicit return.

We currently reflect that in our style by only omitting braces when the
function is expected to have a return value, but that's not very obvious,
not an important differentiation to make, and not easy to express in an
automatic rule.

So just omit braces consistently as mandated by gjs' coding style.

https://gitlab.gnome.org/GNOME/gnome-shell-extensions/merge_requests/57
 2019-02-28 23:29:05 +01:00
Florian Müllner
9b25a227c6 style: Don't exempt ternary expressions from indent rule 
It turns out we can comply with gjs' coding style and still align the
branches if line breaks are required, so do that to reduce diversion
from the canonical GNOME style.

https://gitlab.gnome.org/GNOME/gnome-shell-extensions/merge_requests/57
 2019-02-28 23:28:55 +01:00
Tomasz Gąsior
2582ab4fd0 User theme: compatibility with XDG Base Directory 
See https://gitlab.gnome.org/GNOME/gnome-shell-extensions/merge_requests/55
 2019-02-20 01:15:49 +01:00
Florian Müllner
4671c24b78 places-menu: Stop using deprecated Mainloop module 
Just use the underlying GLib functions directly.

https://gitlab.gnome.org/GNOME/gnome-shell-extensions/merge_requests/54
 2019-02-16 00:49:44 +01:00
Florian Müllner
0d41643866 cleanup: Use destructuring for imports from GI 
This is *much* nicer than repetitive "imports.gi" lines ...

https://gitlab.gnome.org/GNOME/gnome-shell-extensions/merge_requests/54
 2019-02-16 00:49:44 +01:00
Florian Müllner
d8f7d70c10 apps-menu: Remove outdated legacy-tray handling 
The tray is long gone, so trying to access it will result in
warnings.

https://gitlab.gnome.org/GNOME/gnome-shell-extensions/merge_requests/53
 2019-02-16 00:40:55 +01:00
Florian Müllner
bab4be1a59 extensions: Drop Convenience library 
Its methods are now provided by gnome-shell itself and can be used
as an easy drop-in replacement.

https://gitlab.gnome.org/GNOME/gnome-shell-extensions/merge_requests/44
 2019-02-06 20:17:59 +01:00
Florian Müllner
3861ffae31 extensions: Mark exported symbols 
eslint obviously doesn't know about gnome-shell's extension API, so
the various entry points trigger unused-variable errors. To fix,
explicitly mark those symbols as exported.

https://gitlab.gnome.org/GNOME/gnome-shell-extensions/merge_requests/50
 2019-01-28 06:51:20 +01:00
Florian Müllner
08a04b2f02 cleanup: Mark unused (but useful) variables as ignored 
While we aren't using those destructured variables, they are still useful
to document the meaning of those elements. We don't want eslint to keep
warning about them though, so mark them accordingly.

https://gitlab.gnome.org/GNOME/gnome-shell-extensions/merge_requests/50
 2019-01-28 06:51:09 +01:00
Florian Müllner
7b363fd659 cleanup: Mark unused arguments as unused 
This will stop eslint from warning about them, while keeping their
self-documenting benefit.

https://gitlab.gnome.org/GNOME/gnome-shell-extensions/merge_requests/50
 2019-01-28 06:51:02 +01:00
Florian Müllner
b3f009017c style: Use consistent style for object literal parameters 
Spotted by eslint.

https://gitlab.gnome.org/GNOME/gnome-shell-extensions/merge_requests/49
 2019-01-28 06:37:28 +01:00
Florian Müllner
05d961dfe1 style: Avoid trailing commas in array destructuring 
When destructuring multiple return values, we often use trailing commas
to indicate that there are additional elements that we are ignoring.

There isn't anything inherently wrong with that, but it's a style that's
too confusing for eslint - on the one hand we require a space after a
comma, on the other hand we require no space before closing brackets.

https://gitlab.gnome.org/GNOME/gnome-shell-extensions/merge_requests/49
 2019-01-28 06:37:28 +01:00
Florian Müllner
8a2b9abc09 style: Stop using string concatenation 
String concatenation is considered bad style after ES6 added
template strings. The latter is the replacement we generally
want, except where the aforementioned xgettext bug would trip
over the backtick/slash combination.

https://gitlab.gnome.org/GNOME/gnome-shell-extensions/merge_requests/49
 2019-01-28 06:37:28 +01:00
Florian Müllner
3effc9cfc2 style: Fix indentation errors 
While we have some style inconsistencies - mostly regarding split lines,
i.e. aligning to the first arguments vs. a four-space indent - there are
a couple of places where the spacing is simply wrong. Fix those.

Spotted by eslint.

https://gitlab.gnome.org/GNOME/gnome-shell-extensions/merge_requests/49
 2019-01-28 06:37:28 +01:00
Florian Müllner
1be7061da0 style: Fix stray/missing spaces 
Spotted by eslint.

https://gitlab.gnome.org/GNOME/gnome-shell-extensions/merge_requests/49
 2019-01-28 06:37:28 +01:00
Florian Müllner
f75d1d75af style: Fix stray/missing semi-colons 
Spotted by eslint.

https://gitlab.gnome.org/GNOME/gnome-shell-extensions/merge_requests/49
 2019-01-28 06:37:28 +01:00
Florian Müllner
67f9e4c419 style: Use space after catch 
We currently use a consistent style of not adding spaces in catch
clauses, however that's inconsistent with the style we use for any
other statement. There's not really a good reason to stick with it,
so switch to the style gjs/eslint default to.

https://gitlab.gnome.org/GNOME/gnome-shell-extensions/merge_requests/49
 2019-01-28 06:37:28 +01:00
Florian Müllner
aaeff6d12b style: Use camelCase for variable names 
Spotted by eslint.

https://gitlab.gnome.org/GNOME/gnome-shell-extensions/merge_requests/49
 2019-01-28 06:37:28 +01:00
Florian Müllner
912ba1e651 cleanup: Remove unhelpful unused init() argument 
Virtually all extensions use the getCurrentExtension() helper instead
of the obscure init() argument, and we are no exception.

https://gitlab.gnome.org/GNOME/gnome-shell-extensions/merge_requests/49
 2019-01-28 06:37:28 +01:00
Florian Müllner
b741b1bbe2 cleanup: Remove empty init() functions 
The method is optional, so there's no point at all in letting the
shell call an empty method during initialization.

https://gitlab.gnome.org/GNOME/gnome-shell-extensions/merge_requests/49
 2019-01-28 06:37:28 +01:00
Florian Müllner
d7414025a5 cleanup: Remove unused variables 
Spotted by eslint.

https://gitlab.gnome.org/GNOME/gnome-shell-extensions/merge_requests/49
 2019-01-28 06:37:28 +01:00
Florian Müllner
a317d75f70 cleanups: Clean up unused imports 
Spotted by eslint.

https://gitlab.gnome.org/GNOME/gnome-shell-extensions/merge_requests/49
 2019-01-28 06:37:28 +01:00
Florian Müllner
194e294d2c user-theme: Don't use concatenation to build filenames 
Since template strings were added in ES6, string concatenation is
considered bad style. There's a catch though: xgettext currently
has a nasty bug concerning the combination of backticks and slashes.
Avoid that issue by building filenames with the corresponding GLib
helper function.

https://gitlab.gnome.org/GNOME/gnome-shell-extensions/merge_requests/49
 2019-01-28 06:37:28 +01:00