345 Commits

Author SHA1 Message Date
Florian Müllner
af14da5770 window-list: Fix for "app-less" windows
While rare, it is possible to have a window not associated with any app
(not even a fake window-based one). We currently throw an error when
trying to set the icon for such a window, so handle this case and
use a fallback icon instead of the app icon.

https://bugzilla.gnome.org/show_bug.cgi?id=743401
2015-03-23 20:38:14 +01:00
Florian Müllner
1406feb262 window-list: Keep panel below modal dialogs when possible
Currently the window-list will be stacked above system modal dialogs,
which means it is not dimmed like the rest of the desktop and remains
accessible to interaction. We cannot do any better when showing the
on-screen keyboard, as we need to keep ourselves above to not end up
covered by the OSK, and the keyboard itself is stacked above modal
dialogs to allow its use for input. However we can at least fix the
case when not using the OSK.

https://bugzilla.gnome.org/show_bug.cgi?id=740722
2014-12-19 15:29:00 +01:00
Maxime Henrion
3771d49149 Skip over XDG directories that cannot be found.
This fixes loading the places menu gnome-shell extension when the XDG
directories have not been configured.

https://bugzilla.gnome.org/show_bug.cgi?id=741033
2014-12-02 19:01:27 +01:00
Sylvain Pasche
2f49d77931 window-list: _pointerInTray was renamed to _pointerInNotification in bug 695800
https://bugzilla.gnome.org/show_bug.cgi?id=737486
2014-11-26 20:05:44 +01:00
Sylvain Pasche
046c603872 window-list: Disconnect drag and drop handlers
https://bugzilla.gnome.org/show_bug.cgi?id=737486
2014-11-26 20:05:44 +01:00
Florian Müllner
79f263d1ed apps-menu: Center app labels
Currently labels are not vertically centered, unlike icons.
Fix this.

https://bugzilla.gnome.org/show_bug.cgi?id=740724
2014-11-26 19:07:29 +01:00
Florian Müllner
a0a28be128 apps-menu: Update menu arrow to use an icon
gnome-shell no longer uses labels with UTF8 arrows, so the currently
used arrow is no longer consistent with other menus; fix that.

https://bugzilla.gnome.org/show_bug.cgi?id=740725
2014-11-26 18:56:38 +01:00
Florian Müllner
3fca9e88b2 drive-menu: Adjust for renamed .desktop file name
Nautilus now uses reverse domain notation for its .desktop file,
adjust for that.

https://bugzilla.gnome.org/show_bug.cgi?id=739931
2014-11-12 19:54:45 +01:00
Florian Müllner
a1ab174e7a drive-menu: Update for gnome-shell changes
Since shell commit 3227d4f3edad, Shell.Global.create_app_launch_context()
expects additional parameters.

https://bugzilla.gnome.org/show_bug.cgi?id=739931
2014-11-12 19:54:38 +01:00
Florian Müllner
e372c5ace8 window-list: Avoid flashing when using auto-grouping
Currently when using auto-grouping, the list is ungrouped each
time a window is closed, and then possibly re-grouped on the next
allocation - as a result, there is a brief "ungroup flash" if the
list is supposed to remain grouped.
Avoid this by computing the width the ungrouped list would have
rather than by actually ungrouping it.

https://bugzilla.gnome.org/show_bug.cgi?id=738286
2014-10-11 00:06:59 +02:00
Florian Müllner
614d1c9697 window-list: Fix spacing in app buttons 2014-10-07 20:01:56 +02:00
Florian Müllner
70056ba56e window-list: Don't unnecessarily add/remove window buttons
Since commit 191c7ccc24, we check whether we already have a window
in the list before re-adding it on MetaWorkspace::window-added.
We can do something similar on MetaWorkspace::window-removed to
avoid some extra work when a window is moved between workspaces
rather than destroyed.
2014-10-07 18:57:45 +02:00
Florian Müllner
4af36f41fa window-list: Don't use Meta.get_window_actors() directly
The list returned may contain windows that are being destroyed.
The ShellGlobal method filters those out, so use that instead; we
should eventually stop looking at window actors when we want windows,
but for now this is the easy and safe thing to do.
2014-10-07 17:19:00 +02:00
Florian Müllner
60ea0fb172 Stop using deprecated GSettings:schema property 2014-10-07 14:38:12 +02:00
Florian Müllner
54e39c9779 launch-new-instance: Re-use original activate function
Rather than re-implementing the function (and risk missing improvements
like the launch animation), call the original one as if the user had
middle-clicked the launcher.
2014-09-29 15:32:02 +02:00
Florian Müllner
d4ca2aeeb5 extension: Reuse original handler in keyPressHandler injection
We do need to inject our own handler to treat application-switch
actions the same way as the corresponding window-switch ones;
we can actually express exactly this without re-implementing the
entire function, by calling the original handler with a tweaked
action parameter - the resulting code is not only more concise,
but should also be a bit more robust against changes in core.

https://bugzilla.gnome.org/show_bug.cgi?id=737457
2014-09-29 15:32:02 +02:00
Florian Müllner
687ea92e82 alternateTab: Remove _initialSelection injection
Since shell commit 2b1077aaa169, the implementation in the
SwitcherPopup base class already works as expected.

https://bugzilla.gnome.org/show_bug.cgi?id=737457
2014-09-27 16:15:37 +02:00
Florian Müllner
0dd5b5251a alternateTab: Fix Escape not dismissing popup
Since shell commit dd85670f8b25, the handler got a return value to
determine whether Escape should be handled automatically; we do
want this for the window switcher, so add an appropriate return
value to restore the expected behavior.

https://bugzilla.gnome.org/show_bug.cgi?id=737457
2014-09-27 16:15:37 +02:00
Florian Müllner
6e82912fe5 launch-new-instance: Remove unused imports/variables 2014-09-27 16:15:36 +02:00
Florian Müllner
8696067186 screenshot-window-sizer: Do not translate schema for now
It's not worth a string freeze break, we can revert after the freeze
has been lifted ...
2014-09-17 07:05:22 +02:00
Florian Müllner
1d5ab0f0de screenshot-window-sizer: New extension
Originally from hughsie's github[0], but way too useful to leave
in a 3rd party repo :-)

[0] https://github.com/hughsie/gnome-shell-extension-screenshot-window-sizer

https://bugzilla.gnome.org/show_bug.cgi?id=736470
2014-09-17 07:05:22 +02:00
Florian Müllner
191c7ccc24 window-list: Do not add sticky windows more than once
When a window's on-all-workspaces property changes to true, the
workspaces the window was not located on will emit the ::window-added
signal for the window; however we don't want multiple buttons for
the same window, so filter out the extra calls.

https://bugzilla.gnome.org/show_bug.cgi?id=736398
2014-09-11 12:13:10 +02:00
Florian Müllner
2667b9f3e5 launch-new-instance: Update for gnome-shell changes 2014-09-03 15:11:54 +02:00
Florian Müllner
5616a6deae window-list: Expand workspace button for Fitts'ability
The workspace button used to extend to the bottom edge, which of
course is A Good Thing (tm) - commit ec8f269107 broke this when
it added an additional container to the hierarchy, expand the
button again to bring back the old mouse-friendly behavior.

https://bugzilla.gnome.org/show_bug.cgi?id=708247
2014-09-03 14:50:35 +02:00
Adel Gadllah
b2a2653492 alternate-tab: Remove 'backwards' argument from SwitcherPopup:_keyPressHandler
Match the change from commit d450b74e10610c6164e

https://bugzilla.gnome.org/show_bug.cgi?id=735239
2014-08-24 13:33:08 +02:00
Florian Müllner
f38d76db06 native-window-placement: Fix 'button-layout' schema
The defaults have been shifted around so that the normal session
uses the regular schema and classic mode overrides it, so the
key is no longer present in 'org.gnome.shell.overrides'.
2014-06-10 12:26:14 +02:00
Florian Müllner
6a9c4e71fc example: Tweak prefs UI
Position the explanatory text below the actual option and tweak
whitespace a bit.

https://bugzilla.gnome.org/show_bug.cgi?id=730843
2014-05-28 01:27:37 +02:00
Florian Müllner
d0110cf18a auto-move: Tweak prefs UI
- make tree view scrollable when list grows large
- add some borders
- use symbolic icons instead of (deprecated) stock items
- adjust spacing/alignment
- disable remove button when no item is selected

https://bugzilla.gnome.org/show_bug.cgi?id=730843
2014-05-28 01:14:42 +02:00
Florian Müllner
de7fbe5b7d workspace-indicator: Tweak prefs UI
- make tree view scrollable when list grows large
 - add some borders
 - use symbolic icons instead of (deprecated) stock items
 - adjust spacing/alignment
 - disable remove button when no item is selected

https://bugzilla.gnome.org/show_bug.cgi?id=730843
2014-05-28 01:14:42 +02:00
Florian Müllner
f4625f7968 alternate-tab: Tweak pref widget a bit
Adjust spacing to use more standard values and tweak alignments
to make the structure a bit more clear.

https://bugzilla.gnome.org/show_bug.cgi?id=730843
2014-05-28 01:14:42 +02:00
Florian Müllner
db04866ca2 window-list: Use Infinity instead of special-casing 0
This should fix the problem addressed in the last commit without
breaking 0 as stable sequence.
2014-05-27 19:27:43 +02:00
Florian Müllner
f93234e442 window-list: Fix stupid thinko
Without special casing the start value of 0, we did not reduce
to the minimum stable sequence of app windows, but 0.
2014-05-27 19:06:22 +02:00
Florian Müllner
d8eb2273c0 window-list: Sort buttons by stable sequence
Currently the initial set of buttons is in stack/MRU order. To
avoid shuffling around the list each time it is disabled/re-enabled
(lock screen) or the group-mode settings changes, sort it by the
stable sequence.

https://bugzilla.gnome.org/show_bug.cgi?id=719933
2014-04-29 19:08:26 +02:00
Debarshi Ray
512ff51d13 launch-new-instances: Drop obsolete signals and callbacks
The 'launching' signal and this._onActivateOverride callback were
removed from gnome-shell in 7ecb5af587af7ed892c6cfc5af0858a2acb04905
and 7ecb5af587af7ed892c6cfc5af0858a2acb04905 respectively.

https://bugzilla.gnome.org/show_bug.cgi?id=721864
2014-04-29 01:09:38 +02:00
Florian Müllner
80f49c2ed7 auto-move-windows: Never remove the active workspace
Follow core shell in never removing the active workspace.

https://bugzilla.gnome.org/show_bug.cgi?id=728865
2014-04-24 19:15:43 +02:00
Florian Müllner
d9b543c6e0 auto-move-windows: Never show the overview after removing workspace
This follows the core shell behavior, where we stopped doing this
a while ago.

https://bugzilla.gnome.org/show_bug.cgi?id=728865
2014-04-24 19:15:43 +02:00
Florian Müllner
c005393398 auto-move-windows: Take workspaces in startup sequences into account
See https://bugzilla.gnome.org/show_bug.cgi?id=664202 for the
corresponding patch in core shell.

https://bugzilla.gnome.org/show_bug.cgi?id=728865
2014-04-24 19:15:42 +02:00
Florian Müllner
7f008aa3ff auto-move-windows: Respect keep-alive flag in checkWorkspaces
https://bugzilla.gnome.org/show_bug.cgi?id=728865
2014-04-24 19:15:42 +02:00
Florian Müllner
c8b67cb84d auto-move-windows: Move check for dynamic workspaces
Move the check into checkWorkspaces rather than replacing the function
conditionally, to handle changes to the setting.

https://bugzilla.gnome.org/show_bug.cgi?id=728865
2014-04-24 19:15:40 +02:00
Florian Müllner
fee5495692 auto-move-windows: Fix fallout from API change
MetaWindowActor.get_workspace() was removed, however the now used
MetaWindow.get_workspace() returns a MetaWorkspace rather than an
index, so can't be used directly.

https://bugzilla.gnome.org/show_bug.cgi?id=728820
2014-04-24 13:09:11 +02:00
Florian Müllner
ec49693c6f auto-move-windows: Remove unused parameters
meta_window_change_workspace_by_index() lost its timestamp parameter
a while ago.
2014-04-24 11:57:10 +02:00
Florian Müllner
f007807ea1 window-list: Don't shift message tray when on different monitors
The message tray is moved to the bottom-most monitor when there are
monitors below the primary monitor; in that case, we need to leave
the tray alone.

https://bugzilla.gnome.org/show_bug.cgi?id=728288
2014-04-17 18:34:25 +02:00
Giovanni Campagna
4a5521a9ba auto-move-windows: update for gnome-shell changes
meta_window_actor_get_workspace() was removed.
2014-02-20 01:10:15 +01:00
Giovanni Campagna
a42dcee6ec WindowList: allow switching windows with mouse scroll
This is something that gnome-panel supported, and apparently
some users would like to have it back, so restore this feature
on our window list too.

https://bugzilla.gnome.org/show_bug.cgi?id=723693
2014-02-19 17:21:45 +01:00
Florian Müllner
3cde65e85e window-list: Call destroy() on menus instead of their actors
PopupBaseMenu provides a destroy() method that will destroy the menu
actor and make sure that the menu will be removed from the corresponding
PopupMenuManager (if any). We miss the latter when we destroy the menu
actor directly, so use the menu method instead.

https://bugzilla.gnome.org/show_bug.cgi?id=724688
2014-02-18 21:12:16 +01:00
Florian Müllner
b87ddf1195 window-list: Only have a single context menu at any time
Depending on the number of windows, AppButtons use different right-click
menus ("Minimize" vs. "Minimize all").
As the menu for the multiple-windows case remains the same, it is created
and added just once. However this means that in the single-window case,
the corresponding PopupMenuManager will track two menus for the same
source actor, resulting in various misbehaviors.
Fix these issues by adding and removing the app context menu appropriately,
so that the PopupMenuManager tracks a single menu at any time.

https://bugzilla.gnome.org/show_bug.cgi?id=724688
2014-02-18 21:12:16 +01:00
Florian Müllner
c2fe2b5505 window-list: Sync hover after closing menus
StButton takes the hover state into account to decide whether a
series of events should be considered a click. So when dismissing
a menu by clicking on a different window/app button, its menu
cannot be triggered before leaving and re-entering the button
(and thus syncing the hover state).
Fix this by always syncing the hover state after a grab is dropped.

https://bugzilla.gnome.org/show_bug.cgi?id=724688
2014-02-18 21:12:16 +01:00
Florian Müllner
7e3db53dcd launch-new-instance: Update to changed API
https://bugzilla.gnome.org/show_bug.cgi?id=724428
2014-02-15 17:53:42 +01:00
Florian Müllner
c9a4d15f05 window-list: Filter skip-taskbar windows
Applications now track all their windows, not just the ones that are
expected to show up in the window list. So to restore the previous
behavior, we now have to filter out windows with the skip-taskbar
hint ourselves.

https://bugzilla.gnome.org/show_bug.cgi?id=724134
2014-02-11 17:58:14 +01:00
Florian Müllner
9c6c00f8a3 window-list: Restrict right-click actions to windows in list
While the list of windows in the left-click menu is filtered by
workspace, the minimize/maximize/close actions in the right-click
menu apply to all application windows on all workspaces.
This is fairly confusing, so restrict the actions to only apply
to windows that do appear in the left-click list.

https://bugzilla.gnome.org/show_bug.cgi?id=724134
2014-02-11 17:58:14 +01:00