workspace-indicator: Add missing return value to event handler
Event handlers are expected to return a boolean to indicate whether the event should be stopped or propagated further. Omitting the return value effectively means returning a random value, which can lead to unexpected behavior. Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell-extensions/-/merge_requests/423>
This commit is contained in:
@@ -448,8 +448,11 @@ class EditableMenuItem extends PopupMenu.PopupBaseMenuItem {
|
||||
}
|
||||
});
|
||||
this.connect('key-release-event', (o, event) => {
|
||||
if (event.get_key_symbol() === Clutter.KEY_e)
|
||||
this._editButton.checked = true;
|
||||
if (event.get_key_symbol() !== Clutter.KEY_e)
|
||||
return Clutter.EVENT_PROPAGATE;
|
||||
|
||||
this._editButton.checked = true;
|
||||
return Clutter.EVENT_STOP;
|
||||
});
|
||||
|
||||
global.stage.connectObject('notify::key-focus', () => {
|
||||
|
||||
Reference in New Issue
Block a user