From e9153db95459b04e68cff888604c0613f981e88f Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Florian=20M=C3=BCllner?= <fmuellner@gnome.org>
Date: Wed, 10 Sep 2025 13:55:45 +0200
Subject: [PATCH] workspace-indicator: Add missing return value to event
 handler

Event handlers are expected to return a boolean to indicate whether
the event should be stopped or propagated further. Omitting the
return value effectively means returning a random value, which can
lead to unexpected behavior.

Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell-extensions/-/merge_requests/423>
---
 extensions/workspace-indicator/workspaceIndicator.js | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/extensions/workspace-indicator/workspaceIndicator.js b/extensions/workspace-indicator/workspaceIndicator.js
index 80c46e39..476c2f3c 100644
--- a/extensions/workspace-indicator/workspaceIndicator.js
+++ b/extensions/workspace-indicator/workspaceIndicator.js
@@ -448,8 +448,11 @@ class EditableMenuItem extends PopupMenu.PopupBaseMenuItem {
             }
         });
         this.connect('key-release-event', (o, event) => {
-            if (event.get_key_symbol() === Clutter.KEY_e)
-                this._editButton.checked = true;
+            if (event.get_key_symbol() !== Clutter.KEY_e)
+                return Clutter.EVENT_PROPAGATE;
+
+            this._editButton.checked = true;
+            return Clutter.EVENT_STOP;
         });
 
         global.stage.connectObject('notify::key-focus', () => {