Marvin Schmidt and Laurent Pinchart
68683d3811
ipa: rkisp1: lsc: Use double instead of float to accumulate vector of doubles
...
clang-tidy's bugprone-fold-init-type check warns about this:
> ../src/ipa/rkisp1/algorithms/lsc.cpp:61:14: warning: folding type 'double' into type 'float' might result in loss of precision [bugprone-fold-init-type]
> float sum = std::accumulate(sizes.begin(), sizes.end(), 0.0f);
> ^
Fixes: b3e96411d8marvin.schmidt1987@gmail.com >
Reviewed-by: Umang Jain <umang.jain@ideasonboard.com >
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com >
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com >
2022-08-30 22:06:20 +03:00
Marvin Schmidt and Laurent Pinchart
372621352d
ipa: rkisp1: Remove redundant call of std::string::c_str()
...
The constructor of libcamera::File takes a const reference to a std::string
and clang-tidy's readability-redundant-string-cstr check warns about it:
> ../src/ipa/rkisp1/rkisp1.cpp:147:12: warning: redundant call to 'c_str' [readability-redundant-string-cstr]
> File file(settings.configurationFile.c_str());
> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> settings.configurationFile
Signed-off-by: Marvin Schmidt <marvin.schmidt1987@gmail.com >
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com >
Reviewed-by: Umang Jain <umang.jain@ideasonboard.com >
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com >
2022-08-30 15:26:43 +03:00
Marvin Schmidt and Laurent Pinchart
252561e77f
ipa: ipu3: Remove redundant call of std::string::c_str()
...
The constructor of libcamera::File takes a const reference to a std::string
and clang-tidy's readability-redundant-string-cstr check warns about it:
> ../src/ipa/ipu3/ipu3.cpp:330:12: warning: redundant call to 'c_str' [readability-redundant-string-cstr]
> File file(settings.configurationFile.c_str());
> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> settings.configurationFile
Signed-off-by: Marvin Schmidt <marvin.schmidt1987@gmail.com >
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com >
Reviewed-by: Umang Jain <umang.jain@ideasonboard.com >
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com >
2022-08-30 15:26:41 +03:00
Marvin Schmidt and Laurent Pinchart
7354fb3b89
test: camera: Remove redundant call of std::string::c_str()
...
libcamera::File::exists() takes a const reference to a std::string and
clang-tidy's readability-redundant-string-cstr check warns about it:
> ../test/camera/camera_reconfigure.cpp:182:21: warning: redundant call to 'c_str' [readability-redundant-string-cstr]
> if (File::exists(pname.c_str())) {
> ^~~~~~~~~~~~~
> pname
Signed-off-by: Marvin Schmidt <marvin.schmidt1987@gmail.com >
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com >
Reviewed-by: Umang Jain <umang.jain@ideasonboard.com >
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com >
2022-08-30 15:26:38 +03:00
Marvin Schmidt and Laurent Pinchart
18764a15c7
libcamera: media_device: Fix \sa tags for MediaDevice::link
...
doxygen didn't create proper links to the overloads of
MediaDevice::link because the signatures didn't match due to an
additional 'const'
While at it remove the unnecessary `MediaDevice::` and wrap the lines
Fixes: b65feafe32marvin.schmidt1987@gmail.com >
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com >
Reviewed-by: Umang Jain <umang.jain@ideasonboard.com >
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com >
2022-08-30 15:26:04 +03:00
Marvin Schmidt and Kieran Bingham
78150899dd
libcamera: camera: Order parameter documentation correctly
...
Signed-off-by: Marvin Schmidt <marvin.schmidt1987@gmail.com >
Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com >
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com >
Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com >
2020-06-05 09:29:40 +01:00
Marvin Schmidt and Kieran Bingham
99e8f21926
libcamera: ipa_module: Fix typo in function description
...
Signed-off-by: Marvin Schmidt <marvin.schmidt1987@gmail.com >
Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com >
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com >
Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com >
2020-06-05 09:29:40 +01:00
Marvin Schmidt and Kieran Bingham
46b3402b59
docs: Markup LD_PRELOAD as code
...
LD_PRELOAD is an environment variable, use code markup to reflect that
semantic
Signed-off-by: Marvin Schmidt <marvin.schmidt1987@gmail.com >
Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com >
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com >
Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com >
2020-06-05 09:29:40 +01:00
Marvin Schmidt and Kieran Bingham
c3c0afd94b
docs: coding-style: Change full stop to colon
...
Signed-off-by: Marvin Schmidt <marvin.schmidt1987@gmail.com >
Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com >
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com >
Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com >
2020-06-05 09:29:40 +01:00
Marvin Schmidt and Kieran Bingham
e18c7a14a3
docs: Remove trailing whitespace
...
Signed-off-by: Marvin Schmidt <marvin.schmidt1987@gmail.com >
Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com >
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com >
Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com >
2020-06-05 09:29:40 +01:00
Marvin Schmidt and Kieran Bingham
90c7ce6ad2
docs: Remove stray HTML tags
...
Signed-off-by: Marvin Schmidt <marvin.schmidt1987@gmail.com >
Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com >
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com >
Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com >
2020-06-05 09:29:40 +01:00
Marvin SchmidtandLaurent Pinchart
