Commit Graph

49042 Commits

Author SHA1 Message Date
Pasty Chang
b8af3afff8 Merge "Migrating to new footer button for fingerprint and face enrolling pages." 2018-12-20 07:07:29 +00:00
Jason Chiu
02395bf67f Merge "Add Icon at the start of the first row for all contextualcards" 2018-12-20 03:56:47 +00:00
TreeHugger Robot
7ee2f0fe57 Merge "Replace ArgumentCaptor with getReceiversForIntent()" 2018-12-20 03:46:46 +00:00
TreeHugger Robot
307b83ea81 Merge "Fix talkback speaks "double tap to activate" on preference" 2018-12-20 03:39:22 +00:00
Jason Chiu
4bc29425d9 Add Icon at the start of the first row for all contextualcards
- set Icon as a title item rather than an end item in slice builders
- call showTitleItems in renderer

Test: robotest
Bug: 119639527
Change-Id: I043173968ceb3d34e38c2e43ad824b923e647d47
2018-12-20 03:07:19 +00:00
timhypeng
e7cc5d6431 Replace ArgumentCaptor with getReceiversForIntent()
Bug: 117989208
Test: make -j RunSettingsRoboTests
Change-Id: I0a790a6af4075fbb2228aa77c3a4e237d89e3b98
2018-12-20 01:52:08 +00:00
Lei Yu
08caceba9c Merge "Add translatable="false" for config string array" 2018-12-20 01:11:30 +00:00
Raff Tsai
736eae02bd Fix talkback speaks "double tap to activate" on preference
Talkback will speak "double tap to activate" on clickable view.
But the SliderPreference is not clickable. Because it is default
clickable for Preference. We should set android:selectable in every
SliderPreference.

Change-Id: I7bf09c2a7e2d8688352e35c1882674b6e73e5db7
Fixes: 121111172
Test: Manual
2018-12-20 06:57:52 +08:00
jackqdyulei
0edddca95a Add translatable="false" for config string array
Change-Id: Ic6a5423afe8fdb5b877140c5aaf16f65026135a3
Fixes: 115712164
Test: Manual
2018-12-19 14:42:14 -08:00
Aurimas Liutikas
727ce8ec66 Merge "Revert "Revert "Fix test case fail""" 2018-12-19 22:41:46 +00:00
TreeHugger Robot
347829525c Merge "Fix test" 2018-12-19 22:24:22 +00:00
Matthew Fritze
7fa8e3131d Merge "Move Panel to public API" 2018-12-19 19:21:46 +00:00
Philip P. Moltmann
adc1fbc37a Merge "Use new UsbManager#getPorts API" 2018-12-19 19:10:06 +00:00
Fan Zhang
fb643dc4b5 Revert "Revert "Fix test case fail""
This reverts commit 75261d01df.

Reason for revert: roll forward

Change-Id: I0b66ba4ea918baf54ae084f6281c172a07b160b2
2018-12-19 18:57:12 +00:00
Fan Zhang
088bfaab6b Merge "Revert "Fix test case fail"" 2018-12-19 18:28:55 +00:00
Fan Zhang
75261d01df Revert "Fix test case fail"
This reverts commit 6d387e4a5f.

Reason for revert: collateral damage for b/121116425

Change-Id: I3ba716e283bf466ad8603c1d8c64861febec9a8c
2018-12-19 18:26:10 +00:00
TreeHugger Robot
9f7927f6d5 Merge "Hide wifi card sometimes." 2018-12-19 17:42:58 +00:00
TreeHugger Robot
085d2b2018 Merge "Fix test case fail" 2018-12-19 17:31:12 +00:00
pastychang
1b1666855e Migrating to new footer button for fingerprint and face enrolling pages.
Bug: 120805516
Test: RunSettingsRoboTests
Change-Id: I89a5e3674b8ba9ec66945c03c9b783664eee214f
2018-12-19 23:24:48 +08:00
tmfang
6d387e4a5f Fix test case fail
The implementation in PreferenceGroup is changed,
contentEquals doesn't accept null value.

We filter null key case in InstrumentedPreferenceFragment.

Test: robotest
Change-Id: I575d96361edf9bf0b20f7ad4c61d8b3813bf31d9
Fixes: 121232342
2018-12-19 18:38:10 +08:00
Kevin Chyn
ed889a3788 Merge "Add accessibility for Face" 2018-12-19 07:55:04 +00:00
Kevin Chyn
2c8d7757f6 Add accessibility for Face
Bug: 111548033

Test: manual
Change-Id: I6638d471f5c6de76934b90d131a221813a38d2b3
2018-12-18 19:16:16 -08:00
TreeHugger Robot
0ade53c9b5 Merge "Fix crash in BatteryUtils" 2018-12-19 02:04:29 +00:00
TreeHugger Robot
03653641a2 Merge "Add sliceUri in broadcast intent" 2018-12-19 01:47:11 +00:00
Lei Yu
abcfa26bf6 Merge changes from topic "bluetooth_uri"
* changes:
  Add feature provider for bluetooth settings
  Build infra to inject slice to PreferenceFragment
2018-12-19 01:39:43 +00:00
TreeHugger Robot
b807a53bb0 Merge "Clean up AndroidManifest" 2018-12-19 00:08:48 +00:00
Kevin Chyn
549cdc66ad Merge "Show Choose/ConfirmLock before showing BiometricEnrollIntroduction" 2018-12-18 23:53:43 +00:00
jackqdyulei
2def5ccb6c Fix crash in BatteryUtils
When enhanced estimation is enabled, it may still have malfunction
when getting data from it. This CL handles this case and fall back
to default estimation.

Change-Id: Id8d75b07316afa8a73a302b49dc7f8e8b77d4fa4
Fixes: 121213171
Test: RunSettingsRoboTests
2018-12-18 15:26:07 -08:00
Fan Zhang
c002cd5d5e Fix test
Change-Id: I47d2533295e4cbf8f11654d4d3ee2740f971ad67
Fixes: 119829673
Test: robotests
2018-12-18 14:54:38 -08:00
jackqdyulei
bdc4ea6336 Add feature provider for bluetooth settings
Also add method to get settings uri for specific device. Use feature
provider here because it give us more flexibility.

Bug: 120803703
Test: RunSettingsRoboTests
Change-Id: I6f4840e76279c02a75b95fdecd822a72cb0b42e5
2018-12-18 14:42:49 -08:00
jackqdyulei
cf6374e427 Build infra to inject slice to PreferenceFragment
Reuse the PreferenceController and LayoutPreference however create
specific one for slice:
1. SlicePreference: container to inject slice view
2. SlicePreferenceController: handle updates for slice

Also add styles for it with default layout.

Bug: 120803703
Test: RunSettingsRoboTests

Change-Id: I6ab083ad57117e6198dcba37702a25213da78719
2018-12-18 14:38:25 -08:00
Hongming Jin
f969bb48e7 Merge "Add special apps access settings page for financial app." 2018-12-18 22:20:40 +00:00
Kevin Chyn
69e8a089d7 Show Choose/ConfirmLock before showing BiometricEnrollIntroduction
Skip button is now shown when ChooseLock is launched by
BiometricEnroll, otherwise users are forced to use passwords
(maybe good thing?)

Bug: 111548033

Test: Pin/pattern/pass must be set/confirmed before enrollment
Test: Able to enroll FP in SUW and Settings

Change-Id: Ic4bbeb539e4bf01c1c402dec308943292b43406d
2018-12-18 13:59:45 -08:00
Lei Yu
306afbade6 Merge "Fix bug of not showing locked icon in WifiSettings" 2018-12-18 21:07:08 +00:00
Fan Zhang
ac4ad168fa Clean up AndroidManifest
- Remove unused intent-filter
- Remove parent activity on DND

Fixes: 121120881
Fixes: 121122216
Test: rebuild
Change-Id: I308b6de452bbcd5f293863d460ee22a72badfa1e
2018-12-18 12:54:51 -08:00
Hongming Jin
43374eabb8 Add special apps access settings page for financial app.
Test: manual test in settings app
Bug:111207447
Change-Id: Ifa3afba2fbfd2f874deeea35f5735ac3459eed17
2018-12-18 12:38:52 -08:00
Raff Tsai
f7a6d94863 Add sliceUri in broadcast intent
Bug: 119748954
Test: robolectric
Change-Id: I24eb8d5a274be60ba3395d05d2b306e185e7dcab
2018-12-19 02:29:52 +08:00
TreeHugger Robot
f30fb4b20b Merge "Fix some pages crash after importing AndroidX from build 5175906" 2018-12-18 18:19:48 +00:00
Fan Zhang
0db4ead2b3 Hide wifi card sometimes.
When there is a connected wifi, we now hide the wifi slice card.

However, if we initially shows this card but later wifi is connected
while the card is visible, we keep showing this card to avoid janky
animation. The card will be gone if user nagivates to a different UI and
comes back.

- Create a new slice ContextualWifiSlice for homepage use case, all
  special logic for homepage are added here.
- Change reference for WIFI_SLICE to CONTEXTUAL_WIFI_SLICE where make
  sense.

Change-Id: Ibd87f88058f357aabef0f7d68a5bf48350d75b06
Fixes: 121040746
Test: robotests
2018-12-18 10:18:08 -08:00
jackqdyulei
2fba1943fa Fix bug of not showing locked icon in WifiSettings
This bug only exist by launching WifiSettings from quick settings. Quick
settings launch this page by intent, where we use Theme.Settings.
However we only have frictionIconColor in Theme.SubSettings, not
Theme.Settings.

This CL move related attr to correct theme, so we won't show invisible
icon anymore.

Bug: 120710149
Test: Manual
Change-Id: Iae07f6ca19eda0bfbc352f03787b5a583c4066f2
2018-12-18 10:11:19 -08:00
TreeHugger Robot
682fc4e9a3 Merge "Move suggestion from LOCK_SCREEN to DEFAULT." 2018-12-18 17:56:18 +00:00
TreeHugger Robot
8c22eebb40 Merge "Don't have cards auto-filled in the foreground when a card gets dismissed." 2018-12-18 17:40:57 +00:00
Jason Chiu
a42a93bbfe Fix some pages crash after importing AndroidX from build 5175906
- Settings crash while entering Storage, Privacy, and Accounts page,
  because PreferenceGroup changed the API use from String#equals to
  String#contentEquals which doesn't support null keys.
- add a null check before calling findPreference

Test: robotest
Change-Id: I121cd9e4249fbdafbc67be65a09d770603e01044
Fixes: 121116425
2018-12-18 18:27:50 +08:00
Anton Hansson
f109282c8e Move Settings app to /product
Since this app is frequently customized by OEMs, it doesn't
fit in the mainline /system image right now. Move it to
/product.

Bug: 110072687
Test: make
Change-Id: Iee5940125af3f2a8543ecb3a68d7fba737acd77d
2018-12-18 09:51:08 +00:00
Yi-Ling Chuang
39dcad9bd1 Don't have cards auto-filled in the foreground when a card gets dismissed.
Currently if users dismiss a card or navigate back to the homepage,
new suggestions will be auto filled in. We should only add new cards
upon next visit.

Also fix suggestion cards undismissable problem.

Fixes: 121175037
Bug: 120628661
Test: robotests
Change-Id: I01d74aaaa21c8408e5cecafef04a7d52c97bccc5
2018-12-18 17:03:41 +08:00
Lifu Tang
45e9c56036 Merge changes from topic "location settings"
* changes:
  Display app stats for location permission
  Display recent location access in the widget
2018-12-18 08:43:31 +00:00
Arc Wang
9dbc040510 Merge "Fine tune UI layout files of WifiDppQrCodeScannerFragment & WifiDppQrCodeGeneratorFragment" 2018-12-18 07:26:47 +00:00
Pasty Chang
f41bbae1c4 Merge "Change to use footer button of setupcompat" 2018-12-18 07:01:55 +00:00
Cosmo Hsieh
0c4214a200 Merge "Add internal WifiTracker to get correct AccessPoint for WifiNetworkRequestDialog" 2018-12-18 06:15:35 +00:00
Lifu Tang
3da8f8d31d Display app stats for location permission
Bug: 120221631
Test: manually
Change-Id: I53f43079807759c50eeb62029bb0d8d1f84e1118
2018-12-17 21:13:08 -08:00