PawletOS/app_Settings
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Settings: Fix assertThat in tests

Browse Source 
Truth.assertThat is a fluent-style API. Fix the tests to actually
do something.

Found by errorprone.

Bug: 73513670
Test: m RunSettingsRoboTests
Test: m javac-check RUN_ERROR_PRONE=true
Change-Id: Ie0ab35348fa56c73e6257477a50ff130450e74e7
This commit is contained in:
Andreas Gampe
2018-02-26 11:28:21 -08:00
parent 8378efc6af
commit 72eb284ae7
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
tests/robotests/src/com/android/settings/applications/PictureInPictureSettingsTest.java
View File

@@ -97,8 +97,8 @@ public class PictureInPictureSettingsTest {
mProfileUserPackages.add(profileP2);
ArrayList<Pair<ApplicationInfo, Integer>> apps = mFragment.collectPipApps(PRIMARY_USER_ID);
assertThat(containsPackages(apps, primaryP1, profileP2));
assertThat(!containsPackages(apps, primaryP2, profileP1));
assertThat(containsPackages(apps, primaryP1, profileP2)).isTrue();
assertThat(containsPackages(apps, primaryP2, profileP1)).isFalse();
}
@Test
@@ -119,7 +119,7 @@ public class PictureInPictureSettingsTest {
ArrayList<Pair<ApplicationInfo, Integer>> apps = mFragment.collectPipApps(PRIMARY_USER_ID);
Collections.sort(apps, new PictureInPictureSettings.AppComparator(null));
assertThat(isOrdered(apps, primaryP1, profileP1, primaryP2, profileP2));
assertThat(isOrdered(apps, primaryP1, profileP1, primaryP2, profileP2)).isTrue();
}
private boolean containsPackages(ArrayList<Pair<ApplicationInfo, Integer>> apps,