From 72eb284ae7a29049c81a29f0926920a93e447830 Mon Sep 17 00:00:00 2001 From: Andreas Gampe Date: Mon, 26 Feb 2018 11:28:21 -0800 Subject: [PATCH] Settings: Fix assertThat in tests Truth.assertThat is a fluent-style API. Fix the tests to actually do something. Found by errorprone. Bug: 73513670 Test: m RunSettingsRoboTests Test: m javac-check RUN_ERROR_PRONE=true Change-Id: Ie0ab35348fa56c73e6257477a50ff130450e74e7 --- .../settings/applications/PictureInPictureSettingsTest.java | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tests/robotests/src/com/android/settings/applications/PictureInPictureSettingsTest.java b/tests/robotests/src/com/android/settings/applications/PictureInPictureSettingsTest.java index 77acb462462..b72afb63b9e 100644 --- a/tests/robotests/src/com/android/settings/applications/PictureInPictureSettingsTest.java +++ b/tests/robotests/src/com/android/settings/applications/PictureInPictureSettingsTest.java @@ -97,8 +97,8 @@ public class PictureInPictureSettingsTest { mProfileUserPackages.add(profileP2); ArrayList> apps = mFragment.collectPipApps(PRIMARY_USER_ID); - assertThat(containsPackages(apps, primaryP1, profileP2)); - assertThat(!containsPackages(apps, primaryP2, profileP1)); + assertThat(containsPackages(apps, primaryP1, profileP2)).isTrue(); + assertThat(containsPackages(apps, primaryP2, profileP1)).isFalse(); } @Test @@ -119,7 +119,7 @@ public class PictureInPictureSettingsTest { ArrayList> apps = mFragment.collectPipApps(PRIMARY_USER_ID); Collections.sort(apps, new PictureInPictureSettings.AppComparator(null)); - assertThat(isOrdered(apps, primaryP1, profileP1, primaryP2, profileP2)); + assertThat(isOrdered(apps, primaryP1, profileP1, primaryP2, profileP2)).isTrue(); } private boolean containsPackages(ArrayList> apps,