Commit Graph

81174 Commits

Author SHA1 Message Date
Treehugger Robot ffde6fdec8 Merge "Add logging for each migration type" into main 2025-03-14 09:31:34 -07:00
Treehugger Robot 0af5880d28 Merge "Revert "Remove DepartingAnimationTarget from BackMotionEvent(2/2)"" into main 2025-03-14 08:59:01 -07:00
Treehugger Robot 64927397af Merge "Fix KQS arrow button padding" into main 2025-03-14 08:14:16 -07:00
Jordan Silva 04dde14527 Merge "Fix app chip split icon position in RTL" into main 2025-03-14 07:27:00 -07:00
Jordan Silva 50a048bc38 Merge "Fix App Chip positioning in Fake Orientation" into main 2025-03-14 07:26:50 -07:00
Wei Sheng Shih be00793561 Revert "Remove DepartingAnimationTarget from BackMotionEvent(2/2)"
Revert submission 32129017-remove_departing_motion

Reason for revert: b/402422333

Reverted changes: /q/submissionid:32129017-remove_departing_motion

Change-Id: Id3dab47ddac90de8564379ce41cb7943bfb31fa4
2025-03-14 06:23:40 -07:00
Treehugger Robot 520403a822 Merge "Do not apply blur in overview on unsupported devices" into main 2025-03-14 05:50:26 -07:00
Jordan Silva b497f87814 Fix app chip split icon position in RTL
Fix: 403284758
Flag: com.android.launcher3.enable_overview_icon_menu
Test: Manual, please check b/326377497#comment7.
Test: OverviewImageTest
Test: OverviewSplitTaskImageTest
Change-Id: I217e491355f1221ac1840b2c7c47b1000e1ffe71
2025-03-14 12:01:12 +00:00
Jordan Silva 43ba3e9276 Fix App Chip positioning in Fake Orientation
This CL changes how the layoutDirection of the App Chip is handled and update translations in the PagedViewHandler for the app chip for fake orientation.

- The App Chip was updated to use the device layoutDirection instead of the same of RecentsView. This prevents the app chip being displayed in RTL when the device is LTR and vice-versa.
- It also applies the correct layout direction to `IconAppChipView` and its related views to ensure proper RTL behavior.
- RecentsView now updates layoutDirection for its children when updateChildTaskOrientation is called. This will make sure its children have the the latest and the correct layoutDirection.. Before it was only applied when adding a view (addView).
- In `SeascapePagedViewHandler`, it adjust the gravity for app chip be aligned correctly in Seascape.
- In `GroupedTaskView`, it checks if the device is in RTL to align the app chip correctly for split tasks.

- Multiple test combinations were done to validate this fix, please see table in b/326377497#comment7.

Fix: 326377497
Bug: 403284758
Flag: com.android.launcher3.enable_overview_icon_menu
Test: Manual, please check b/326377497#comment7.
Test: OverviewImageTest
Test: OverviewSplitTaskImageTest
Change-Id: I8e8050ccf58c3f90718a48773ee7e32ddbc00f13
2025-03-14 12:01:12 +00:00
Helen Cheuk 8b408e4767 Merge "Check null when getting drop view in DragController" into main 2025-03-14 04:05:23 -07:00
vinayjoglekar 559f8c514d Do not apply blur in overview on unsupported devices
Bug: 403475392
Test: Manual. Enter overview from app/home.
Flag: com.android.launcher3.enable_overview_background_wallpaper_blur
Change-Id: I280ad08e7d66f664598791d01a58a8d090e48a3f
2025-03-14 16:04:13 +05:30
Will Osborn 53cb4f2b42 Merge "Make TaskAnimationManager per-display" into main 2025-03-14 02:18:29 -07:00
Sukesh Ram a9b92cb68f Merge "[CD Taskbar] Stop External Taskbar Destruction on Window Close" into main 2025-03-14 00:17:32 -07:00
Sunny Goyal 370eabf534 Merge "Making ModelDbController injectable" into main 2025-03-13 23:20:17 -07:00
Toni Barzic 3c07c2156f Fix KQS arrow button padding
The padding values were set to their totals.
They needed to be halved.

Bug: 397975686
Flag: com.android.launcher3.taskbar_overflow
Test: None
Change-Id: Icae56e02fa6082b7f99b9fef265d6220b613d06b
2025-03-14 04:58:38 +00:00
Min Chen 3956f310c0 Merge "Get displayId from DesktopTask for DesktopTaskView" into main 2025-03-13 21:05:28 -07:00
Federico Baron 3da182844d Add logging for each migration type
Flag: EXEMPT logging
Test: n/a
Bug: 393175684
Change-Id: Idfa551cb1e83c3c3bce498b6986035460798b93b
2025-03-14 02:54:31 +00:00
Sukesh Ram dca6b4da8b [CD Taskbar] Stop External Taskbar Destruction on Window Close
When all windows on external taskbar are closed, exit desktop mode is trigggered. We stop this signal from destroying the external taskbar. This is because we want to be in desktop mode as long as we are connected to a non-mirroring display.

Flag: com.android.window.flags.enable_taskbar_connected_displays
Bug: 401553128
Test: m
Change-Id: I23b61172bb13f1377c4532a56e7838fbe2140f20
2025-03-13 16:15:08 -07:00
minch 68e116e79f Get displayId from DesktopTask for DesktopTaskView
Bug: 401011627
Flag: com.android.window.flags.enable_multiple_desktops_frontend
Flag: com.android.window.flags.enable_multiple_desktops_backend
Test: Added a test in RecentTasksListTest
Change-Id: I21164de812d57b79cd84370bbf0426268c4b645d
2025-03-13 22:24:22 +00:00
Ana Salazar Maldonado 4b40d05ebb Merge "Migrate desktop_form_factor to Launcher3" into main 2025-03-13 13:14:07 -07:00
Treehugger Robot 85db442ef1 Merge "Handle visibility of AddDesktopButton for overview/quickswitch" into main 2025-03-13 13:13:46 -07:00
Treehugger Robot d7c4922ddf Merge "Enable Perceptible tasks when in desktop mode." into main 2025-03-13 13:09:40 -07:00
Treehugger Robot f2ceba9ba7 Merge "Removing listeners from FolderInfo" into main 2025-03-13 12:48:34 -07:00
Treehugger Robot bfd041a055 Merge "Spring neighboring tasks on dismiss reflow." into main 2025-03-13 12:47:19 -07:00
Treehugger Robot 9b577bc9b5 Merge "Mark KQS arrow strings translatable" into main 2025-03-13 12:41:19 -07:00
Treehugger Robot c23c94520b Merge "Implementation of overview background blur" into main 2025-03-13 12:02:43 -07:00
Ana Salazar Maldonado fa6c0babc8 Migrate desktop_form_factor to Launcher3
Bug: 391958794
Flag: com.android.launcher3.enable_scalability_for_desktop_experience
Test: Verified manually
Change-Id: I7002e04eaf980e5037a6d33935457cb2d26cf5cd
2025-03-13 11:33:36 -07:00
Sunny Goyal 25f5c7e761 Making ModelDbController injectable
Bug: 361850561
Test: Updated tests
Flag: EXEMPT dagger
Change-Id: Ie600469476ce5eb60813a3c8b57b9445fcf82c24
2025-03-13 11:23:23 -07:00
Mady Mellor 6e9cc31ba2 Merge "Update flyout text view to use a diff font" into main 2025-03-13 11:21:25 -07:00
Treehugger Robot d8eac67aad Merge "Associate ResetGestureInputConsumer and NO_OP input consumers with display IDs" into main 2025-03-13 11:19:33 -07:00
Brandon Dayauon d6e638c5cd Merge changes from topic "privateProfileMoveContent" into main
* changes:
  Change private space app content description
  Don't show system shortcuts for the psApp
2025-03-13 11:03:01 -07:00
Suhua Lei c8fcf08dfd Handle visibility of AddDesktopButton for overview/quickswitch
This change introduces mDisallowScrollToAddDesk to handle the visibility
of AddDesktopButton in overview/quickswitch. In overview, set its scroll
as the first task; in quick switch, set its scroll out range of
[minScroll, maxScroll].

Bug: 398036110
Flag: com.android.window.flags.enable_multiple_desktops_frontend
Flag: com.android.window.flags.enable_multiple_desktops_backend
Test: manual quick switch
Change-Id: I5fada0c4c5bccc5572b458da9970e3524087508d
2025-03-13 10:50:21 -07:00
Sukesh Ram bf31635e25 Merge "Remove Taskbar WindowToken upon onDisplayRemoved" into main 2025-03-13 10:45:40 -07:00
Stefan Andonian 22574b46e8 Merge "Fix Entry Animations for VisualRefresh Page Indicator Dots" into main 2025-03-13 10:42:53 -07:00
Stefan Andonian d84dbe35d8 Merge "Fix Page Indicator Dots Arrow Clicks in RTL Mode" into main 2025-03-13 10:42:49 -07:00
Sunny Goyal 1ac78b6ec6 Removing listeners from FolderInfo
Folder and FolderIcon are UI objects and can talk to each other directly.
FolderInfo changes are already propogated via model callbacks, and doesn't need a separate listener pattern.

Bug: 398791288
Flag: EXEMPT bugfix
Test: atest FolderTest

Change-Id: Iefd47b8ea12a8ecaf34211a3d908220a0e999187
2025-03-13 10:28:07 -07:00
Shamali Patwa a29ec52cce Merge changes from topic "prp-fix" into main
* changes:
  Improve reliability of cleanup done in onDestroy.
  Change the studio build specific onEndCallback exception to a log.e
2025-03-13 10:25:06 -07:00
Toni Barzic 026306b793 Mark KQS arrow strings translatable
Bug: 397975686
Flag: EXEMPT bugfix
Test: None
Change-Id: I3911a7c9b9cd19388934355e684941acc27a1c01
2025-03-13 10:17:31 -07:00
vinayjoglekar 7d88ef3aae Implementation of overview background blur
- Remove overview background scrim color.
- Create blur layer and blur surface to set blur to behind live app tile.
- Handles cases like live tile to screenshot during AiAi and orientation change.

Bug: 377244819
Test: Manual. Enter overview from app/home.
Flag: com.android.launcher3.enable_overview_background_wallpaper_blur
Change-Id: I5dce0268f4421cd0ac29dbb429e5d106da7a0bdc
2025-03-13 22:30:27 +05:30
Orhan Uysal 5cb4bd1bcd Merge "Add logging to DesksUtils for debugging." into main 2025-03-13 09:57:04 -07:00
Li Lin a7bdabcef5 Merge "Add skeleton Growth Framework nudge controller." into main 2025-03-13 09:49:00 -07:00
Treehugger Robot 099fe40588 Merge "Use primary task size instead of width to compute dismiss gap." into main 2025-03-13 09:35:54 -07:00
Will Osborn 6c413c1e80 Make TaskAnimationManager per-display
Test: locally tested on Tangor
Flag: com.android.launcher3.enable_overview_on_connected_displays
Bug: 402362875
Change-Id: I6acb166c200e8bd9198e2aa73e506b3c3414f526
2025-03-13 16:14:46 +00:00
Orhan Uysal 4ea154cb28 Add logging to DesksUtils for debugging.
Bug: 403118101
Test: m
Flag: EXEMPT adding logs
Change-Id: I10305afcb10199b820567714422356158e894d2b
2025-03-13 16:08:17 +00:00
Schneider Victor-Tulias 9419102ec1 Associate ResetGestureInputConsumer and NO_OP input consumers with display IDs
All input consumers should be associated with display IDs, especially since these are used by TouchInteractionService.onConsumerInactive and they will be using per-display objects.

Flag: com.android.launcher3.enable_gesture_nav_on_connected_displays
Bug: 382130680
Test: InputConsumerUtilsTest
Change-Id: Ic14121db2361da1f0a819221b85256b1b3926774
2025-03-13 15:58:30 +00:00
helencheuk de869b3624 Check null when getting drop view in DragController
When the flag is on, there are some cases dropTarget is null:
TaplTestsTaskbar.testOpenMenu_fromTaskbarAllApps
TaplTestsTaskbar.testLaunchShortcutInSplitscreen
TaplTestsTaskbar.testLaunchShortcut

Add logic to check null before getting drop view and calling drop complete.

Bug: 343650193
Test: TaplTestsTaskbar.testOpenMenu_fromTaskbarAllApps
Test: TaplTestsTaskbar.testLaunchShortcutInSplitscreen
Test: TaplTestsTaskbar.testLaunchShortcut
Flag: com.android.launcher3.remove_apps_refresh_on_right_click
Change-Id: If8ce93bd6f7d0506e2272ca17dd7c19666549cfa
2025-03-13 15:21:11 +00:00
Pat Manning 32f730b38b Spring neighboring tasks on dismiss reflow.
Fix: 389081477
Test: TaplTestsQuickstep
Flag: com.android.launcher3.enable_expressive_dismiss_task_motion
Change-Id: I9a354ce6471fee7b6e23b3a5cf97f2866c870abd
2025-03-13 15:18:40 +00:00
Shamali P 9cf28d1772 Improve reliability of cleanup done in onDestroy.
As seen in the bug, an exception caused rest of onDestroy to not clean
up the other objects - which could cause other leaks.

So, for somewhat non-trivial clean ups, I've wrapped them in try-catch.
This way, with Log.e we still will know about them, but not crash
destruction of activity and other clean up.

Bug: 400793700
Flag: EXEMPT BUGFIX
Test: Leak canary and studio heap dump
Change-Id: I45e7298394eafff182a2c800eebfa5f772fbe2de
2025-03-13 14:26:55 +00:00
Pat Manning 62a57cf13b Use primary task size instead of width to compute dismiss gap.
This fixes issues for fake landscape.

Fix: 403233871
Test: Manual.
Flag: com.android.launcher3.enable_expressive_dismiss_task_motion
Change-Id: I5b98e9d6c191c8cc951ae19b1f5e42fce2922c08
2025-03-13 14:18:36 +00:00
Sergey Pinkevich 6aaec1a019 Merge "Add end animation listener for trampoline animation" into main 2025-03-13 04:46:50 -07:00