- Made TaskThumbnailViewDeprecated nullable in TaskContainer, with non-null getter that requires feature flag to be on/off
- Removed TaskThumbnailViewDeprecated.setTaskOverlay, as it'll now be null with feature flag on
- Removed TaskThumbnailViewDeprecated from DesktopTaskView xml
- Simplifed DesktopTaskView binding logic, to always get thumbnailViews from viewPool, removeView and recycle all thumbnailViews in onRecycle
- Didn't implement view pooling of TaskThumbnailView due to difficulty with TaskContainer not being recycled togetehr with TaskThumbnailView
Bug: 338360089
Test: TaskThumbnailViewModelTest
Test: manual testing for DesktopTaskView for both enable_refactor_task_thumbnail on and off
Flag: com.android.launcher3.enable_refactor_task_thumbnail
Flag: com.android.window.flags.enable_desktop_windowing_mode
Change-Id: I38a6dfc6bc561689578d1660794f91d30bad4a68
* changes:
Override DisplayController on main thread.
Add annotations for manipulating secure settings.
Don't use UiThreadTest for Taskbar Unit tests.
Suspend Launcher taskbar while removed for tests.
* RecentsView#onAttachedToWindow relies on splitSelectStateController
being initialized, so we now do it before RecentsActivity calls
setContentView()
Bug: 332643607
Test: Couldn't repro before or after :(
Flag: EXEMPT bugfix
Change-Id: Ic26460e08ca74adcf6dcf31abc956ad57f4061c2
Fix: 336697780
Test: Manual testing, open widget picker on folded front screen and then unfold, the widget picker should be showing and the backgesture should work.
Flag: EXEMPT bugfix
Change-Id: Ie4a7bffbd9b24ba26826f825a7c66216f565952f
- Also migrated getScaledInsets method into TaksOverlay
Bug: 335606129
Test: TaskOverlayViewModelTest
Test: TaskOverlayHelper is not tested because it should be a view-based screenshot test for TaskOverlay, which is currently impossible until we refactor TaskOverlay to MVVM
Flag: com.android.launcher3.enable_refactor_task_thumbnail
Change-Id: I07a8657ff0fe925d8021875310e3ed12a712ba7a
This is to keep the main launcher aconfig file more organized and easier to read and aligned with gantry namespace.
Bug: 349534860
Change-Id: Ib21fbac38ed0564fa481fce3a2da9a9b8c1a7139
Flag: EXEMPT - moving flags to another file
Test: EXEMPT - moving flags to another file
By default, tests will run with user setup complete and kids mode
disabled.
Test: TaskbarUnitTestRuleTest
Flag: TEST_ONLY
Bug: 230027385
Change-Id: If6c74b3b2c07aa0eac5b6bda933b565351d65188
This annotation also runs the rule on the main thread, which can lead to
deadlocks with other threads (e.g. loading the model synchronously).
Change-Id: Ib276e9dc322f6f65bd32658e774d6076efb94f2e
Flag: TEST_ONLY
Test: Taskbar Unit Tests
Bug: 230027385
This approach is less destructive than completely destroying Taskbar
while still ensuring it will not try to recreate itself.
Test: Taskbar Unit Tests
Bug: 230027385
Flag: TEST_ONLY
Change-Id: Ida0f7cc0b9c5b1d53bbadc2bb9fd81689c7f3940
In the past, tap didn't do anything, but now that we reveal add button
it should be kept.
Bug: 335029809
Flag: EXEMPT BUGFIX
Test: With switch access (see video)
Change-Id: I2ca9086f0dd4b0c9ac8167ab32aa278d4e2d1211
This change stores the bubble that was dismissed by drag temporarily
in BubbleBarView so that when we remove the bubble, we can avoid
updating it as part of the animation.
This is step 1 in this change. Next I'll look into removing the
bubble immediately after dismissing it from the menu, and lastly
update sysui to not send the removal event back to launcher.
Flag: com.android.wm.shell.enable_bubble_bar
Bug: 349826879
Test: manual
- have bubbles in the bubble bar and expand it
- drag a bubble to dismiss it
- observe the bubble does not reappear in the bar during
the animation
Change-Id: I6628ce779db4aac8d82edd4ecf2a25dedf8feef9
Removed the check on safeInsets#top and apply the offset.
Updated also the comment.
Flag: EXEMPT bugfix
Bug: 331128612
Test: Hold unfolded foldable in different orientation, enter PiP
Test: Hold folded foldable in different orientation, enter PiP
Change-Id: I56442ab2c4bfb1bf7ac68561aee8c0cc1fb183a8
fbaron
Treehugger Robot
Alina Zaidi
Alex Chau
Uwais Ashraf
Brian Isganitis
Sebastián Franco
Vinit Nayak
Olivier St-Onge
Liran Binyamin
Shamali Patwa
Pat Manning
Jordan Silva
Zak Cohen
Hongwei Wang
Saumya Prakash
Tracy Zhou