Commit Graph

14084 Commits

Author SHA1 Message Date
Alex Chau fc5a07e40b Revert "Remove unnecessary call to RecentsView.reset when switching from any non-overview state."
This reverts commit 162a85e777.

Reason for revert: b/406430367

Change-Id: I1be60513d8f034d6aab9489a95f98a7a0f16d26d
2025-03-26 07:41:36 -07:00
vinayjoglekar 162a85e777 Remove unnecessary call to RecentsView.reset when switching from any non-overview state.
We were checking whether recents is visible or not while opening all
apps and calling RecentsView#reset. Since Recents is not visible, we
were always calling reset which was making additional blur. Adding check
here of what current state is, will reduce these calls.

Added perfetto traces comparison here

https://drive.google.com/drive/folders/146K_4WLaOGQcZ1gsuhCFlOCzfZ-mJBw8?resourcekey=0-r1-NnNtYGH88d8DGEvnXZg&usp=sharing

Bug: 404647629
Test: Manual. Launcher home -> all apps.
Flag: EXEMPT bugfix
Change-Id: If0e31638adee50d36974abd7a4c809e3747f37a0
2025-03-25 03:40:18 -07:00
Treehugger Robot 88b2f23a83 Merge changes from topic "ttt-refactor" into main
* changes:
  Migrate to TopTaskTracker.getPlaceholderGroupedTaskInfo
  Introduce TopTaskTracker.getPlaceholderGroupedTaskInfo
2025-03-22 08:35:44 -07:00
Treehugger Robot 43b4273e91 Merge "[Memory Leak] Avoid spamming DragLayer's run queue" into main 2025-03-21 22:54:24 -07:00
minch 13e1445773 Migrate to TopTaskTracker.getPlaceholderGroupedTaskInfo
Migrate all the call sites of `TopTaskTracker.getPlaceholderTasks`
and `getSplitPlaceholderTask`s to the new API
`getPlaceholderGroupedTaskInfo`

Bug: 401582344
Flag: EXEMPT refactor
Test: m
Change-Id: I0d71508f4dd9633fea025ed842c4c048d0e70462
2025-03-22 05:23:06 +00:00
minch fba9726258 Introduce TopTaskTracker.getPlaceholderGroupedTaskInfo
This CL just introduces an API inside TopTaskTracker to return
a GroupedTaskInfo, no existing logic being migrated to it yet.

It will be used to replace `getPlaceholderTasks` and
`getSplitPlaceholderTasks` in the follow-up cls.

Bug: 401582344
Flag: EXEMPT, introduce a new API without usage
Test: m
Change-Id: Ic12003833605582d191c4abfd4a0878c266dd30f
2025-03-22 05:22:05 +00:00
Sukesh Ram 54f23ff654 Fix Pinning Animation
Fix Pinning Animation.

Flag: EXEMPT not adding new behavior
Bug: 405469510
Test: m
Change-Id: Iabc580031495f39902cb4d718ab12a7362c07d13
2025-03-21 17:18:45 -07:00
Fengjiang Li 8c7805b67a [Memory Leak] Avoid spamming DragLayer's run queue
Avoid adding duplicated ViewTreeObserver#addOnDrawListener from DepthController

Fix: 405158421
Flag: NONE - released code
Test: manual - presubmit
Change-Id: Ib59c130667c5c0a012de3205d11c8de1d6de3903
2025-03-21 13:40:17 -07:00
Treehugger Robot 500698152c Merge "Hide scroll arrows from Alt+Tab UI" into main 2025-03-21 11:41:55 -07:00
Saumya Prakash cfe62a68d2 Merge "Ensure back button shows up in Simple View for SUW" into main 2025-03-21 10:41:59 -07:00
Saumya Prakash 91a081f26c Merge "Shift to using SUW System property flag for expressive theme" into main 2025-03-21 09:10:33 -07:00
Alex Chau df6dc455a7 Merge changes from topic "revert_task_content_view" into main
* changes:
  Revert "Add TaskContentView parent to TaskThumbnailViewHeader and TTV"
  Revert "Remove redundant FrameLayout from task_header_view.xml"
2025-03-21 04:14:36 -07:00
Treehugger Robot a75e779ee8 Merge "[CD Taskbar] Bypass binder calls for TaskbarManager#getDefaultDisplayId()" into main 2025-03-20 16:25:34 -07:00
Treehugger Robot fe15021226 Merge "Fix back button not reacting to accessibility actions (2)" into main 2025-03-20 15:43:52 -07:00
Li Lin ce62f1d47a Merge "Add action performers for Growth Framework." into main 2025-03-20 14:13:14 -07:00
Sukesh Ram 602874bb51 [CD Taskbar] Bypass binder calls for TaskbarManager#getDefaultDisplayId()
Calls to TaskbarManager#getDefaultDisplay() were making binder calls each time, which caused a crash in cases where binder is blocked. Now, I cache the default displayId avoid these calls.

Flag: EXEMPT not adding new behavior
Bug: 400606685
Test: m
Change-Id: I4a0c0d0c99efb137119b2299d3259541379a6bb6
2025-03-20 13:57:35 -07:00
Jagrut Desai bda2a6fb10 Merge "Fix 3-button nav diplacement on lockscreen" into main 2025-03-20 13:49:54 -07:00
Mykola Podolian c12d67c4e0 Merge "Drag and drop from the search view on the overview screen." into main 2025-03-20 13:40:29 -07:00
Treehugger Robot 0d58891187 Merge "Reset IconAppChipView drawables when TaskContainer is destroyed" into main 2025-03-20 13:34:27 -07:00
Randy Pfohl ccab1b83e8 Merge "Small refactor to displayDecor listeners" into main 2025-03-20 13:31:08 -07:00
Treehugger Robot 00310cd372 Merge "Get top task per display from TopTaskTracker" into main 2025-03-20 12:19:06 -07:00
Saumya Prakash 850ee61de6 Ensure back button shows up in Simple View for SUW
This change adds support for the dynamic changing of navigation modes in
SUW such that the back button will be visible in both states. Previously
there was no way to switch navigation modes during Setup Wizard, before the
introduction of Simple View. The buttons were not being drawn correctly
(or at all).

Fix: 381016997
Fix: 381363853
Test: Rerun SUW, enable simple view and ensure that the back buttons
works in both orientations and that the SUW buttons are unaffected
Flag: EXEMPT bugfix

Change-Id: Ifbdf0c9cd06f1347e6c2c9a943711cefbf6bff2c
2025-03-20 19:17:32 +00:00
Jordan Silva 3795b04634 Reset IconAppChipView drawables when TaskContainer is destroyed
Bug: 405116138
Flag: com.android.launcher3.enable_overview_icon_menu
Test: OverviewImageTest
Test: OverviewSplitTaskImageTest
Test: OverviewMenuImageTest
Test: Manual. Instructions in the bug.
Change-Id: I6f0d63867147995461ada7c21ad1ab22a26a9f55
2025-03-20 11:07:03 -07:00
Sukesh Ram 19de54a02d Merge "[CD Taskbar] Null Protect Taskbar against onLauncherVisibilityChange crash" into main 2025-03-20 10:26:33 -07:00
Schneider Victor-tulias f30a5e3cce Merge changes Id10bb2ac,Ie8edd55b into main
* changes:
  Have Taskbar listen for RecentsState as well
  Fix TaskarUIController being wrong with Overview-in-Window enabled
2025-03-20 10:09:18 -07:00
Will Osborn 7e3c0c2249 Get top task per display from TopTaskTracker
Test: locally tested on tablet
Flag: com.android.launcher3.enable_overview_on_connected_displays
Bug: 402362465
Change-Id: I0eb66c5c931fe30ce954657ee1b0eb2d87e58943
2025-03-20 16:40:28 +00:00
Mykola Podolian 6ddfa5dfd5 Drag and drop from the search view on the overview screen.
When the bubble bar is stashed and an icon is dragged from the search
grid towards it, the bubble bar should be un-stashed. Conversely, if the
icon is dragged to the opposite location of the stashed bubble bar, the
handle should teleport out, and the collapsed bubble bar should
teleport in.
This change implements logic that addresses this behavior.

Bug: 399678274
Test: Manual. Drag and drop application icons from the search grid to
the bubble bar drop areas.
Flag: com.android.wm.shell.enable_create_any_bubble

Change-Id: Ief9ef3e5c24f8199b2812fd0adf63ae3f6cf8f32
2025-03-20 09:39:35 -07:00
Jordan Silva efb3f85615 Merge "Set the elevation for TaskMenuView when overview icon menu is enabled." into main 2025-03-20 09:22:09 -07:00
Randy Pfohl 941634bb53 Small refactor to displayDecor listeners
Test: Ran tests and verified callbacks

Flag: com.android.launcher3.enable_launcher_overview_in_window

Bug: 292269949

Change-Id: I33a4219209495f1960094ba766c1d5c82d70d9d1
2025-03-20 15:00:33 +00:00
Treehugger Robot aa53bd3392 Merge "Allow fast flinging to cancel task dismiss." into main 2025-03-20 07:15:16 -07:00
Uwais Ashraf bbe63db85c Merge changes from topic "cleanup-existing-update-disabled-flags" into main
* changes:
  Remove existing superceded calls to updateDisableFlags
  Change actions view disabling logic
2025-03-20 07:00:19 -07:00
Pat Manning 90eceafb5f Merge "Update recents focus when TOGGLE command is issued to OverviewCommandHelper." into main 2025-03-20 06:42:50 -07:00
Sukesh Ram cb38ecbc8c [CD Taskbar] Null Protect Taskbar against onLauncherVisibilityChange crash
Null Protect Taskbar against onLauncherVisibilityChange crash.

Flag: EXEMPT not adding new behavior
Bug: 403294086
Bug: 404928723
Test: m
Change-Id: I84e899d26f93d484031073d1b63c6757daa8b141
2025-03-20 05:22:18 -07:00
Johannes Gallmann 3db6f288a3 Fix back button not reacting to accessibility actions (2)
This line was accidentally not put behind the flag in the last CL.

Bug: 403184586
Test: Manual, i.e. verified that back button is clickable with TalkBack
      enabled. Also verified no regressions in kids themed taskbar.
Flag: com.android.window.flags.predictive_back_three_button_nav
Change-Id: Ia495e3f25e0c15815cb8d26254ecacfe245864a4
2025-03-20 13:20:32 +01:00
Alex Chau 77ddc254cc Revert "Add TaskContentView parent to TaskThumbnailViewHeader and TTV"
This reverts commit e0cc96df62.

Reason for revert: b/403826044, b/402277471

Flag: EXEMPT revert

Change-Id: I0c6e507753bf47be4f74b6056de75d981f0c2848
2025-03-20 04:45:52 -07:00
Pat Manning 1ecece51d7 Update recents focus when TOGGLE command is issued to OverviewCommandHelper.
Removing condition that was added in ag/32267401.

Fix: 404098161
Test: Manual.
Flag: EXEMPT bugfix
Change-Id: I62d061d3c5588c846038b580f323aaebb9c667cf
2025-03-20 04:24:07 -07:00
Pat Manning 0ad72c5837 Allow fast flinging to cancel task dismiss.
Fix: 404213155
Test: Manual. Fling tasks back to rest state.
Flag: com.android.launcher3.enable_expressive_dismiss_task_motion
Change-Id: I7b738b80c375fe96994798ffadc9b5f77dd8a208
2025-03-20 11:22:40 +00:00
Alex Chau 7034889756 Revert "Remove redundant FrameLayout from task_header_view.xml"
Revert submission 32215257-b/401469907-remove-redundant-headerview-layout

Reason for revert: b/403826044, b/402277471

Reverted changes: /q/submissionid:32215257-b/401469907-remove-redundant-headerview-layout

Change-Id: I5c619179c849f8b65484937ed0c37623612316f8
2025-03-20 11:11:00 +00:00
Johannes Gallmann be97a35d31 Merge "Fix back button not reacting to accessibility actions" into main 2025-03-20 03:50:14 -07:00
Johannes Gallmann 4d1ab3a784 Fix back button not reacting to accessibility actions
Bug: 403184586
Test: Manual, i.e. verified that back button is clickable with TalkBack
      enabled. Also verified no regressions in kids themed taskbar.
Flag: com.android.window.flags.predictive_back_three_button_nav
Change-Id: Ie6fd6b7d8a76cdac0389c4dd33f8cb62f689ba61
2025-03-20 09:24:27 +01:00
Treehugger Robot 57f0e8ebe6 Merge "Add flag to gate checking last task visibility on dismiss." into main 2025-03-20 00:36:11 -07:00
Jagrut Desai 642f8be48d Fix 3-button nav diplacement on lockscreen
Test: Manual
Bug: 375112190
Flag: EXEMPT bugfix
Change-Id: I7f7d82563c2956aaafff91a75e79e4e2b554230e
2025-03-19 16:06:12 -07:00
Priyanka Advani (xWF) 5283a91609 Merge "Revert^3 "Inflate TaskThumbnailViewDeprecated as TaskContentView"" into main 2025-03-19 14:53:59 -07:00
Priyanka Advani (xWF) 92aef0d99a Revert^3 "Inflate TaskThumbnailViewDeprecated as TaskContentView"
This reverts commit bca368924c.

Reason for revert: Droidmonitor created revert due to b/404894013. Will be verifying through ABTD before submission.

Change-Id: If43e23bca9f7e62f26ee3c977cac643fcda3e3e6
2025-03-19 12:56:55 -07:00
Tony Wickham 81469da43b Have Taskbar listen for RecentsState as well
Also update parallel animation to GestureEndState instead of
assuming it's always a LauncherState.

Fixes: 401382426
Test: manual/existing automated tests
Flag: com.android.launcher3.enable_fallback_overview_in_window
Flag: com.android.launcher3.enable_launcher_overview_in_window

Change-Id: Id10bb2ac5601462a3885d24d6484889ddfeb59d6
2025-03-19 11:59:54 -07:00
Li Lin 5f5f5abb60 Add action performers for Growth Framework.
The action performers will be used for performing actions that triggered
by clicking on nudge buttons.

Bug: 398033012
Test: Manual
Flag: com.android.launcher3.enable_growth_nudge
Change-Id: I6d80542b10fd6442e716126ceb3123bbc0d1cf07
2025-03-19 11:57:18 -07:00
Tony Wickham 32888e1519 Fix TaskarUIController being wrong with Overview-in-Window enabled
- isHomeAndOverviewSame now returns true for launcher in window
- added isHomeAndOverviewSameActivity to differentiate specifically
  when Overview is hosted in the Launcher activity (currently only
  used for launcherChildTask handling, which we can clean up in a
  follow up change)
- overviewIntent now equals homeIntent for launcher in window
- fixed containerInterface to always use FallbackoverviewInWindow
  when overview-in-window is enabled; this means TaskbarManager
  gets the proper RecentsViewContainer for creating the correct
  TaskbarUIController
- updated getSwipeUpHandlerFactory based on isHomeAndOverviewSame
  change above

Fixes: 401382430
Test: InputConsumerUtilsTest, manual
Flag: com.android.launcher3.enable_fallback_overview_in_window
Flag: com.android.launcher3.enable_launcher_overview_in_window

Change-Id: Ie8edd55b47d6438af36b9d2a788d72d69afa02f3
2025-03-19 11:37:19 -07:00
Uwais Ashraf f7d0e2a576 Remove existing superceded calls to updateDisableFlags
Fix: 402351284
Flag: com.android.launcher3.enable_refactor_task_thumbnail
Test: OverviewImageTest (attached abtd run)
Test: OverviewMenuImageTest (attached abtd run)
Change-Id: Iffea8cd0afea52cfbfd8ed44a956da0aa26e91c6
2025-03-19 18:04:01 +00:00
Uwais Ashraf 7fd33ebde5 Change actions view disabling logic
1. Introduces "central task" - the task relating to the actions view
2. Decouple the overlay and actions view
3. Undo filter of taskViewType == SINGLE for overlay as it can be enabled for split tasks as well

Bug: 402351284
Flag: com.android.launcher3.enable_refactor_task_thumbnail
Test: OverviewImageTest (attached abtd run)
Test: OverviewMenuImageTest (attached abtd run)
Change-Id: Id7bc5c9c6620183d91e99d9dc5d2980eb8e3ec36
2025-03-19 18:03:52 +00:00
Jon Miranda ed79f7f269 Merge "Crop based on real-time insets" into main 2025-03-19 10:28:40 -07:00