Commit Graph

60277 Commits

Author SHA1 Message Date
Pat Manning fb9687dded Merge "Change hover state based on color selector" into udc-dev 2023-05-04 10:17:35 +00:00
Nick Chameyev 1aa2383d26 Merge "[Unfold animation] Start Launcher animation preemptively to synchronize the first frame" into udc-dev 2023-05-04 09:36:04 +00:00
Wei Sheng Shih 37d8c93893 Merge "Fix pauseBlur make launcher become opaque" into udc-dev 2023-05-04 07:29:50 +00:00
Jagrut Desai d2852c90fc Merge "Revert to Fix AddConfigWidgetTest" into udc-dev 2023-05-04 04:16:50 +00:00
TreeHugger Robot 8360dcdf20 Merge "Import translations. DO NOT MERGE ANYWHERE" into udc-dev 2023-05-04 04:06:31 +00:00
wilsonshih 8bf6c9edda Fix pauseBlur make launcher become opaque
...so reveal animation can blend with the launching target.

Bug: 279785569
Test: manual, rotate device, launch app from quick switch.
Verify launcher surface isn't opaque so app window can blend with
reveal animation.

Change-Id: I46b0652fd14ff66b681a9212608c13fe4ec50eb3
2023-05-04 03:02:45 +00:00
Jagrut Desai 8818b17337 Revert to Fix AddConfigWidgetTest
- we were checking the widget being valid and bound after we are accepting the config
- solution is to revert back to test before and check post result after be check if widget is valid and bound.

making sure that ShellCommandRule is checking for success,
refactor for AddConfigWidgetTest with extra launcher wait condition.

Test: none
Bug: 276794291
Flag: not needed
Change-Id: I4a6caf0851a947da03711b2a5d5bc9f736a47f95
2023-05-03 18:03:33 -07:00
Bill Yi bdfb610b93 [automerger skipped] Import translations. DO NOT MERGE ANYWHERE am: fad0b4037f -s ours
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22973045

Change-Id: Ie81f5195d08bd815fa40d2f9e821796caafcf4a8
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-03 21:46:45 +00:00
Treehugger Robot b87399af44 Merge "Import translations. DO NOT MERGE ANYWHERE" into udc-dev 2023-05-03 21:31:19 +00:00
Sebastián Franco db982003b2 Merge "Adding unit test to ReorderAlgorithm" into udc-dev 2023-05-03 20:13:15 +00:00
Jagrut Desai 5dbfe1f238 Merge "Design review updates for Taskbar Pinning" into udc-dev 2023-05-03 18:24:07 +00:00
TreeHugger Robot c4e2508681 Merge "Changing GridMigrationTask to use ModelDbController directly instead of using content uris" into udc-dev 2023-05-03 18:03:08 +00:00
Jeremy Sim 8ecacd3624 Merge "Move test to presubmit" into udc-dev 2023-05-03 17:39:35 +00:00
Saumya Prakash 32a38c9ff1 Merge "Remove unused Assistant gesture tutorial and add error checking" into udc-dev 2023-05-03 17:37:52 +00:00
Sebastian Franco 45b39b50e5 Adding unit test to ReorderAlgorithm
Adding 100 different test cases for the ReorderAlgorithm.
The test cases are randomly generated using generateRandomTestCase()
the boards are generated once and then written in the file
reorder_algorithm_test_cases. I will leave the code to generate
the boards in the Test even though is not used anymore in case
we need to generate more boards later on.

Also, I found that the ReorderAlgorithm was not deterministic,
meaning that it could generate two different results with the same
inputs (views positions and view being drag positions), because
it was traversing a map whose has was the object id which is
random. So I sort the views before traversing them.

Bug: 229292911
Test: atest ReorderAlgorithmUnitTestCase

Change-Id: I196eb8f1dafcb57d5259969268c458129ae4f46b
2023-05-03 11:22:09 -06:00
Sunny Goyal 9ef41413e0 Changing GridMigrationTask to use ModelDbController directly
instead of using content uris

Bug: 277345535
Test: Updated tests
Flag: Presubmit
Change-Id: Ib62db3334c01d9e7d27ae7b02ea703d046e2bcaa
2023-05-03 08:54:14 -07:00
patmanning f8bfdef4c0 Change hover state based on color selector
Fix: 278046965
Test: OverviewActionsMenuImageTest.

Change-Id: I5190510dabb3b515e6e8939f57d56ffb14c28fbd
2023-05-03 13:23:40 +01:00
Nick Chameyev 705c665c06 [Unfold animation] Start Launcher animation preemptively to synchronize the first frame
Starts unfold animation in Launcher right after receiving
configuration change for the unfolded screen.
This makes sure that before we unblock the screen we
have the first frame of the unfold animation ready
in Launcher (transformations are applied).

Bug: 271099882
Test: atest com.android.systemui.unfold.util.PreemptiveUnfoldTransitionProgressProviderTest
Test: manual testing fold/unfold, checking perfetto traces
Test: test with flag enabled/disabled
Change-Id: Icb8f91f9264248600d4bed14811445f50aac99c7
2023-05-03 11:35:03 +01:00
Kateryna Ivanova 46b73c2338 Merge "Revert^2 "Introduce library for public animation APIs"" into udc-dev 2023-05-03 08:41:31 +00:00
Fengjiang Li c15679d512 Merge "[1/n] Launcher Startup Latency: add StartupLatencyLogger to launcher3 and log startup latency" into udc-dev 2023-05-03 03:18:46 +00:00
Tracy Zhou 41bfd86c1e Merge "Revert "Fix touch focus not updated correctly after launching overview with live tile."" into udc-dev 2023-05-03 00:41:34 +00:00
Fengjiang Li 5a36c17a32 [1/n] Launcher Startup Latency: add StartupLatencyLogger to launcher3 and log startup latency
More details at "Log Startup Latency" section in go/launcher-startup-latency

Test: tested on phone, foldable and tablet, print latency logs in logcat
Bug: 278092752
Change-Id: Ibf269b0ecd6007d29b95e36f65ab6f02c45deb3a
2023-05-02 17:08:05 -07:00
Tracy Zhou 3ec15b04f5 Revert "Fix touch focus not updated correctly after launching overview with live tile."
This reverts commit 8899f3a387.

Reason for revert: Regression b/280167174, b/280240591

Change-Id: Id82ab1dafb8c939b0e073ad4978d2782e3d953d8
2023-05-02 21:40:13 +00:00
Sihua Ma 8f85ad38ba Merge "Fix ConcurrentModificationException in QuickstepWidgetHolder" into udc-dev 2023-05-02 21:26:53 +00:00
Bill Yi fad0b4037f Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I155fb98d02799e9a5f4ba1f78d7801846081a0eb
2023-05-02 11:30:46 -07:00
Bill Yi 566418d7d1 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I3ff1d6201b126f19812620ed44701f598e8ac0d4
2023-05-02 11:30:05 -07:00
Bill Yi fb6e930ce8 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I1bdeb09ead444b550da4ff6f7bea2deaa7af5d24
2023-05-02 11:28:26 -07:00
Jeremy Sim deda0d0c05 Move test to presubmit
testSplitAppFromHomeWithItself() has been in postsubmit for approx. 4 months with no major flakes, moving to presubmit

Fixes: 270201357
Test: Android Test Investigate reports 2/45 test failure rate
Change-Id: I13cd5bc9e0ba376ffe97e8e61ed577a51b59bdb4
2023-05-02 18:25:39 +00:00
Schneider Victor-tulias db07d2223e Merge "Add null checks for mRecentsView" into udc-dev 2023-05-02 18:15:47 +00:00
Winson Chung 52cc03e42c Merge "Wait for shell drop target to be ready for handling drags in tests" into udc-dev 2023-05-02 16:46:24 +00:00
Winson Chung c8ad4f7f43 Wait for shell drop target to be ready for handling drags in tests
- Wait for the shell drop target to be made visible and drawn before
  attempting to continue with the drag gesture

Bug: 234653212
Test: atest NexusLauncherTests

Change-Id: Ida851343873b51288460f25bba062f29019005d4
2023-05-02 05:29:36 +00:00
Tony Wickham 5e43031ed0 Merge "Simplify/correct Taskbar insetsRoundedCornerFrame calculation" into udc-dev 2023-05-02 00:56:38 +00:00
Jagrut Desai 1c9c6d0ea9 Design review updates for Taskbar Pinning
Changes:

- icon allignment animation for taskbar diviver view
- taskbar divider background color according to spec.

Test: Manual
Bug: 265170176
Flag: ENABLE_TASKBAR_PINNING
Change-Id: Ief45e48f4fc9f9b4cc30124c4c93cd3c5a880a33
2023-05-01 14:57:54 -07:00
Schneider Victor-tulias f77d2086c4 Add null checks for mRecentsView
Fixed a NPE and added some null checks for mRecentsView. These NPEs can happen if the launcher is destroyed unexpectedly.

Flag: not needed
Fixes: 279738827
Test: ran launcher and tested some gestures
Change-Id: I9c32e22a13d950346ce705ba3a6f11dd3f1da87f
2023-05-01 13:51:02 -07:00
Vinit Nayak 90dce8b8b2 Merge "Refactor handling data launching split screen to separate class" into udc-dev 2023-05-01 19:55:21 +00:00
Saumya Prakash 94c8cf49cf Remove unused Assistant gesture tutorial and add error checking
The Assistant gesture tutorial is unused in both the current and
redesigned gesture nav tutorials and can be removed. Left in, its
detections of gestures are leading to bugs with the tutorial.

Additionally, this change adds in error checking for side swipes in the
overview tutorial.

Flag: ENABLE_NEW_GESTURE_NAV_TUTORIAL
Fix: 280115831
Fix: 261239858
Fix: 278926113
Test: Manually went through both versions of gesture tutorial on
handheld, foldable, and tablet devices

Change-Id: Ie481d92ede2c2ab16ce2b3d1f729f6cb88f1b4c0
2023-05-01 17:58:54 +00:00
Andrew Cole 5f45663552 Merge "Adding Alex Chau to Launcher OWNERS" into udc-dev 2023-05-01 16:19:11 +00:00
Sebastián Franco c9cc7ea612 Merge "Set start time for open folder animation before starting the animation" into udc-dev 2023-04-29 02:39:01 +00:00
Vinit Nayak 2a014d4c0d Refactor handling data launching split screen to separate class
* SplitSelectDataHolder contains logic for knowing how
to launch split, separate from the actual API calls to launch split

Flag: ENABLE_SPLIT_LAUNCH_DATA_REFACTOR
Bug: 279494325
Test: Tested w/ all 6 types of launches noted in
SplitSelectDataHolder#@SplitLaunchType.
Also checked to make sure most-recent running tasks are
still being used where applicable.

Change-Id: I8114f87e9956b100622c80f578e291937ed4eeac
2023-04-28 18:00:22 -07:00
Tony Wickham 3cfada0a00 Simplify/correct Taskbar insetsRoundedCornerFrame calculation
Now we base it on the current tappableElement insets, which will only be
> 0 for the unstashed, persistent taskbar which draws rounded corners.
This inset also stays stable during temporary stash transitions such as
when the IME is showing.

Flag: ENABLE_TRANSIENT_TASKBAR=true, ENABLE_TASKBAR_PINNING=true
Test: in split screen for both transient and pinned (persistent)
taskbar, ensure split screen divider bottom is drawn appropriately
Fixes: 278028503

Change-Id: Iab56c5dc8f9fc81c34aa01f41b5212dd5c6fd7f0
2023-04-28 23:51:41 +00:00
Marcello Galhardo 9cba6b6751 Merge "Remove white boarders from Shortcut Category icon" into udc-dev 2023-04-28 21:50:10 +00:00
Sihua Ma d72ce23707 Fix ConcurrentModificationException in QuickstepWidgetHolder
If the listeners would modify the listener list in the widget holder, this would cause a ConcurrentModificationException.

Fix: 275100497
Test: N/A
Change-Id: I3ae0e92db71f1c21d35dbf391dfcb92b46dd30f1
2023-04-28 14:21:24 -07:00
Stefan Andonian 5961d96235 Merge "Move Wallpaper RPC call to background thread." into udc-dev 2023-04-28 20:13:40 +00:00
Andrew Cole e91b7cbbb7 Adding Alex Chau to Launcher OWNERS
By request we are adding Alex Chau as a code owner of launcher.

Bug: 273771605
Test: Alex Approving Code
Change-Id: Iacc8b4aa78e822ed1e8e738927c370e46d6ca722
2023-04-28 10:40:26 -07:00
Marcello Galhardo b771653919 Remove white boarders from Shortcut Category icon
* The icon works with light mode, but breaks the UI with dark mode on.
* Previously, the icon would be show as a white square in dark mode.
* The new version shows it correctly, as a circle.

Test: manual
Flag: not needed

Change-Id: I61838266494a9a2c3048030ff3c95ced3db6347c
Fixes: 280069069
2023-04-28 17:10:31 +00:00
Saumya Prakash 71d05f963f Merge "Update the colors for gesture navigation tutorial." into udc-dev 2023-04-28 17:03:31 +00:00
Kateryna Ivanova c0a003ed77 Revert^2 "Introduce library for public animation APIs"
af289a1cd1

Bug: 271850966
Change-Id: Iddc1790fc3704ce20fde4377d05360a77b6c146c
2023-04-28 08:38:26 +00:00
Saumya Prakash 796ebc6006 Update the colors for gesture navigation tutorial.
This change introduces tokens for the lottie animations so that the
colors can be changed. In this change, the home gesture tutorial colors have
been updated to match the updated design at http://shortn/_VvbigpP0ys

Flag: ENABLE_NEW_GESTURE_NAV_TUTORIAL
Bug: 279823249
Test: Manually went through the tutorial on handheld, foldable, and tablet
Change-Id: Id2270cea41345e8f4d330097e10a7dae2b00032a
2023-04-27 22:06:17 +00:00
Stefan Andonian efcff6ceb6 Move Wallpaper RPC call to background thread.
Bug: 251502424
Test: Used logs to time it. This was taking anywhere from 3ms to 19ms on my Pixel 7 Pro device.
Change-Id: I4e9ce55c1269a31f15e910628153c3dfdfd26649
2023-04-27 21:29:39 +00:00
Ats Jenk 0e068b1213 Pass in display when using DesktopMode APIs
Pass in the display id when asking wmshell to show desktop apps or when
querying the number of visible desktop tasks.

Bug: 278084491
Test: open some apps on the desktop, swipe up to recents, tap the
  desktop tile to open desktop again
Change-Id: Ia7328613244a1aa401e0e4792bc747a4b99b412d
2023-04-27 11:50:49 -07:00