Commit Graph
60394 Commits
Author SHA1 Message Date
Stefan Andonian fa8091661a Added ViewCapture to all tests which implement AbstractLauncherUiTest.
This enables developers to watch failed tests in classes like
TaplTestsQuickstep in the go/web-hv tool.

Bug: 242867462
Test: Failed a test and verified that the TimeLapse bugreport entry
showed up properly in the go/web-hv tool.

Change-Id: Ic89af2a0e7102db52c52ddc668607a81c4809ed6
2023-05-12 21:15:14 +00:00
Jagrut Desai 4d559a6c92 Merge "Fixing TaplTests" into udc-dev 2023-05-10 23:19:39 +00:00
Mady Mellor 3291bfecf2 Merge "Modify Taskbar code to accommodate bubble bar gesture to stash/unstash" into udc-dev 2023-05-10 23:11:42 +00:00
Jagrut Desai cd86880481 Merge "Remove Screen Record for the test" into udc-dev 2023-05-10 22:19:47 +00:00
Treehugger Robot 1a7dcf55ee Merge "Import translations. DO NOT MERGE ANYWHERE" into udc-dev 2023-05-10 21:55:16 +00:00
Treehugger Robot c75783f565 Merge "Import translations. DO NOT MERGE ANYWHERE" into udc-dev 2023-05-10 21:55:16 +00:00
Treehugger Robot 360b5a301a Merge "Import translations. DO NOT MERGE ANYWHERE" into udc-dev 2023-05-10 21:55:16 +00:00
Treehugger Robot f3fdca59d2 Merge "Revert "Fix null-pointers in SurfaceTransactionApplier constructor."" into udc-dev 2023-05-10 21:40:40 +00:00
Sunny Goyal 64809780ce Revert "Fix null-pointers in SurfaceTransactionApplier constructor."
This reverts commit d86c5657e0.

Reason for revert: b/281294745

Change-Id: Ib2680b60346a9bc5932057707d0ef105441f324d
2023-05-10 19:34:01 +00:00
Jagrut Desai 4d17468f88 Merge "Fixing NPE in TransfromParams.java" into udc-dev 2023-05-10 18:57:17 +00:00
Jagrut Desai fe5234fd86 Remove Screen Record for the test
We no longer need the screen record as test is stable and passing.

Test: Pre-Submit
Bug: 281722118
Flag: not needed
Change-Id: I4fa59968c58355068deee8429753b28120048eeb
2023-05-10 11:55:23 -07:00
Bill Yi 95285f1ed1 [automerger skipped] Import translations. DO NOT MERGE ANYWHERE am: 6de8754830 -s ours
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23122649

Change-Id: I01f86908b456f5f3db5f58b5ec6dc21eed0c934e
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-10 18:13:48 +00:00
Jagrut Desai c875f27912 Fixing TaplTests
Test: Pre-Submit
Fixes: 281772186
Flag: not needed
Change-Id: Ibe2987a69c9ca393ed267e755a3b99826164fee4
2023-05-10 10:47:45 -07:00
Treehugger Robot fb085e6393 Merge "Animate the position of the selected bubble arrow in the expanded bubble bar." into udc-dev 2023-05-10 16:49:09 +00:00
Thales Lima 0740b7fb43 Merge "Add feature flag and attribute for responsive grid" into udc-dev 2023-05-10 09:44:49 +00:00
Marcello Galhardo 09b42b3d83 Merge "Move Note Shortcut from Settings to SystemUI" into udc-dev 2023-05-10 09:23:54 +00:00
Bill Yi 6de8754830 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I7dd50c73ab58bc08e112cb134653fe68b6fb4a2a
2023-05-09 16:07:31 -07:00
Bill Yi 6443e92ce7 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: Ibc09d04d7c91017dac70785a8f1463127b54d90a
2023-05-09 16:06:35 -07:00
Bill Yi 986a5c9cfd Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: Ic3134f388645ce0d7c3af8cf3fc28938682aa78c
2023-05-09 16:05:28 -07:00
Bill Yi cd5558fcd9 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: If7588e84680dbc8f4fcc616af06914ab7c57d1a7
2023-05-09 16:04:17 -07:00
Xiaowen Lei 7c8aeffa4e Merge "Add Lifecycle and SavedState support in Launcher ActivityContext." into udc-dev 2023-05-09 22:07:40 +00:00
Jagrut Desai 4aa44e5169 Fixing NPE in TransfromParams.java
- we were not actually using mRecentsSurface so we no longer need to compute that. By removing this we will also fix the NPE.

Test: Pre-Submit
Fixes: 269716918
Flag: not needed
Change-Id: Ief4be341061a1c914456d6740f175662ccebc364
2023-05-09 14:45:17 -07:00
Fengjiang Li d382a4880b Merge "[5/n] Log cardinality to StatsLogManager" into udc-dev 2023-05-09 21:33:36 +00:00
Treehugger Robot 386f9796e3 Merge "Removing unused wallpaper-scrim feature" into udc-dev 2023-05-09 20:57:33 +00:00
Jagrut Desai 53b4435b7e Merge "Un-Split TaplTestsTaskbar" into udc-dev 2023-05-09 20:43:01 +00:00
Liran Binyamin 4e909d07ac Animate the position of the selected bubble arrow in the expanded bubble bar.
Fixes: 280605070
Test: Tested on a physical device
Change-Id: I961254527ba9a26d211c2c348a937a424fa2fb4d
2023-05-09 16:35:30 -04:00
Schneider Victor-tulias 458971616d Merge "Fix tutorial menu layout issues" into udc-dev 2023-05-09 20:18:07 +00:00
Vinit Nayak 5f475a2f48 Merge "Restore Recents TaskView based on all taskIDs, not first" into udc-dev 2023-05-09 20:15:01 +00:00
Mady Mellor 7344766886 Modify Taskbar code to accommodate bubble bar gesture to stash/unstash
* Bubble bar typically follows the behavior of taskbar - if taskbar
  is shown, the bubble bar is shown, if taskbar hides, bubble bar
  hides.
* The bubble bar has 3 states: stashed, collapsed (unstashed but
  the bubbles are not expanded), and expanded. When bubbles are
  expanded, this means WMShell is rendering the bubble
  expanded view. In this situation taskbar becomes collapsed.

Bug: 253318833
Test: manual, with other CLs, see go/bubble-bar-tests
Flag: WM_BUBBLE_BAR
Change-Id: Ic210c382e7482c259ae543a0dc083fe9305cbf5b
2023-05-09 12:37:14 -07:00
Liran Binyamin a72094ad66 Merge "Wire up the important conversation bit in BubbleBarController." into udc-dev 2023-05-09 18:02:53 +00:00
Xiaowen Lei 3c0f30a2bb Add Lifecycle and SavedState support in Launcher ActivityContext.
And call initCompose() in Launcher.java. Therefore there is no behavior
change for BaseActivity, or other ActivityContext subtypes that don't
call initCompose().

This should work for non-activity subtypes of ActivityContext. It's
likely that the Launcher activity will require more complete supoort for
Lifecycle and SavedState.

Note: In order to test the ComposeView, need to build this CL together
with ag/22461463.

1. `ViewTreeLifecycleOwner.set(..., ...);` is necessary to fix the
   following crash:

java.lang.IllegalStateException: ViewTreeLifecycleOwner not found

This error comes from WindowRecomposer.android.kt
  - http://cs/androidx-platform-dev/compose/ui/ui/src/androidMain/kotlin/androidx/compose/ui/platform/WindowRecomposer.android.kt;l=351-354;rcl=5673af1441ebe04c776f528193dfc5f85c0c9a66

2. `ViewTreeSavedStateRegistryOwner.set(..., ...);` is necessary to fix
   the following crash:

java.lang.IllegalStateException: Composed into the View which doesn't propagateViewTreeSavedStateRegistryOwner!

This error comes from AndroidComposeView.android.kt.
  - http://cs/androidx-platform-dev/compose/ui/ui/src/androidMain/kotlin/androidx/compose/ui/platform/AndroidComposeView.android.kt;l=1178-1183;rcl=5673af1441ebe04c776f528193dfc5f85c0c9a66

3. The lifecycle needs to be STARTED. Otherwise the ComposeView doesn't
   show up in its parent (i.e., isn't drawn).
  - In ComponentActivity, `onSaveInstanceState` starts the lifecycle.
  - In ComposeInitializeImpl (from SystemUI),
    ViewLifecycleOwner.updateState() starts the lifecycle when the
    window is visible and in focus.
The implementation in this CL does the same thing as the
ComposeInitializeImpl.

Bug: 275905704
Test: on device, trigger a card such as the timer
Test: RUN_ERROR_PRONE=True m out/soong/.intermediates/packages/apps/Launcher3/Launcher3/android_common/lint/lint-report.xml
Test: RUN_ERROR_PRONE=True m out/soong/.intermediates/vendor/google/gms/packages/SearchLauncher/SearchLauncher/android_common/lint/lint-report.html
Test: Presubmit
Change-Id: Ieced66ad5238916a82ea13c01f69146bbdcf287a
2023-05-09 09:40:03 -07:00
Jagrut Desai 9569ce86a2 Un-Split TaplTestsTaskbar
Before we use TaskbarModeSwitch but had a drawback where we would not know which variant of taskbar the test failed for. So, we split the taskbar tests into transient and persistent for better error logs and debugging.
But, now we can use Parameterized Test Runner to achieve the same and do not have to duplicate test code for testing two different variants of Taskbar.

There can be instances where we only want to test certain taskbar variant only, we have separated files for that.

Test: Presubmit
Bug: 267648422
Flag: not needed
Change-Id: I4322498f13d257a5f1793b008f45b09ac9b9f3ff
2023-05-09 09:36:09 -07:00
Jagrut Desai 75109c7abc Merge "Taskbar All Apps Icon Shortcuts Popup Accesiiblity" into udc-dev 2023-05-09 16:19:44 +00:00
Pat Manning 266689014e Merge "Exit hover after taskbar unstash to clean up events between tests." into udc-dev 2023-05-09 11:11:33 +00:00
patmanning 419cac7ab3 Exit hover after taskbar unstash to clean up events between tests.
Fix: 281068877
Test: TaplTestsTaskbar
Change-Id: I5cbac63cb96788bf84bf5dc0e60a7d5c579c1438
2023-05-09 11:10:46 +00:00
Thales Lima ec5abba93b Add feature flag and attribute for responsive grid
This shouldn't change anything in the grids, only support the creation of responsive grids in the future. For now, to check that the flag works, turn it on and check the dumpsys. There is also a dump test created for this.

Fix: 277064696
Fix: 277064702
Test: DeviceProfileResponsiveDumpTest
Flag: ENABLE_RESPONSIVE_WORKSPACE
Change-Id: I1bef87043a100234bd661cd6ac00007fdc654116
2023-05-09 12:06:18 +01:00
Vinit Nayak b33a2e0762 Enable flag ENABLE_SPLIT_LAUNCH_DATA_REFACTOR
Flag: ENABLE_SPLIT_LAUNCH_DATA_REFACTOR
Bug: 279494325
Change-Id: I9c58ba50f0269c69a12f548a1873c2d8251f6243
2023-05-08 17:27:03 -07:00
Jagrut Desai 29fcd9a636 Taskbar All Apps Icon Shortcuts Popup Accesiiblity
Before we were only applying the icon.clearAccessibilityFocus() only on normal popup and not material u popups, since the flag is turned on for udc, we can move it outside.

There seems to be a bug associated with either nested abstract floating views or the accessibility service where upon opening a nested abstract floating view from another the icon get the focus. This change make the bug littl less visible to use but users will still see this bug if they open the shortcut pop agian withought closing taskbar all apps.

The accessibility delegate was always null when using the TaskbarOverlayContext, now we use TaskbarActivityContext Delegate when in TaskbarOverlayContext.

Test: Manual
Bug: 280657266
Flag: not needed
Change-Id: I631e3aa6e54748c4c8ea2ac7daf5473b198e47d6
2023-05-08 16:25:53 -07:00
Fengjiang Li d9253224b3 [5/n] Log cardinality to StatsLogManager
Test: app builds
Bug: 278271805
Change-Id: Ia0180815509759caf867296a7941fa32402d8f45
2023-05-08 16:13:05 -07:00
Schneider Victor-tulias c50f870625 Fix tutorial menu layout issues
- Fixed back button image padding (and updated all other images to prevent hidden padding)
- fixed done button size
- padding top and bottom insets for status bar and nav bar

Flag: ENABLE_NEW_GESTURE_NAV_TUTORIAL
Fixes: 281121442
Fixes: 281121138
Test: launched the tutorial menu on handheld, foldable and tablet, compared before/after pictures
Change-Id: I61bce2fc4a8d3824048229e0d48f9a429c80a204
2023-05-08 15:43:39 -07:00
Vinit Nayak f46fa7ac49 Restore Recents TaskView based on all taskIDs, not first
* Return a copy of taskIds in TaskView#getTaskIds() to
prevent accessors from getting clobbered values
* In RecentsView#applyLoadPlan we overwrite values in that
array, so callers using it to cache old values would read
incorrect values when reading it after a TaskView has been
bound to new tasks.
* Load/Unload visible task data for all tasks in a given
TaskView, not just single task <-- probably not necessary for
bug fix, but seems sensible

Flag: none
Fixes: 266905177
Test: Quickswitch works as expected. Currently
unable to test thumbnails (created b/281582106)
Change-Id: Ifd4d8a856976ab9cc200b0f61eca1c68897f343c
2023-05-08 22:34:29 +00:00
Winson Chung 606c4bfc59 Merge "Potential fix for end callback not being run in 3-button" into udc-dev 2023-05-08 21:13:01 +00:00
TreeHugger Robot 35f5bfea4c Merge "Use a property instead of a getter function for key in BubbleBarBubble. Using a property here is more Kotlin idiomatic." into udc-dev 2023-05-08 18:52:25 +00:00
Schneider Victor-tulias a40de23f04 Merge "Fix null-pointers in SurfaceTransactionApplier constructor." into udc-dev 2023-05-08 16:50:13 +00:00
Lucas Silva 39e28c9190 Merge "Update QuickstepTransitionManager to allow remote transitions to be overridden" into udc-dev 2023-05-08 14:20:36 +00:00
Sunny Goyal 356aa61fe4 Merge "Revert "Revert "Revert "Changing GridMigrationTask to use ModelDbController directly"""" into udc-dev 2023-05-06 18:19:13 +00:00
Sunny Goyal 3772b246c2 Revert "Revert "Revert "Changing GridMigrationTask to use ModelDbController directly"""
This reverts commit 8d9e468dbb.

Reason for revert: b/281179368

Change-Id: Ibfc5329f72cdbcb37d01a8bf3dac2ba0724b9faf
2023-05-06 18:18:07 +00:00
Mady Mellor 764608263f Merge "Adds BubbleControllers to TaskbarControllers" into udc-dev 2023-05-06 17:22:21 +00:00
Mady Mellor b7dce64db5 Merge "Add Bubbles and BubblesListener to SystemUiProxy and use it" into udc-dev 2023-05-06 17:22:06 +00:00
Brian Isganitis 0b53332c31 Merge changes I35fe528b,Ia612c1b5 into udc-dev
* changes:
  Don't close AFVs when opening Taskbar folder.
  Keep persistent Taskbar visible over Taskbar All Apps.
2023-05-06 14:42:54 +00:00