Commit Graph

16725 Commits

Author SHA1 Message Date
Steven Ng 4f0f5d732d Fix widget cell container size
This was the same calculation used before http://ag/15177218.

Test: run AddWidgetTest, AddConfigWidgetTest
Bug: 193819550
Change-Id: I1b5e0072a4c05b656de98f8d42667ae99438c005
2021-07-16 12:43:55 +01:00
Steven Ng 73f83cd14d Merge "Scale RemoteViews from requestPinAppWidget shown in AddItemActivity" into sc-v2-dev am: 4083ae30db am: 8971abebf1
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15288650

Change-Id: I4505f4b08835992839e0c72545ee75e232c64796
2021-07-16 09:57:24 +00:00
Steven Ng 4083ae30db Merge "Scale RemoteViews from requestPinAppWidget shown in AddItemActivity" into sc-v2-dev 2021-07-16 09:24:02 +00:00
Andras Kloczl 77b3eb0acb Fix two panel accessibility issues
When two panel home was enabled in Launcher the items on
the left panel weren't able to get selected while on Talkback
because of an incorrect calculation in getScrollProgress.
Also the user was unable to jump to other workspaces by doing
simple one finger swipes because the page jump count was
only 1.

Test: manual
Bug: 174464170
Change-Id: I6cfe39b5059e8e7e7a32c9b0d372c658e796c3e8
2021-07-16 10:39:51 +02:00
Steven Ng 02c75d9897 Fix class cast issue in AddItemActivity am: 671ffb88ca
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15299573

Change-Id: I393d4540df0b32e644e3d1a963db14564281c03c
2021-07-16 02:04:23 +00:00
TreeHugger Robot f877edb8fc Merge "Fix work profile disable button falsing" into sc-dev am: 753c8b7016
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15286021

Change-Id: I20ea01059f339d8a3dbe1186b7d838fd17faf539
2021-07-16 02:02:54 +00:00
TreeHugger Robot 3559798fba Merge "Removing support for change listeners from feature flags" into sc-v2-dev am: 4aac62110e am: fdbabc6be4
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15302089

Change-Id: I9bb74727ab64325944f2d01e4fcc7aebfda144fd
2021-07-16 01:56:33 +00:00
TreeHugger Robot fdbabc6be4 Merge "Removing support for change listeners from feature flags" into sc-v2-dev am: 4aac62110e
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15302089

Change-Id: Ib53f78f1badbf62661b96ad9b7f6455f596704e8
2021-07-16 01:30:55 +00:00
TreeHugger Robot 4aac62110e Merge "Removing support for change listeners from feature flags" into sc-v2-dev 2021-07-16 01:20:32 +00:00
Alex Chau 20d83a976d Merge "Enable logs on swipe detection in tests" into sc-v2-dev am: 0eaf4e86a2 am: 5873f9f085
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15302098

Change-Id: I30a792a8f248d0dd17146efc3f78702eefb2178d
2021-07-16 01:05:43 +00:00
Alex Chau 5873f9f085 Merge "Enable logs on swipe detection in tests" into sc-v2-dev am: 0eaf4e86a2
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15302098

Change-Id: I4883b5be8c49ef0215a50a8a94a025492f239424
2021-07-16 00:48:30 +00:00
Alex Chau 0eaf4e86a2 Merge "Enable logs on swipe detection in tests" into sc-v2-dev 2021-07-16 00:28:42 +00:00
Sunny Goyal d3af716ca4 Binding Taskbar directly from Launcher model am: 711c596c86 am: c18cdf7c9d
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15082875

Change-Id: I847ff8821328118761279cced5f6a642de8fd382
2021-07-15 22:40:12 +00:00
Sunny Goyal c18cdf7c9d Binding Taskbar directly from Launcher model am: 711c596c86
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15082875

Change-Id: I3c0247dc339993ecb9d6c740a064231a06857c22
2021-07-15 22:25:28 +00:00
Sunny Goyal 8cbefe2086 Removing support for change listeners from feature flags
FeatureFlags are supposed to work as static values and change
listeners can cause leaks if not handled properly at every place.

Bug: 193825269
Test: Manual
Change-Id: I54f9113bc01025da781a420154829d80ffa6a084
2021-07-15 15:07:04 -07:00
Alex Chau 46b9a41686 Enable logs on swipe detection in tests
- Enable BaseSwipeDetector log in tests
- Add log for scroll finish and motion pause event

Bug: 193440212
Test: TaplTestsQuickstep#testSwitchToOverview
Change-Id: Idab566bc615050f73d898459897b66f8b95951b3
2021-07-15 20:45:51 +01:00
Sunny Goyal 711c596c86 Binding Taskbar directly from Launcher model
This allows taskbar to be loaded even in case of 3P Launchers
and removes dependency on LauncherActivity lifecycle

Bug: 187353581
Bug: 188788621
Test: Manual
Change-Id: I5a0988e0697b41677d4c58f0213aef14ec0c0972
2021-07-15 12:43:11 -07:00
Steven Ng 14f90e1a3e Fix class cast issue in AddItemActivity am: 671ffb88ca am: 414e50b0f3
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15299573

Change-Id: I799285ff538d8b9fd232edfb88faa8af09327cd0
2021-07-15 18:06:39 +00:00
Steven Ng 06b9d39aed Fix class cast issue in AddItemActivity am: 671ffb88ca am: 5ff9bb7f75
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15299573

Change-Id: Ie723144ff6b59095b571aee32c57c6de7f44447e
2021-07-15 18:05:45 +00:00
Steven Ng 2b123833ad Scale RemoteViews from requestPinAppWidget shown in AddItemActivity
Test: manual
Bug: 193144010

Change-Id: Ia2b64c32f92a43a8d71ee82f164543e1e624814a
2021-07-15 17:59:45 +01:00
TreeHugger Robot fbfb5d691f Merge "Reland "Snap to relative position to snappd task when dismissing"" into sc-v2-dev am: eba399c130 am: 94ab05138f
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15299582

Change-Id: Idb1bb656ee9ce79dea91e108dfc164b1014b9821
2021-07-15 16:54:43 +00:00
TreeHugger Robot 94ab05138f Merge "Reland "Snap to relative position to snappd task when dismissing"" into sc-v2-dev am: eba399c130
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15299582

Change-Id: If49e262fcf6c6df96035d3bc61d669cf34e67b6a
2021-07-15 16:40:11 +00:00
TreeHugger Robot eba399c130 Merge "Reland "Snap to relative position to snappd task when dismissing"" into sc-v2-dev 2021-07-15 16:27:11 +00:00
Steven Ng e429a8ceff Merge "Scale widget previews" into sc-v2-dev am: b3880636c4 am: 6d95608cc9
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15177218

Change-Id: I1f2e80152aa8dfd952a91652db808af0d2fa35c4
2021-07-15 16:24:18 +00:00
Steven Ng 6d95608cc9 Merge "Scale widget previews" into sc-v2-dev am: b3880636c4
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15177218

Change-Id: I5e584600e9b9fb0388f37f2d5ccc2d7b7afcf47a
2021-07-15 16:15:08 +00:00
Steven Ng b3880636c4 Merge "Scale widget previews" into sc-v2-dev 2021-07-15 15:58:08 +00:00
Steven Ng 671ffb88ca Fix class cast issue in AddItemActivity
AddItemActivity is a standalone activity. There is no Launcher activity
instance. Avoid using LauncherAppWidgetHostView in WidgetCell by
replacing it NavigableAppWidgetHostView instead

Test: Check preview layouts are correctly rendered in widgets picker
      and pin widget dialog. Also test drag and drop to verify the
      local color extraction still works when dragging a preview layout
      from widgets picker to home screen.
Fix: 193765783
Change-Id: I3a734a54941257cebcd7b7f6a4c2c9cc764c5c12
2021-07-15 16:06:51 +01:00
Alex Chau 031373daa3 Reland "Snap to relative position to snappd task when dismissing"
This reland commit ba61b98fca accidentally reverted by http://ag/15162411

Bug: 188793333
Test: manual
Change-Id: Iae07a67d528aa80e8f87d37758244d0c46b61cf7
2021-07-15 15:12:34 +01:00
Steven Ng f3d23f67bd Scale widget previews
This CL covers drag requests initiated from Launcher.java but not from
other activities.

Test: Manual
Bug: 193144010
Change-Id: Ieb862d689afe81a5b35aedeb9a277de08c775230
2021-07-15 12:22:37 +01:00
TreeHugger Robot 814e245349 Merge "Fix work profile disable button falsing" into sc-dev am: 753c8b7016 am: 32762d9d30
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15286021

Change-Id: I48ade2a1f48477fccf9cc05d153feca2daafcbad
2021-07-15 05:59:42 +00:00
TreeHugger Robot 9166027b1f Merge "Fix work profile disable button falsing" into sc-dev am: 753c8b7016 am: f98ce58dab
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15286021

Change-Id: I82b23f5ea9c15aaaf3434c08ccab190e375a387b
2021-07-15 01:03:16 +00:00
TreeHugger Robot 753c8b7016 Merge "Fix work profile disable button falsing" into sc-dev 2021-07-15 00:27:59 +00:00
Hyunyoung Song 44424572b4 Fix work profile disable button falsing
Bug: 191996677

Test: before this CL: when tapping on immediately above keyboard when
keyboard is translating or when onApplyWindowInset is called, the
hidden (GONE) view handles touch and triggers work profile to be disabled.

After the CL, the button view is not attached to the parent container
when on personal tab. Also, the onApplyWindowInsets method translations
can only be called when work tab is selected.

Change-Id: Ib3e9a5c4b3280052f9ccb62a199ed256ae4e094f
2021-07-14 15:09:26 -07:00
András Klöczl ada8a69f5a Merge "Fix launcher preview for two panel home" into sc-v2-dev am: 7609cc4e58 am: 7fb850458b
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15079450

Change-Id: I9d5fca01fd8ebe0f1400921e8b3ab6ab0868c629
2021-07-14 15:44:11 +00:00
András Klöczl 7609cc4e58 Merge "Fix launcher preview for two panel home" into sc-v2-dev 2021-07-14 15:16:07 +00:00
TreeHugger Robot e9b4712cfa Merge "Notify System UI about taskbar state" into sc-v2-dev am: 6224eaea29 am: d258acb0b8
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15162411

Change-Id: Ifc44c34ce18153e1f94270406e68a7a2dccfff09
2021-07-14 11:27:30 +00:00
TreeHugger Robot 6224eaea29 Merge "Notify System UI about taskbar state" into sc-v2-dev 2021-07-14 10:59:26 +00:00
Schneider Victor-tulias 00adfcee2c Merge "Update Gesture navigation tutorial to match new specs" into sc-dev am: ae2e5d9231 am: c564a2487c
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15099479

Change-Id: I5f52e76ad326b4027369af33c280b3fd80ec43e4
2021-07-13 23:57:50 +00:00
Schneider Victor-tulias 38a6d462a2 Merge "Update Gesture navigation tutorial to match new specs" into sc-dev am: ae2e5d9231
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15099479

Change-Id: Icb5e7cdca02fab3c6c165ab3c612ee943d97d947
2021-07-13 23:41:14 +00:00
Schneider Victor-tulias ae2e5d9231 Merge "Update Gesture navigation tutorial to match new specs" into sc-dev 2021-07-13 23:27:45 +00:00
Andras Kloczl ac3f08558c Fix launcher preview for two panel home
Test: manual
Bug: 185508060
Gif: http://shortn/_oOgKLjg5QC
Change-Id: I216b3761b3bd15c7069b92aa4a1bff8ad655b767
2021-07-13 23:13:17 +02:00
TreeHugger Robot 39672b85de Merge "Fix hole in recycler view" into sc-dev am: 3d6d2e38b0 am: 88b1d61a49
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15270060

Change-Id: I31c2add68cc7888ab567126e9dec5a655a9f8436
2021-07-13 19:41:53 +00:00
TreeHugger Robot a4821a0bb8 Merge "Fix hole in recycler view" into sc-dev am: 3d6d2e38b0
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15270060

Change-Id: I7bf9cd8b3ed98c086b0496ce84f5f41d312d68dc
2021-07-13 19:16:02 +00:00
TreeHugger Robot 3d6d2e38b0 Merge "Fix hole in recycler view" into sc-dev 2021-07-13 19:05:22 +00:00
Hyunyoung Song b6acd14d0f Fix hole in recycler view
Bug: 153780395
Test: manual

Without this change, typing single character and then
backspace, and then scrolling down and up will result in
hole in recycler view.

Change-Id: Iff6fa3f147d8bfdb8a7e84847b96e5390941dd4e
2021-07-13 09:51:42 -07:00
Steven Ng adcacd3e4f Merge "Fix shortcut size calcuation" into sc-dev am: 372e85106d am: 352eefaf78
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15259646

Change-Id: I595846e72121f6505a6cc7dfaaa59dfd007385ef
2021-07-13 14:17:09 +00:00
Steven Ng 16c9ebabbf Merge "Fix shortcut size calcuation" into sc-dev am: 372e85106d
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15259646

Change-Id: I5b37dc1971d67afbc3923774db2256459e389ae6
2021-07-13 14:10:25 +00:00
Steven Ng 372e85106d Merge "Fix shortcut size calcuation" into sc-dev 2021-07-13 13:59:41 +00:00
Steven Ng 6fe115b2ae Fix shortcut size calcuation
Shortcut size should be the size of all apps icon + padding

Test: Check shortcuts and widgets are shown without crash in the
      following surfaces with display & font set to largest and
      display cutout enabled. Repeat the same test with normal
      display setting and no cutout.
      1. Full widgets picker
      2. Bottom widgets picker
      3. Pin widget dialog
Fix: 193422438
Change-Id: Ibfebf94e92eed5e9cd1dd4196d98823b0e4dda6b
2021-07-13 12:46:31 +01:00
TreeHugger Robot 1a1db6a3e0 Merge "Add accessibility announcement when user clicks on 'Add automatically to home screen' button" into sc-dev am: 972ab9327c am: 04fd845ee3
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15242979

Change-Id: I4d6cc491a79a0bb034fbc360a86e9ad05cb21777
2021-07-13 05:29:09 +00:00