Commit Graph

16725 Commits

Author SHA1 Message Date
Steven Ng 3de51d518d Merge "Remove drop target button drawable padding if text isn't hidden" into sc-v2-dev 2021-07-27 13:21:57 +00:00
TreeHugger Robot a494c64749 Merge "Use 32dp as the content margin for widgets pickers in large screen devices" into sc-v2-dev am: 8d5cd17801 am: 72e564e247
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15393091

Change-Id: Ie98ba0dd07081789ade7fd34a7811e4019f12b78
2021-07-27 13:14:09 +00:00
TreeHugger Robot 8d5cd17801 Merge "Use 32dp as the content margin for widgets pickers in large screen devices" into sc-v2-dev 2021-07-27 12:47:45 +00:00
Steven Ng 24c16de329 Use 32dp as the content margin for widgets pickers in large screen
devices

Test: manual
Bug: 194369046
Change-Id: I7376eab59d57bdd9ccc8a64e9f321358e09ee579
2021-07-27 12:00:52 +01:00
TreeHugger Robot 35cb68df1e Merge "Fix launcher preview for two panel follow up" into sc-v2-dev am: d616cc2db0 am: 0515343faa
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15393095

Change-Id: I94ebe693a7ce7d6b59ff6a36ed3588c433ebb01c
2021-07-27 01:33:54 +00:00
TreeHugger Robot d616cc2db0 Merge "Fix launcher preview for two panel follow up" into sc-v2-dev 2021-07-27 01:01:50 +00:00
TreeHugger Robot 3342ea0337 Merge "Enables Enhanced Smartspace by default." into sc-v2-dev am: a8fb9629fe am: 78214676d1
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15373288

Change-Id: If1577f1c78d5063e4a1e4b4984b851eecbc229e3
2021-07-27 00:50:00 +00:00
TreeHugger Robot a8fb9629fe Merge "Enables Enhanced Smartspace by default." into sc-v2-dev 2021-07-27 00:22:16 +00:00
Andras Kloczl 454ea214ad Fix launcher preview for two panel follow up
Fixing a possible context issue that was suggested
on the previous CL (ag/15079450) after it got submitted.

Bug: 185508060
Test: manually check launcher preview in wallpaper app
Change-Id: Ia653b833e4c1b911c7d7cac38c35ec2d12ab3a29
2021-07-27 00:27:32 +02:00
Andy Wickham 59c3b1cf04 Merge "Doesn't scale PagedView snap speed during tests." into sc-v2-dev am: 075c50e0c6 am: 6c482bc9e1
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15373287

Change-Id: If09fab150342854d2bd3573b501032bc0e888573
2021-07-26 20:16:12 +00:00
Andy Wickham 075c50e0c6 Merge "Doesn't scale PagedView snap speed during tests." into sc-v2-dev 2021-07-26 19:42:38 +00:00
Steven Ng a1dcbce15a Remove drop target button drawable padding if text isn't hidden
Test: manual
Fix: 194320733
Change-Id: I12adeaf37cee5a0fcf383641f24b7750f14daf27
2021-07-26 17:10:56 +01:00
Alex Chau 38dad54d80 Add overviewShowAsGrid to DeviceProfile am: 646f804627 am: 989e308fcb
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15390570

Change-Id: I0aa8ebd55ae03a68f52ce12ef3169ed4a5033eb5
2021-07-26 13:35:16 +00:00
Alex Chau 5fd9d491b0 Tune Overview size according to VisD
- Removed modalTransformY as overview actions no longer need to move in modal view
- Moved row spacing and page spacing to DeviceProfile
- Added several tablet / orientation specific DeviceProfile params

Bug: 194194694
Test: Manual
Change-Id: Id5435e7f6fc1b6fb7c0e55e55fa240cf84c4d6da
2021-07-26 12:01:30 +01:00
Alex Chau 646f804627 Add overviewShowAsGrid to DeviceProfile
- Simplified a lot of dp.isTablet && FeatureFlags.ENABLE_OVERVIEW_GRID.get() usage

Bug: 194194694
Test: manual
Change-Id: Idfb0ad192048106bbe6f8e2a28fa5613b86e5208
2021-07-26 11:59:34 +01:00
Jonathan Miranda 707dee501a Merge "resolve merge conflicts of 2e8356ba64 to sc-v2-dev-plus-aosp" into sc-v2-dev-plus-aosp am: d4b102dbc5
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15372300

Change-Id: I0fc03a187a9b7a1486879ebe43e40d70788df8c8
2021-07-24 01:28:32 +00:00
Jonathan Miranda 0658dc78e3 resolve merge conflicts of 2e8356ba64 to sc-v2-dev-plus-aosp
Add more extra space to hotseat for taller devices.

Bug: 194533332
Bug: 192520231
Change-Id: Ia0fa307bb4085e6fbc5d873b6dec63ab7fb53fea
Test: manual test on taller devices
2021-07-23 23:14:12 +00:00
Jonathan Miranda 8f16a7703e resolve merge conflicts of 6d9e866669 to sc-v2-dev
Add more extra space to hotseat for taller devices.

Bug: 194533368
Bug: 192520231
Change-Id: Ib4705342329767a3e4eb2781aff6cd72220e4eaa
Test: manual test on taller devices
2021-07-23 23:13:44 +00:00
Andy Wickham da5a89b130 Doesn't scale PagedView snap speed during tests.
Settings.Global.getFloat causes a Binder
transaction which breaks BinderTests.java
when running it from Android Studio.

Test: BinderTests.java
Bug: 187428578
Change-Id: I07ce2fe256dba0bfa98a5dade538d68e7ce357ff
2021-07-23 23:08:46 +00:00
Andy Wickham 02db569cad Enables Enhanced Smartspace by default.
Bug: 187428578
Test: BinderTests.java, MemoryTests.java, manual
Change-Id: Iffc6ae9b79db47d0585486529d2d8dfdf0a24692
2021-07-23 12:40:59 -10:00
TreeHugger Robot 6d9e866669 Merge "Update hotseat sizing for 4x5 grids." into sc-dev 2021-07-23 22:39:48 +00:00
Jonathan Miranda 28713afa00 Merge "Add more extra space to hotseat for taller devices." into sc-dev am: 0c7153bbdf am: 74aecceafa
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15363650

Change-Id: I65624cc951d45d62d04c47ff94fc7f20ca5080cc
2021-07-23 22:15:37 +00:00
Jonathan Miranda 65a42b6b90 Merge "Add more extra space to hotseat for taller devices." into sc-dev am: 0c7153bbdf am: 3491abbc28
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15363650

Change-Id: Iffd30d24df93cb8ba4ed3ee600fef9d44a2aaf16
2021-07-23 22:14:23 +00:00
Jonathan Miranda 6fbcbc7a4c Merge "Add more extra space to hotseat for taller devices." into sc-dev am: 0c7153bbdf
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15363650

Change-Id: I3ff54d0d1559305b8e501abeba31ab3cec8c37f1
2021-07-23 22:02:13 +00:00
Jonathan Miranda 0c7153bbdf Merge "Add more extra space to hotseat for taller devices." into sc-dev 2021-07-23 21:41:27 +00:00
Jon Miranda 80cddbccb6 Add more extra space to hotseat for taller devices.
Bug: 192520231
Test: manual test on taller devices
Change-Id: I3eccada67f0ba07d01f823c4156f02c3feb97f84
2021-07-23 20:01:16 +00:00
Jon Miranda 069f8c5ac9 Update hotseat sizing for 4x5 grids.
If the qsb bottom margin is smaller than the bottom insets,
we'll fall back to centering the qsb in the available freespace.

Bug: 194435265
Test: 4x5 grid
      multiple devices,
      with: gesture nav enabled
            3 button nav enabled

Merged-In: I9fd4f0da3f2bc9f0b38a621ad1192533260379e3
Change-Id: I711e7d168b80254e73df0d4e1854756d819a705b
2021-07-23 18:47:33 +00:00
Jon Miranda 374336a571 Update hotseat sizing for 4x5 grids.
If the qsb bottom margin is smaller than the bottom insets,
we'll fall back to centering the qsb in the available freespace.

Bug: 194435265
Test: 4x5 grid
      multiple devices,
      with: gesture nav enabled
            3 button nav enabled

Change-Id: I9fd4f0da3f2bc9f0b38a621ad1192533260379e3
2021-07-23 18:46:31 +00:00
TreeHugger Robot 749f913562 Merge "Folder polish: unbold folder title, ensure icons not cropped in folder." into sc-dev am: 3f062ab8b6 am: e172950463
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15365040

Change-Id: I1da273b116173f9f41b15f13f94e7636a85a1839
2021-07-23 18:41:23 +00:00
TreeHugger Robot 2ed55ed9de Merge "Folder polish: unbold folder title, ensure icons not cropped in folder." into sc-dev am: 3f062ab8b6
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15365040

Change-Id: I0fccfe7fdf32f7bcbcddb3633e34acb1c7c979f6
2021-07-23 18:23:49 +00:00
Alex Chau c1a459f633 Clean up debug flags and add more screen record am: 261708ba00 am: 4f7129330e
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15371934

Change-Id: I5a22605150e3a8001fbc6ebf61e5263fdc736cf5
2021-07-23 18:22:25 +00:00
TreeHugger Robot 3f062ab8b6 Merge "Folder polish: unbold folder title, ensure icons not cropped in folder." into sc-dev 2021-07-23 18:10:48 +00:00
Alex Chau 261708ba00 Clean up debug flags and add more screen record
Bug: 193440212
Bug: 194484556
Test: manual
Change-Id: I1b09ae74462c86afb8effb0a2635fd0e70a59bf8
2021-07-23 15:42:01 +01:00
Jon Miranda f33f5b3fc5 Folder polish: unbold folder title, ensure icons not cropped in folder.
- Ensure folder items are scaled to fit within the height/width in 4x5 mode.
- This bug surfaced now since  we increased the icon size.

Bug: 194356039
Test: set display to large, set font to large
Change-Id: Ie360ca67c3c91649a471bce920b2fc6a82fb9661
2021-07-22 17:19:28 -07:00
Adam Cohen ec049b019d Fix widget drop preview outline on 4x5 grids am: ed82e0daef am: 8e1908da59
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15351419

Change-Id: Id5931118c3a6c3795142e5f246ff03a43e8dd255
2021-07-22 23:08:33 +00:00
Adam Cohen 2a0516f6cc Fix widget drop preview outline on 4x5 grids am: ed82e0daef
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15351419

Change-Id: I37f0cde316ac0a4c7b793ad25b23d5208ca90b65
2021-07-22 22:55:49 +00:00
TreeHugger Robot 7e7f595719 Merge "Animate SplitPlaceholderView when entering split from overview" into sc-v2-dev am: f2af895b20 am: 092efed8d7
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15081296

Change-Id: I6091d6c30f9392cb15566ef6eab00c57505bf0ef
2021-07-22 21:51:11 +00:00
TreeHugger Robot f2af895b20 Merge "Animate SplitPlaceholderView when entering split from overview" into sc-v2-dev 2021-07-22 21:17:35 +00:00
Vinit Nayak 7903758d08 Animate SplitPlaceholderView when entering split from overview
Bugs tracked in b/181704764

Bug: 181704764
Test: Tested on phone and large screen in multiple orientations

Change-Id: I07509006ae3d1f4425dc5119d0c8ed52b41a3bc2
2021-07-22 20:12:26 +00:00
TreeHugger Robot 85b38729a8 Merge "Removing UI dependency from LauncherModel in case of 2-panel layout" into sc-v2-dev am: d327290762 am: 3694d653c4
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15302087

Change-Id: I438361fe609dcfe38d5455ceb3139d5e5784ae06
2021-07-22 19:40:16 +00:00
Adam Cohen ed82e0daef Fix widget drop preview outline on 4x5 grids
=> We were not account for mBorderSpacing in the outline calculation
=> This was fine in most cases as this value is 0, but 4x5 appears to be the exception

Bug: 194227752

Test: manual, see video in bug.
Change-Id: Ib590bc142a0f65e75f92ee057f8b4f4b0f81521b
2021-07-22 12:31:21 -07:00
TreeHugger Robot a914d2d70a Merge "Measure WidgetsFullSheet before estimating the recommended table size" into sc-dev am: 6a01fe49a5 am: 268dd89cb0
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15359118

Change-Id: Ia8971a215762c5f9b9e1a0a4b97da5ed3359a400
2021-07-22 19:22:41 +00:00
TreeHugger Robot d327290762 Merge "Removing UI dependency from LauncherModel in case of 2-panel layout" into sc-v2-dev 2021-07-22 19:16:52 +00:00
TreeHugger Robot c48e4fa64d Merge "Measure WidgetsFullSheet before estimating the recommended table size" into sc-dev am: 6a01fe49a5
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15359118

Change-Id: I0004e2f55347e018fa553f8b56c26a754a93e0f1
2021-07-22 19:11:55 +00:00
TreeHugger Robot 6a01fe49a5 Merge "Measure WidgetsFullSheet before estimating the recommended table size" into sc-dev 2021-07-22 18:53:32 +00:00
Sunny Goyal 12e3f1f2f7 Removing UI dependency from LauncherModel in case of 2-panel layout
Bug: 175939730
Bug: 192431856
Bug: 185515153
Test: Manual
Change-Id: I8baa1cf9e5a8a04d5b8bc38c1f4b0755265cd8a9
2021-07-22 10:34:25 -07:00
TreeHugger Robot f3a387d731 Merge "resolve merge conflicts of 46378eb881 to sc-v2-dev" into sc-v2-dev 2021-07-22 16:49:35 +00:00
Steven Ng a606d344a6 Measure WidgetsFullSheet before estimating the recommended table
size

Issue: The header view height was obtained before any measurement.

Test: On Pixel 5 4x5 gird with Photo widget shown in recommended
      table, make the device in landscape. Then open the full widgets
      picker. The widgets picker can be scrolled. Before this fix,
      scrolling is not possible.
Fix: 194172597
Change-Id: Ib30cf4b95d2ed23ff28f3d24e103f0e919b3a551
2021-07-22 16:08:15 +01:00
TreeHugger Robot 58d6237dae Merge "Fix scaling on widget previews that have width / height set to wrap_content" into sc-v2-dev am: b971baefe1 am: 841fc730ef
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15346899

Change-Id: I02a14ea7f818f35f64f4d663ec897543458d1802
2021-07-22 12:38:55 +00:00
TreeHugger Robot b971baefe1 Merge "Fix scaling on widget previews that have width / height set to wrap_content" into sc-v2-dev 2021-07-22 12:05:03 +00:00