Commit Graph

16725 Commits

Author SHA1 Message Date
Jeremy Sim afff936235 Merge "Fix bug with Launcher animation canceling, esp. around OverviewSplitSelect" into tm-qpr-dev 2022-09-02 20:46:41 +00:00
Anushree Ganjam a6bef07555 Merge "Add a boolean to track QSB edu card dismissal." into tm-qpr-dev am: 37bcfaddba am: ed05568c66
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19774828

Change-Id: I3c593d9c3924947c402e53f788a8770083fcb89b
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-02 16:35:09 +00:00
Anushree Ganjam 37bcfaddba Merge "Add a boolean to track QSB edu card dismissal." into tm-qpr-dev 2022-09-02 15:37:17 +00:00
Alex Chau 1cf8d0895d Merge "Change wallpaper depth value in AllApps bottomsheet" into tm-qpr-dev am: f28c9f14a4 am: 18d7004c76
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19607219

Change-Id: Ic3f9e45cb7ea5ab0427b9b2f9250385cd283ba8d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-02 11:10:32 +00:00
Alex Chau f28c9f14a4 Merge "Change wallpaper depth value in AllApps bottomsheet" into tm-qpr-dev 2022-09-02 10:06:37 +00:00
Jeremy Sim b33471a21f Fix bug with Launcher animation canceling, esp. around OverviewSplitSelect
This commit fixes a bug where the user could cancel animations when transitioning between Launcher states, potentially resulting in a state where Overview elements (task thumbnails etc.) were wrongly hidden or invisible.

The bug occurred because functions such as createInitialSplitSelectAnimation() and createAtomicAnimation() did not carry out any cleanup upon animation failure. This resulted in RecentsView potentially being in a polluted state for the next launch.

Bug was fixed by adding cleanup routines to two onAnimationEnd listeners.

Fixes: 242715097
Test: Manual
Change-Id: I05415ecf515e247aa535e3ca8371e540c3189b01
2022-09-01 20:51:53 -07:00
Sukesh Ram 8d3d944d5d Fix SecondaryDisplayLauncher crash by initializing OnBoardingPrefs after initializing UI
Bug: 238325716
Test: Manual
Change-Id: I66a85eb79cda89a63c3116a56a52b51526720158
Merged-In: I66a85eb79cda89a63c3116a56a52b51526720158
2022-09-02 00:44:39 +00:00
Schneider Victor-tulias 119ae79e3c Enable input consumer selection reason logging and gesture navigation error detection.
Bug: 227514916
Test: ran locally, tested multiple gestures and checked logs
Change-Id: Iab0c9a21ee0141744cf82afd16ee941f2b49a9cc
2022-09-01 15:59:07 -07:00
Sukesh Ram 82da9fc5be Made getOnBoardingPrefs @Nullable & avoid NPE
Bug: 236679197
Test: Manual
Change-Id: I3cbb0891cbfcf7cab956a4e05a28dbbcc2b33e19
(cherry picked from commit c0650e7725)
2022-09-01 22:20:35 +00:00
Alex Chau 3193522616 Change wallpaper depth value in AllApps bottomsheet
- Cap AllApps wallpaper zoom to workspaceContentScale rather than all the way to max depth (config_wallpaperMaxScale)
- Changed both workspace scale and depth interpolator to correlate with AllApps threshold

Bug: 240580498
Test: manual
Change-Id: I0342a37c72206268dcffc5697a212704a41b020f
2022-09-01 21:26:30 +01:00
Thales Lima fd3baebd87 Merge "Extract cell horizontal space to a method" into tm-qpr-dev am: e3948da48d am: 0503560e16
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19746173

Change-Id: I812219395a915d2d078c5be2d07d07f434dd2a02
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-01 20:04:46 +00:00
Sunny Goyal f2c6bf8346 Moving view capture dump to a service to allow longer timeout
Bug: 243827665
Test: Verified on device
Change-Id: I7273cc14d86620b52aaf71c7ea293bd643d881f9
2022-09-01 11:57:23 -07:00
Thales Lima e3948da48d Merge "Extract cell horizontal space to a method" into tm-qpr-dev 2022-09-01 16:23:53 +00:00
TreeHugger Robot 4563f5cb6e Merge "[Toast] Add a feature flag for using app search for web zero-state." into tm-qpr-dev am: a29868e30c am: b73f762e28
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19747910

Change-Id: Idcbe944619afb89f9aea16fbb15db14bc69eaa7a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-01 03:35:32 +00:00
TreeHugger Robot a29868e30c Merge "[Toast] Add a feature flag for using app search for web zero-state." into tm-qpr-dev 2022-09-01 01:54:18 +00:00
Tony Wickham 2be2312543 Merge changes Ie55bd70e,I69bcfa97,I222522bc into tm-qpr-dev am: d833fe4a12 am: 94894d8d88
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19472817

Change-Id: Ib419b6f6fad396917f5b477e5c20ca5bd425a165
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-01 01:43:50 +00:00
Tony Wickham d833fe4a12 Merge changes Ie55bd70e,I69bcfa97,I222522bc into tm-qpr-dev
* changes:
  Fix taskbar stash state not persisting properly across recreate
  Add support to Tapl to recreateTaskbar
  Don't rely on QuickstepLauncher instance for tests
2022-09-01 00:52:54 +00:00
Anushree Ganjam b368fcc624 Add a boolean to track QSB edu card dismissal.
Bug: 243680092
Test: Manual.
Change-Id: I6981e423d037851020ae1cdec9879ab577769258
2022-08-31 21:46:39 +00:00
TreeHugger Robot bcbba897fc Merge "Add app predictions to secondary display app drawer & fix tab UI." into tm-qpr-dev 2022-08-31 00:01:21 +00:00
Schneider Victor-tulias 7ba044f10b Merge "Add gesture nav error state tracking and logging" into tm-qpr-dev am: ff5ad47a06 am: 520bf2e892
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19300928

Change-Id: I7830f925e70d89f84fce7da317403e03dacbb419
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-08-30 23:55:39 +00:00
Sukesh Ram 1b4869fcbc Add app predictions to secondary display app drawer & fix tab UI.
Bug: 233926067
Test: Manual
Change-Id: I2f45a4b30964b365bf149e8864a3af2ea909a237
(cherry picked from commit 9e5fe63a22)
Merged-In: I2f45a4b30964b365bf149e8864a3af2ea909a237
2022-08-30 22:30:03 +00:00
Tony Wickham c8e824dbdb Add support to Tapl to recreateTaskbar
Also moved references of "tasbkar_view" to share TASKBAR_RES_ID constant

Test: compiles; see follow up CLs
Bug: 235986838
Change-Id: I69bcfa975550e567f3daa35af8a810546297d79c
2022-08-30 13:40:45 -07:00
Schneider Victor-tulias 038922a653 Add gesture nav error state tracking and logging
- Added ActiveGestureErrorDetector
- Removed startQuickstep logs; these were confusing and not helpful in ActiveGestureLogs

Test: printed logs after several gestures
Bug: 227514916
Design: go/gesture-nav-logging
Change-Id: Ia2a7e4f90a3a371d9a92190aa66eb07acd061d6c
2022-08-30 12:18:29 -07:00
Pat Manning 7a5048297d Merge "Refactor overview progress as splash progress." into tm-qpr-dev am: b4a30ab955 am: 99bce932a2
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19730966

Change-Id: I3abd3fd009ed7d6d7f4754bcece6a594bab3db61
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-08-30 14:17:18 +00:00
Pat Manning e63dd25a54 Use full screen width for drop target buttons to support higher screen densities from truncating text.
Scale oversized text down if after all computations it will still be truncated at higher densities.

Fix: 239401464
Test: manual. To follow up with screenshot test: b/241386128
Change-Id: Ie088d0631b0d13beb2d9f9d5396a56f7b971dee1
2022-08-30 14:57:42 +01:00
Pat Manning b4a30ab955 Merge "Refactor overview progress as splash progress." into tm-qpr-dev 2022-08-30 13:29:53 +00:00
Pat Manning 81dc9ad131 Refactor overview progress as splash progress.
This also avoids showing splash in split select state

Fix: 242284413
Test: follow up after b/238405972
Change-Id: I2e83fa3d030e8a74edb4152c472dbf02ac5a80b1
2022-08-30 11:23:08 +01:00
Sebastian Franco 47558a6201 Adding flag to improve the icons reordering on foldables
Test: compiles
Bug: 188081026
Change-Id: Ifa30bbc9ff38f2cc0f9530f3e075b5eb662f63eb
Merged-In: Ifa30bbc9ff38f2cc0f9530f3e075b5eb662f63eb
2022-08-29 22:08:20 +00:00
Sebastián Franco b35a9e51fc Merge "[Merge conflict tmp-qpr] Adding flag to improve the icons reordering on foldables" 2022-08-29 22:03:29 +00:00
Becky Qiu edea2575e6 [Toast] Add a feature flag for using app search for web zero-state.
Bug: 241001264
Test: local
Change-Id: Id4af1664253182217014a43d8f8025f1a00da291
2022-08-26 16:41:05 -07:00
Sebastian Franco ffae7d256c [Merge conflict tmp-qpr] Adding flag to improve the icons reordering on foldables
Test: compiles
Bug: 188081026
Change-Id: Ifa30bbc9ff38f2cc0f9530f3e075b5eb662f63eb
2022-08-26 00:05:27 +00:00
Schneider Victor-tulias 305a1df9d9 Merge changes I562abc6c,I7a48d960,I0916f969 into tm-qpr-dev am: 7fb96a5305 am: 2ed4c84e68
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19517498

Change-Id: If267d42f6d15fef03373ffe0c77fc1ebb1a7dd3a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-08-25 21:31:02 +00:00
Schneider Victor-tulias 7fb96a5305 Merge changes I562abc6c,I7a48d960,I0916f969 into tm-qpr-dev
* changes:
  Update ActiveGestureLog to store n-gestures rather than n-events.
  Add input consumer selection reason to active gesture logs
  Collapse EventLogArray into ActiveGesture log.
2022-08-25 20:42:13 +00:00
Schneider Victor-tulias 24637f50c5 Add input consumer selection reason to active gesture logs
Test: manually tried gestures in 3 button and gesture nav and checked logs
Bug: 227514916
Change-Id: I7a48d960ef5a41ddee95153fa08a2345f00cbef7
2022-08-25 10:03:30 -07:00
Schneider Victor-tulias a0cd3e0295 Collapse EventLogArray into ActiveGesture log.
EventLogArray is never used directly, only used as a super class of ActiveGestureLog. Simplifying the hierarchy to simplify follow-up changes.

Test: manually tried gestures in 3 button and gesture nav and checked logs
Bug: 227514916
Change-Id: I0916f969a776953ddc4886846ad2f4936566e7d7
2022-08-25 09:59:13 -07:00
Thales Lima 1e8b45f8f1 Extract cell horizontal space to a method
Fixes: 229100375
Test: DeviceProfileTest
Change-Id: Ia2e560b37f4e9fbff9b5c2e7c0ef3fe710e55c29
2022-08-25 11:50:59 -04:00
Brandon Dayauon c2cb9a3823 Merge "Fix jumpiness when dragging surface down and up." into tm-qpr-dev am: dc51afd920 am: 6c3f5a32aa
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19600189

Change-Id: I50d10c838e8e6291a261243898de201f3ce1bb0b
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-08-24 05:25:07 +00:00
Pinyao Ting 292d0d3dc9 Merge "Explicit Nullbility in Launcher (Part 2)" into tm-qpr-dev am: 775b0d21dc am: ff8f09b5b5
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19679564

Change-Id: I569d5e6fd9ebbcb31266c6683c129481ee3c2144
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-08-24 05:08:54 +00:00
Brian Isganitis 06b1d8c114 Merge "Added debug menu option for testing secondary display." into tm-qpr-dev 2022-08-23 23:57:15 +00:00
Brandon Dayauon dc51afd920 Merge "Fix jumpiness when dragging surface down and up." into tm-qpr-dev 2022-08-23 20:38:52 +00:00
Pinyao Ting 775b0d21dc Merge "Explicit Nullbility in Launcher (Part 2)" into tm-qpr-dev 2022-08-23 16:53:20 +00:00
Brandon Dayauon d4a60b394f Fix jumpiness when dragging surface down and up.
Currently the overshoot only works when you first open all apps and try
to extend the all apps to the top (making it overshoot). This pull works
when you go mFromState:Normal -> mToState:AllApps. However once the all
apps is set and you move the surface down then up..that overshoot
animation jumps AFTER your finger goes all the way up and off the
screen. At this point, once all apps is completely opened.. the states are
mFromState:AllApps -> mToState:Normal.

Now with this change, it addresses the jumpiness by considering the
current states (mFromState==AllApps) by
including the same onPull() but with different calculations

bug: 240669628
test: manual - videos included in bug thread
Change-Id: I7873f1ec22574f87fab3d2f11d1f5a5f81dfb5bc
2022-08-23 01:20:22 +00:00
Sunny Goyal 94da7bd9f3 Merge "Compressing view capture data and changing the format to avoid storing duplicate strings" into tm-qpr-dev am: 56677c50bd am: 97da32d50d
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19638802

Change-Id: Id35b4b24ce569b1abe9ee4169de8e2bd4eb7af2e
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-08-23 00:45:39 +00:00
Pinyao Ting 023b973d15 Explicit Nullbility in Launcher (Part 2)
This CL updates the nullabality on methods associated with IconCache in Launcher.

Bug: 242895652
Test: manual
Change-Id: I4832c0950141c8a52c8a9e62659ccabb082897c8
2022-08-22 17:15:44 -07:00
Sunny Goyal 56677c50bd Merge "Compressing view capture data and changing the format to avoid storing duplicate strings" into tm-qpr-dev 2022-08-23 00:10:05 +00:00
Sukesh Ram 93c710b9ac Added debug menu option for testing secondary display.
Test: manual
Fix: 233639924
Change-Id: Iaca90a1391078d56bd57fa5de097f34ec0425866
(cherry picked from commit aed1b074f3)
2022-08-22 22:25:28 +00:00
Sunny Goyal ca5761d21f Merge "Removing some obsolete features" into tm-qpr-dev am: 211496e3d8 am: a3dacac8b9
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19505122

Change-Id: I8a0157caa803b2edcef458895d7e9ded06ea5fe0
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-08-22 21:07:20 +00:00
Sunny Goyal 211496e3d8 Merge "Removing some obsolete features" into tm-qpr-dev 2022-08-22 20:27:45 +00:00
Luca Zuccarini c97195c1fc Merge "Set the default for keyboard sync to IS_STUDIO_BUILD." into tm-qpr-dev am: ee29b830b4 am: c905fd544a
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19668493

Change-Id: Id3cad76e985f7b8da0f586b3b515b55b1d3b1a6e
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-08-22 09:52:24 +00:00
Luca Zuccarini ee29b830b4 Merge "Set the default for keyboard sync to IS_STUDIO_BUILD." into tm-qpr-dev 2022-08-22 09:12:01 +00:00