Commit Graph

16725 Commits

Author SHA1 Message Date
Jeremy Sim 08a9bcac1f Fix issue with Overview thumbnails appearing blank in certain situations
This CL fixes an issue where canceling any Launcher animation by entering Quick Switch would cause Overview to appear with all thumbnail tiles blank.

The issue occurred because we recently added a reset() to Overview that triggered on all state transition animation cancels. This fixed some issues, but introduced this bug.

Fixed by tailoring the reset() to only fire on animation cancels within BaseRecentsView and FallbackRecentsView.

Fixes: 246232494
Fixes: 243471493
Test: Manual
Change-Id: I175a22d52597a63e164a6f3b9353c62b199b0712
2022-09-17 16:01:46 -07:00
TreeHugger Robot abda780906 Merge "Updating the title of the Add to homescreen prompt to the requesting app instead of the Launcher name" into tm-qpr-dev am: 17c4741432 am: 4e758bfc23
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19980314

Change-Id: I6a3e8e4479d9ac04a59b924ef5dc9e0264e27485
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-17 02:39:10 +00:00
Holly Jiuyu Sun 0efe4cf313 Merge "Clear the staled mFocusedView when toast surface is closed." into tm-qpr-dev am: a6f9b4b76b am: f0a4b7dfcd
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19956349

Change-Id: I782f141b023938d159c3f3a567ba2b0dd339f309
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-17 02:38:57 +00:00
TreeHugger Robot 17c4741432 Merge "Updating the title of the Add to homescreen prompt to the requesting app instead of the Launcher name" into tm-qpr-dev 2022-09-17 01:47:48 +00:00
Holly Jiuyu Sun a6f9b4b76b Merge "Clear the staled mFocusedView when toast surface is closed." into tm-qpr-dev 2022-09-17 01:34:45 +00:00
TreeHugger Robot ca5a1a6c60 Merge "Updating the scroll calculation from recyclerView to avoid view inflation" into tm-qpr-dev am: 860657a5f2 am: cd4951f54b
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19469421

Change-Id: I5f9c405e1bff93b3e96b051bcb9b6ad0a87eecb5
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-17 01:14:58 +00:00
Pinyao Ting 777c13eb00 Explicit Nullbility in Launcher (Part 5)
This CL addresses the nullbility in LauncherModel and update tasks.

Bug: 242895652
Test: manual
Change-Id: Ied635c944c3656f0d493b295f772aa0329b354b9
2022-09-16 17:17:16 -07:00
TreeHugger Robot 860657a5f2 Merge "Updating the scroll calculation from recyclerView to avoid view inflation" into tm-qpr-dev 2022-09-16 23:07:54 +00:00
Sunny Goyal bb5ebb7f2d Updating the title of the Add to homescreen prompt to the requesting app
instead of the Launcher name

Bug: 239055068
Test: Verified on device
Change-Id: I1494d911565ddf3a598f9fbf372b8d784a4276e4
2022-09-16 15:54:53 -07:00
Yein Jo 40a0690301 Merge "Migrate Launcher to use the new OnBackInvokedCallback" into tm-qpr-dev am: dfaabbb499 am: f8804d8ccd
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19934356

Change-Id: I5843a470ee7194f84899ad8fa3426c9c4af6d178
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-16 22:13:10 +00:00
Andy Wickham 05e2e266af Merge "Pivot search results scale around top of view." into tm-qpr-dev am: 455c942fd2 am: 92574a99f5
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19956355

Change-Id: Ia4b2eb1478ac0159a87ed8a97c60c7c373926ea5
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-16 22:12:31 +00:00
Yein Jo dfaabbb499 Merge "Migrate Launcher to use the new OnBackInvokedCallback" into tm-qpr-dev 2022-09-16 21:44:49 +00:00
Holly Sun 98d6a4027a Clear the staled mFocusedView when toast surface is closed.
Test: manual
Bug: 224756660
Change-Id: Iadce94f9138ee375fa9b6e3ef8fb685847312045
2022-09-16 14:28:23 -07:00
Andy Wickham 455c942fd2 Merge "Pivot search results scale around top of view." into tm-qpr-dev 2022-09-16 21:17:26 +00:00
TreeHugger Robot 5a469bd163 Merge "Turn off changing depth in wallpaper picker" into tm-qpr-dev am: af2fe7fd12 am: d7d05d1d7a
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19967481

Change-Id: I3729ee399399d7bbea5e0569f132ce53690b45df
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-16 17:52:21 +00:00
TreeHugger Robot af2fe7fd12 Merge "Turn off changing depth in wallpaper picker" into tm-qpr-dev 2022-09-16 16:50:04 +00:00
Alex Chau fa83199e62 Turn off changing depth in wallpaper picker
Fix: 246845529
Bug: 240580498
Test: manual
Change-Id: Ib8fd624c518fb4c26d2598137d056b196a0ddeb7
2022-09-16 16:39:47 +08:00
TreeHugger Robot 1508328e72 Merge "Moving ViewCapture to Quickstep level to use hidden apis." into tm-qpr-dev am: 9fb4802a67 am: 3d021d46d9
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19975454

Change-Id: Ifa5a7419ff4a314b3ac1aaa9a90da6eb63d814df
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-16 08:38:55 +00:00
TreeHugger Robot 9fb4802a67 Merge "Moving ViewCapture to Quickstep level to use hidden apis." into tm-qpr-dev 2022-09-16 06:23:07 +00:00
Stefan Andonian 5df305fed6 Moving ViewCapture to Quickstep level to use hidden apis.
Bug: 242867462
Test: Compilation succeeded while using private flags.
Change-Id: I9b15967b594963c5573ea1a0000b60f7c705da95
2022-09-16 03:36:15 +00:00
Andy Wickham 5c5852a2df Merge "Adds SearchRecyclerView as a notification dot listener." into tm-qpr-dev am: 889be463f7 am: 67136a7e2b
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19969467

Change-Id: I652832276f6fdc097972345dcdbc1e0d610a212d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-16 01:41:40 +00:00
Andy Wickham 889be463f7 Merge "Adds SearchRecyclerView as a notification dot listener." into tm-qpr-dev 2022-09-15 23:47:00 +00:00
Andy Wickham 2d5b049531 Pivot search results scale around top of view.
This way views scale in/out relative to the top of the view,
instead of the center. This is most noticeable on larger views,
like Search Edu card.

Before/after videos: https://drive.google.com/drive/folders/1aXMGD44AQBeu6cLyzpV1DcFeh1Q8Vvmk?resourcekey=0-ShsGtgCTcST5cjUPAGPfwg&usp=sharing

Bug: 234882587
Test: Manual with 10x animation duration.
Change-Id: Ifb02f9dcb14e69b9cf3f9dea55d03d155b720391
2022-09-15 16:41:25 -07:00
Andy Wickham 5429b8fd86 Adds SearchRecyclerView as a notification dot listener.
This way app dots get updated as notifications come in or get
dismissed.

Bug: 246962476
Test: Dismissed notification while Search active.
Change-Id: I41e1b44561fb5ccd43deff342afb722cc5107330
2022-09-15 11:21:04 -07:00
TreeHugger Robot f6b9723bd6 Merge "Add metrics sources for split invocation" into tm-qpr-dev am: e58e123bd7 am: 1c46220a98
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19820319

Change-Id: I1b7e2debef2cbe78f110403f7ce80e8873b28708
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-15 10:00:15 +00:00
TreeHugger Robot e58e123bd7 Merge "Add metrics sources for split invocation" into tm-qpr-dev 2022-09-15 09:35:12 +00:00
Jeremy Sim 1ccec2e53a Update animations for TM-QPR: Overview > OverviewSplitSelect transition am: 21a5b12b6f am: 7439620808
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19728187

Change-Id: If7323b12cc2653bf914d8345a123e00c1aadee9d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-15 04:55:16 +00:00
TreeHugger Robot 592cd4e323 Merge "Fix launcher crash related to widget updates" into tm-qpr-dev am: 06849c4e36 am: 4b6c7aa844
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19935324

Change-Id: Iab004cebde73e1f5fe426b3695cc6b87320f64a9
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-15 02:17:42 +00:00
Becky Qiu ca82417086 Merge "[Toast] Switch to use a device config instead of feature flag for appSearch." into tm-qpr-dev am: 1c8e630381 am: ff057e9b43
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19902946

Change-Id: Ia1161f357ddaa341bbfae3cb85f7a9dcfb4b4034
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-15 01:38:31 +00:00
Jeremy Sim 21a5b12b6f Update animations for TM-QPR: Overview > OverviewSplitSelect transition
This change updates the Overview > OverviewSplitSelect animation to the latest spec. This is a re-upload of a previous change, ag/19464657, but no longer will cause the b/241165022 issue.

Includes:
- New timings
- Task thumbnails slide in with an "overshoot" animation
- Icons fade out and fade in appropriately
- SplitInstructionsView has a new compound "unfold" animation

Bug: 236760307
Test: Manual on tablet. Made sure the b/241165022 issue is fixed.
Change-Id: Ia22f6b6d7b9474b782e693fae2320a34a2985b18
2022-09-14 18:06:05 -07:00
Pinyao Ting fc14807d7a Fix launcher crash related to widget updates
LauncherAppWidgetHost fails to cleanup deferred widget when launcher
started binding the widgets in workspace, which leads to a crash because
widgets that was previously attached to the workspace get re-attached to
the workspace.

Bug: 245016152
Test: manual
Change-Id: I4de261e08cfdcee74f210c39bcadf403b98887ab
2022-09-14 13:22:29 -07:00
Yein Jo dc1b3660fe Migrate Launcher to use the new OnBackInvokedCallback
Bug: b/238475344
Test: Tapl & manual
Change-Id: Ieab329873f82890d95136e490086cc2cffff7ba8
2022-09-14 19:45:41 +00:00
Vinit Nayak 7fb4f997c4 Add metrics sources for split invocation
* See design doc in bug description for
usage/details

Bug: 231369744
Change-Id: I0c0ec11e924e387c523b5ac5feb7cabf78eaa748
2022-09-14 11:58:03 -07:00
Becky Qiu 1c8e630381 Merge "[Toast] Switch to use a device config instead of feature flag for appSearch." into tm-qpr-dev 2022-09-14 06:53:49 +00:00
TreeHugger Robot fcb43caf6b Merge "Add error detection for aborting the recents scrolling during transition to home" into tm-qpr-dev am: 839297e232 am: d675769721
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19873684

Change-Id: I4e7fba7f2c510893d744317eedad78934e9b7a3c
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-13 23:46:58 +00:00
TreeHugger Robot fb77b34d1d Merge "Change wallpaper depth in widget picker" into tm-qpr-dev am: 3ded296cee am: 9c43626a36
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19852193

Change-Id: Ie17c03949c3ac30156129182fec88f19cfb46e1d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-13 23:38:23 +00:00
TreeHugger Robot 839297e232 Merge "Add error detection for aborting the recents scrolling during transition to home" into tm-qpr-dev 2022-09-13 19:49:44 +00:00
Becky Qiu cdac570298 [Toast] Switch to use a device config instead of feature flag for appSearch.
Bug: 241001264
Test: local
Change-Id: I47416b07a62379ab5c2c17b3b769c8bc8b2ef106
2022-09-13 12:26:42 -07:00
TreeHugger Robot b5cd064a26 Merge "Removing UiThreadHelper and moving code to corresponding classes" into tm-qpr-dev am: 22af7c2e7e am: 93d74aa41a
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19931705

Change-Id: I39c565b0ea40b4e1c1ed2b3b908837e04817ce64
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-13 18:49:08 +00:00
TreeHugger Robot 3ded296cee Merge "Change wallpaper depth in widget picker" into tm-qpr-dev 2022-09-13 18:46:53 +00:00
TreeHugger Robot 22af7c2e7e Merge "Removing UiThreadHelper and moving code to corresponding classes" into tm-qpr-dev 2022-09-13 17:57:44 +00:00
Alex Chau 3d2c062567 Change wallpaper depth in widget picker
- Also changed widget picker open/close duration, refactored the values into DeviceProfile
- Generalized MultiAdditivePropertyFactory to accept aggregator as parameter

Bug: 240580498
Test: manual
Change-Id: I6886ca514593e404b8d7b0e8ed44f20ec2b77c73
2022-09-13 12:20:56 +08:00
Andy Wickham 369c6e8be7 Reduces vertical padding of predicted apps in All Apps.
Rather than using the full allAppsCellHeight, manually construct
the icon + padding + text and add custom padding (8dp).

Screenshots: https://drive.google.com/drive/folders/1hgEE72PaTj60SxgfPUzQ8hGwnCOWx-Lp?resourcekey=0-TgrHKITyzIXmNAAMYpA_MA&usp=sharing

Fix: 242915342
Test: Manual inspection
Change-Id: Ic566e0f7ea7cf486054bb8fe2429ee5c53e8b174
2022-09-12 18:34:14 -07:00
Becky Qiu 1dce2a9394 Merge "[Toast] Add a debug log config for app search flow." into tm-qpr-dev am: a7be354913 am: d91561558d
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19890488

Change-Id: Ib07934c05c27c007823e3c0829f587a9cf4cf8c2
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-13 01:28:25 +00:00
Becky Qiu a7be354913 Merge "[Toast] Add a debug log config for app search flow." into tm-qpr-dev 2022-09-13 00:33:26 +00:00
Sunny Goyal 42beb544e9 Removing UiThreadHelper and moving code to corresponding classes
This allows for better code organization based on the code logic

Bug: 246382466
Test: Presubmit
Change-Id: I6148143a60afdd917a11587e327f5e8a4d7def9e
2022-09-12 22:14:15 +00:00
TreeHugger Robot 5f65e29d27 Merge "Removing some unused code:" into tm-qpr-dev am: d581f40b30 am: e6f7559b8c
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19914949

Change-Id: I47ac6650d9c5ba65aab59099662bf9e904a25101
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-12 20:32:21 +00:00
Brandon Dayauon cda6cd412a Merge "Work toggle button staying at the top when moving keyboard down" into tm-qpr-dev am: f17c581165 am: 27b479a29b
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19914917

Change-Id: Ie7bb7cf03e573bc410a2df90a5793eeec2ca50ee
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-12 20:32:13 +00:00
Vinit Nayak ebd04c4bc1 Merge "Place TaskMenuView aligned with secondary split thumbnail" into tm-qpr-dev am: f5e5c8e1ce am: 1f97ccf5e2
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19912686

Change-Id: I11d27495a0aaa09ebcd376fd38ad96721562eb63
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-12 20:29:41 +00:00
Sunny Goyal 20bbe95ddb Updating the scroll calculation from recyclerView to avoid view inflation
> Updating the LayoutManager's scroll calculation instead of a separate
  implementation to better support recyclerView's calculations
> Caching the view sizes during layout to avoid view-inflation for
  unknown types
> Fixing scrollbar jump during scroll when widget list is expanded
> Fixing scrollbar never reaching end when onboarding card is displayed
  in work tab

Bug: 240343082
Test: Verified on device that new views are not inflated
Change-Id: Ied11ccf65b053691c5c126c4bf8de306ec24786d
2022-09-12 12:24:34 -07:00