When using a 3P Launcher, i.e. when the ROLE_HOME is not held by QuickstepLauncher, there should be no back callback registered with SystemUI.
Bug: 374882166
Flag: EXEMPT bugfix
Test: Manual, i.e. verified back-callback registration updates in SystemUI and also verified that back-to-home navigations in Nova Launcher are responsive.
Change-Id: I03187f80a4c3c893a6529f0a22613f6fdfe7b7b3
Bug: 373544911
Test: Manual, i.e. verified that sliding away from the back button (within the taskbar window) cancels the predictive back animation
Flag: com.android.window.flags.predictive_back_three_button_nav
Change-Id: I9a1448c7005211c87a8979261b13fe37ab64a5b2
This means that overlay is initialised in all cases, not just some. Also uses pre-existing method for `isTaskViewFullyVisible()`
Fix: 376264918
Test: Manual checking of flows in bug.
Flag: com.android.launcher3.enable_refactor_task_thumbnail
Change-Id: Ia898a2a869b79fb120a162fa5a3fe7df0fbf9800
When a workspace item is removed, launcher currently shows a Snackbar which contains a message saying "item removed". This renders the a11y announcement in DeleteDropTarget#onAccessibilityDrop redundant since it's saying exactly the same string.
Bug: 378032433
Change-Id: Iaf3b42404ecd382b1ee15f670cc4ebe0124218d2
Test: manual
Flag: EXEMPT bugfix
We were checking the wrong index (off by one), leading to a crash if the divider is already in the Taskbar at the correct index. However, we do need to add it after the expected index if the divider isn't there, otherwise it will push the icon that is at that position to the right of the divider (it should be to the left).
Flag: com.android.launcher3.taskbar_recents_layout_transition
Bug: 343521765
Bug: 368522274
Test: go/testedequals
Change-Id: I0263f704728286b53da5b45828784b20aaae31ce
The mock makes sure we don't rely on a device hardware for tests.
Test: DeleteDropTargetTest
Flag: com.android.launcher3.msdl_feedback
Bug: 379958544
Change-Id: I202b81f3dd16af1c0985980d0b962be0000bf31f
- To workaround the fact that TTT does not get full task visibility info,
we can existing tasks as not-visible whenever the occluding home task
is moved to front
- Fix an issue where task icons were not loading for running tasks
due to us skipping updating for running tasks in the recents
transition (we will continue to skip updating the thumbnail though)
- Also skip updating the same taskview multiple times if the task
container has multiple tasks that need to be updated
Bug: 372067617
Bug: 280812109
Flag: EXEMPT bugfix
Test: atest TaskThumbnailViewModelTest,TasksRepositoryTest,RecentsViewModelTest
Test: atest TaplTestsQuickstep#testExcludeFromRecents
Change-Id: Ifa33cfe53d44e5fe7778aecd5434abf9c29b3170
* changes:
Prepare for LayoutTransition with RTL support.
Split up hotseat and recents into two methods.
Filter out unsupported items immediately when updating Taskbar.
Was not able to repo the initial bug, but this change leaves the
original path unchanged.
Fixes: 374579710
Test: N/A
Flag: EXEMPT bugfix
Change-Id: I91e0235571b0736dcbe70c7730d7c90ec949a13e
Only remove divider when it needs to be removed or moved between All Apps and recents locations. Keep All Apps and QSB in Taskbar at all times. LayoutTransition does not work if views are being removed and then immediately readded (what current code branch does).
Overflow is not supported yet with the LayoutTransition flag.
Test: go/tested-equals
Flag: com.android.launcher3.taskbar_recents_layout_transition
Bug: 368522274, 343521765
Change-Id: I9ae1d7c52e853106cdf86329be6f221213e7cb86
To support RTL with recents, will need to support calling updateRecents before updateHotseatItems. Splitting into two methods makes this doable.
Test: go/testedequals
Flag: EXEMPT refactor
Bug: 343521765, 368522274
Change-Id: I8756ea23fff1606ef4ab9f72d18dd4b21f135b25
Fixes an issue where hotseatItems may not reflect the number of hotseat views in Taskbar. Entries in the array can be null (e.g. no predictions but there is space in the hotseat for them). If these are filtered out immediately, hotseatItems.length will correspond to the number of hotseat views.
Test: go/testedequals
Flag: EXEMPT bugfix
Fix: 379704910
Change-Id: I375d8152fccb6df5a9b783842ecf5dcedf6894c1
Cancels split select when tapping the floating task view created from
the desktop split select transition, similar to other implementations of
split select.
Bug: 368631327
Test: Manual
Flag: EXEMPT bugfix
Change-Id: Ib83de3a5ff95a35627b7fac115d4e4566ec79e40
- excludeFromRecents are sometimes added as index 0 after moveRunningTaskToFront, breking the model that fullscreen tasks should be shown after desktop tasks
- Added getRunningTaskExpectedIndex to compute expected runningTask postion in all scenario, and apply this position both when adding the view in showCurrentTask and moveRunningTaskToExpectedPosition
Fix: 380232192
Test: Swipe up from following scenario in phone/tablet, repeat several times
1) 1st fullscreen task
2) 2nd fullscreen task
3) excludeFromRecents task
4) Desktop task
Flag: EXEMPT BUG_FIX
Change-Id: Iec551fb1403a6bb5307b684a50f7ae7d31bd4644
TLDR:
* This change should not break anything or change any color.
* Simplifies theming and styling while improving developer experience.
* With this developers can often skip styling for color entirely, while ensuring consistency and preventing accidental overrides.
Bug: 374273611
Test: presubmit
Flag: EXEMPT bugfix
Change-Id: Id19038078e83c73847b1a7c686c3a3df1ecccac2
This CL fixes the taskbar visibility when showLockedTaskbarOnHome is
enabled.
Ife336ebd57eb2f60c2bc33ed6a4527c42111808f wrongly assumes that the
taskbar is always invisible when the launcher is visible, so this CL
fixes the assumption.
Bug: 379870867
Bug: 379785901
Flag: EXEMPT bug fix
Test: manual
Change-Id: I9043898fb499520954ee3c5463ab28208d374875
Refactor the TaskbarManager to support multiple TaskbarActivityContexts.
Flag: EXEMPT not adding new behavior
Bug: 362720616
Test: Manual
Change-Id: I1baa081f6994cb94465f20aa7e0c6b47f5cb7eb8
We can access the static instance as needed without retaining it
in this class.
Bug: 321226611
Test: Manual (test Circle to Search setting works as expected)
Flag: EXEMPT bugfix
Change-Id: I79a22d313bf802b6ea5e388e06269dd9ee5131a4
PiP2's enter flow is different in that we resolve
TRANSIT_PIP's startWCT in Shell, and PipTransition
will always make sure to set the right alphas
at the start and finish.
Bug: 380030547
Flag: com.android.wm.shell.enable_pip2
Test: atest NexusLauncherOutOfProcTests:TaplTestsSplitscreen
Change-Id: I7d28ed5dcccecfab71ff324098d5c31653ce1c9f
This change addresses an issue where the background of the multi
instance menu would sometimes not render in time, leading to a visual
bug.
Fix: 380087041
Bug: 315989246
Test: Manual
Flag: com.android.launcher3.enable_multi_instance_menu_taskbar
Change-Id: I32b746a990e89e954b00a0cdcb0e1bf2fae2537f
The keyboard doesn't close when swiping down from A-Z list. So in Launcher when going to any state from A-Z getAPpsView().reset() gets called which eventually
calls resetSearch() where we can hideKeyboard.
bug: 379052503
Test: before in bug
after: https://drive.google.com/file/d/11oVTvkBtj9rECEtz4IVH1tURaJz6pFTO/view?usp=sharing
Flag: NONE bug fix
Change-Id: I707bf5dc2f81d5e83e869e34de674ef7fc065486
Treehugger Robot
Johannes Gallmann
Alex Chau
Uwais Ashraf
Bill Yi
Pinyao Ting
Android Build Coastguard Worker
Brian Isganitis
Xin Li
Brandon Dayauon
fbaron
Artsiom Mitrokhin
Juan Sebastian Martinez
mattsziklay
Andy Wickham
Winson Chung
Jon Miranda
Sukesh Ram
Sebastián Franco
Saumya Prakash
Luca Zuccarini
Liran Binyamin
Marcelo Arteiro
Toshiki Kikuchi
Ikram Gabiyev
Charlie Anderson