Commit Graph

83004 Commits

Author SHA1 Message Date
Liran Binyamin c48b4ed025 Fix flake in BubbleBarViewAnimatorTest
100x run: http://ab/I70900010339337557

Flag: EXEMPT test only
Fixes: 381093181
Test: http://ab/I70900010339337557
Change-Id: Ifd126156d6e69f885b37487743e06d482c2e3921
2024-11-26 13:44:25 -05:00
Bill Yi c53bf7890a Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: Iaa1d8352b628aeb47f79a5c8e59256a3c45a2909
2024-11-26 08:54:19 -08:00
Bill Yi d8b551f5e1 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: Ifc912f63a98981d58b7ca3c11102cca16171589d
2024-11-26 08:53:51 -08:00
Bill Yi 2f784ae9ff Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: Ie974d62c56f4e2b5a8a915c29c93a5d26fd94811
2024-11-26 08:53:30 -08:00
Bill Yi 2e0b4ce52e Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: Ic16394da3ded917b22342bf6bfbefb3f9dfb4c90
2024-11-26 07:36:15 -08:00
Bill Yi 47853ec09f Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I6ea65f527652a356445233d3cdba31ee0f901f02
2024-11-26 07:35:54 -08:00
Bill Yi 42a07b47e1 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: Ic9e26fa7f91bd7b0e2ca251032e115f46f715b2c
2024-11-26 07:35:35 -08:00
Uwais Ashraf 322b831d1d Merge "Make RV focusable when empty to read out content desc for TalkBack." into main 2024-11-26 15:25:25 +00:00
Liran Binyamin 16a604fe0c Show the bubble bar edu view
We now show the bubble bar edu view after a request from shell
to show it was received, and as soon as the user performs a touch
gesture on the bubble bar or flyout that causes the bar to be
expanded.

The click listener on the bubble bar is removed with this change
because the input consumer already handles taps. Removing the
listener avoids processing the tap twice which causes the edu view
to not be displayed. Removing the click listener solves the issue
but ideally we should move the edu view to launcher since that
would allow us to manage its state easily.

Flag: com.android.wm.shell.enable_bubble_bar
Fixes: 374842575
Test: atest PersistentBubbleStashControllerTest
Test: atest BubbleBarSwipeControllerTest
Test: atest TransientBubbleStashControllerTest
Test: manual
       - force show the bar edu view
       - send a bubble
       - tap the bubble bar to expand
       - observe bubble bar edu is visible
       - repeat with swiping on the bar and tapping the flyout
       - launch an app
       - swipe up to show the taskbar
       - observe edu view not visible
       - send a bubble with auto expand
       - observe bubble bar expanded and edu view not visible
Change-Id: I98ec44e6edf6c69d6d47b5709140796c2ecab23e
2024-11-26 10:23:45 -05:00
Uwais Ashraf 6c85912736 Make RV focusable when empty to read out content desc for TalkBack.
Fix: 379638096
Flag: EXEMPT BUG_FIX
Test: Manual - go to overview with and without tasks. Check TalkBack.
Change-Id: I1f3faace530ed3c9b0384b94dbc163f5b8c15dda
2024-11-26 11:42:42 +00:00
Chaitanya Cheemala (xWF) 1743fd9e77 Merge "Revert "Use the Coreographer's frame time for a more reliable ti..."" into main 2024-11-26 11:37:15 +00:00
Chaitanya Cheemala (xWF) 9155cf9066 Revert "Use the Coreographer's frame time for a more reliable ti..."
Revert submission 30509816-raf-timing

Reason for revert: Likely culprit for b/381006945  - verified through ABTD before revert submission as part of standard investigation process.

Reverted changes: /q/submissionid:30509816-raf-timing

Change-Id: Iaed968120be662df8d915bac61e7cfa5b936f35c
2024-11-26 11:35:00 +00:00
Alex Chau 1d720793fa Merge "Add TaskOverlay children for accessibility" into main 2024-11-26 10:49:34 +00:00
Holly Sun 879af5779c Do not let talkback read "Item added to home screen" after an app is added to home screen.
Bug: 379643701
Test: manual
Flag: EXEMPT talkback bug fix
Change-Id: I29082c2db33e0a5d20f07e7ecc4a71448337104e
2024-11-25 21:15:53 -08:00
Anushree Ganjam 61d0c95f76 Create ApplicationInfoWrapper with ItemInfo.getTargetPackage() to support DeepShortcuts
Follow up fix for
https://googleplex-android-review.git.corp.google.com/c/platform/packages/apps/Launcher3/+/29586180/9/src/com/android/launcher3/popup/PopupPopulator.java#119
and crash since componentName can be null for Deep shortcuts.

Bug: 375567866
Test: Presubmit
Flag: EXEMPT Bugfix
Change-Id: I5b20248a3cc87cf044aac9848aed4cbeb6d5b092
2024-11-25 20:14:41 -08:00
Treehugger Robot cff3ade324 Merge "Remove padding from All Apps and Divider views for transient taskbar." into main 2024-11-26 04:02:56 +00:00
Android Build Coastguard Worker 5a12033741 Snap for 12710726 from f612dc1a5b to 25Q1-release
Change-Id: If191ca982e1a9b55ac9876989da5b752aebd9499
2024-11-26 02:17:17 +00:00
fbaron 493583435b Convert px to dp for determining minWidth and minHeight for each row count, and add breakpoints
Bug: 364711064
Flag: com.android.launcher3.one_grid_specs
Test: HomeScreenImageTest
Change-Id: I391e001ddee454baccbc0a8f1e002cc815722239
2024-11-26 00:38:19 +00:00
Treehugger Robot f612dc1a5b Merge "Fix taskbar visibility when default-to-desktop" into main 2024-11-25 23:18:43 +00:00
Saumya Prakash cdaf04a556 Add animations to Manage Windows menu in Taskbar
This change switches to using animations to open and close the Manage
Windows view is the multi instance menu of Taskbar. Previously the view
would just appear and disappear, but this makes it smoother.

Fix: 380921297
Bug: 315989246
Test: Open and close the Manage Windows view and observe the motion
Flag: com.android.launcher3.enable_multi_instance_menu_taskbar
Change-Id: I9fb85d4a3ee437bed53991aac7a240d536478f4b
2024-11-25 21:23:56 +00:00
Fengjiang Li 3daaad8498 [Launcher Memory Leak] Avoid leaking Folder/FolderIcon when removing FolderIcon from TaskbarView
Fix: 380868830
Flag: NONE - released code
Test: Presubmit
Change-Id: I57c179384df06015a7e95a173c399cfcda236e46
2024-11-25 11:30:53 -08:00
Alex Chau 0aee46e098 Add TaskOverlay children for accessibility
- ag/28947579 add a speicifc order for children of TaskView to be added for accessibility. All TaskView children will need to added through TaskContainer.addChildForAccessibility

Fix: 379802031
Fix: 380016834
Fix: 204280593
Test: Go to Select mode, ensures Talkback can cycle through text selection boxes
Flag: EXEMPT BUG_FIX
Change-Id: Id7991a8b3e76fe47f562e338e9967c8e85fa4908
2024-11-25 19:04:46 +00:00
Bill Yi 040aad2cb2 Merge "Import translations. DO NOT MERGE ANYWHERE" into main 2024-11-25 18:54:47 +00:00
Bill Yi 1cfdd3a833 Merge "Import translations. DO NOT MERGE ANYWHERE" into main 2024-11-25 18:54:47 +00:00
Saumya Prakash 43ecc1d0a1 Merge "Fix Taskbar not auto stashing from multi instance menu" into main 2024-11-25 18:34:35 +00:00
Xin Li 759798d79a [automerger skipped] Merge ab/AP4A.240925.013 into aosp-main-future am: 7b31be6dfa -s ours
am skip reason: Merged-In If0497fcc17bb0ec44294c4ea1163104b4d8be459 with SHA-1 7519b7c2e6 is already in history

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/30533411

Change-Id: Ib3ca50f17930dae3b394ef6c0632e351238ba1ab
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-11-25 18:18:41 +00:00
Jon Miranda f86e0e4b88 Remove padding from All Apps and Divider views for transient taskbar.
(Initial CL removed padding always) I0f9cce376d47918e69a65ed288f10143930ee3be

Bug: 375661139
Test: confirmed with design team
Flag: EXEMPT bugfix
Change-Id: I467d0a5ae3ab48ebebc5a05f7a0902ddd01f8084
2024-11-25 18:16:26 +00:00
Jagrut Desai 7a14d1b7b9 Don't recreate taskbar in Overview
This cl includes
	- when going to overview from Launcher or Desktop Mode don't recreate taskbar and keep it a same variant as the context user was in.
        - user will still be able to pin/unpin taskbar in overview, but it will be recreated to the launcher context.

Bug: 343882478
Test: Manual
Flag: com.android.window.flags.enable_desktop_windowing_mode

Change-Id: Icb62e1767a83a31422d952ca44fae96ad84ebf44
2024-11-25 10:09:02 -08:00
Schneider Victor-tulias 54e50f43a6 Merge "Start the home intent when swiping from home to home" into main 2024-11-25 17:53:27 +00:00
Luca Zuccarini fb2525a850 Merge "Use the Coreographer's frame time for a more reliable timestamp." into main 2024-11-25 16:19:35 +00:00
Schneider Victor-Tulias ccd08f4667 Start the home intent when swiping from home to home
This allows us to clean up the home screen properly (close all apps and floating views)

Flag: com.android.launcher3.enable_fallback_overview_in_window
Fixes: 380049465
Fixes: 380049942
Test: TAPL tests
Test: swipe home from home all apps, with and without an open popup menu, with and without a 3P launcher
Change-Id: I3c3c8e832329afc3ffaa1de7cf646be79d84e9a3
2024-11-25 10:56:54 -05:00
Artsiom Mitrokhin 86bf6ae902 Prevent spawning multiple pinning popups on right click
The dismiss logic only checks for `ACTION_DOWN` events, but when the
user frequently right-clicks OR right-press-move-release, we get
multiple `ACTION_MOVE` events instead, which are ignored by the dismiss
logic of the previous popup instance.

Attached screen recordings to the bug.

Bug: 362475367
Flag: EXEMPT bugfix
Test: manual
Change-Id: I665c3127e4b449a8f4c71e443cc6ae07c1bf2794
2024-11-25 10:52:36 -05:00
Johannes Gallmann 0b0452eda9 Merge "Cancel predictive back when sliding off back button" into main 2024-11-25 08:17:56 +00:00
Johannes Gallmann 4af733d65f Merge "Only register Launcher back-callback when ROLE_HOME is held." into main 2024-11-25 08:13:05 +00:00
Android Build Coastguard Worker 2230ad5d25 Snap for 12704382 from 7005aff0dc to 25Q1-release
Change-Id: I1f9a65c691bf8319c7c73678e79484d49eb3f260
2024-11-23 22:16:37 +00:00
Android Build Coastguard Worker 7bca4d5d78 Snap for 12702769 from f18e02fa7b to 25Q1-release
Change-Id: Id95394c6524e552bc2a1dd31f6647263ce6df3cf
2024-11-23 02:16:47 +00:00
Dan Brunwasser 7005aff0dc Merge "Fix home gesture animation for 3rd party launchers." into main 2024-11-23 01:06:42 +00:00
Treehugger Robot ba13bc11c6 Merge "[CD Taskbar] Refactor TaskbarManager to store TaskbarRootLayouts in a map" into main 2024-11-23 00:38:44 +00:00
Sebastian Franco 8fc5f39007 Add Event log for FIXED_LANDSCAPE_TOGGLE
Bug: 364711735
Test: NA
Flag: com.android.launcher3.one_grid_specs
Change-Id: I154839e78a197444ccbcbd86bba101865c6a964b
2024-11-22 15:35:35 -08:00
Sukesh Ram 7516dd06d5 [CD Taskbar] Refactor TaskbarManager to store TaskbarRootLayouts in a map
Refactor the TaskbarManager's existing usages of TaskbarRootLayouts to use a map, so that there can be a 1:1 relationship between TaskbarRootLayouts and TaskbarActivityContexts.

Flag: EXEMPT not adding new behavior
Bug: 380351840
Test: Manual
Change-Id: Ib4379a9b6d50b8bdd64b70d7b15ce798ebb42731
2024-11-22 14:30:49 -08:00
Ana Salazar Maldonado f18e02fa7b Merge "Avoid drawing the launcher pill outside the view bounds" into main 2024-11-22 22:13:38 +00:00
Winson Chung bf84fe574e Merge "Update OHM regions whenever other regions change" into main 2024-11-22 21:23:21 +00:00
Dan Brunwasser e026b261b3 Fix home gesture animation for 3rd party launchers.
Previously home animations for 3rd party launchers were being cancelled by the recently added onFinishComplete call in AbsSwipeUpHandler.onTasksAppeared. This was because FallbackSwipeHandler.handleTasksAppeared was returning false even though mActiveAnimationFactory.handleHomeTaskAppeared was true. However, only fixing this so it returned true instead would allow AbsSwipeUpHandler.onTasksAppeared to continue to the following conditions which would fail, so this change also converts FallbackSwipeHandler.handleTasksAppeared to override onTasksAppeared instead. This allows home tasks to be handled first and skip splash screen handling since it is not needed.

Flag: NONE bug fix for recently introduced issue
Fixes: 362900007
Test: set 3rd party launcher as default and use home navigation gesture
Change-Id: I88015bd3bdbad94bd4897411714ff3f52a782499
2024-11-22 13:00:33 -08:00
Saumya Prakash 0028bed674 Fix Taskbar not auto stashing from multi instance menu
This change addresses an issue where touching the bottom of the screen would result in the dismissal of the multi instance menu, but leave the taskbar in a state that it would not auto stash. This is because the view was being removed through another way leading to taskbar being in a bad state. Now when the view is removed, the taskbar is correctly reset.

Fix: 380304394
Bug: 315989246
Test: Manually launch the menu then tap the bottom of the screen. Ensure that taskbar eventually auto stashes.
Flag: com.android.launcher3.enable_multi_instance_menu_taskbar
Change-Id: Ie6bae803a42cf0bcd0ff6362473a63cb22a841eb
2024-11-22 20:50:46 +00:00
Brian Isganitis 39837267eb Merge changes Ie1523446,I0263f704 into main
* changes:
  Do not pre-add All Apps icon in phone mode.
  Fix LayoutTransition All Apps divider logic for RTL.
2024-11-22 20:14:37 +00:00
Ana Salazar Maldonado f9884f20f3 Avoid drawing the launcher pill outside the view bounds
When drawing the launcher pill, the round rect corners may extend a little
beyond the view bounds.  Add a small padding for the round rect corners around
the text view to avoid drawing out of bounds for the view.

Bug: 341217082
Flag: com.android.launcher3.enable_contrast_tiles
Test: Manual, visual change
Change-Id: I41cd2ad9909081cb66751d7f03e52f03f8ae928b
2024-11-22 11:06:14 -08:00
Matt Sziklay 5763a6d0b7 Merge "Move shared logic to new package." into main 2024-11-22 18:53:58 +00:00
Juan Sebastian Martinez a91fbb2efd Adding MSDL haptics for dragging app icons in Workspace and Hotseat.
The feedback occurs when an icon hovers over an empty available space in
Workspace and Hotseat, as well as over other icons to create folders.
This is now compliant with the Multi-sensory Design Language spec.

Test: manual. Verified haptics while dragging icons over Workspace and
  Hotseat.
Test: manual. Verified haptics with adb shell dumpsys of Launcher and
  checking the MSDL token history.
Flag: com.android.launcher3.msdl_feedback
Bug: 371314631

Change-Id: I7d039ddf9d05faa39a6e6e3f9a84217d8916adc0
2024-11-22 10:31:18 -08:00
Juan Sebastian Martinez 12c5b06add Merge "Adding a mock for MSDLPlayerWrapper to DeleteDropTargetTest." into main 2024-11-22 18:21:05 +00:00
Winson Chung ce1a73829f Update OHM regions whenever other regions change
- Speculative fix, there are some scenarios where we update the swipe
  touch/assistant regions without updating the OHM regions

Bug: 362039326
Flag: EXEMPT bugfix
Test: Manual
Change-Id: If5c558623073e5185827ae17a162dacf322c74a4
2024-11-22 16:53:22 +00:00