Commit Graph

83004 Commits

Author SHA1 Message Date
Charlie Anderson a2464c6609 Merge "Add logging to verify when LoaderTask is stopped or cancelled" into main 2024-12-05 02:34:09 +00:00
Treehugger Robot 744d0b9925 Merge "Workaround for incomplete setup flow prior to Launcher tests" into main 2024-12-05 01:30:50 +00:00
Sebastian Franco 2b0cdbbc87 Make sure GRID_NAME is updated every time it changes.
Bore it was only updated when the device was innitialized,
but other changes to the IDP would not udpate the GRID_NAME pref.

Fix: 380954618
Test: NA
Flag: com.android.launcher3.one_grid_specs
Change-Id: I4fa73a4b838c0d0c7c1c88ea91c62ac8ae6676b7
2024-12-05 01:25:25 +00:00
Saumya Prakash ddd667ac9a Prevent Taskbar all apps from showing multi instance options
This change makes it so that we don't show any multi instance options in
Taskbar all apps. This matches the behavior from regular All apps.

Fix: 382342931
Test: Long press an app icon in Taskbar all apps and ensure multi
instance options don't show up.
Flag: com.android.launcher3.enable_multi_instance_menu_taskbar

Change-Id: I5322df328ee5484168b96831f32c2023521704e6
2024-12-05 01:04:54 +00:00
Treehugger Robot db013a8e75 Merge "TaskViews indices inside RecentsView continue [2/n]" into main 2024-12-05 00:35:26 +00:00
mpodolian 2fd98270a7 Update Hotseat icons adjustment X calculation based on cell X Index
Resolved an issue where the X translation for hotseat icons was computed
using the view index in the parent, leading to misaligned adjustments.
The logic has been updated to calculate translation based on the cell X
index, ensuring more accurate positioning and alignment.

Fixes: 380794616
Test: Manual. Have a bubble in landscape orientation. Drag any item from
the hotseat to the workspace, then rotate the device.
Flag: com.android.wm.shell.enable_bubble_bar

Change-Id: Ibd0709e6c58ad9c1470de469cfced8bbe66fd30b
2024-12-04 16:23:00 -08:00
Android Build Coastguard Worker e848231264 Snap for 12748980 from 2909e72d36 to 25Q1-release
Change-Id: I2ed1a23c847ed954b52002d13d9bd5e62298d8ed
2024-12-05 00:17:23 +00:00
fbaron 9ce45bac05 Fix findMinWidthAndHeightDpForDevice so it finds the smallest dp height of the cached displays
Bug: 364711064
Flag: com.android.launcher3.one_grid_specs
Test: HomeScreenImageTest
Change-Id: I04bc264a3f3579eff18412c02546460aaaeff955
2024-12-04 23:51:43 +00:00
Sebastian Franco 789546f528 Using the right context when in FixedLandscape
Fix: 378956881
Test: HomeScreenImageTest
Flag: com.android.launcher3.one_grid_specs
Change-Id: I57c0fb2b57828e0cb80d20417f0a45e49c78b80e
2024-12-04 23:51:34 +00:00
Ikram Gabiyev ee4d9ed3ad Do not send setFinishTaskTransaction if not swipe
In PiP2, there is no need to send setFinishTaskTransaction()
unless we are swiping PiP to home.

This is because either ATMS#enterPictureInPictureMode() is supposed
to request a TRANSIT_PIP as the activity goes to pause.

Bug: 380515865
Flag: com.android.wm.shell.enable_pip2
Test: repro the steps in the bug
Change-Id: Ic24c0c0f471179198a5fe3221971cf5b6d634797
2024-12-04 15:36:26 -08:00
Pinyao Ting caac0a978d Hide "Shortcut Menu" from a11y actions when shortcut menu is already opened
Bug: 378062790
Change-Id: Iab742e7f24625b1f626c30bbbefdcad68d61904e
Test: manual
Flag: EXEMPT bugfix
2024-12-04 23:14:12 +00:00
Jon Miranda 591c44a63b Keep transient taskbar open while overflow is open.
Fixes: 380375446
Test: open taskbar overflow, interact with overflow, taskbar stays open
Flag: com.android.launcher3.taskbar_overflow
Change-Id: Iec95e40336debd6cc2a8f9a79fce2093b6d10e6c
2024-12-04 22:57:34 +00:00
Uwais Ashraf 5305c71e8b Add flag for using top visible activity for recent tasks instead of indicies
Bug: 342627272
Flag: com.android.launcher3.enable_use_top_visible_activity_for_exclude_from_recent_task
Test: none - flag addition
Change-Id: Ia32dacaab750f485a584d5a15fd0b3bf40e36446
2024-12-04 22:28:57 +00:00
minch 1bf7678154 TaskViews indices inside RecentsView continue [2/n]
In applyLoadPlan
- Refactored newFocusedTaskView to be based on first non-Desktop TaskView
- Set newFocusedTaskView to null when enableGridOnlyOverview() is on
- Updated target page calcuation to be based on the following priority: running task, focused task, first non-desktop task, last desktop task

Flag: EXEMPT as no functionality changes
Bug: 379942019
Test: Ensure targetPage in applyLoadPlan is correct in the following scenarios:
1. Only have desktop task
2. Desktop task and a few full screen tasks
3. Swipe up from desktop, 1st fullscreen task, and 2nd fullscreen task
4. Repeat with enableGridOnlyOverview() on, which does not have focused task

Change-Id: Iea519ad4a37c15f76557487078ac4dcf4d53480c
2024-12-04 22:21:20 +00:00
Jon Miranda 73797f8188 Revert^2 "Check if all apps are translucent when finishing recents animation."
This reverts commit 4fd400994a.

Reason for revert: Found the cause of the regression and fixed it
The regression was caused when adding a new method params to an
overloaded method, and then passing in the wrong parameter.

Bug: 379602904 
Bug: 354627538 
Change-Id: I54bc40042e08ae2da1808427b16e3587b6da789c
2024-12-04 21:57:04 +00:00
Charlie Anderson 8d76114fe3 Add logging to verify when LoaderTask is stopped or cancelled
Flag: EXEMPT just logging
Test: Presubmit
Bug: 377510898
Change-Id: Ie97adc07ed995af8b09eab232fcce9431bea42d5
2024-12-04 15:56:43 -05:00
Shamali Patwa 2909e72d36 Merge "Update accessibility hint for widget cell that shows add button." into main 2024-12-04 20:22:26 +00:00
Liran Binyamin 77827d3167 Fix bubble bar flicker in initial animation
When the first bubble animates in we make the bubble bar visible
before translating it below the screen to prepare for the spring
animation. This change defers updating the visibility letting the
animator notify when it's safe to update visibility.

Flag: com.android.wm.shell.enable_bubble_bar
Fixes: 382296842
Test: atest BubbleBarViewAnimatorTest
Test: manual
       - dismiss bubble bar
       - send new bubble
       - observe bubble bar does not flicker
Change-Id: Ib611771dd9f315ab57ef00f8f6cb982b8b88ea73
2024-12-04 15:05:22 -05:00
Sebastian Franco bb3eb4de72 Setting mIsFixedLandscape as the first if condition while fixing 380940677
It seems that when turning the flag oneGridSpecs on with some existing
condition the user is allow to continue rotating, there is a chance
that the bug is in SysUI but I need to submit this to rule it out.

Bug: 380940677
Test: NA
Flag: com.android.launcher3.one_grid_specs
Change-Id: I9d551dc0c742f8e3596ffc79ef2be9037dfa4b25
2024-12-04 11:31:33 -08:00
Treehugger Robot 14a4684992 Merge "Fix issue in scrolling in remote compose widgets" into main 2024-12-04 18:38:57 +00:00
Jordan Silva aed3b14abc Dismiss recents when device goes to sleep
Dismiss recents automatically after lock and unlock the device, otherwise recents screen becomes non-responsive for 3P Launchers.

Bug: 319365581
Change-Id: I6571f25cf311ca586f6d9c9e1228f1addcbed1f1
Flag: EXEMPT bugfix.
Test: FallbackRecentsTest
2024-12-04 18:37:47 +00:00
Shamali P 0e668e1b1d Update accessibility hint for widget cell that shows add button.
With tap to add feature, tapping widget cell reveals add button.

So, clarify the intent with ACTION_CLICK

Bug: 374033389
Test: Talkback
Flag: EXEMPT BUGFIX
Change-Id: I03e47241fbc16f1354394e3a6fd412998642e6cf
2024-12-04 18:12:36 +00:00
Liran Binyamin 0de5987efb Don't crop bubble flyout in overview
When switching to overview we set the taskbar window size as part
of the taskbar animation. If a bubble is animating the window size
becomes too small and the bubble flyout gets cropped. This change
avoids updating the window size in the middle of a bubble animation.

Flag: com.android.wm.shell.enable_bubble_bar
Fixes: 377809168
Test: manual
       - create a bubble and wait for the flyout to show
       - switch to overview
       - observe the flyout is not cropped
Change-Id: Ic0a3f2c0fc534162ae5583e744a7bc400c3d921b
2024-12-04 12:36:56 -05:00
Treehugger Robot 9fdf9efdd2 Merge "multiple-desktops: Add new desktop button xml file" into main 2024-12-04 14:02:41 +00:00
Alex Chau d7ad4d5dee Merge "Reapply insets normalization on configuration changes" into main 2024-12-04 11:25:37 +00:00
Alex Chau ba8b4d7851 Merge "Reland "Handle uiMode changes in QuickstepLauncher"" into main 2024-12-04 10:45:02 +00:00
minch 7fbc82cab1 multiple-desktops: Add new desktop button xml file
- Add the skeleton xml file for the new desktop button
- Add the icon for this button as well
- Create the kotlin file for this button

Flag: EXEMPT as added files haven't connected with the production logic
Fix: 379941322
Test: None
Change-Id: I5c7ea2c061f0f9539483221f40c892626103d11e
2024-12-04 10:26:42 +00:00
Tracy Zhou 3d31b97389 Restore barMode and wallpaperVisible to Taskbar NavbarButtonsViewController state
Fixes: 379816005
Test: manual
Flag: EXEMPT bugfix
Change-Id: I2a181c498cb674f077d1b0accfe85b62880a1cfc
2024-12-03 17:16:09 -08:00
Pinyao Ting 1f72f9b3de Fix issue in scrolling in remote compose widgets
There was special check in LauncherAppWidgetHostView to disallow intercept touch events in launcher when the widget is scrollable, the same check needs to be implemented for remote compose widget for scrolling to work properly.

Bug: 339721781
Change-Id: I8b824f293ab287a7844f93610b8b952c4aefa3dd
Test: manual
Flag: EXEMPT bugfix
2024-12-04 00:45:48 +00:00
Tony Wickham ab8fa5e67e Merge "Factor in userId for updateHotseatItemsFromRunningTasks" into main 2024-12-04 00:31:48 +00:00
Tony Wickham db64e1b3d1 Factor in userId for updateHotseatItemsFromRunningTasks
Test: onRecentTasksChanged_inDesktopMode_sameHotseatPackage_differentUser_isInShownTasks
Test: Pin personal Chrome, open work Chrome in desktop mode; ensure a
new work icon is created in the running apps section
Flag: com.android.window.flags.enable_desktop_windowing_taskbar_running_apps
Bug: 376818660

Change-Id: Ie5cf3ab8e839456e6bd774de8a4398835e790019
2024-12-04 00:31:36 +00:00
Android Build Coastguard Worker af79b55208 Snap for 12742097 from f274d3ca95 to 25Q1-release
Change-Id: Iabe3a51adf01a05806e36a3c0274ecb4166fef1b
2024-12-04 00:17:41 +00:00
Treehugger Robot d0b6a849ad Merge "Make DynamicResource as dagger singleton (15/n)" into main 2024-12-03 22:14:56 +00:00
Treehugger Robot 5ef606c417 Merge "Do not let talkback read "Item added to home screen" after an app is added to home screen." into main 2024-12-03 21:43:08 +00:00
Saumya Prakash 1fa9b25b73 Merge "Ensure Desktop Tasks show up in Taskbar multi instance menu" into main 2024-12-03 21:14:32 +00:00
Anushree Ganjam b60be0896d Make DynamicResource as dagger singleton (15/n)
Bug: 361850561
Test: Manual
Flag: EXEMPT Dagger Integration
Change-Id: I8a3de783de34f79c8f8f64c5c964cc1636ace1a8
2024-12-03 12:01:45 -08:00
Alex Chau 579a785144 Reapply insets normalization on configuration changes
- When going from an app to Overview after deivce is rotated, sometimes the Configuration associated with Launcher activity have old information (dimension from preious rotation), causing LauncherRootView.onApplyWindowInsets to store wrong insets from WindowManagerProxy.normalizeWindowInsets
- The fix is when LaucnehrRootView.dispatchInsets is called, reapply insets by calling onApplyWindowInsets again to get updated normalized insets.

Fix: 323105140
Test: Launch an app, rotate to landscape, tap Recents button to go to Overview
Flag: EXEMPT BUG_FIX
Change-Id: I8e641a2702670d1364ee5a0f10a1b3c8d1a2b324
2024-12-03 19:03:28 +00:00
Brandon Dayauon f274d3ca95 Merge "Fix "disabled" at the end of talkback for workPausedCard." into main 2024-12-03 18:31:46 +00:00
Xin Li aa31d0d320 [automerger skipped] Merge ab/AP4A.241205.013 into aosp-main-future am: c7ff9cc0af -s ours
am skip reason: Merged-In Ia507354f42959ce9d320114a313bfc533186b524 with SHA-1 9aa005b657 is already in history

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/30626202

Change-Id: Ibdedab3fbbd4c755527d9e79d9eaf775ecc651c8
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-12-03 18:21:59 +00:00
Alex Chau 007abe80e4 Reland "Handle uiMode changes in QuickstepLauncher"
- Added uiMode in handled configChanges for QuickstepLauncher, NexusLauncherActivity
- RecentsActivity will be handled separately in b/382072029
- This avoids Launcher from being recreated when swithching from an app in driving mode (e.g. Maps), which causes massive jank
- Launcher layout is unaffected when driving mode changes, so a recreation is unnecessary
- When Light/dark mode changes, BaseActivity.updateTheme will still causes activity to be recreated. Launcher will mark a boolean in saved staete so next recreate will restore previous state even if state has FLAG_DISABLE_RESTORE (e.g. Overview), similar to the existing check that force restore when UI_MODE changes

Relanded changes: /q/submissionid:27627108-b/339747262

Fix: 339747262
Test: Swtich from driving mode app to another or home in 1p and 3p laucnher
Test: Switch light/dark mode and Launcher is updated correctly and stay in previous state
Flag: EXEMPT bugfix
Change-Id: I5a62b1bcd19eed9d232f30db94aa0e032f4541bd
2024-12-03 18:20:56 +00:00
Treehugger Robot 1733dedf85 Merge "Add GridDimensionSpecs to fixed landscape and make grid dimension generalized so we can use it to determine row count or col count" into main 2024-12-03 18:05:10 +00:00
Schneider Victor-tulias bbefa5daf7 Merge "Use the RecentsWindowTracker in FallbackRecentsTest rather than RecentsActivity's ActivityTracker when flag is enabled" into main 2024-12-03 16:06:40 +00:00
Brandon Dayauon a7340e8575 Merge "Add unit testing to workkUtilityView" into main 2024-12-03 15:43:48 +00:00
Treehugger Robot 1c9b6dd4f3 Merge "[Launcher Memory Leak] Fix leak of AbsSwipeUpHandler via Launcher#mOnDeferredActivityLaunchCallback" into main 2024-12-03 03:56:03 +00:00
fbaron d1cd8c2ea6 Add GridDimensionSpecs to fixed landscape and make grid dimension generalized so we can use it to determine row count or col count
Bug: 364711064
Flag: com.android.launcher3.one_grid_specs
Test: HomeScreenImageTest
Change-Id: If1dafedc710ebc483fc7b6b5cd6cae6f70dc3cfc
2024-12-03 02:43:13 +00:00
Android Build Coastguard Worker 63d08c4e28 Snap for 12735943 from 79fb6dfbdb to 25Q1-release
Change-Id: I56fa830920320f3495e84626b96ae626d27e6169
2024-12-03 00:16:57 +00:00
Saumya Prakash a32f7f3f4a Ensure Desktop Tasks show up in Taskbar multi instance menu
This change adds in desktop tasks to show up in the Manage Windows
Taskbar menu. Previously these were getting filtered out.

Fix: 380167542
Bug: 315989246
Test: Launch multiple tasks in desktop mode and see that they show up in
the multi instance viewer from the Taskbar menu
Flag: com.android.launcher3.enable_multi_instance_menu_taskbar

Change-Id: Ia07b3ad68f43c0f121b0608c5341d50970c8af4c
2024-12-02 23:44:59 +00:00
Tony Wickham 7614088dc5 Merge "Fix Taskbar 3 Button y position on launcher home pause/resume" into main 2024-12-02 23:33:57 +00:00
Wen-chien Wang ef427290c9 Merge "Register back action to close the KQS view" into main 2024-12-02 22:04:11 +00:00
Schneider Victor-Tulias 1df3836591 Use the RecentsWindowTracker in FallbackRecentsTest rather than RecentsActivity's ActivityTracker when flag is enabled
Test: pre/postsubmit
Fixes: 381548102
Flag: EXEMPT checking broken tests
Change-Id: I5764c661c53c383a80fbd568e839a5f3d2633427
2024-12-02 16:40:32 -05:00