Commit Graph

83004 Commits

Author SHA1 Message Date
Schneider Victor-Tulias 76e1676c7f Update TaplTestsQuickstep to expect recents window states when enabled
Flag: com.android.launcher3.enable_fallback_overview_in_window
Fixes: 382527932
Test: TaplTestsQuickstep
Change-Id: I14f66628105fab5d8c39ae7f9fd9ebfa61a268b7
2024-12-10 16:17:57 -05:00
Schneider Victor-Tulias 37deb21bd4 Update QuickstepTestInformationHandler.getWindowInsets to support recents window
Flag: com.android.launcher3.enable_fallback_overview_in_window
Fixes: 382252723
Fixes: 378158368
Test: TaplDragTest
Change-Id: I272a9e50f2209d3b7959bb9abc834546c9b845e8
2024-12-10 16:17:48 -05:00
Sunny Goyal 89551b71be Fising some tests bugs, assuming primary user is user 0
Bug: 383091872
Bug: 383183795
Bug: 383088668
Test: Presubmit
Flag: EXEMPT test fix
Change-Id: I551f13fc3d51bf1c2718f0582f8ee76d51067896
2024-12-10 12:09:33 -08:00
Shamali Patwa 5f5b1a3f56 Merge "Fix missing IME back animation in widget picker" into main 2024-12-10 19:44:47 +00:00
Shamali Patwa d60bb5a2f2 Merge "[HSUM] Update createTestWidgetItem to use current user for test widget" into main 2024-12-10 19:42:42 +00:00
Treehugger Robot 8fd2e6df9a Merge "Don't use flow for one-off get of ThumbnailData" into main 2024-12-10 19:21:36 +00:00
Mykola Podolian 9763990e9e Merge "Align hotseat drop target with the adjusted hotseat" into main 2024-12-10 18:50:22 +00:00
Fengjiang Li c290787cf7 [PostBoot] Support post boot animation on launcher3
Add ALPHA_CHANNEL_COUNT to DragLayer

Test: manual
Flag: NONE - gated in xml
Bug: 346332241
Change-Id: Ie7cf4c11b4e606e01d54d8a87e7f1dc5906e97b0
2024-12-10 10:07:29 -08:00
Uwais Ashraf 1f09cd720d Don't use flow for one-off get of ThumbnailData
Bug: 381317629
Flag: com.android.launcher3.enable_refactor_task_thumbnail
Test: TasksRepositoryTest
Test: Performance tests
Change-Id: I1990ad1972beea8c81b44cdd50c7f674f225c69d
2024-12-10 17:28:55 +00:00
Sebastian Franco 279b77a882 Making sure that test go to FixedLandscape on landscape
Fix: 379871292
Test: TaplDragTest
Flag: com.android.launcher3.one_grid_specs
Change-Id: I56027c22e4c3b1b0532ba0ac00eb0f4caea24abb
2024-12-10 17:08:54 +00:00
Sam Cackett 6593622db5 Disable "MissingClass" lint check in QuickstepResLib
QuickstepResLib just contains resources. The code implementation for custom views is in NexusLauncher, so the linter doesn't know about this and falsely thinks a custom view resource is added without a corresponding class.

Change-Id: Icfe57c82af679c22428319e20d4c0e29b5c374fe
Fix: 383318069
Bug: 376817827
Flag: EXEMPT trivial build config change
Test: Add a custom view resource to QuickstepResLib, add code for custom view to NexusLauncher, run presubmits, check lint warning isn't there
2024-12-10 16:40:19 +00:00
Shamali P aaf585aef2 Fix missing IME back animation in widget picker
Discussed with folks who worked on IME animation, and root cause seemed
to be picker unconditionally clearing the focus. Also, there is no
in-built way for clearing focus on other user interactions. So, had to
write custom logic to conditionally clear the focus.

Bug: 369933372
Test: See screencast (tested back, and other user interactions)
Flag: EXEMPT BUGFIX
Change-Id: I693bd27662563e5320159c082eb955a3bd5386f8
2024-12-10 16:28:05 +00:00
Vania Desmonda 7fd479c454 Add Aster logging for entering and exiting desktop mode via quick switch
Fixes: 360874817
Fixes: 381214742
Flag: com.android.window.flags.enable_desktop_windowing_quick_switch
Test: manual test
Change-Id: I7bae2aaff614a5590fa107d0c102c520b14b85d9
2024-12-10 13:35:15 +00:00
Johannes Gallmann 9899283045 Merge "Don't cancel or commit predictive back on multi touch in 3-button-nav" into main 2024-12-10 13:33:00 +00:00
Johannes Gallmann 200ee94279 Don't cancel or commit predictive back on multi touch in 3-button-nav
Bug: 381054861
Test: Manual, i.e. verify that tapping the taskbar while predictive back is in progress does not cancel or commit it
Flag: com.android.window.flags.predictive_back_three_button_nav
Change-Id: I4117aca74216849519a0cabcbd3cb14f7fc5b38f
2024-12-10 13:28:36 +00:00
Johannes Gallmann 09603bfb39 Play workspace reveal animation for predictive back-to-home
Bug: 382453424
Test: Manual, i.e. tested back-to-home and back-to-allapps animation on phones, tablets and foldables, including interruptions.
Flag: EXEMPT bugfix
Change-Id: Iece001b6b9edd9ca7a909e3ccbe8ebdff2e71d9f
2024-12-10 12:42:12 +00:00
Alex Chau 20ed6de98b Merge "Revert "Don't recreate taskbar in Overview"" into main 2024-12-10 10:33:30 +00:00
Treehugger Robot ea27c11334 Merge "Use ViewStub for TTV creation to prevent double inflation (TTVDeprecated then TTV)." into main 2024-12-10 10:20:46 +00:00
Uwais Ashraf ca8a53911a Use ViewStub for TTV creation to prevent double inflation (TTVDeprecated then TTV).
Bug: 381317629
Flag: com.android.launcher3.enable_refactor_task_thumbnail
Test: Performance tests
Test: Open single, split and desktop tasks with flag combinations for TTV refactor and app chip.
Change-Id: Ie43955ddf6c9fac162974077a37e8448c5ef1781
2024-12-10 08:19:22 +00:00
Shamali P 2536bcae0c [HSUM] Update createTestWidgetItem to use current user for test widget
Bug: 383087777
Fix: 383087777
Test: Unit test and ABTD for HSUM
Flag: EXEMPT BUGFIX
Change-Id: I3d7ac21628b8ddc16ed09853523a45cde858adb6
2024-12-10 03:59:28 +00:00
Brian Isganitis 9c0552e09d Merge changes from topic "taskbar-view-recents-changes" into main
* changes:
  Move recents divider if hotseat is set after recents.
  Animate out/in the correct task view when recents change.
  Implement initial LayoutTransition for Taskbar recents.
2024-12-10 02:18:53 +00:00
Treehugger Robot 74cc80d239 Merge "Introduce a function getFristTaskView()" into main 2024-12-10 01:51:26 +00:00
Treehugger Robot 278ab17033 Merge "Fixing missing userId in various shell commands" into main 2024-12-10 00:50:10 +00:00
Android Build Coastguard Worker 47b243fa07 Snap for 12770256 from b172e86472 to 25Q1-release
Change-Id: Ic534ad217c8ee116f0a26ffdda444319df798609
2024-12-10 00:46:30 +00:00
Jeremy Sim 0c3b2e9540 App Groups: Allow app pairs to take more than 2 members
Changes saveAppPair to take a general number of apps, rather than just 2. At the moment, this will not change anything, since GroupedTaskViews are still hard coded to contain 2 apps.

Bug: 349828130
Flag: com.android.wm.shell.enable_flexible_split
Test: No effect on behavior, just a small refactor.
Change-Id: I6f86210ab4662f0d3a8fba1f6bb6fd78391e7fa2
2024-12-09 16:41:24 -08:00
Treehugger Robot 9bb546953c Merge "Adapt TaskbarOverflow tests to check items added overflow view" into main 2024-12-10 00:21:18 +00:00
Treehugger Robot 07e6109dc6 Merge "Add logs to output intent string for NPE in DbEntry." into main 2024-12-09 23:41:08 +00:00
minch 0933ba83d8 Introduce a function getFristTaskView()
- Introduce a function `getFirstTaskView()` in RecentsView to get the
  first TaskView inside RecentsView.
- Replace `getTaskViewAt(0)` with this newly introduced function.
- Let `RecentsView.isTaskInExpectedScrollPosition()` accept a TaskView
  instead of index of the TaskView. This can avoid using the index at
  the callsites of this function.
- Change `getTaskViews()` to be a public function, thus it can be
  used outside of the RecentsView.

Flag: EXEMPT as no functionality changes
Bug: 379942019
Test: Ensure the TaskViews required are correct in the following
      scrnarios:
      1. Swiping up from home screen to enter overview with empty or
         multiple tasks
      2. Swiping up from a fullscreen app to enter overview with
         one or multiple tasks
      3. Dimissing one or multiple tasks, exit and re-enter overview
         w/o newly opened tasks
      4. Remvoing all the tasks, re-enter overview w/o newly opened
         tasks
Change-Id: If63ad6dc9f5106be08d867090fdaf616117dcd82
2024-12-09 22:43:14 +00:00
Randy Pfohl 6cbf910d9a Merge "initial commit for multicontext management for recent windows" into main 2024-12-09 22:27:52 +00:00
Stefan Andonian e2c19253b2 Add logs to output intent string for NPE in DbEntry.
Bug: 380555381
Test: No tests, just changed log string.
Flag: EXEMPT bug fix logs
Change-Id: I0b0a36ebce0db38c89afb22a89b7e969fdc16bd9
2024-12-09 13:41:57 -08:00
Stefan Andonian 3d76150128 Merge "Convert SpringLoadedDragController to Kotlin" into main 2024-12-09 21:04:16 +00:00
Brian Isganitis c7f6cd6062 Move recents divider if hotseat is set after recents.
Fixes a bug where updateItems is first called with recents and then with hotseat. This causes the Taskbar to first be All Apps, Divider, and then Recents. The layout transition path assumes though that the Divider after All Apps is not for recents in this case, which is wrong. Due to this assumption, it skips over the divider and then adds the hotseat items after it (should be added before). Added a test for this case.

Flag: com.android.launcher3.taskbar_recents_layout_transition
Bug: 343521765
Test: go/testedequals
Change-Id: Ia690c71fe482709e35ab302a7b497bf547eb4478
2024-12-09 15:35:43 -05:00
Brian Isganitis 3c24c421f6 Animate out/in the correct task view when recents change.
Flag: com.android.launcher3.taskbar_recents_layout_transition
Bug: 343521765
Test: go/testedequals
Change-Id: I6c7708ed9f03eff8469b5f2e75ce00e545b03f54
2024-12-09 15:35:43 -05:00
Brian Isganitis 8e2b850df7 Implement initial LayoutTransition for Taskbar recents.
The animations mostly match the spec, though the recents indicators scale/fade with icon currently.

The change transitions need to incorporate translateX since that changes based on the number of icons in Taskbar. We need the translateX for pinning update to happen before TaskbarView lays out its children so that the animator computes the correct start and end values.

Flag: com.android.launcher3.taskbar_recents_layout_transition
Bug: 343521765
Test: go/testedequals
Change-Id: I13aa49abf80ddc09fab890f78bde924a8f7f1d6e
2024-12-09 15:35:43 -05:00
Alex Chau e8aa9a383c Revert "Don't recreate taskbar in Overview"
This reverts commit 7a14d1b7b9.

Reason for revert: b/383084557
Bug: 343882478

Change-Id: Ia9b13964df7d85cfee441f4163f41e198c283021
2024-12-09 19:05:39 +00:00
Sunny Goyal 3dfaba2d8c Fixing missing userId in various shell commands
Bug: 380276168
Test: atest TaplMemoryTests
Flag: EXEMPT testfix
Change-Id: I87026eaf6340a2a43cbc899d262879259e339fc5
2024-12-09 10:36:06 -08:00
Treehugger Robot b172e86472 Merge "Loading generated preview on-demand instead of keeping everything in memory" into main 2024-12-09 17:26:02 +00:00
Treehugger Robot cea1888874 Merge "Update SystemUiProxy to support RemoteTransition when moving a task to desktop" into main 2024-12-09 12:50:20 +00:00
Android Build Coastguard Worker 9768928250 Snap for 12765415 from 45e274977d to 25Q1-release
Change-Id: I5db2bd603452fdf0159ea87ffd94e1314b9444aa
2024-12-07 23:18:55 +00:00
Treehugger Robot 45e274977d Merge "Some test fixes where default user is assumed to be user 0" into main 2024-12-07 08:11:56 +00:00
Brandon Dayauon 5d69c5c505 Merge "Fix workUtilityView receiving touch for pause work apps button." into main 2024-12-07 07:28:02 +00:00
Sunny Goyal 9c58954488 Some test fixes where default user is assumed to be user 0
CheckLongPressHelper: Cancelling view longpress which inturn also cancels self
This ensures that long press is properly cancelled if the default timeout for system longpress is same as ours

Bug: 379777736
Bug: 379807782
Bug: 379805363
Bug: 379805788
Bug: 379777734
Bug: 379774350
Flag: EXEMPT bugfix
Test: Presubmit
Change-Id: Ic4d9d6c4f79325a5d7ab98eafa1c86db4c2e67a5
2024-12-06 22:23:51 -08:00
Treehugger Robot cc0e19d298 Merge "Add more logs to investigate empty launcher restore" into main 2024-12-07 05:13:33 +00:00
Android Build Coastguard Worker 8af47ad0dd Snap for 12763142 from 3f04014298 to 25Q1-release
Change-Id: I3a92569ff8941972b52bdb7c977237abaad1d540
2024-12-07 02:18:20 +00:00
Treehugger Robot c531c9fb90 Merge "Minor kotlin cleanup" into main 2024-12-06 23:49:12 +00:00
Shamali Patwa 5fb8180b00 Merge "Remove the elevation on the DragView to avoid shadows underneath" into main 2024-12-06 23:40:38 +00:00
Treehugger Robot ddaf0bbd7a Merge "Modify the accessibility tree to move the searchbox to the top." into main 2024-12-06 23:37:45 +00:00
Stefan Andonian 0c057f7df9 Convert SpringLoadedDragController to Kotlin
Bug: 379798547
Test: Verified that this works well on device.
Flag: EXEMPT kotlin conversion
Change-Id: Icaf874557e86a8231614ab75e55aedc8c3718703
2024-12-06 15:11:30 -08:00
mpodolian 06fb33ceb3 Align hotseat drop target with the adjusted hotseat
Added logic to adjust the drop target to account for changes in the
hotseat position when accommodating the bubble bar.

Fixes: 382348730
Test: all tests in package src.com.android.launcher3.celllayout
Test: Manual. Ensure bubbles are present, and the hotseat width is
adjusted. Long-press any icon in the hotseat, begin dragging it over
other hotseat icons, and observe that the drop target is drawn
appropriately.
Flag: com.android.wm.shell.enable_bubble_bar

Change-Id: Ice961f40ace03077ab8c9312a93eda1a16d7da34
2024-12-06 14:57:31 -08:00
Sunny Goyal ee15f52a7c Loading generated preview on-demand instead of keeping everything in memory
Bug: 369906121
Test: atest GeneratedPreviewTest
Flag: EXEMPT bugfix
Change-Id: Idd7610e8a5c577d2c7b0a1d7d2a1f1efde40b11f
2024-12-06 22:25:40 +00:00