Commit Graph

83004 Commits

Author SHA1 Message Date
Alex Chau 865982c634 Merge "Pulling secondary user artifacts from tests" into main 2025-02-26 02:47:54 -08:00
Treehugger Robot d9435c6d41 Merge "If the desktop task is visible, increase the count" into main 2025-02-26 02:08:25 -08:00
Treehugger Robot 006ea72afe Merge "More test for taskbar overflow" into main 2025-02-25 22:35:47 -08:00
Treehugger Robot d668dd6e30 Merge "Visual updates for PageDotIndicators" into main 2025-02-25 22:33:46 -08:00
Saumya Prakash 3fe4e7d90f Ensure Talkback announces text correctly in Gesture tutorial
This change modifies how Talkback announces the title and the subtitle
in the gesture navigation tutorial. It no longer shifts the focus to the
subtitle, but instead makes the whole window focusable.

Fix: 386884587
Test: Open the gesture tutorial with talkback and ensure the text is
announced without change of focus. Ensure the Done button doesn't get
announced
Flag: EXEMPT bugfix

Change-Id: Id28382acbebe763f2f64f4e49eb00d6ea61e0553
2025-02-26 05:47:34 +00:00
Stefan Andonian ae8ab4c403 Visual updates for PageDotIndicators
TODOs have been added for verifying and updating the Outline, right to left mode,
and the entry animation. This CL is complex, and those have been left out on purpose.

Bug: 394355070
Test: Verified this behavior looks good in LTR on the workspace.
Flag: com.android.launcher3.enable_launcher_visual_refresh
Change-Id: I8f0192f461d344360572411e1a62921fd65ba600
2025-02-25 20:26:00 -08:00
Charlie Anderson dfb45d9c03 Simplify ShapesProvider and use constants
Bug: 398689048
Bug: 372884380
Test: presubmit and locally
Flag: com.android.launcher3.enable_launcher_icon_shapes

Change-Id: I102265ef4b25d84bb7a0b1f9642a9c19a7200e22
2025-02-25 20:17:54 -08:00
Vadim Tryshev 52bf5cd945 Pulling secondary user artifacts from tests
Bug: 396447643
Test: abtd run
Flag: NONE Not production code
Change-Id: I884a787f350ffb646827a32749c45fde8e93f53f
2025-02-25 19:20:15 -08:00
mpodolian 1a4025a10d Added a bubble bar location argument to IPC calls adding app bubbles.
Added an optional bubble bar location to the IBubbles.aidl interface
adding bubble methods to allow the launcher to update the bubble bar's
location when dragging application icons into it within the launcher
process.

Bug: 397459664
Flag: com.android.wm.shell.enable_create_any_bubble
Test: N/A
Change-Id: Ief2296146a686a72d79a5d92522feb9c7a949470
2025-02-25 15:52:05 -08:00
Owner Cleanup Bot c383866630 Merge "[owners] Remove zakcohen@google.com from tests/multivalentTests/src/com/android/launcher3/widget/picker/OWNERS" into main am: bbda0821a6 am: c8abc144b7
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/3490671

Change-Id: I9a0698da781bae7365ed46bc52fee13f46aaba2f
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2025-02-25 15:37:31 -08:00
Owner Cleanup Bot c8abc144b7 Merge "[owners] Remove zakcohen@google.com from tests/multivalentTests/src/com/android/launcher3/widget/picker/OWNERS" into main am: bbda0821a6
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/3490671

Change-Id: I5745efc226967581ed7d62454aa9976e8fca2b5d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2025-02-25 15:12:04 -08:00
Owner Cleanup Bot bbda0821a6 Merge "[owners] Remove zakcohen@google.com from tests/multivalentTests/src/com/android/launcher3/widget/picker/OWNERS" into main 2025-02-25 14:47:00 -08:00
Bill Yi 32a30bfb5c Merge "Import translations. DO NOT MERGE ANYWHERE" into main 2025-02-25 14:18:51 -08:00
Treehugger Robot b00227ca3f Merge "Adding events check to TAPL method for flinging to clear all." into main 2025-02-25 12:15:47 -08:00
Sunny Goyal 998cf2cb7e Adding option to skip animations for testing
Bug: 398894260
Flag: EXEMPT test
Test: atest GridPreviewTest
Change-Id: I9c3a7f6d8dfd63eac46038cc5d769def0392c194
2025-02-25 19:22:12 +00:00
Orhan Uysal ba7b64ba13 If the desktop task is visible, increase the count
When the desktop tasks are visible while constructing tasks, increase the number of visible tasks count by 1. Otherwise we might not exclude tasks that are marked as transparent and exludeFromRecents in the constructed list.

Fix: 397190111
Test: Enter desktop, trigger CtS and swipe up. Observe there is only one
desktop tile
Flag: EXEMPT Bug fix

Change-Id: Iabb382b20305a9a5b099bf8ee09a96ac13d0f36d
2025-02-25 18:19:08 +00:00
Jon Miranda 294e029be0 Prevent taskbar from stashing in overview in live tile mode.
Fixes: 354627538
Flag: EXEMPT bugfix
Test: Open app, go to overview, pause app
Change-Id: I82717747408f5776a50aa239c384f87927b54832
2025-02-25 10:12:28 -08:00
Brian Isganitis fbd55aeda4 Merge "Have per-environment bindings for Taskbar multivalent tests." into main 2025-02-25 09:53:16 -08:00
Thu-Huong Vu 803145f6f5 Merge "Add a growth broadcast receiver in taskbar." into main 2025-02-25 09:45:00 -08:00
Will Osborn 8bc3268ec4 Merge "DisplayController refactoring for multiple displays" into main 2025-02-25 08:16:52 -08:00
Treehugger Robot 4ea485eca4 Merge "[CD Taskbar] Refactor TaskbarManager - Add Debugging Support for Stability." into main 2025-02-25 08:14:09 -08:00
Treehugger Robot 14756d5a30 Merge "Convert TaskMenuView.java to Kotlin" into main 2025-02-25 08:09:02 -08:00
Pat Manning 11f50b01c7 Adding events check to TAPL method for flinging to clear all.
Clear all impl separate from public method, as nested events checking fails assertions.

Fix: 398771634
Test: TaplTestsQuickstep#testDismissLastGridRow
Flag: com.android.launcher3.enable_expressive_dismiss_task_motion
Change-Id: I7f86c0667034c95b4b21dd0fd75307ca0f8cf48d
2025-02-25 15:46:45 +00:00
Jordan Silva c5e3d0abf5 Convert TaskMenuView.java to Kotlin
Fix: 398831742
Flag: EXEMPT converting class to kotlin.
Test: OverviewMenuImageTest
Change-Id: I6080b9c315eb7fc8b1cd221ed41f1c8f498ffef3
2025-02-25 12:55:03 +00:00
Bill Yi 63a7fe5bac Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I49090c01d57680c0bd6ccadff73a81db9727a895
2025-02-25 04:07:22 -08:00
Alex Chau 45c1192fdf Merge "Handle AddDesktopButton's visibility in different launcher states" into main 2025-02-25 03:39:39 -08:00
Will Osborn c47d03f1f9 DisplayController refactoring for multiple displays
Test: locally tested on Tangor
Flag: com.android.launcher3.enable_overview_on_connected_displays
Bug: 392858637
Change-Id: I18c196c977b3731aa09d2cc93ab6341b8f1636c6
2025-02-25 11:29:02 +00:00
Sukesh Ram f1ec7a7699 [CD Taskbar] Refactor TaskbarManager - Add Debugging Support for Stability.
Refactor TaskbarManager & add Debugging Support for Stability. Centralize all existing logging behind existing logging methods.

Bug: 398878697
Bug: 382378283
Bug: 391653300
Test: m
Flag: EXEMPT not adding new behavior
Change-Id: I3f131b5e9ce720140c1d3eb46a53a4763926df83
2025-02-25 02:52:48 -08:00
Treehugger Robot 3ac18ead77 Merge "[CD Taskbar] Create a seperate device profile for external displays." into main 2025-02-25 01:47:59 -08:00
Sukesh Ram 23d9282043 [CD Taskbar] Create a seperate device profile for external displays.
Remove legacy all apps UI from secondary display.

Bug: 398306484
Test: m
Flag: com.android.window.flags.enable_taskbar_connected_displays
Change-Id: I93214fbf7fbda0b2f809e4d72424264276164831
2025-02-24 23:44:56 -08:00
Sukesh Ram 3242782931 Merge "[CD Taskbar] Remove legacy all apps button (secondary display)" into main 2025-02-24 23:38:34 -08:00
Toni Barzic 501562f09a More test for taskbar overflow
Adds tests to TaskbarOverflowTests to verify that:
*   tapping overflow view toggles keyboard quick switch view
*   tasks associated with a hotseat item don't get added to
    recents taskbar section / overflow view
*   keyboard quick switch view shown from taskbar contains
    running tasks, excluding tasks associated with a hotseat item

Bug: 379774843
Flag: com.android.launcher3.taskbar_overflow
Test: atest TaskbarOverflowTest

Change-Id: Iee6316c33cef6322d567e853f9fa358b7af9e172
2025-02-25 04:39:23 +00:00
Jeremy Sim bc872b2ae4 Merge "Fix icon positioning for flexible split in Overview" into main 2025-02-24 17:03:09 -08:00
Treehugger Robot 1799b85186 Merge "Fix grid previewing so it matches the applied layout" into main 2025-02-24 17:00:15 -08:00
Thu-Huong Vu 4aa26a3944 Add a growth broadcast receiver in taskbar.
The growth broadcast receiver will be used to receive broadcast from
Growth Framework and show a nudge on screen.

Refer to go/al-growth-framework-nudge

Test: Manual
Bug: b/396165728
Flag: com.android.launcher3.enable_growth_nudge
Change-Id: Iebf006c733f6f9d079a4c3b03d78fb7c9dd3e5e7
2025-02-25 00:29:42 +00:00
Wen-Chien Wang a49081917b pin-shortcut: Implements the actual pinning functionality
This cl implements the onClick function for the pin shortcut, so
that clicking on it will actually pin an app/item to the taskbar.

Bug: 375648361
Test: Manual, Recording uploaded to buganizer
Flag: com.android.launcher3.enable_pinning_app_with_context_menu
Change-Id: Ia0e9464ceb99efd47a9fefd8136b930f908599cb
2025-02-25 00:11:03 +00:00
Wen-Chien Wang f77c3cac2b pin-shortcut: Tracks hotseat states and adds unpin option for taskbar
This cl adds the unpin option by tracking the hotseat/taskbar state. The
option shown is determined by the following conditions:

1. If the target non-predicted item is on the taskbar, shows
   "Unpin from taskbar"
2. If the taskbar is not full, that is, reaching the limit of the
   available spaces, and the target item is anywhere outside of the
   taskbar, including All apps, shows "Pin to taskbar".
3. If the taskbar is full, simply don't show any shortcut option.

This cl also removes the option that will be shown on Launcher
homescreen or hotseat, as further UX alignment is needed.

One note about why the pin shortcut is not implemented in the
getShortcuts(). The reason is that getShortcuts does not have the
ItemInfo of the triggered item, while the SystemShortcut.Factory doesn't
have the hotseat/taskbar information. The simplest way at this point is
to check all the conditions in the controller and then manually add the
shortcut into the list.

Bug: 375648361
Test: Manual, Recording uploaded to buganizer
Flag: com.android.launcher3.enable_pinning_app_with_context_menu
Change-Id: I7d048bcb1b00f78651e909fbfcd911052a4cd4ef
2025-02-25 00:10:59 +00:00
Jagrut Desai 269fb15e97 Merge "Desktop Mode Taskbar Recreate Animation" into main 2025-02-24 16:00:48 -08:00
Sukesh Ram dc0a634362 [CD Taskbar] Remove legacy all apps button (secondary display)
Remove legacy all apps UI from secondary display. This is a quick temporary fix just to remove the legacy all apps button for aesthetic purposes without breaking secondary display launcher. The button will appear invisible. A more robust removal will be done when secondary launcher is eradicated completely.

Bug: 398196983
Test: m
Flag: com.android.window.flags.enable_taskbar_connected_displays
Change-Id: Ic5bc44efd479f7298e346d9d45fbb6f24dfad5d3
2025-02-24 15:26:56 -08:00
Treehugger Robot 087e54c81c Merge "Removing temporary debug tracing" into main 2025-02-24 14:55:05 -08:00
Sihua Ma 8587b2916e Enable forced theme icon in Launcher3 tests
Test: atest --start-avd Launcher3Tests:MonoIconThemeControllerTest
Bug: 398039548
Flag: com.android.launcher3.force_monochrome_app_icons
Change-Id: I629e36f77726c22b83e284beb218d8e804e0499f
2025-02-24 22:02:37 +00:00
minch b10cedd21c Handle AddDesktopButton's visibility in different launcher states
Introduce [ADD_DESK_BUTTON] in LauncherState and change the button's
visibility across different launcher states. E.g., the button
shouldn't be visible in the quick switch.

Bug: 389209338
Flag: com.android.window.flags.enable_multiple_desktops_frontend
Flag: com.android.window.flags.enable_multiple_desktops_backend
Test: 1. Swipe up from home, the button shown util in overview.
      2. Swipe up from the fullscreen app, the button is invisible
         util release the finger.
      3. The button is invisible in quick switch.
      4. All the above tested with NexusLauncher and Nova launcher,
         which is a 3rd launcher.
      5. Tested with gesture and 3-finger swipe on the touchpad.
      6. Both the ClearAllButton and AddDesktopButton are not
         visibile when in select mode.
Change-Id: I54e11d4d03401be68b5b67a6f591edd737c9ea30
2025-02-24 21:33:36 +00:00
Schneider Victor-tulias 6040a652a6 Merge "Respect accessibility animation guidelines in AllSetActivity" into main 2025-02-24 13:30:10 -08:00
Jagrut Desai cf05d3ec0e Merge "Fix Taskbar Edu accessibility anmimation" into main 2025-02-24 13:27:53 -08:00
Treehugger Robot da7d6aff2e Merge "Enforcing grid customization permission in manifest instead of code" into main 2025-02-24 13:16:51 -08:00
Jagrut Desai 8b2e5eff9b Desktop Mode Taskbar Recreate Animation
This Cl includes
       - addition of entry/exit callback methods in DesktopVisibilityController.
       - taskbar manager now listens to desktop mode changes.
       - TaskbarBackrgroundRedererer can now individually animation backgrounds for transient and persistent taskbars
       - new channel for taskbar icon alpha added to TaskbarViewController
       - new animated float to handle background alpha while we are recreating taskbar with animation.

Solution:

we use the callabck we get from DekstopVisibilty for entry/exit to first change logic of when we are considered inDesktopMode. Upon entry/exit we notify display controller for info change.
we also at notify taskbar manager who is now a listener to the desktop mode change and start the recreate process. TaskbarManager first animates existing taskbar out of user view and then follows the original recreate flow.

Test: Presubmit
Bug: 343882478
Flag: com.android.window.flags.enable_desktop_windowing_mode
Change-Id: Ib827564cacd194f499e7d9b1965e2bb13e3548ab
2025-02-24 11:59:53 -08:00
Federico Baron 45fe4733fb Fix grid previewing so it matches the applied layout
Bug: 392019771
Flag: com.android.systemui.shared.new_customization_picker_ui
Test: tested manually
Change-Id: If0fdd130d4278222b0b6ec2787aa7d6d56fc4b2f
2025-02-24 11:54:26 -08:00
Jeremy Sim 633b94abf1 Fix icon positioning for flexible split in Overview
In flexible split ratios like 90:10 and 10:90, we hide the Overview icon of the smaller app completely. This resulted in a bug where the single remaining visible icon was positioned badly.

Fixed this by adding a check in updateIconPlacement() so that we can skip the two-icon positioning and center the visible icon alone. Also fixed the cases where split select is initiated on a split tile (from Taskbar). Now the correct icon should be shown and centered.

Fixes: 391865942
Flag: com.android.wm.shell.enable_flexible_two_app_split
Test: Single icon is positioned correctly in the middle. When split select is initiated, the right icon is shown and centered. When app chip menus are enabled, the (existing) correct behavior is not changed.
Change-Id: I79842222fc325a7661cbabbb54d277389a317504
2025-02-24 11:48:50 -08:00
Sunny Goyal b1fab90e26 Enforcing grid customization permission in manifest instead of code
Bug: 389173244
Test: Updated tests
Flag: EXEMPT manifest change
Change-Id: I0fee57f935156da6b2b5a612259db2c4b3605846
2025-02-24 10:40:43 -08:00
Saumya Prakash b716d19362 Merge "Update gesture nav tutorial to new font style" into main 2025-02-24 10:37:22 -08:00