Commit Graph

83004 Commits

Author SHA1 Message Date
Uwais Ashraf 7a797477ea Use Recents CoroutineScope with cancellable Jobs per TaskView.
This saves time on first usage which can happen during a CUJ on main.

Bug: 395294954
Flag: com.android.launcher3.enable_refactor_task_thumbnail
Test: Perfetto trace comparison
Change-Id: I496a00e3002f29830adbd8bb10857e78b16c68c8
2025-03-03 17:39:54 +00:00
Jagrut Desai 39dd498074 Fix SystemNav and Taskbar related Memory Leaks
Test: Presubmit
Bug: 398908322
Bug: 399884290
Flag: EXEMPT bugfix
Change-Id: Idf1ed3ff154e64de523b477aa34b67cbcd3cf8b4
2025-03-03 09:29:39 -08:00
Treehugger Robot 12934bc891 Merge "Skip TaskView settledProgress and fullscreenProgress updates for same progress value" into main 2025-03-03 08:52:00 -08:00
Helen Cheuk 7fd7325fb8 Merge "Not refresh predicted app in right click" into main 2025-03-03 08:44:59 -08:00
minch 5cb890579e Disallow scroll to the AddDesktopButton
Bug: 389209338
Flag: com.android.window.flags.enable_multiple_desktops_frontend
Flag: com.android.window.flags.enable_multiple_desktops_backend
Test: m
Change-Id: Ib9e5bc3ff73aed9facd1bad17d34722bd7a24652
2025-03-03 15:37:11 +00:00
helencheuk b17cde5c3a Not refresh predicted app in right click
When users right click the mouse/touchpad, predicted apps in hotseat refresh and it is weird.
It refreshes because the right click is treated as a drag and a drag would trigger predicted apps refresh.
This fix adds a PreDragCondition to avoid it from starting drag.

Bug: 343650193
Test: Manual, connect to touchpad and right click on widget and folderIcon
Flag: NONE, Bug fix
Change-Id: I650f34f02a920b61e3a1f1ada7d2da10e1625e47
2025-03-03 14:37:05 +00:00
Uwais Ashraf f58fbaae2d Merge "Revert "Fix OutlineProvider for PageIndicatorDots for new visual updates."" into main 2025-03-03 06:28:16 -08:00
Jon Miranda 18441b720c Merge "Add bugfix flag for enable_taskbar_behind_shade" into main 2025-03-03 06:27:40 -08:00
Jordan Silva 266de900d5 Skip TaskView settledProgress and fullscreenProgress updates for same progress value
This prevents calling settledProgress with the same value multiple times during the onFullscreenProgress animation. It was causing a performance issue when the icon visibility was switching between VISIBILE and INVISIBLE each frame of the animation. More information in the comments of b/398318613.

Bug: 398318613
Flag: com.android.launcher3.enable_overview_icon_menu
Test: Manual
Test: systemui-thermal-throttling-3-suite
Change-Id: Ib24bfd7541bb177d7141718fa36d2349f7ec9d46
2025-03-03 12:07:47 +00:00
Alex Chau 00677dffa7 Merge "Remove commented block in testOverviewForTablet" into main 2025-03-03 03:52:51 -08:00
Alex Chau 8619197e6a Merge "desktop-exploded-view: Calculate an accurate crop rect for desktop tasks" into main 2025-03-03 02:12:35 -08:00
Pechetty Sravani (xWF) 6208483668 Revert "Fix OutlineProvider for PageIndicatorDots for new visual updates."
This reverts commit c09f4d331a.

Reason for revert: <Droidmonitor created revert due to b/400302622.Will be verified through ABTD for standard investigation.>

Change-Id: Ie088a7ceebb79966c9951e13ed0059c8ea75ca6c
2025-03-03 00:43:57 -08:00
Eric Lok 59d0c16f6b Fix issue where tasks were not reliably marked as Perceptible
Flag enablement is for desktop devices only.

Bug: 395538503
Test: Manual
Flag: com.android.server.am.perceptible_tasks
Change-Id: Ifa13e42de5592bcd5e6a57ab574b6dc4f8710dd9
2025-03-03 08:34:42 +00:00
Treehugger Robot 6e8347912c Merge changes I6846a3dd,I45356fd7 into main
* changes:
  Update ActiveGestureLogs to print gestures' display IDs
  Update TIS to use one input monitor per display
2025-03-02 18:07:04 -08:00
Treehugger Robot 7caa7cb9be Merge "Fix OutlineProvider for PageIndicatorDots for new visual updates." into main 2025-03-02 17:34:20 -08:00
Schneider Victor-Tulias 841c6a98d2 Update ActiveGestureLogs to print gestures' display IDs
Flag: com.android.launcher3.enable_gesture_nav_on_connected_displays
Bug: 382130680
Test: connected an external display and checked logs
Change-Id: I6846a3dda77fc4afbbd83855aacca726eeb8eace
2025-03-02 16:03:32 -08:00
Schneider Victor-Tulias 21dba415e9 Update TIS to use one input monitor per display
Flag: com.android.launcher3.enable_gesture_nav_on_connected_displays
Bug: 382130680
Bug: 398881237
Test: connected an external display and attempted touch gestures. checked logs to ensure motion events are separated by display id
Change-Id: I45356fd7f1926685093833990d39c85a4a074c58
2025-03-02 16:03:08 -08:00
Treehugger Robot eb808032f1 Merge "Propagate the display id with SysUIState changes to launcher" into main 2025-02-28 22:14:13 -08:00
Treehugger Robot b43cae24a4 Merge "Fix home screen page description when removing an existing page." into main 2025-02-28 21:26:35 -08:00
Mykola Podolian b0fe82378a Merge changes from topic "bubblebar_drop_target" into main
* changes:
  Removed fly-back animation after a taskbar item drop on the bubble bar
  Added BubbleBarLocation drop target.
2025-02-28 18:02:48 -08:00
Treehugger Robot c032512a82 Merge "Add screenrecord for uninstallWorkspaceIcon" into main 2025-02-28 17:19:37 -08:00
Treehugger Robot 55dd78123c Merge "Taskbar on home should open all apps that support drag to workspace" into main 2025-02-28 17:04:20 -08:00
Treehugger Robot dad3394772 Merge "Fix LauncherPrefs crash by allowing sub-types of Set" into main 2025-02-28 16:49:02 -08:00
Toni Barzic a5c5536d7d Test all apps -> workspace drag for taskbar on home
Adds TAPL test that verifies users are able to drag app items from all
apps to workspace when all apps is opened on from a pinned taskbar shown
on the home screen, as may be the case when a desktop mode taskbar is
shown on home screen.

Adapts LauncherInstrumentation to handle the case where taskbar is shown
on home - when verifying launcher states, it sets taskbar visibility
expectations to account for a posibility that taskbar is visible in
home, or workspace states. Adds a request to the test protocol to
determine whether taskbar should be visible on home.

Bug: 392118517
Flag: com.android.window.flags.enter_desktop_by_default_on_freeform_displays
Test: Ran TaplTestLockedTaskbar tests
Change-Id: I40b06da70aaa49b0a3e0673797e6c18773a72238
2025-03-01 00:31:46 +00:00
Sihua Ma 2e964781ad Merge "Enable forced theme icon in Launcher3 tests" into main 2025-02-28 16:06:04 -08:00
Stefan Andonian c09f4d331a Fix OutlineProvider for PageIndicatorDots for new visual updates.
Bug: 394355070
Test: Verified locally that the active indicator is outlined properly.
Flag: com.android.launcher3.enable_launcher_visual_refresh
Change-Id: Ia8bd95285292c532f741707e446c83df01c3d540
2025-02-28 15:12:28 -08:00
Brian Isganitis fbe72436c8 Merge "Remove TYPE_TASKBAR_OVERLAY_PROXY from TYPE_ACCESSIBLE." into main 2025-02-28 14:58:30 -08:00
Shamali P aeeedc02cc [Part 3] Clean up references for flags from past release.
Cleans up the unfold 2-pane picker flag

Bug: 399933655
Flag: EXEMPT cleanup
Test: Screenshot tests
Change-Id: I14a0f58cc25ba8984a1cd61a8453da5ddc57089b
2025-02-28 22:45:52 +00:00
Shamali P d5123be6d0 [Part 2] Clean up references for flags from past release.
Cleans up the tap to add flag.

Bug: 399933655
Flag: EXEMPT cleanup
Test: Screenshot tests
Change-Id: Ifc7bb572ed93f36ebb7f7ae808d0e14bba020a2f
2025-02-28 22:45:52 +00:00
Shamali P c7b3ec241e [Part 1] Clean up references to flags from past release.
Cleans up the categorized suggestions flag.

Bug: 399933655
Flag: EXEMPT cleanup
Test: Screenshot tests
Change-Id: I6cbd1b4e912a51e7cfe50171424512300f2d783f
2025-02-28 22:45:50 +00:00
Charlie Anderson 4e4ad89696 Fix LauncherPrefs crash by allowing sub-types of Set
Bug: 396616795
Test: LauncherPrefsTest
Flag: EXEMPT bugfix
Change-Id: Id380a6e4bb5eb809978070ff1b523c9e98e6b869
2025-02-28 21:57:43 +00:00
Brandon Dayauon aa39accd49 Include multiuser flag to launcher3 dependency
Bug: 360313403
Test: mp Launcherd / Static import of the android.multiuser.Flag method
Flag: EXEMPT adding dependency
Change-Id: I1a234ce61550c12d65c6e682285ec357fe91b82a
2025-02-28 21:51:33 +00:00
Toni Barzic 26ad16592a Taskbar on home should open all apps that support drag to workspace
If taskbar is shown on home screen, have the taskbar all apps button
toggle the launcher activity version of all apps UI. This makes the
behavior consistent with how all apps system action (keyboard shortcut)
works, and addresses a gap in functionality where users are unable to
drag apps from the taskbar all apps UI to the workspace.

Bug: 392118517
Flag: com.android.window.flags.enter_desktop_by_default_on_freeform_displays
Test: On desktop device, toggle all apps from taskbar on home screen,
      drag and app from all apps to workspace.
Change-Id: Ida0f230bf38c6e1e35041556f33de1be85daf785
2025-02-28 21:31:46 +00:00
Federico Baron 66999f0a19 Add screenrecord for uninstallWorkspaceIcon
Bug: 399756302
Flag: EXEMPT TEST_ONLY
Test: TaplUninstallRemoveTest
Change-Id: I4bdf8087276a93f8f736c23ba95f35acb7f05c3a
2025-02-28 21:27:07 +00:00
Treehugger Robot d300486e66 Merge "Adding option to skip animations for testing" into main 2025-02-28 13:10:53 -08:00
Toni Barzic 8ca3eaa345 Arrows to scroll recent tasks in KQS
Bug: 397878339
Bug: 397975686
Flag: com.android.launcher3.taskbar_overflow
Test: Enter taskbar overflow, and open the overflow view.
    Verify that arrow buttons are present; tapping them scrolls in the
    correct direction; when fully scrolled in a direction, the
    associated arrow button is disabled; verify arrow buttons have hover
    effects.
    Open Alt+Tab view, verify no buttons are present if the view cannot
    be scrolled (and present if the view can be scrolled).

Change-Id: Id1c37a2967a629aeb4b3cc2dc5ff7efb21c90cbe
2025-02-28 19:49:50 +00:00
Ana Salazar Maldonado d4cce41c27 Fix tokens for App Contrast Pill
Bug: 397101795
Test: update screenshots
Flag: com.android.launcher3.enable_contrast_tiles
Change-Id: Iffe86d8b1bdebbf8ddab9dcfd6197ad24edb684f
2025-02-28 11:23:44 -08:00
Daniel Andersson 7250db2fee desktop-exploded-view: Calculate an accurate crop rect for desktop tasks
This change fixes crop rects on desktop tasks when exploded view is
enabled. The crop rect calculation now takes the current task rect
transform into account (which is used to position windows when exploded
view is enabled).

Flag: com.android.launcher3.enable_desktop_exploded_view
Test: Manual
Bug: 367353392
Change-Id: I2b296a5065a5bc74c8ba884f2329081546b40ad0
2025-02-28 11:17:38 -08:00
Alex Chau 59e8c59ec6 Update gridTranslation of live tile when gestures ends
- Instead of updating in updateGridProperties, which will be re-run after dismiss and potentially apply wrong translations to live tile.
- Also set gridTranslationX of live tile to 0, as recentsScroll already takes care of horizontally task offest
- Guaded assigning RemoteTargetHandle to DesktopTaskView with enableDrawingLiveTile, so going to Home won't continue to mananages the TaskViewSimulator

Fix: 398231631
Fix: 394316748
Test: App to Overview with live tile on different location in the grid
Flag: com.android.launcher3.enable_grid_only_overview
Change-Id: I2e0f83a55421279581f3632c16c1e4c41d1fdae6
2025-02-28 18:48:40 +00:00
Randy Pfohl 42405b2fa3 Enabling secondary deviceprofile creation in windowcontext
Test: Built and ran locally

Flag: com.android.launcher3.enable_fallback_overview_in_window
      com.android.launcher3.enable_launcher_overview_in_window

Change-Id: Iafb75840c4acadb35eb9e89810e9de61bbeda326
2025-02-28 18:14:02 +00:00
mpodolian 672a32a18b Removed fly-back animation after a taskbar item drop on the bubble bar
Added logic to track whether the drop target handled the app icon drop,
in order to prevent the fly-back animation in those cases.

Bug: 397459664
Flag: com.android.wm.shell.enable_create_any_bubble
Test: Manual. Drop a taskbar icon onto the bubble bar. Observe that no
fly-back animation is performed for the dropped icon.

Change-Id: If439d7280fe9f713c181531ac899ac8ad37ed481
2025-02-28 10:01:13 -08:00
Justin Yun c237929450 Merge "Launcher3 is in system_ext container" into main 2025-02-28 09:40:25 -08:00
Orhan Uysal a7cd4f21d3 Merge "Change the misused logic" into main 2025-02-28 09:37:20 -08:00
Orhan Uysal 5e99882d75 Change the misused logic
Refactor from ag/31915496 was wrong. We should skip the transparent
activity tiles when there is a visible task already found not when
visible tasks are not found.

Bug: 397190111
Test: Enter any app, trigger circle to search, see only one tile
produced.
Flag: EXEMPT Bug fix

Change-Id: Ic19710a7d1f5be78e96aa5ac25553358732acf3b
2025-02-28 15:42:37 +00:00
Sam Cackett e0cc96df62 Add TaskContentView parent to TaskThumbnailViewHeader and TTV
- Add TaskContentView parent view
- Extract TaskThumbnailViewHeader logic and any related state out of
TaskThumbnailView and move to TaskContentView
- Use vertical LinearLayoutManager to hold the TaskThumbnailViewHeader
and TaskThumbnailView
- Rename TaskThumbnailViewHeader to TaskHeaderView. Rename xml and state
 similarly

Bug: 397889146
Flag: EXEMPT. Refactor
Test: Refactoring CL. Existing unit tests still pass.

Change-Id: Ie31f35c6617aab272f984a6beb3e4cb8f58e3ce9
2025-02-28 12:19:26 +00:00
Nicolo' Mazzucato 6bccfb49c2 Propagate the display id with SysUIState changes to launcher
This changes the ILauncherProxy.aidl interface to also allow propagating the display id from SysUI to launcher for each SysUIState update.

The SysUI part of filling SysUI state correctly has not been implemented yet. But for now, only default display flags are propagated anyway.

On the launcher side, the sysui state is propagated correctly to each taskbar instance (there is one for each display)

Bug: 362719719
Bug: 398011576
Bug: 399371607
Test: LauncherProxyServiceTest
Flag: com.android.systemui.shade_window_goes_around
Change-Id: Ic9fa55ca82e4fe395a915c4d611afc8835c5d65d
2025-02-28 10:34:55 +00:00
Jon Miranda 7b7a73a7b6 Add bugfix flag for enable_taskbar_behind_shade
Bug: 343194358
Test: n/a this is just adding a flag
Flag: EXEMPT adding the flag
Change-Id: I3f1b1f958427a22bbbaab95da362397c5f79f1cd
2025-02-27 17:58:26 -08:00
Andy Wickham 8cbe719df7 Fix NPE from navbar touch cancel without down.
TouchInteractionService sends a touch cancel when the screen turns
off, for example. So we shouldn't assume there was a touch down.

Fix: 398855863
Test: NavHandleLongPressInputConsumerTest#testTouchCancelWithoutTouchDown
Flag: EXEMPT bugfix
Change-Id: Ic1b6e981fe183864663bd44e1488d6f6749183bc
2025-02-28 00:51:42 +00:00
Xin Li 3848c51edb [automerger skipped] Merge 25Q1 (ab/12770256) to aosp-main-future am: 2ba372343b -s ours
am skip reason: Merged-In Ic4d9d6c4f79325a5d7ab98eafa1c86db4c2e67a5 with SHA-1 9c58954488 is already in history

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/31817467

Change-Id: I5c003fb2be8a103ed646a4d78dd08ed3f2b97dbb
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2025-02-27 16:45:05 -08:00
Brian Isganitis 8bab8eb171 Remove TYPE_TASKBAR_OVERLAY_PROXY from TYPE_ACCESSIBLE.
The invisible proxy view was preventing anything below it from being
accessible.

Flag: EXEMPT bugfix
Fix: 377526512
Test: #14 in bug.
Change-Id: I9d4596ebbbc4317a9ff7ded37b43b5fa1885e6ea
2025-02-27 19:41:48 -05:00