Commit Graph

83004 Commits

Author SHA1 Message Date
Willie Koomson 086e7b1d10 Implement collectWidgetEvent in QuickstepWidgetHolderListener
This change updates QuickstepWidgetHolderListener to implement the new
AppWidgetHostListener.collectWidgetEvent API.

Bug: 364655296
Test: Manual, interact with Launcher and check that events are logged
Flag: android.appwidget.flags.engagement_metrics

Change-Id: I9bf859f18025a49ef98e57e32e4b53e6547bd84b
2025-04-30 16:55:20 +00:00
Jordan Silva 8517ba500d Fix: Prevent app chip being destroyed for DesktopTask
DesktopTask shares the same iconView between different TaskContainers. When destroying a single Task in DesktopTask should not reset this shared IconAppChip.

Fix: 411406340
Flag: com.android.launcher3.enable_overview_icon_menu
Test: Manual
Change-Id: I40f144c836715290eabb9db49ed0582986a11945
2025-04-30 09:46:51 -07:00
Mykola Podolian 5259038c6f Merge "Launcher TAPL test for dragging task bar icon to the bubble bar." into main 2025-04-30 09:29:47 -07:00
vinayjoglekar 45cb055158 Apply fallback overview scrim, overviewactions and clearall in battery saver mode.
1. BlurFallbackStyle/BlurStyle will now be applied in Launcher startup.
   When "updateBlurStyle" is called, individual element style's swap
   happens as per blur style.
2. "hasOpaqueBg" background will now be checked in "applyDepthAndBlur"
   for setting the "currentBlur" value.

Bug: 409758306
Test: Manual. go to overview, enable/disable battery saver mode.
Flag: com.android.launcher3.enable_overview_background_wallpaper_blur
Change-Id: Ic9030c2b267867b9124705426dd51deb1b30ca55
2025-04-30 17:23:42 +01:00
Schneider Victor-tulias b4692a9ea4 Merge "Update AbstractLauncherUiTest to use recents window when possible" into main 2025-04-30 06:54:19 -07:00
Shamali P de578610a1 Account for cell size changes in resize frame when changing display size
- On display change, we don't seem to re-arrange workspace widgets
 whose current span size may no longer be a valid
- In some cases, the existing span showing on workspace is less than
the widget's min size and user is unable to resize to the correct size.
- Ideally irrespective of problem they should be able to resize to
 correct size.

This cl lets user resize to valid size. In another bug we might want to
evaluate refreshing / updating widgets on display change.

Bug: 408974387
Test: See demo
Flag: EXEMPT BUGFIX
Change-Id: I9712a20739ec8ee1de9d85f22814c7f1b3474e47
2025-04-30 02:06:05 +00:00
Treehugger Robot f4b64aaebf Merge "Revert^2 "Store bubble bar state in sysui proxy"" into main 2025-04-29 18:11:26 -07:00
Toshiki Kikuchi d1a0e640cb Revert^2 "Restrict nav mode UI checks within primary display"
This reverts commit 9d7b814eec.

Reason for revert: Cache the taskbar primary display to reduce the number of binder calls and calm down Droidmonitor. Please check the difference between PS1 and PS2.

Bug: 414092022
Bug: 413244466
Bug: 408631713
Change-Id: I24138de2e2b9975fadcdf4a27402e06e212e4a19
2025-04-29 18:00:47 -07:00
Sebastian Franco d94fa97779 Log which active controller is handling input in the BaseDragLayer
Bug: 405042311
Test: NA only adding logs
Flag: EXEMPT bug fix
Change-Id: Ibb7aac4b9baf30b7a7052180a1c4130f9d6b7cbe
2025-04-29 16:47:14 -07:00
Treehugger Robot bab5af8a4f Merge "Update bug associated with enable_overview_background_wallpaper_blur" into main 2025-04-29 16:04:29 -07:00
Ajinkya Chalke 94bc9fa860 Merge "Enable enableAltTabKqsFlatenning in Desktop Experience developer option" into main 2025-04-29 15:47:37 -07:00
Ats Jenk ac16eb2d73 Revert^2 "Store bubble bar state in sysui proxy"
This reverts commit fbfec0d3e1.

Reason for revert: Per the comment in the bug, this test was still failing after the rollback: https://b.corp.google.com/issues/413593389#comment7. The real culprit was a flag which was rolled back here: https://b.corp.google.com/issues/413593389#comment10.

Change-Id: Idd516b7c8576a3668f6248d8440da89867823df2
2025-04-29 15:38:05 -07:00
Sunny Goyal 036ced4703 Converting BgDataModel to Kotlin
This will allow the use of Flows in BgDataModel

Flag: EXEMPT refactor
Bug: 390572144
Test: Presubmit
Change-Id: I8fdd1635a19ae4d75260fb1ddb9cd7ab00cd0496
2025-04-29 15:37:11 -07:00
mpodolian 9764250b60 Launcher TAPL test for dragging task bar icon to the bubble bar.
Added a test and TAPL objects to check dragging taskbar icons to the
bubble bar.

Fixes: 388910897
Test: TaplTestTaskBarIconDrag
Flag: EXEMPT test
Change-Id: I8a3e64a83c72a9f6b89b2f8a875ca6565d501701
2025-04-29 15:32:41 -07:00
Pierre Barbier de Reuille 9f23a4cb06 Merge "Enable DesktopExperienceFlags in developer option for features in teamfood" into main 2025-04-29 15:21:14 -07:00
Xiaoqian Dai 107f85d20c desktop-exploded-view: Implement the activate window behavior
Clicking on one task window in the desktop exploded view, it should
activate that task window.

Flag: com.android.launcher3.enable_desktop_exploded_view
Test: Manual
Bug: 353948437, 410888109
Change-Id: I1836bf0babcec039ef76b13ecd40f87a8ab4d822
2025-04-29 22:03:41 +00:00
Shamali Patwa 32a30e410c Merge "Fix widget size in wallpaper preview when switching the grid" into main 2025-04-29 14:40:15 -07:00
Schneider Victor-Tulias b8440b75ef Update AbstractLauncherUiTest to use recents window when possible
Flag: com.android.launcher3.enable_launcher_overview_in_window
Bug: 377678992
Test: pre/postsubmit
Change-Id: Id3ddc11aa9163df3f2914edba66e1db36fdde63b
2025-04-29 14:13:26 -07:00
Ats Jenk 861f887dfe Merge changes I91a3b558,Ifc9c391a,I3da2bc22,Ied187c63,I859b7359 into main
* changes:
  Store bubble bar stashed state during rotation [6/N]
  Restore bubbles without affecting bar state [5/N]
  Do not animate bubbles from initial update [4/N]
  Store and restore selected bubble and expanded state [3/N]
  Do not animate bubble bar for initial state [2/N]
2025-04-29 13:17:42 -07:00
Treehugger Robot 589dfc9672 Merge "No recents-in-window on default display if enableOverviewOnConnectedDisplays is true" into main 2025-04-29 10:39:08 -07:00
Treehugger Robot d771ad1951 Merge "Import translations. DO NOT MERGE ANYWHERE" into main 2025-04-29 09:56:36 -07:00
Treehugger Robot 9ab4c7eafe Merge "Import translations. DO NOT MERGE ANYWHERE" into main 2025-04-29 09:56:36 -07:00
Sebastián Franco d23b8fc142 Merge "Always change the container when dropping in icon" into main 2025-04-29 09:51:09 -07:00
Alex Chau 8b2340e946 Merge "Update bug associated with enable_refactor_task_thumbnail" into main 2025-04-29 09:47:03 -07:00
Treehugger Robot e2a5c2c10c Merge "Handle addDesktopButton visibility wrt desk num limits" into main 2025-04-29 08:14:18 -07:00
Will Osborn 51943297be No recents-in-window on default display if enableOverviewOnConnectedDisplays is true
Bug: 413257766
Flag: com.android.launcher3.enable_overview_on_connected_displays
Test: local + presubmit
Change-Id: I0ae36d4bec4cf962e4c71304c82838dbf2bf518f
2025-04-29 15:11:27 +00:00
Alex Chau 3a06efdceb Update bug associated with enable_overview_background_wallpaper_blur
Bug: 360297985
Test: None
Flag: EXEMPT flag only
Change-Id: I1a3a3c706533b52bf759b61bee46439d35dab57b
2025-04-29 15:41:22 +01:00
Alex Chau fcb0339a48 Update bug associated with enable_refactor_task_thumbnail
Bug: 331754864
Test: None
Flag: EXEMPT flag only
Change-Id: I9d3148c7d2601619a543bc21ca822dd20608994c
2025-04-29 15:28:33 +01:00
Treehugger Robot 516a457dbe Merge "Move enableGestureNavOnConnectedDisplays to using DesktopExperienceFlags" into main 2025-04-29 07:25:41 -07:00
Treehugger Robot 7103e478b3 Merge "Register KEY_GESTURE_TYPE_RECENT_APPS[_SWITCHER] in the quickstep" into main 2025-04-29 04:53:12 -07:00
Treehugger Robot dcc634e0bb Merge "Notify StateManager of predictive back animation." into main 2025-04-29 03:52:30 -07:00
Ajinkya Chalke b4b208f12d Enable enableAltTabKqsFlatenning in Desktop Experience developer option
Bug: 407954908
Flag: EXEMPT (Flag infra)
Tests: Build and presubmit
Change-Id: I388fc8460ee795fc92d37276ea1dede4b00a041e
2025-04-29 02:29:46 -07:00
Will Osborn 43bc12baf2 Merge "Refactor OverviewOnConnectedDisplays flag" into main 2025-04-29 02:01:47 -07:00
Ats Jenk 1133492a3e Store bubble bar stashed state during rotation [6/N]
Store and restore bubble bar stashed state.
When bubble bar is restored from saved state, restore the bar state to
stashed, collapsed or expanded.
This ensures correct positioning of the bar on screen, before we receive
an update from shell.

Bug: 357115534
Test: bubble bar collapsed on home screen, rotate device and check
    bubble bar remains in correct position and collapsed
Test: bubble bar stashed in app, rotate device and check bubble bar
    remains stashed
Test: bubble bar and taskbar shown while in app, rotate device,
    bubble bar remains shown after rotation, not expanded or stashed
Test: bubble bar is expanded on home screen, rotate device and
    check bubble bar remains expanded
Test: bubble bar is expanded in app, rotate device and check bubble bar
    remains expanded
Flag: com.android.wm.shell.enable_bubble_bar
Change-Id: I91a3b5582a4af753e9e54156358b2ce9adb841c7
2025-04-28 18:45:01 -07:00
Ats Jenk 8ed27029d4 Restore bubbles without affecting bar state [5/N]
When we restore bubbles after taskbar is recreated, we should not modify
the bubble bar state as part of restoring the bubble views. Bubble bar
state is restored separately.
Create new helper method to restore bubbles without affecting bubble bar
state.

Bug: 357115534
Test: have bubble bar expanded on top of an app, rotate device multiple
  times back and forth, check that bubble bar remains expanded
Flag: com.android.wm.shell.enable_bubble_bar
Change-Id: Ifc9c391a1a367535daa3b83283fe145824294bcc
2025-04-28 18:44:28 -07:00
Ats Jenk 6c7cb1a5f0 Do not animate bubbles from initial update [4/N]
Bubbles that are restored with initial update should not be animated in.
If we restore the bubble bar after rotation, we need to show it
immediately. Attempting to animate the bubbles from initial update
causes the UI to flicker.

Bug: 357115534
Test: on home screen, have bubble bar expanded, rotate device, check
  bubble bar bubbles do not flicker after rotation
Test: have no bubbles in bubble bar, trigger a bubble, check it is
  animated
Flag: com.android.wm.shell.enable_bubble_bar
Change-Id: I3da2bc22588c0f5d2dd9c7a3adfcd2c19c339809
2025-04-28 18:44:26 -07:00
Ats Jenk 14474695a2 Store and restore selected bubble and expanded state [3/N]
When bubble bar gets recreated, store the expanded state and selected
bubble.
Allows us to show the bubble bar in previous state after rotation,
before shell has been able to send us an update.

Bug: 357115534
Test: on home screen, have bubble bar expanded, rotate device, check
  bubble bar remains expanded
Test: in app, have bubble bar expanded, rotate device, check bubble bar
  remains expanded
Test: have bubble bar collapsed, rotate device, check it is not expanded
Flag: com.android.wm.shell.enable_bubble_bar
Change-Id: Ied187c638287599297e15db77efdf44bd701d559
2025-04-28 18:44:23 -07:00
Andy Wickham ae48c582e9 Notify StateManager of predictive back animation.
This way if you go to a different state like All Apps, that
existing animation can be cancelled.

This is essentially the same as b/405836159, but for exiting an app
via predictive back rather than standard home gesture.

Demo: https://drive.google.com/file/d/1x66LHDMQLArZX7sO3RBcI-M-vWW_icRg/view?usp=drive_link&resourcekey=0-_0FYAfonv7YC9u8mCmm07Q

Fix: 412562139
Flag: com.android.launcher3.all_apps_blur
Test: Open app from homescreen, go back, swipe to All Apps quickly.
Change-Id: I83973df5702b271853149dbea5baa1781358c207
2025-04-29 01:14:28 +00:00
Li Lin 6e718cffb1 Merge "Show Growth Framework nudge driven by nudge payload." into main 2025-04-28 17:01:20 -07:00
Min Chen 31f5e79ffd Merge "Fix integration tests with multi-desks on" into main 2025-04-28 16:44:30 -07:00
Pierre Barbier de Reuille 76757afa3f Enable DesktopExperienceFlags in developer option for features in teamfood
Bug: 407954908
Test: Manual
Flag: EXEMPT (flag infra)
Change-Id: I354906d0d5b20eff2ef981da3a021290f22afe43
2025-04-28 16:03:52 -07:00
Pierre Barbier de Reuille bb3afc1457 Move enableGestureNavOnConnectedDisplays to using DesktopExperienceFlags
Also enable it by default, as this is now in teamfood.

Flag: EXEMPT (flag infra)
Test: Build and run
Fix: 414440345
Change-Id: I3389bc2ad16b65761eaaccceef91a1a80f6dc3f0
2025-04-28 15:19:15 -07:00
Li Lin 0f82810cdb Show Growth Framework nudge driven by nudge payload.
Current implementation of the nudge will show at default position
(bottom left corner) and may extended to other position in the future.
More detail at: go/al-growth-framework-nudge

Bug: 398033012
Test: NudgeControllerTest.*
Flag: com.android.launcher3.enable_growth_nudge
Change-Id: Idff9d62a5b1b26aa1cfbef5817f5425f8e94b7c9
2025-04-28 13:59:30 -07:00
Treehugger Robot 51ebe952be Merge "Enable enableAltTabKqsOnConnectedDisplays in Desktop Experience developer option" into main 2025-04-28 13:57:54 -07:00
Treehugger Robot 6305597a67 Merge "Update the PageIndicatorDots to track scroll progress." into main 2025-04-28 13:54:42 -07:00
Treehugger Robot 3bde3a8331 Merge "Update blur style for more things." into main 2025-04-28 13:51:25 -07:00
Treehugger Robot 075869da85 Merge "Renaming CONTAINER_PREDICTION to CONTAINER_ALL_APPS_PREDICTION" into main 2025-04-28 12:52:27 -07:00
Shamali P 5ad55f2c68 Fix widget size in wallpaper preview when switching the grid
Currently there is a bit of inconsistency in the way grid change
happens.

1. Grid migration decides different size, inflate item uses
different, and scale is applied using yet another size.

2. also when
going from small -> medium we reload data, but if while wallpaper picker
is open, if we revert to small, it leads to a wrong state due to
inconsistencies in #1 and shows cropped widget content. Instead in this
cl, we always reload on grid update, so widgets are shown for correct
size. There is still possibility of issue if the widget didn't respond
with data - but even in public build today there are tons of issues with
widgets on changing grid.

Bug: 408934352
Flag: EXEMPT BUGFIX
Test: See demo.
Change-Id: I91741d762cbf34ab7f9e0269ea307d2aad9e0eda
2025-04-28 12:20:15 -07:00
Priyanka Advani (xWF) 9d5903bb10 Merge "Revert "Restrict nav mode UI checks within primary display"" into main 2025-04-28 12:18:34 -07:00
Sebastian Franco fea773a5c2 Always change the container when dropping in icon
I was being cautios on my previous fix for this same
isse, cautios because I'm modifying an object by reference
That's why I was only updating the container when the icon being
dropped was PendingAddShortcutInfo but we can change the container
on every icon (we don't need to in the Widget case which is the
other if statement), we can be sure it is a safe operation because
we later update the info anyway rendering the previous info invalid.

Fix: 413784315
Test: WIP
Flag: EXEMPT bug fix
Change-Id: I60ecdb52be1c7bf0584cb1c74ee15b85961e5012
2025-04-28 11:57:17 -07:00